#3546

Committed 03 Dec 2024 10:02AM UTC coverage: 60.691% (-0.1%) from 60.839%

Build # #3546

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #29015 from taosdata/fix/TS-5668

[TS-5668] fix(keeper): fix endpoint value too long for column/tag and eliminate warnings

Run Details

120577 of 253823 branches covered (47.5%)

Branch coverage included in aggregate %.

201666 of 277134 relevant lines covered (72.77%)

18719900.08 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

61.89

/source/libs/nodes/src/nodesToSQLFuncs.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "cmdnodes.h"
#include "nodesUtil.h"
#include "plannodes.h"
#include "querynodes.h"
#include "taos.h"
#include "taoserror.h"
#include "thash.h"

const char *operatorTypeStr(EOperatorType type) {
  switch (type) {
    case OP_TYPE_ADD:
      return "+";
    case OP_TYPE_SUB:
      return "-";
    case OP_TYPE_MULTI:
      return "*";
    case OP_TYPE_DIV:
      return "/";
    case OP_TYPE_REM:
      return "%";
    case OP_TYPE_MINUS:
      return "-";
    case OP_TYPE_BIT_AND:
      return "&";
    case OP_TYPE_BIT_OR:
      return "|";
    case OP_TYPE_GREATER_THAN:
      return ">";
    case OP_TYPE_GREATER_EQUAL:
      return ">=";
    case OP_TYPE_LOWER_THAN:
      return "<";
    case OP_TYPE_LOWER_EQUAL:
      return "<=";
    case OP_TYPE_EQUAL:
      return "=";
    case OP_TYPE_NOT_EQUAL:
      return "<>";
    case OP_TYPE_IN:
      return "IN";
    case OP_TYPE_NOT_IN:
      return "NOT IN";
    case OP_TYPE_LIKE:
      return "LIKE";
    case OP_TYPE_NOT_LIKE:
      return "NOT LIKE";
    case OP_TYPE_MATCH:
      return "MATCH";
    case OP_TYPE_NMATCH:
      return "NMATCH";
    case OP_TYPE_IS_NULL:
      return "IS NULL";
    case OP_TYPE_IS_NOT_NULL:
      return "IS NOT NULL";
    case OP_TYPE_IS_TRUE:
      return "IS TRUE";
    case OP_TYPE_IS_FALSE:
      return "IS FALSE";
    case OP_TYPE_IS_UNKNOWN:
      return "IS UNKNOWN";
    case OP_TYPE_IS_NOT_TRUE:
      return "IS NOT TRUE";
    case OP_TYPE_IS_NOT_FALSE:
      return "IS NOT FALSE";
    case OP_TYPE_IS_NOT_UNKNOWN:
      return "IS NOT UNKNOWN";
    case OP_TYPE_JSON_GET_VALUE:
      return "=>";
    case OP_TYPE_JSON_CONTAINS:
      return "CONTAINS";
    case OP_TYPE_ASSIGN:
      return "=";
    default:
      break;
  }
  return "UNKNOWN";
}

const char *logicConditionTypeStr(ELogicConditionType type) {
  switch (type) {
    case LOGIC_COND_TYPE_AND:
      return "AND";
    case LOGIC_COND_TYPE_OR:
      return "OR";
    case LOGIC_COND_TYPE_NOT:
      return "NOT";
    default:
      break;
  }
  return "UNKNOWN";
}

int32_t nodesNodeToSQL(SNode *pNode, char *buf, int32_t bufSize, int32_t *len) {
  switch (pNode->type) {
    case QUERY_NODE_COLUMN: {
      SColumnNode *colNode = (SColumnNode *)pNode;
      if (colNode->dbName[0]) {
        *len += tsnprintf(buf + *len, bufSize - *len, "`%s`.", colNode->dbName);
      }

      if (colNode->tableAlias[0]) {
        *len += tsnprintf(buf + *len, bufSize - *len, "`%s`.", colNode->tableAlias);
      } else if (colNode->tableName[0]) {
        *len += tsnprintf(buf + *len, bufSize - *len, "`%s`.", colNode->tableName);
      }

      if (colNode->tableAlias[0]) {
        *len += tsnprintf(buf + *len, bufSize - *len, "`%s`", colNode->node.userAlias);
      } else {
        *len += tsnprintf(buf + *len, bufSize - *len, "%s", colNode->node.userAlias);
      }

      return TSDB_CODE_SUCCESS;
    }
    case QUERY_NODE_VALUE: {
      SValueNode *colNode = (SValueNode *)pNode;
      char       *t = nodesGetStrValueFromNode(colNode);
      if (NULL == t) {
        nodesError("fail to get str value from valueNode");
        NODES_ERR_RET(TSDB_CODE_APP_ERROR);
      }

      int32_t tlen = strlen(t);
      if (tlen > 32) {
        *len += tsnprintf(buf + *len, bufSize - *len, "%.*s...%s", 32, t, t + tlen - 1);
      } else {
        *len += tsnprintf(buf + *len, bufSize - *len, "%s", t);
      }
      taosMemoryFree(t);

      return TSDB_CODE_SUCCESS;
    }
    case QUERY_NODE_OPERATOR: {
      SOperatorNode *pOpNode = (SOperatorNode *)pNode;
      *len += tsnprintf(buf + *len, bufSize - *len, "(");
      if (pOpNode->pLeft) {
        NODES_ERR_RET(nodesNodeToSQL(pOpNode->pLeft, buf, bufSize, len));
      }

      *len += tsnprintf(buf + *len, bufSize - *len, " %s ", operatorTypeStr(pOpNode->opType));

      if (pOpNode->pRight) {
        NODES_ERR_RET(nodesNodeToSQL(pOpNode->pRight, buf, bufSize, len));
      }

      *len += tsnprintf(buf + *len, bufSize - *len, ")");

      return TSDB_CODE_SUCCESS;
    }
    case QUERY_NODE_LOGIC_CONDITION: {
      SLogicConditionNode *pLogicNode = (SLogicConditionNode *)pNode;
      SNode               *node = NULL;
      bool                 first = true;

      *len += tsnprintf(buf + *len, bufSize - *len, "(");

      FOREACH(node, pLogicNode->pParameterList) {
        if (!first) {
          *len += tsnprintf(buf + *len, bufSize - *len, " %s ", logicConditionTypeStr(pLogicNode->condType));
        }
        NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));
        first = false;
      }

      *len += tsnprintf(buf + *len, bufSize - *len, ")");

      return TSDB_CODE_SUCCESS;
    }
    case QUERY_NODE_FUNCTION: {
      SFunctionNode *pFuncNode = (SFunctionNode *)pNode;
      SNode         *node = NULL;
      bool           first = true;

      *len += tsnprintf(buf + *len, bufSize - *len, "%s(", pFuncNode->functionName);

      FOREACH(node, pFuncNode->pParameterList) {
        if (!first) {
          *len += tsnprintf(buf + *len, bufSize - *len, ", ");
        }
        NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));
        first = false;
      }

      *len += tsnprintf(buf + *len, bufSize - *len, ")");

      return TSDB_CODE_SUCCESS;
    }
    case QUERY_NODE_NODE_LIST: {
      SNodeListNode *pListNode = (SNodeListNode *)pNode;
      SNode         *node = NULL;
      bool           first = true;
      int32_t        num = 0;

      *len += tsnprintf(buf + *len, bufSize - *len, "(");

      FOREACH(node, pListNode->pNodeList) {
        if (!first) {
          *len += tsnprintf(buf + *len, bufSize - *len, ", ");
          if (++num >= 10) {
            *len += tsnprintf(buf + *len, bufSize - *len, "...");
            break;
          }
        }
        NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));
        first = false;
      }

      *len += tsnprintf(buf + *len, bufSize - *len, ")");

      return TSDB_CODE_SUCCESS;
    }
    default:
      break;
  }

  nodesError("nodesNodeToSQL unknown node = %s", nodesNodeName(pNode->type));
  NODES_RET(TSDB_CODE_APP_ERROR);
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "cmdnodes.h"
17	#include "nodesUtil.h"
18	#include "plannodes.h"
19	#include "querynodes.h"
20	#include "taos.h"
21	#include "taoserror.h"
22	#include "thash.h"
23
24	const char *operatorTypeStr(EOperatorType type) {	258,639✔
25	switch (type) {	258,639!
26	case OP_TYPE_ADD:	44✔
27	return "+";	44✔
28	case OP_TYPE_SUB:	×
29	return "-";	×
30	case OP_TYPE_MULTI:	×
31	return "*";	×
32	case OP_TYPE_DIV:	×
33	return "/";	×
34	case OP_TYPE_REM:	×
35	return "%";	×
36	case OP_TYPE_MINUS:	×
37	return "-";	×
38	case OP_TYPE_BIT_AND:	×
39	return "&";	×
40	case OP_TYPE_BIT_OR:	×
41	return "\|";	×
42	case OP_TYPE_GREATER_THAN:	18,765✔
43	return ">";	18,765✔
44	case OP_TYPE_GREATER_EQUAL:	67,886✔
45	return ">=";	67,886✔
46	case OP_TYPE_LOWER_THAN:	42,110✔
47	return "<";	42,110✔
48	case OP_TYPE_LOWER_EQUAL:	53,912✔
49	return "<=";	53,912✔
50	case OP_TYPE_EQUAL:	42,639✔
51	return "=";	42,639✔
52	case OP_TYPE_NOT_EQUAL:	107✔
53	return "<>";	107✔
54	case OP_TYPE_IN:	145✔
55	return "IN";	145✔
56	case OP_TYPE_NOT_IN:	×
57	return "NOT IN";	×
58	case OP_TYPE_LIKE:	2,131✔
59	return "LIKE";	2,131✔
60	case OP_TYPE_NOT_LIKE:	×
61	return "NOT LIKE";	×
62	case OP_TYPE_MATCH:	1,068✔
63	return "MATCH";	1,068✔
64	case OP_TYPE_NMATCH:	212✔
65	return "NMATCH";	212✔
66	case OP_TYPE_IS_NULL:	16,254✔
67	return "IS NULL";	16,254✔
68	case OP_TYPE_IS_NOT_NULL:	13,366✔
69	return "IS NOT NULL";	13,366✔
70	case OP_TYPE_IS_TRUE:	×
71	return "IS TRUE";	×
72	case OP_TYPE_IS_FALSE:	×
73	return "IS FALSE";	×
74	case OP_TYPE_IS_UNKNOWN:	×
75	return "IS UNKNOWN";	×
76	case OP_TYPE_IS_NOT_TRUE:	×
77	return "IS NOT TRUE";	×
78	case OP_TYPE_IS_NOT_FALSE:	×
79	return "IS NOT FALSE";	×
80	case OP_TYPE_IS_NOT_UNKNOWN:	×
81	return "IS NOT UNKNOWN";	×
82	case OP_TYPE_JSON_GET_VALUE:	×
83	return "=>";	×
84	case OP_TYPE_JSON_CONTAINS:	×
85	return "CONTAINS";	×
86	case OP_TYPE_ASSIGN:	×
87	return "=";	×
88	default:	×
89	break;	×
90	}
91	return "UNKNOWN";	×
92	}
93
94	const char *logicConditionTypeStr(ELogicConditionType type) {	2,354✔
95	switch (type) {	2,354!
96	case LOGIC_COND_TYPE_AND:	1,065✔
97	return "AND";	1,065✔
98	case LOGIC_COND_TYPE_OR:	1,289✔
99	return "OR";	1,289✔
100	case LOGIC_COND_TYPE_NOT:	×
101	return "NOT";	×
102	default:	×
103	break;	×
104	}
105	return "UNKNOWN";	×
106	}
107
108	int32_t nodesNodeToSQL(SNode pNode, char buf, int32_t bufSize, int32_t *len) {	18,476✔
109	switch (pNode->type) {	18,476!
110	case QUERY_NODE_COLUMN: {	5,841✔
111	SColumnNode colNode = (SColumnNode )pNode;	5,841✔
112	if (colNode->dbName[0]) {	5,841✔
113	len += tsnprintf(buf + len, bufSize - *len, "`%s`.", colNode->dbName);	4,998✔
114	}
115
116	if (colNode->tableAlias[0]) {	5,841✔
117	len += tsnprintf(buf + len, bufSize - *len, "`%s`.", colNode->tableAlias);	5,042✔
118	} else if (colNode->tableName[0]) {	799!
119	len += tsnprintf(buf + len, bufSize - *len, "`%s`.", colNode->tableName);	×
120	}
121
122	if (colNode->tableAlias[0]) {	5,841✔
123	len += tsnprintf(buf + len, bufSize - *len, "`%s`", colNode->node.userAlias);	5,042✔
124	} else {
125	len += tsnprintf(buf + len, bufSize - *len, "%s", colNode->node.userAlias);	799✔
126	}
127
128	return TSDB_CODE_SUCCESS;	5,841✔
129	}
130	case QUERY_NODE_VALUE: {	5,017✔
131	SValueNode colNode = (SValueNode )pNode;	5,017✔
132	char *t = nodesGetStrValueFromNode(colNode);	5,017✔
133	if (NULL == t) {	5,017!
134	nodesError("fail to get str value from valueNode");	×
135	NODES_ERR_RET(TSDB_CODE_APP_ERROR);	×
136	}
137
138	int32_t tlen = strlen(t);	5,017✔
139	if (tlen > 32) {	5,017!
140	len += tsnprintf(buf + len, bufSize - len, "%.s...%s", 32, t, t + tlen - 1);	×
141	} else {
142	len += tsnprintf(buf + len, bufSize - *len, "%s", t);	5,017✔
143	}
144	taosMemoryFree(t);	5,017✔
145
146	return TSDB_CODE_SUCCESS;	5,017✔
147	}
148	case QUERY_NODE_OPERATOR: {	5,378✔
149	SOperatorNode pOpNode = (SOperatorNode )pNode;	5,378✔
150	len += tsnprintf(buf + len, bufSize - *len, "(");	5,378✔
151	if (pOpNode->pLeft) {	5,378!
152	NODES_ERR_RET(nodesNodeToSQL(pOpNode->pLeft, buf, bufSize, len));	5,378!
153	}
154
155	len += tsnprintf(buf + len, bufSize - *len, " %s ", operatorTypeStr(pOpNode->opType));	5,378✔
156
157	if (pOpNode->pRight) {	5,378✔
158	NODES_ERR_RET(nodesNodeToSQL(pOpNode->pRight, buf, bufSize, len));	5,338!
159	}
160
161	len += tsnprintf(buf + len, bufSize - *len, ")");	5,378✔
162
163	return TSDB_CODE_SUCCESS;	5,378✔
164	}
165	case QUERY_NODE_LOGIC_CONDITION: {	2,167✔
166	SLogicConditionNode pLogicNode = (SLogicConditionNode )pNode;	2,167✔
167	SNode *node = NULL;	2,167✔
168	bool first = true;	2,167✔
169
170	len += tsnprintf(buf + len, bufSize - *len, "(");	2,167✔
171
172	FOREACH(node, pLogicNode->pParameterList) {	6,688!
173	if (!first) {	4,521✔
174	len += tsnprintf(buf + len, bufSize - *len, " %s ", logicConditionTypeStr(pLogicNode->condType));	2,354✔
175	}
176	NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));	4,521!
177	first = false;	4,521✔
178	}
179
180	len += tsnprintf(buf + len, bufSize - *len, ")");	2,167✔
181
182	return TSDB_CODE_SUCCESS;	2,167✔
183	}
184	case QUERY_NODE_FUNCTION: {	36✔
185	SFunctionNode pFuncNode = (SFunctionNode )pNode;	36✔
186	SNode *node = NULL;	36✔
187	bool first = true;	36✔
188
189	len += tsnprintf(buf + len, bufSize - *len, "%s(", pFuncNode->functionName);	36✔
190
191	FOREACH(node, pFuncNode->pParameterList) {	180!
192	if (!first) {	144✔
193	len += tsnprintf(buf + len, bufSize - *len, ", ");	108✔
194	}
195	NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));	144!
196	first = false;	144✔
197	}
198
199	len += tsnprintf(buf + len, bufSize - *len, ")");	36✔
200
201	return TSDB_CODE_SUCCESS;	36✔
202	}
203	case QUERY_NODE_NODE_LIST: {	37✔
204	SNodeListNode pListNode = (SNodeListNode )pNode;	37✔
205	SNode *node = NULL;	37✔
206	bool first = true;	37✔
207	int32_t num = 0;	37✔
208
209	len += tsnprintf(buf + len, bufSize - *len, "(");	37✔
210
211	FOREACH(node, pListNode->pNodeList) {	152!
212	if (!first) {	115✔
213	len += tsnprintf(buf + len, bufSize - *len, ", ");	78✔
214	if (++num >= 10) {	78!
215	len += tsnprintf(buf + len, bufSize - *len, "...");	×
216	break;	×
217	}
218	}
219	NODES_ERR_RET(nodesNodeToSQL(node, buf, bufSize, len));	115!
220	first = false;	115✔
221	}
222
223	len += tsnprintf(buf + len, bufSize - *len, ")");	37✔
224
225	return TSDB_CODE_SUCCESS;	37✔
226	}
227	default:	×
228	break;	×
229	}
230
231	nodesError("nodesNodeToSQL unknown node = %s", nodesNodeName(pNode->type));	×
232	NODES_RET(TSDB_CODE_APP_ERROR);	×
233	}

taosdata / TDengine / #3546

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous