12095503980

Committed 30 Nov 2024 10:03AM UTC coverage: 49.178% (-0.003%) from 49.181%

Build # 12095503980

Build Type

push

github

Committed by

web-flow

Commit Message

Introduce AbstractOperation::validate() to check operation parameters (#6908)

Most operations don't check their parameters before execution, so when
they are deserialized from invalid JSON payloads, this can lead to
execution errors which ought to be prevented earlier.

This introduces a validate() method on operations giving them the
opportunity to check the validity of their parameters. It would
intuitively be more natural to do those checks in the operation
constructors, as it would guarantee that if you have an instance of an
operation, it has suitable parameters, but if we were to do this, we
would run into the risk that deserializing operations fail at the
loading of a project (for instance: say I use an extension which
provides a custom expression language, which I then use in an operation.
If I then remove the extension, I wouldn't be able to open my project
anymore)

For now this PR just contains the basic scaffold without implementing
any checks in any operation, just to validate the general approach.

Run Details

5347 of 12350 branches covered (43.3%)

Branch coverage included in aggregate %.

13357 of 25683 relevant lines covered (52.01%)

2.39 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

12.5

/com/google/refine/commands/history/ApplyOperationsCommand.java

Source Not Available

The file "com/google/refine/commands/history/ApplyOperationsCommand.java" isn't available on github. Either it's been removed, or the repo root directory needs to be updated.

OpenRefine / OpenRefine / 12095503980

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source Not Available

Source File
Press 'n' to go to next uncovered line, 'b' for previous