12080353131

Committed 29 Nov 2024 06:55AM UTC coverage: 89.471% (-0.02%) from 89.491%

Build # 12080353131

Build Type

Pull #2159

github

Committed by

iamacook

Commit Message

Rename variable and add comment

Pull Request Pull Request #2159: Automatically type all network requests as `Raw`

Run Details

2769 of 3446 branches covered (80.35%)

Branch coverage included in aggregate %.

62 of 63 new or added lines in 12 files covered. (98.41%)

2 existing lines in 2 files now uncovered.

9399 of 10154 relevant lines covered (92.56%)

426.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.42

/src/datasources/swaps-api/cowswap-api.service.ts

import type { INetworkService } from '@/datasources/network/network.service.interface';
import type { Order } from '@/domain/swaps/entities/order.entity';
import type { ISwapsApi } from '@/domain/interfaces/swaps-api.interface';
import type { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
import type { FullAppData } from '@/domain/swaps/entities/full-app-data.entity';
import type { Raw } from '@/validation/entities/raw.entity';

export class CowSwapApi implements ISwapsApi {
  constructor(
    private readonly baseUrl: string,
    private readonly networkService: INetworkService,
    private readonly httpErrorFactory: HttpErrorFactory,
  ) {}

  async getOrder(uid: string): Promise<Raw<Order>> {
    try {
      const url = `${this.baseUrl}/api/v1/orders/${uid}`;
      const { data } = await this.networkService.get<Order>({ url });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }

  async getOrders(txHash: string): Promise<Raw<Array<Order>>> {
    try {
      const url = `${this.baseUrl}/api/v1/transactions/${txHash}/orders`;
      const { data } = await this.networkService.get<Array<Order>>({
        url,
      });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }

  async getFullAppData(appDataHash: `0x${string}`): Promise<Raw<FullAppData>> {
    try {
      const url = `${this.baseUrl}/api/v1/app_data/${appDataHash}`;
      const { data } = await this.networkService.get<FullAppData>({ url });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }
}

1	import type { INetworkService } from '@/datasources/network/network.service.interface';
2	import type { Order } from '@/domain/swaps/entities/order.entity';
3	import type { ISwapsApi } from '@/domain/interfaces/swaps-api.interface';
4	import type { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
5	import type { FullAppData } from '@/domain/swaps/entities/full-app-data.entity';
6	import type { Raw } from '@/validation/entities/raw.entity';
7
8	export class CowSwapApi implements ISwapsApi {	128✔
9	constructor(
10	private readonly baseUrl: string,	42✔
11	private readonly networkService: INetworkService,	42✔
12	private readonly httpErrorFactory: HttpErrorFactory,	42✔
13	) {}
14
15	async getOrder(uid: string): Promise<Raw<Order>> {
16	try {	30✔
17	const url = `${this.baseUrl}/api/v1/orders/${uid}`;	30✔
18	const { data } = await this.networkService.get<Order>({ url });	30✔
19	return data;	26✔
20	} catch (error) {
21	throw this.httpErrorFactory.from(error);	4✔
22	}
23	}
24
25	async getOrders(txHash: string): Promise<Raw<Array<Order>>> {
26	try {	×
27	const url = `${this.baseUrl}/api/v1/transactions/${txHash}/orders`;	×
NEW 28	const { data } = await this.networkService.get<Array<Order>>({	×
29	url,
30	});
31	return data;	×
32	} catch (error) {
33	throw this.httpErrorFactory.from(error);	×
34	}
35	}
36
37	async getFullAppData(appDataHash: `0x${string}`): Promise<Raw<FullAppData>> {
38	try {	12✔
39	const url = `${this.baseUrl}/api/v1/app_data/${appDataHash}`;	12✔
40	const { data } = await this.networkService.get<FullAppData>({ url });	12✔
41	return data;	12✔
42	} catch (error) {
43	throw this.httpErrorFactory.from(error);	×
44	}
45	}
46	}

safe-global / safe-client-gateway / 12080353131

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous