• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3541

26 Nov 2024 03:56AM UTC coverage: 60.776% (-0.07%) from 60.846%
#3541

push

travis-ci

web-flow
Merge pull request #28920 from taosdata/fix/TD-33008-3.0

fix(query)[TD-33008]. fix error handling in tsdbCacheRead

120076 of 252763 branches covered (47.51%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1395 existing lines in 154 files now uncovered.

200995 of 275526 relevant lines covered (72.95%)

19612328.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.33
/source/dnode/vnode/src/vnd/vnodeSnapshot.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tsdb.h"
17
#include "vnd.h"
18

19
static int32_t vnodeExtractSnapInfoDiff(void *buf, int32_t bufLen, TFileSetRangeArray **ppRanges) {
196✔
20
  int32_t            code = 0;
196✔
21
  STsdbFSetPartList *pList = tsdbFSetPartListCreate();
196✔
22
  if (pList == NULL) {
196!
23
    code = terrno;
×
24
    goto _out;
×
25
  }
26

27
  code = tDeserializeTsdbFSetPartList(buf, bufLen, pList);
196✔
28
  if (code) goto _out;
196!
29

30
  code = tsdbFSetPartListToRangeDiff(pList, ppRanges);
196✔
31
  if (code) goto _out;
196!
32

33
_out:
196✔
34
  tsdbFSetPartListDestroy(&pList);
196✔
35
  return code;
196✔
36
}
37

38
// SVSnapReader ========================================================
39
struct SVSnapReader {
40
  SVnode *pVnode;
41
  int64_t sver;
42
  int64_t ever;
43
  int64_t index;
44
  // config
45
  int8_t cfgDone;
46
  // meta
47
  int8_t           metaDone;
48
  SMetaSnapReader *pMetaReader;
49
  // tsdb
50
  int8_t              tsdbDone;
51
  TFileSetRangeArray *pRanges;
52
  STsdbSnapReader    *pTsdbReader;
53
  // tsdb raw
54
  int8_t              tsdbRAWDone;
55
  STsdbSnapRAWReader *pTsdbRAWReader;
56

57
  // tq
58
  int8_t         tqHandleDone;
59
  STqSnapReader *pTqSnapReader;
60
  int8_t         tqOffsetDone;
61
  STqSnapReader *pTqOffsetReader;
62
  int8_t         tqCheckInfoDone;
63
  STqSnapReader *pTqCheckInfoReader;
64
  // stream
65
  int8_t              streamTaskDone;
66
  SStreamTaskReader  *pStreamTaskReader;
67
  int8_t              streamStateDone;
68
  SStreamStateReader *pStreamStateReader;
69
  // rsma
70
  int8_t              rsmaDone;
71
  TFileSetRangeArray *pRsmaRanges[TSDB_RETENTION_L2];
72
  SRSmaSnapReader    *pRsmaReader;
73
};
74

75
static TFileSetRangeArray **vnodeSnapReaderGetTsdbRanges(SVSnapReader *pReader, int32_t tsdbTyp) {
396✔
76
  if (!(sizeof(pReader->pRsmaRanges) / sizeof(pReader->pRsmaRanges[0]) == 2)) {
77
    terrno = TSDB_CODE_INVALID_PARA;
78
    return NULL;
79
  }
80
  switch (tsdbTyp) {
396!
81
    case SNAP_DATA_TSDB:
198✔
82
      return &pReader->pRanges;
198✔
83
    case SNAP_DATA_RSMA1:
99✔
84
      return &pReader->pRsmaRanges[0];
99✔
85
    case SNAP_DATA_RSMA2:
99✔
86
      return &pReader->pRsmaRanges[1];
99✔
87
    default:
×
88
      return NULL;
×
89
  }
90
}
91

92
static int32_t vnodeSnapReaderDealWithSnapInfo(SVSnapReader *pReader, SSnapshotParam *pParam) {
99✔
93
  int32_t code = 0;
99✔
94
  SVnode *pVnode = pReader->pVnode;
99✔
95

96
  if (pParam->data) {
99!
97
    // decode
98
    SSyncTLV *datHead = (void *)pParam->data;
99✔
99
    if (datHead->typ != TDMT_SYNC_PREP_SNAPSHOT_REPLY) {
99!
100
      code = TSDB_CODE_INVALID_DATA_FMT;
×
101
      terrno = code;
×
102
      goto _out;
×
103
    }
104

105
    STsdbRepOpts         tsdbOpts = {0};
99✔
106
    TFileSetRangeArray **ppRanges = NULL;
99✔
107
    int32_t              offset = 0;
99✔
108

109
    while (offset + sizeof(SSyncTLV) < datHead->len) {
297✔
110
      SSyncTLV *subField = (void *)(datHead->val + offset);
198✔
111
      offset += sizeof(SSyncTLV) + subField->len;
198✔
112
      void   *buf = subField->val;
198✔
113
      int32_t bufLen = subField->len;
198✔
114

115
      switch (subField->typ) {
198!
116
        case SNAP_DATA_TSDB:
99✔
117
        case SNAP_DATA_RSMA1:
118
        case SNAP_DATA_RSMA2: {
119
          ppRanges = vnodeSnapReaderGetTsdbRanges(pReader, subField->typ);
99✔
120
          if (ppRanges == NULL) {
99!
121
            vError("vgId:%d, unexpected subfield type in snapshot param. subtyp:%d", TD_VID(pVnode), subField->typ);
×
122
            code = TSDB_CODE_INVALID_DATA_FMT;
×
123
            goto _out;
×
124
          }
125
          code = vnodeExtractSnapInfoDiff(buf, bufLen, ppRanges);
99✔
126
          if (code) {
99!
127
            vError("vgId:%d, failed to get range diff since %s", TD_VID(pVnode), terrstr());
×
128
            goto _out;
×
129
          }
130
        } break;
99✔
131
        case SNAP_DATA_RAW: {
99✔
132
          code = tDeserializeTsdbRepOpts(buf, bufLen, &tsdbOpts);
99✔
133
          if (code) {
99!
134
            vError("vgId:%d, failed to deserialize tsdb rep opts since %s", TD_VID(pVnode), terrstr());
×
135
            goto _out;
×
136
          }
137
        } break;
99✔
138
        default:
×
139
          vError("vgId:%d, unexpected subfield type of snap info. typ:%d", TD_VID(pVnode), subField->typ);
×
140
          code = TSDB_CODE_INVALID_DATA_FMT;
×
141
          goto _out;
×
142
      }
143
    }
144

145
    // toggle snap replication mode
146
    vInfo("vgId:%d, vnode snap reader supported tsdb rep of format:%d", TD_VID(pVnode), tsdbOpts.format);
99!
147
    if (pReader->sver == 0 && tsdbOpts.format == TSDB_SNAP_REP_FMT_RAW) {
99!
148
      pReader->tsdbDone = true;
99✔
149
    } else {
150
      pReader->tsdbRAWDone = true;
×
151
    }
152

153
    vInfo("vgId:%d, vnode snap writer enabled replication mode: %s", TD_VID(pVnode),
99!
154
          (pReader->tsdbDone ? "raw" : "normal"));
155
  }
156

157
_out:
×
158
  return code;
99✔
159
}
160

161
int32_t vnodeSnapReaderOpen(SVnode *pVnode, SSnapshotParam *pParam, SVSnapReader **ppReader) {
99✔
162
  int32_t       code = 0;
99✔
163
  int64_t       sver = pParam->start;
99✔
164
  int64_t       ever = pParam->end;
99✔
165
  SVSnapReader *pReader = NULL;
99✔
166

167
  pReader = (SVSnapReader *)taosMemoryCalloc(1, sizeof(*pReader));
99✔
168
  if (pReader == NULL) {
99!
169
    code = terrno;
×
170
    goto _exit;
×
171
  }
172
  pReader->pVnode = pVnode;
99✔
173
  pReader->sver = sver;
99✔
174
  pReader->ever = ever;
99✔
175

176
  // snapshot info
177
  code = vnodeSnapReaderDealWithSnapInfo(pReader, pParam);
99✔
178
  if (code) goto _exit;
99!
179

180
  // open tsdb snapshot raw reader
181
  if (!pReader->tsdbRAWDone) {
99!
182
    code = tsdbSnapRAWReaderOpen(pVnode->pTsdb, ever, SNAP_DATA_RAW, &pReader->pTsdbRAWReader);
99✔
183
    if (code) goto _exit;
99!
184
  }
185

186
  // check snapshot ever
187
  SSnapshot snapshot = {0};
99✔
188
  code = vnodeGetSnapshot(pVnode, &snapshot);
99✔
189
  if (code) goto _exit;
99!
190
  if (ever != snapshot.lastApplyIndex) {
99!
191
    vError("vgId:%d, abort reader open due to vnode snapshot changed. ever:%" PRId64 ", commit ver:%" PRId64,
×
192
           TD_VID(pVnode), ever, snapshot.lastApplyIndex);
193
    code = TSDB_CODE_SYN_INTERNAL_ERROR;
×
194
    goto _exit;
×
195
  }
196

197
_exit:
99✔
198
  if (code) {
99!
199
    vError("vgId:%d, vnode snapshot reader open failed since %s", TD_VID(pVnode), tstrerror(code));
×
200
    *ppReader = NULL;
×
201
  } else {
202
    vInfo("vgId:%d, vnode snapshot reader opened, sver:%" PRId64 " ever:%" PRId64, TD_VID(pVnode), sver, ever);
99!
203
    *ppReader = pReader;
99✔
204
  }
205
  return code;
99✔
206
}
207

208
static void vnodeSnapReaderDestroyTsdbRanges(SVSnapReader *pReader) {
99✔
209
  int32_t tsdbTyps[TSDB_RETENTION_MAX] = {SNAP_DATA_TSDB, SNAP_DATA_RSMA1, SNAP_DATA_RSMA2};
99✔
210
  for (int32_t j = 0; j < TSDB_RETENTION_MAX; ++j) {
396✔
211
    TFileSetRangeArray **ppRanges = vnodeSnapReaderGetTsdbRanges(pReader, tsdbTyps[j]);
297✔
212
    if (ppRanges == NULL) continue;
297!
213
    tsdbTFileSetRangeArrayDestroy(ppRanges);
297✔
214
  }
215
}
99✔
216

217
void vnodeSnapReaderClose(SVSnapReader *pReader) {
99✔
218
  vInfo("vgId:%d, close vnode snapshot reader", TD_VID(pReader->pVnode));
99!
219
  vnodeSnapReaderDestroyTsdbRanges(pReader);
99✔
220

221
  if (pReader->pRsmaReader) {
99!
222
    rsmaSnapReaderClose(&pReader->pRsmaReader);
×
223
  }
224

225
  if (pReader->pTsdbReader) {
99!
226
    tsdbSnapReaderClose(&pReader->pTsdbReader);
×
227
  }
228

229
  if (pReader->pTsdbRAWReader) {
99!
230
    tsdbSnapRAWReaderClose(&pReader->pTsdbRAWReader);
×
231
  }
232

233
  if (pReader->pMetaReader) {
99!
234
    metaSnapReaderClose(&pReader->pMetaReader);
×
235
  }
236

237
  if (pReader->pTqSnapReader) {
99!
238
    tqSnapReaderClose(&pReader->pTqSnapReader);
×
239
  }
240

241
  if (pReader->pTqOffsetReader) {
99!
242
    tqSnapReaderClose(&pReader->pTqOffsetReader);
×
243
  }
244

245
  if (pReader->pTqCheckInfoReader) {
99!
246
    tqSnapReaderClose(&pReader->pTqCheckInfoReader);
×
247
  }
248

249
  taosMemoryFree(pReader);
99✔
250
}
99✔
251

252
int32_t vnodeSnapRead(SVSnapReader *pReader, uint8_t **ppData, uint32_t *nData) {
52,208✔
253
  int32_t code = 0;
52,208✔
254
  int32_t lino;
255
  SVnode *pVnode = pReader->pVnode;
52,208✔
256
  int32_t vgId = TD_VID(pReader->pVnode);
52,208✔
257

258
  // CONFIG ==============
259
  // FIXME: if commit multiple times and the config changed?
260
  if (!pReader->cfgDone) {
52,208✔
261
    char    fName[TSDB_FILENAME_LEN];
262
    int32_t offset = 0;
99✔
263

264
    vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, fName, TSDB_FILENAME_LEN);
99✔
265
    offset = strlen(fName);
99✔
266
    snprintf(fName + offset, TSDB_FILENAME_LEN - offset - 1, "%s%s", TD_DIRSEP, VND_INFO_FNAME);
99✔
267

268
    TdFilePtr pFile = taosOpenFile(fName, TD_FILE_READ);
99✔
269
    if (NULL == pFile) {
99!
270
      code = terrno;
×
271
      TSDB_CHECK_CODE(code, lino, _exit);
×
272
    }
273

274
    int64_t size;
275
    code = taosFStatFile(pFile, &size, NULL);
99✔
276
    if (code != 0) {
99!
277
      if (taosCloseFile(&pFile) != 0) {
×
278
        vError("vgId:%d, failed to close file", vgId);
×
279
      }
280
      TSDB_CHECK_CODE(code, lino, _exit);
×
281
    }
282

283
    *ppData = taosMemoryMalloc(sizeof(SSnapDataHdr) + size + 1);
99✔
284
    if (*ppData == NULL) {
99!
285
      if (taosCloseFile(&pFile) != 0) {
×
286
        vError("vgId:%d, failed to close file", vgId);
×
287
      }
288
      TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
289
    }
290
    ((SSnapDataHdr *)(*ppData))->type = SNAP_DATA_CFG;
99✔
291
    ((SSnapDataHdr *)(*ppData))->size = size + 1;
99✔
292
    ((SSnapDataHdr *)(*ppData))->data[size] = '\0';
99✔
293

294
    if (taosReadFile(pFile, ((SSnapDataHdr *)(*ppData))->data, size) < 0) {
99!
295
      taosMemoryFree(*ppData);
×
296
      if (taosCloseFile(&pFile) != 0) {
×
297
        vError("vgId:%d, failed to close file", vgId);
×
298
      }
299
      TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
300
    }
301

302
    if (taosCloseFile(&pFile) != 0) {
99!
303
      vError("vgId:%d, failed to close file", vgId);
×
304
    }
305

306
    pReader->cfgDone = 1;
99✔
307
    goto _exit;
99✔
308
  }
309

310
  // META ==============
311
  if (!pReader->metaDone) {
52,109✔
312
    // open reader if not
313
    if (pReader->pMetaReader == NULL) {
48,554✔
314
      code = metaSnapReaderOpen(pReader->pVnode->pMeta, pReader->sver, pReader->ever, &pReader->pMetaReader);
99✔
315
      TSDB_CHECK_CODE(code, lino, _exit);
99!
316
    }
317

318
    code = metaSnapRead(pReader->pMetaReader, ppData);
48,554✔
319
    TSDB_CHECK_CODE(code, lino, _exit);
48,554!
320

321
    if (*ppData) {
48,554✔
322
      goto _exit;
48,455✔
323
    } else {
324
      pReader->metaDone = 1;
99✔
325
      metaSnapReaderClose(&pReader->pMetaReader);
99✔
326
    }
327
  }
328

329
  // TSDB ==============
330
  if (!pReader->tsdbDone) {
3,654!
331
    // open if not
332
    if (pReader->pTsdbReader == NULL) {
×
333
      code = tsdbSnapReaderOpen(pReader->pVnode->pTsdb, pReader->sver, pReader->ever, SNAP_DATA_TSDB, pReader->pRanges,
×
334
                                &pReader->pTsdbReader);
335
      TSDB_CHECK_CODE(code, lino, _exit);
×
336
    }
337

338
    code = tsdbSnapRead(pReader->pTsdbReader, ppData);
×
339
    TSDB_CHECK_CODE(code, lino, _exit);
×
340
    if (*ppData) {
×
341
      goto _exit;
×
342
    } else {
343
      pReader->tsdbDone = 1;
×
344
      tsdbSnapReaderClose(&pReader->pTsdbReader);
×
345
    }
346
  }
347

348
  if (!pReader->tsdbRAWDone) {
3,654✔
349
    // open if not
350
    if (pReader->pTsdbRAWReader == NULL) {
3,561!
351
      code = tsdbSnapRAWReaderOpen(pReader->pVnode->pTsdb, pReader->ever, SNAP_DATA_RAW, &pReader->pTsdbRAWReader);
×
352
      TSDB_CHECK_CODE(code, lino, _exit);
×
353
    }
354

355
    code = tsdbSnapRAWRead(pReader->pTsdbRAWReader, ppData);
3,561✔
356
    TSDB_CHECK_CODE(code, lino, _exit);
3,561!
357
    if (*ppData) {
3,561✔
358
      goto _exit;
3,462✔
359
    } else {
360
      pReader->tsdbRAWDone = 1;
99✔
361
      tsdbSnapRAWReaderClose(&pReader->pTsdbRAWReader);
99✔
362
    }
363
  }
364

365
  // TQ ================
366
  vInfo("vgId:%d tq transform start", vgId);
192!
367
  if (!pReader->tqHandleDone) {
192✔
368
    if (pReader->pTqSnapReader == NULL) {
142✔
369
      code = tqSnapReaderOpen(pReader->pVnode->pTq, pReader->sver, pReader->ever, SNAP_DATA_TQ_HANDLE,
99✔
370
                              &pReader->pTqSnapReader);
371
      TSDB_CHECK_CODE(code, lino, _exit);
99!
372
    }
373

374
    code = tqSnapRead(pReader->pTqSnapReader, ppData);
142✔
375
    TSDB_CHECK_CODE(code, lino, _exit);
142!
376
    if (*ppData) {
142✔
377
      goto _exit;
43✔
378
    } else {
379
      pReader->tqHandleDone = 1;
99✔
380
      tqSnapReaderClose(&pReader->pTqSnapReader);
99✔
381
    }
382
  }
383
  if (!pReader->tqCheckInfoDone) {
149✔
384
    if (pReader->pTqCheckInfoReader == NULL) {
99!
385
      code = tqSnapReaderOpen(pReader->pVnode->pTq, pReader->sver, pReader->ever, SNAP_DATA_TQ_CHECKINFO,
99✔
386
                              &pReader->pTqCheckInfoReader);
387
      TSDB_CHECK_CODE(code, lino, _exit);
99!
388
    }
389

390
    code = tqSnapRead(pReader->pTqCheckInfoReader, ppData);
99✔
391
    TSDB_CHECK_CODE(code, lino, _exit);
99!
392
    if (*ppData) {
99!
393
      goto _exit;
×
394
    } else {
395
      pReader->tqCheckInfoDone = 1;
99✔
396
      tqSnapReaderClose(&pReader->pTqCheckInfoReader);
99✔
397
    }
398
  }
399
  if (!pReader->tqOffsetDone) {
149✔
400
    if (pReader->pTqOffsetReader == NULL) {
141✔
401
      code = tqSnapReaderOpen(pReader->pVnode->pTq, pReader->sver, pReader->ever, SNAP_DATA_TQ_OFFSET,
99✔
402
                              &pReader->pTqOffsetReader);
403
      TSDB_CHECK_CODE(code, lino, _exit);
99!
404
    }
405

406
    code = tqSnapRead(pReader->pTqOffsetReader, ppData);
141✔
407
    TSDB_CHECK_CODE(code, lino, _exit);
141!
408
    if (*ppData) {
141✔
409
      goto _exit;
42✔
410
    } else {
411
      pReader->tqOffsetDone = 1;
99✔
412
      tqSnapReaderClose(&pReader->pTqOffsetReader);
99✔
413
    }
414
  }
415

416
  // STREAM ============
417
  vInfo("vgId:%d stream task start to take snapshot", vgId);
107!
418
  if (!pReader->streamTaskDone) {
107!
419
    if (pReader->pStreamTaskReader == NULL) {
107✔
420
      code = streamTaskSnapReaderOpen(pReader->pVnode->pTq, pReader->sver, pReader->sver, &pReader->pStreamTaskReader);
99✔
421
      TSDB_CHECK_CODE(code, lino, _exit);
99!
422
    }
423

424
    code = streamTaskSnapRead(pReader->pStreamTaskReader, ppData);
107✔
425
    TSDB_CHECK_CODE(code, lino, _exit);
107!
426
    if (*ppData) {
107✔
427
      vInfo("vgId:%d no streamTask snapshot", vgId);
8!
428
      goto _exit;
8✔
429
    } else {
430
      pReader->streamTaskDone = 1;
99✔
431
      code = streamTaskSnapReaderClose(pReader->pStreamTaskReader);
99✔
432
      TSDB_CHECK_CODE(code, lino, _exit);
99!
433
      pReader->pStreamTaskReader = NULL;
99✔
434
    }
435
  }
436
  if (!pReader->streamStateDone) {
99!
437
    if (pReader->pStreamStateReader == NULL) {
99!
438
      code =
439
          streamStateSnapReaderOpen(pReader->pVnode->pTq, pReader->sver, pReader->sver, &pReader->pStreamStateReader);
99✔
440
      if (code) {
99!
441
        pReader->streamStateDone = 1;
×
442
        pReader->pStreamStateReader = NULL;
×
443
        TSDB_CHECK_CODE(code, lino, _exit);
×
444
      }
445
    }
446
    code = streamStateSnapRead(pReader->pStreamStateReader, ppData);
99✔
447
    TSDB_CHECK_CODE(code, lino, _exit);
99!
448
    if (*ppData) {
99!
UNCOV
449
      goto _exit;
×
450
    } else {
451
      pReader->streamStateDone = 1;
99✔
452
      code = streamStateSnapReaderClose(pReader->pStreamStateReader);
99✔
453
      TSDB_CHECK_CODE(code, lino, _exit);
99!
454
      pReader->pStreamStateReader = NULL;
99✔
455
    }
456
  }
457

458
  // RSMA ==============
459
  if (VND_IS_RSMA(pReader->pVnode) && !pReader->rsmaDone) {
99!
460
    // open if not
461
    if (pReader->pRsmaReader == NULL) {
×
462
      code = rsmaSnapReaderOpen(pReader->pVnode->pSma, pReader->sver, pReader->ever, &pReader->pRsmaReader);
×
463
      TSDB_CHECK_CODE(code, lino, _exit);
×
464
    }
465

466
    code = rsmaSnapRead(pReader->pRsmaReader, ppData);
×
467
    TSDB_CHECK_CODE(code, lino, _exit);
×
468
    if (*ppData) {
×
469
      goto _exit;
×
470
    } else {
471
      pReader->rsmaDone = 1;
×
472
      rsmaSnapReaderClose(&pReader->pRsmaReader);
×
473
    }
474
  }
475

476
  *ppData = NULL;
99✔
477
  *nData = 0;
99✔
478

479
_exit:
52,208✔
480
  if (code) {
52,208!
481
    vError("vgId:%d, vnode snapshot read failed at %s:%d since %s", vgId, __FILE__, lino, tstrerror(code));
×
482
  } else {
483
    if (*ppData) {
52,208✔
484
      SSnapDataHdr *pHdr = (SSnapDataHdr *)(*ppData);
52,109✔
485

486
      pReader->index++;
52,109✔
487
      *nData = sizeof(SSnapDataHdr) + pHdr->size;
52,109✔
488
      pHdr->index = pReader->index;
52,109✔
489
      vDebug("vgId:%d, vnode snapshot read data, index:%" PRId64 " type:%d blockLen:%d ", vgId, pReader->index,
52,109!
490
             pHdr->type, *nData);
491
    } else {
492
      vInfo("vgId:%d, vnode snapshot read data end, index:%" PRId64, vgId, pReader->index);
99!
493
    }
494
  }
495
  return code;
52,208✔
496
}
497

498
// SVSnapWriter ========================================================
499
struct SVSnapWriter {
500
  SVnode *pVnode;
501
  int64_t sver;
502
  int64_t ever;
503
  int64_t commitID;
504
  int64_t index;
505
  // config
506
  SVnodeInfo info;
507
  // meta
508
  SMetaSnapWriter *pMetaSnapWriter;
509
  // tsdb
510
  TFileSetRangeArray *pRanges;
511
  STsdbSnapWriter    *pTsdbSnapWriter;
512
  // tsdb raw
513
  STsdbSnapRAWWriter *pTsdbSnapRAWWriter;
514
  // tq
515
  STqSnapWriter *pTqSnapHandleWriter;
516
  STqSnapWriter *pTqSnapOffsetWriter;
517
  STqSnapWriter *pTqSnapCheckInfoWriter;
518
  // stream
519
  SStreamTaskWriter  *pStreamTaskWriter;
520
  SStreamStateWriter *pStreamStateWriter;
521
  // rsma
522
  TFileSetRangeArray *pRsmaRanges[TSDB_RETENTION_L2];
523
  SRSmaSnapWriter    *pRsmaSnapWriter;
524
};
525

526
TFileSetRangeArray **vnodeSnapWriterGetTsdbRanges(SVSnapWriter *pWriter, int32_t tsdbTyp) {
388✔
527
  switch (tsdbTyp) {
388!
528
    case SNAP_DATA_TSDB:
194✔
529
      return &pWriter->pRanges;
194✔
530
    case SNAP_DATA_RSMA1:
97✔
531
      return &pWriter->pRsmaRanges[0];
97✔
532
    case SNAP_DATA_RSMA2:
97✔
533
      return &pWriter->pRsmaRanges[1];
97✔
534
    default:
×
535
      return NULL;
×
536
  }
537
}
538

539
static int32_t vnodeSnapWriterDealWithSnapInfo(SVSnapWriter *pWriter, SSnapshotParam *pParam) {
97✔
540
  SVnode *pVnode = pWriter->pVnode;
97✔
541
  int32_t code = 0;
97✔
542
  int32_t lino;
543

544
  if (pParam->data) {
97!
545
    SSyncTLV *datHead = (void *)pParam->data;
97✔
546
    if (datHead->typ != TDMT_SYNC_PREP_SNAPSHOT_REPLY) {
97!
547
      TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_DATA_FMT, lino, _exit);
×
548
    }
549

550
    STsdbRepOpts         tsdbOpts = {0};
97✔
551
    TFileSetRangeArray **ppRanges = NULL;
97✔
552
    int32_t              offset = 0;
97✔
553

554
    while (offset + sizeof(SSyncTLV) < datHead->len) {
291✔
555
      SSyncTLV *subField = (void *)(datHead->val + offset);
194✔
556
      offset += sizeof(SSyncTLV) + subField->len;
194✔
557
      void   *buf = subField->val;
194✔
558
      int32_t bufLen = subField->len;
194✔
559

560
      switch (subField->typ) {
194!
561
        case SNAP_DATA_TSDB:
97✔
562
        case SNAP_DATA_RSMA1:
563
        case SNAP_DATA_RSMA2: {
564
          ppRanges = vnodeSnapWriterGetTsdbRanges(pWriter, subField->typ);
97✔
565
          if (ppRanges == NULL) {
97!
566
            vError("vgId:%d, unexpected subfield type in snapshot param. subtyp:%d", TD_VID(pVnode), subField->typ);
×
567
            TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
568
          }
569

570
          code = vnodeExtractSnapInfoDiff(buf, bufLen, ppRanges);
97✔
571
          TSDB_CHECK_CODE(code, lino, _exit);
97!
572
        } break;
97✔
573
        case SNAP_DATA_RAW: {
97✔
574
          code = tDeserializeTsdbRepOpts(buf, bufLen, &tsdbOpts);
97✔
575
          TSDB_CHECK_CODE(code, lino, _exit);
97!
576
        } break;
97✔
577
        default:
×
578
          vError("vgId:%d, unexpected subfield type of snap info. typ:%d", TD_VID(pVnode), subField->typ);
×
579
          TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_DATA_FMT, lino, _exit);
×
580
          goto _exit;
581
      }
582
    }
583

584
    vInfo("vgId:%d, vnode snap writer supported tsdb rep of format:%d", TD_VID(pVnode), tsdbOpts.format);
97!
585
  }
586

587
_exit:
×
588
  if (code) {
97!
589
    vError("vgId:%d %s failed at %s:%d since %s", TD_VID(pVnode), __func__, __FILE__, __LINE__, tstrerror(code));
×
590
  }
591
  return code;
97✔
592
}
593

594
extern int32_t tsdbDisableAndCancelAllBgTask(STsdb *pTsdb);
595
extern void    tsdbEnableBgTask(STsdb *pTsdb);
596

597
static int32_t vnodeCancelAndDisableAllBgTask(SVnode *pVnode) {
97✔
598
  TAOS_CHECK_RETURN(tsdbDisableAndCancelAllBgTask(pVnode->pTsdb));
97!
599
  TAOS_CHECK_RETURN(vnodeSyncCommit(pVnode));
97!
600
  TAOS_CHECK_RETURN(vnodeAChannelDestroy(&pVnode->commitChannel, true));
97!
601
  return 0;
97✔
602
}
603

604
static int32_t vnodeEnableBgTask(SVnode *pVnode) {
97✔
605
  tsdbEnableBgTask(pVnode->pTsdb);
97✔
606
  TAOS_CHECK_RETURN(vnodeAChannelInit(1, &pVnode->commitChannel));
97!
607
  return 0;
97✔
608
}
609

610
int32_t vnodeSnapWriterOpen(SVnode *pVnode, SSnapshotParam *pParam, SVSnapWriter **ppWriter) {
97✔
611
  int32_t       code = 0;
97✔
612
  int32_t       lino;
613
  SVSnapWriter *pWriter = NULL;
97✔
614
  int64_t       sver = pParam->start;
97✔
615
  int64_t       ever = pParam->end;
97✔
616

617
  // disable write, cancel and disable all bg tasks
618
  (void)taosThreadMutexLock(&pVnode->mutex);
97✔
619
  pVnode->disableWrite = true;
97✔
620
  (void)taosThreadMutexUnlock(&pVnode->mutex);
97✔
621

622
  code = vnodeCancelAndDisableAllBgTask(pVnode);
97✔
623
  TSDB_CHECK_CODE(code, lino, _exit);
97!
624

625
  // alloc
626
  pWriter = (SVSnapWriter *)taosMemoryCalloc(1, sizeof(*pWriter));
97✔
627
  if (pWriter == NULL) {
97!
628
    TSDB_CHECK_CODE(code = terrno, lino, _exit);
×
629
  }
630
  pWriter->pVnode = pVnode;
97✔
631
  pWriter->sver = sver;
97✔
632
  pWriter->ever = ever;
97✔
633

634
  // inc commit ID
635
  pWriter->commitID = ++pVnode->state.commitID;
97✔
636

637
  // snapshot info
638
  code = vnodeSnapWriterDealWithSnapInfo(pWriter, pParam);
97✔
639
  TSDB_CHECK_CODE(code, lino, _exit);
97!
640

641
_exit:
97✔
642
  if (code) {
97!
643
    vError("vgId:%d, vnode snapshot writer open failed since %s", TD_VID(pVnode), tstrerror(code));
×
644
    if (pWriter) taosMemoryFreeClear(pWriter);
×
645
    *ppWriter = NULL;
×
646
  } else {
647
    vInfo("vgId:%d, vnode snapshot writer opened, sver:%" PRId64 " ever:%" PRId64 " commit id:%" PRId64, TD_VID(pVnode),
97!
648
          sver, ever, pWriter->commitID);
649
    *ppWriter = pWriter;
97✔
650
  }
651
  return code;
97✔
652
}
653

654
static void vnodeSnapWriterDestroyTsdbRanges(SVSnapWriter *pWriter) {
97✔
655
  int32_t tsdbTyps[TSDB_RETENTION_MAX] = {SNAP_DATA_TSDB, SNAP_DATA_RSMA1, SNAP_DATA_RSMA2};
97✔
656
  for (int32_t j = 0; j < TSDB_RETENTION_MAX; ++j) {
388✔
657
    TFileSetRangeArray **ppRanges = vnodeSnapWriterGetTsdbRanges(pWriter, tsdbTyps[j]);
291✔
658
    if (ppRanges == NULL) continue;
291!
659
    tsdbTFileSetRangeArrayDestroy(ppRanges);
291✔
660
  }
661
}
97✔
662

663
int32_t vnodeSnapWriterClose(SVSnapWriter *pWriter, int8_t rollback, SSnapshot *pSnapshot) {
97✔
664
  int32_t code = 0;
97✔
665
  SVnode *pVnode = pWriter->pVnode;
97✔
666

667
  vnodeSnapWriterDestroyTsdbRanges(pWriter);
97✔
668

669
  // prepare
670
  if (pWriter->pTsdbSnapWriter) {
97!
671
    code = tsdbSnapWriterPrepareClose(pWriter->pTsdbSnapWriter, rollback);
×
672
    if (code) goto _exit;
×
673
  }
674

675
  if (pWriter->pTsdbSnapRAWWriter) {
97✔
676
    code = tsdbSnapRAWWriterPrepareClose(pWriter->pTsdbSnapRAWWriter);
89✔
677
    if (code) goto _exit;
89!
678
  }
679

680
  if (pWriter->pRsmaSnapWriter) {
97!
681
    code = rsmaSnapWriterPrepareClose(pWriter->pRsmaSnapWriter, rollback);
×
682
    if (code) goto _exit;
×
683
  }
684

685
  // commit json
686
  if (!rollback) {
97!
687
    pWriter->info.state.committed = pWriter->ever;
97✔
688
    pVnode->config = pWriter->info.config;
97✔
689
    pVnode->state = (SVState){.committed = pWriter->info.state.committed,
97✔
690
                              .applied = pWriter->info.state.committed,
97✔
691
                              .commitID = pWriter->commitID,
97✔
692
                              .commitTerm = pWriter->info.state.commitTerm,
97✔
693
                              .applyTerm = pWriter->info.state.commitTerm};
97✔
694
    pVnode->statis = pWriter->info.statis;
97✔
695
    char dir[TSDB_FILENAME_LEN] = {0};
97✔
696
    vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);
97✔
697

698
    code = vnodeCommitInfo(dir);
97✔
699
    if (code) goto _exit;
97!
700

701
  } else {
702
    vnodeRollback(pWriter->pVnode);
×
703
  }
704

705
  // commit/rollback sub-system
706
  if (pWriter->pMetaSnapWriter) {
97✔
707
    code = metaSnapWriterClose(&pWriter->pMetaSnapWriter, rollback);
89✔
708
    if (code) goto _exit;
89!
709
  }
710

711
  if (pWriter->pTsdbSnapWriter) {
97!
712
    code = tsdbSnapWriterClose(&pWriter->pTsdbSnapWriter, rollback);
×
713
    if (code) goto _exit;
×
714
  }
715

716
  if (pWriter->pTsdbSnapRAWWriter) {
97✔
717
    code = tsdbSnapRAWWriterClose(&pWriter->pTsdbSnapRAWWriter, rollback);
89✔
718
    if (code) goto _exit;
89!
719
  }
720

721
  if (pWriter->pTqSnapHandleWriter) {
97✔
722
    code = tqSnapWriterClose(&pWriter->pTqSnapHandleWriter, rollback);
43✔
723
    if (code) goto _exit;
43!
724
  }
725

726
  if (pWriter->pTqSnapCheckInfoWriter) {
97!
727
    code = tqSnapWriterClose(&pWriter->pTqSnapCheckInfoWriter, rollback);
×
728
    if (code) goto _exit;
×
729
  }
730

731
  if (pWriter->pTqSnapOffsetWriter) {
97✔
732
    code = tqSnapWriterClose(&pWriter->pTqSnapOffsetWriter, rollback);
42✔
733
    if (code) goto _exit;
42!
734
  }
735

736
  if (pWriter->pStreamTaskWriter) {
97✔
737
    code = streamTaskSnapWriterClose(pWriter->pStreamTaskWriter, rollback, pWriter->pStreamStateWriter == NULL ? 1 : 0);
4✔
738

739
    if (code) goto _exit;
4!
740
  }
741

742
  if (pWriter->pStreamStateWriter) {
97!
UNCOV
743
    code = streamStateSnapWriterClose(pWriter->pStreamStateWriter, rollback);
×
UNCOV
744
    if (code) goto _exit;
×
745

UNCOV
746
    code = streamStateRebuildFromSnap(pWriter->pStreamStateWriter, 0);
×
UNCOV
747
    pWriter->pStreamStateWriter = NULL;
×
UNCOV
748
    if (code) goto _exit;
×
749
  }
750

751
  if (pWriter->pRsmaSnapWriter) {
97!
752
    code = rsmaSnapWriterClose(&pWriter->pRsmaSnapWriter, rollback);
×
753
    if (code) goto _exit;
×
754
  }
755

756
  code = vnodeBegin(pVnode);
97✔
757
  if (code) goto _exit;
97!
758

759
  (void)taosThreadMutexLock(&pVnode->mutex);
97✔
760
  pVnode->disableWrite = false;
97✔
761
  (void)taosThreadMutexUnlock(&pVnode->mutex);
97✔
762

763
_exit:
97✔
764
  if (code) {
97!
765
    vError("vgId:%d, vnode snapshot writer close failed since %s", TD_VID(pWriter->pVnode), tstrerror(code));
×
766
  } else {
767
    vInfo("vgId:%d, vnode snapshot writer closed, rollback:%d", TD_VID(pVnode), rollback);
97!
768
    taosMemoryFree(pWriter);
97✔
769
  }
770
  if (vnodeEnableBgTask(pVnode) != 0) {
97!
771
    tsdbError("vgId:%d, failed to enable bg task", TD_VID(pVnode));
×
772
  }
773
  return code;
97✔
774
}
775

776
static int32_t vnodeSnapWriteInfo(SVSnapWriter *pWriter, uint8_t *pData, uint32_t nData) {
97✔
777
  int32_t       code = 0;
97✔
778
  int32_t       lino;
779
  SVnode       *pVnode = pWriter->pVnode;
97✔
780
  SSnapDataHdr *pHdr = (SSnapDataHdr *)pData;
97✔
781

782
  // decode info
783
  code = vnodeDecodeInfo(pHdr->data, &pWriter->info);
97✔
784
  TSDB_CHECK_CODE(code, lino, _exit);
97!
785

786
  // change some value
787
  pWriter->info.state.commitID = pWriter->commitID;
97✔
788

789
  // modify info as needed
790
  char dir[TSDB_FILENAME_LEN] = {0};
97✔
791
  vnodeGetPrimaryDir(pVnode->path, pVnode->diskPrimary, pVnode->pTfs, dir, TSDB_FILENAME_LEN);
97✔
792

793
  SVnodeStats vndStats = pWriter->info.config.vndStats;
97✔
794
  pWriter->info.config = pVnode->config;
97✔
795
  pWriter->info.config.vndStats = vndStats;
97✔
796
  vDebug("vgId:%d, save config while write snapshot", pWriter->pVnode->config.vgId);
97!
797
  code = vnodeSaveInfo(dir, &pWriter->info);
97✔
798
  TSDB_CHECK_CODE(code, lino, _exit);
97!
799

800
_exit:
97✔
801
  return code;
97✔
802
}
803

804
int32_t vnodeSnapWrite(SVSnapWriter *pWriter, uint8_t *pData, uint32_t nData) {
52,005✔
805
  int32_t       code = 0;
52,005✔
806
  int32_t       lino;
807
  SSnapDataHdr *pHdr = (SSnapDataHdr *)pData;
52,005✔
808
  SVnode       *pVnode = pWriter->pVnode;
52,005✔
809

810
  if (!(pHdr->size + sizeof(SSnapDataHdr) == nData)) {
52,005!
811
    return TSDB_CODE_INVALID_PARA;
×
812
  }
813

814
  if (pHdr->index != pWriter->index + 1) {
52,005!
815
    vError("vgId:%d, unexpected vnode snapshot msg. index:%" PRId64 ", expected index:%" PRId64, TD_VID(pVnode),
×
816
           pHdr->index, pWriter->index + 1);
817
    TSDB_CHECK_CODE(code = TSDB_CODE_INVALID_MSG, lino, _exit);
×
818
  }
819

820
  pWriter->index = pHdr->index;
52,005✔
821

822
  vDebug("vgId:%d, vnode snapshot write data, index:%" PRId64 " type:%d blockLen:%d", TD_VID(pVnode), pHdr->index,
52,005!
823
         pHdr->type, nData);
824

825
  switch (pHdr->type) {
52,005!
826
    case SNAP_DATA_CFG: {
97✔
827
      code = vnodeSnapWriteInfo(pWriter, pData, nData);
97✔
828
      TSDB_CHECK_CODE(code, lino, _exit);
97!
829
    } break;
97✔
830
    case SNAP_DATA_META: {
48,445✔
831
      // meta
832
      if (pWriter->pMetaSnapWriter == NULL) {
48,445✔
833
        code = metaSnapWriterOpen(pVnode->pMeta, pWriter->sver, pWriter->ever, &pWriter->pMetaSnapWriter);
89✔
834
        TSDB_CHECK_CODE(code, lino, _exit);
89!
835
      }
836

837
      code = metaSnapWrite(pWriter->pMetaSnapWriter, pData, nData);
48,445✔
838
      TSDB_CHECK_CODE(code, lino, _exit);
48,445!
839
    } break;
48,445✔
840
    case SNAP_DATA_TSDB:
×
841
    case SNAP_DATA_DEL: {
842
      // tsdb
843
      if (pWriter->pTsdbSnapWriter == NULL) {
×
844
        code = tsdbSnapWriterOpen(pVnode->pTsdb, pWriter->sver, pWriter->ever, pWriter->pRanges,
×
845
                                  &pWriter->pTsdbSnapWriter);
846
        TSDB_CHECK_CODE(code, lino, _exit);
×
847
      }
848

849
      code = tsdbSnapWrite(pWriter->pTsdbSnapWriter, pHdr);
×
850
      TSDB_CHECK_CODE(code, lino, _exit);
×
851
    } break;
×
852
    case SNAP_DATA_RAW: {
3,370✔
853
      // tsdb
854
      if (pWriter->pTsdbSnapRAWWriter == NULL) {
3,370✔
855
        code = tsdbSnapRAWWriterOpen(pVnode->pTsdb, pWriter->ever, &pWriter->pTsdbSnapRAWWriter);
89✔
856
        TSDB_CHECK_CODE(code, lino, _exit);
89!
857
      }
858

859
      code = tsdbSnapRAWWrite(pWriter->pTsdbSnapRAWWriter, pHdr);
3,370✔
860
      TSDB_CHECK_CODE(code, lino, _exit);
3,370!
861
    } break;
3,370✔
862
    case SNAP_DATA_TQ_HANDLE: {
43✔
863
      // tq handle
864
      if (pWriter->pTqSnapHandleWriter == NULL) {
43!
865
        code = tqSnapWriterOpen(pVnode->pTq, pWriter->sver, pWriter->ever, &pWriter->pTqSnapHandleWriter);
43✔
866
        TSDB_CHECK_CODE(code, lino, _exit);
43!
867
      }
868

869
      code = tqSnapHandleWrite(pWriter->pTqSnapHandleWriter, pData, nData);
43✔
870
      TSDB_CHECK_CODE(code, lino, _exit);
43!
871
    } break;
43✔
872
    case SNAP_DATA_TQ_CHECKINFO: {
×
873
      // tq checkinfo
874
      if (pWriter->pTqSnapCheckInfoWriter == NULL) {
×
875
        code = tqSnapWriterOpen(pVnode->pTq, pWriter->sver, pWriter->ever, &pWriter->pTqSnapCheckInfoWriter);
×
876
        TSDB_CHECK_CODE(code, lino, _exit);
×
877
      }
878

879
      code = tqSnapCheckInfoWrite(pWriter->pTqSnapCheckInfoWriter, pData, nData);
×
880
      TSDB_CHECK_CODE(code, lino, _exit);
×
881
    } break;
×
882
    case SNAP_DATA_TQ_OFFSET: {
42✔
883
      // tq offset
884
      if (pWriter->pTqSnapOffsetWriter == NULL) {
42!
885
        code = tqSnapWriterOpen(pVnode->pTq, pWriter->sver, pWriter->ever, &pWriter->pTqSnapOffsetWriter);
42✔
886
        TSDB_CHECK_CODE(code, lino, _exit);
42!
887
      }
888

889
      code = tqSnapOffsetWrite(pWriter->pTqSnapOffsetWriter, pData, nData);
42✔
890
      TSDB_CHECK_CODE(code, lino, _exit);
42!
891
    } break;
42✔
892
    case SNAP_DATA_STREAM_TASK:
8✔
893
    case SNAP_DATA_STREAM_TASK_CHECKPOINT: {
894
      if (pWriter->pStreamTaskWriter == NULL) {
8✔
895
        code = streamTaskSnapWriterOpen(pVnode->pTq, pWriter->sver, pWriter->ever, &pWriter->pStreamTaskWriter);
4✔
896
        TSDB_CHECK_CODE(code, lino, _exit);
4!
897
      }
898
      code = streamTaskSnapWrite(pWriter->pStreamTaskWriter, pData, nData);
8✔
899
      TSDB_CHECK_CODE(code, lino, _exit);
8!
900
    } break;
8✔
UNCOV
901
    case SNAP_DATA_STREAM_STATE_BACKEND: {
×
UNCOV
902
      if (pWriter->pStreamStateWriter == NULL) {
×
UNCOV
903
        code = streamStateSnapWriterOpen(pVnode->pTq, pWriter->sver, pWriter->ever, &pWriter->pStreamStateWriter);
×
UNCOV
904
        TSDB_CHECK_CODE(code, lino, _exit);
×
905
      }
UNCOV
906
      code = streamStateSnapWrite(pWriter->pStreamStateWriter, pData, nData);
×
UNCOV
907
      TSDB_CHECK_CODE(code, lino, _exit);
×
908

UNCOV
909
    } break;
×
910
    case SNAP_DATA_RSMA1:
×
911
    case SNAP_DATA_RSMA2:
912
    case SNAP_DATA_QTASK: {
913
      // rsma1/rsma2/qtask for rsma
914
      if (pWriter->pRsmaSnapWriter == NULL) {
×
915
        code = rsmaSnapWriterOpen(pVnode->pSma, pWriter->sver, pWriter->ever, (void **)pWriter->pRsmaRanges,
×
916
                                  &pWriter->pRsmaSnapWriter);
917
        TSDB_CHECK_CODE(code, lino, _exit);
×
918
      }
919

920
      code = rsmaSnapWrite(pWriter->pRsmaSnapWriter, pData, nData);
×
921
      TSDB_CHECK_CODE(code, lino, _exit);
×
922
    } break;
×
923
    default:
×
924
      break;
×
925
  }
926
_exit:
52,005✔
927
  if (code) {
52,005!
928
    vError("vgId:%d, vnode snapshot write failed since %s, index:%" PRId64 " type:%d nData:%d", TD_VID(pVnode),
×
929
           tstrerror(code), pHdr->index, pHdr->type, nData);
930
  }
931
  return code;
52,005✔
932
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc