#3541

Committed 26 Nov 2024 03:56AM UTC coverage: 60.776% (-0.07%) from 60.846%

Build # #3541

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28920 from taosdata/fix/TD-33008-3.0

fix(query)[TD-33008]. fix error handling in tsdbCacheRead

Run Details

120076 of 252763 branches covered (47.51%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1395 existing lines in 154 files now uncovered.

200995 of 275526 relevant lines covered (72.95%)

19612328.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.03

/source/dnode/snode/src/snode.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "executor.h"
#include "rsync.h"
#include "sndInt.h"
#include "tqCommon.h"
#include "tuuid.h"

// clang-format off
#define sndError(...) do {  if (sndDebugFlag & DEBUG_ERROR) {taosPrintLog("SND ERROR ", DEBUG_ERROR, sndDebugFlag, __VA_ARGS__);}} while (0)
#define sndInfo(...)  do {   if (sndDebugFlag & DEBUG_INFO) { taosPrintLog("SND INFO ", DEBUG_INFO, sndDebugFlag, __VA_ARGS__);}} while (0)
#define sndDebug(...) do {  if (sndDebugFlag & DEBUG_DEBUG) { taosPrintLog("SND ", DEBUG_DEBUG, sndDebugFlag, __VA_ARGS__);}} while (0)
// clang-format on

int32_t sndBuildStreamTask(SSnode *pSnode, SStreamTask *pTask, int64_t nextProcessVer) {
  if (!(pTask->info.taskLevel == TASK_LEVEL__AGG && taosArrayGetSize(pTask->upstreamInfo.pList) != 0)) {
    return TSDB_CODE_INVALID_PARA;
  }
  int32_t code = streamTaskInit(pTask, pSnode->pMeta, &pSnode->msgCb, nextProcessVer);
  if (code != TSDB_CODE_SUCCESS) {
    return code;
  }

  pTask->pBackend = NULL;
  streamTaskOpenAllUpstreamInput(pTask);

  streamTaskResetUpstreamStageInfo(pTask);

  SCheckpointInfo *pChkInfo = &pTask->chkInfo;
  tqSetRestoreVersionInfo(pTask);

  char *p = streamTaskGetStatus(pTask).name;
  if (pTask->info.fillHistory) {
    sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64
            " nextProcessVer:%" PRId64
            " child id:%d, level:%d, status:%s fill-history:%d, related stream task:0x%x trigger:%" PRId64 " ms",
            SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
            pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
            (int32_t)pTask->streamTaskId.taskId, pTask->info.delaySchedParam);
  } else {
    sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64
            " nextProcessVer:%" PRId64
            " child id:%d, level:%d, status:%s fill-history:%d, related fill-task:0x%x trigger:%" PRId64 " ms",
            SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
            pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
            (int32_t)pTask->hTaskInfo.id.taskId, pTask->info.delaySchedParam);
  }
  return 0;
}

SSnode *sndOpen(const char *path, const SSnodeOpt *pOption) {
  int32_t code = 0;
  SSnode *pSnode = taosMemoryCalloc(1, sizeof(SSnode));
  if (pSnode == NULL) {
    return NULL;
  }

  stopRsync();
  code = startRsync();
  if (code != 0) {
    terrno = code;
    goto FAIL;
  }

  pSnode->msgCb = pOption->msgCb;
  code = streamMetaOpen(path, pSnode, (FTaskBuild *)sndBuildStreamTask, tqExpandStreamTask, SNODE_HANDLE,
                        taosGetTimestampMs(), tqStartTaskCompleteCallback, &pSnode->pMeta);
  if (code != TSDB_CODE_SUCCESS) {
    terrno = code;
    goto FAIL;
  }

  streamMetaLoadAllTasks(pSnode->pMeta);
  return pSnode;

FAIL:
  taosMemoryFree(pSnode);
  return NULL;
}

int32_t sndInit(SSnode *pSnode) {
  if (streamTaskSchedTask(&pSnode->msgCb, pSnode->pMeta->vgId, 0, 0, STREAM_EXEC_T_START_ALL_TASKS) != 0) {
    sndError("failed to start all tasks");
  }
  return 0;
}

void sndClose(SSnode *pSnode) {
  stopRsync();
  streamMetaNotifyClose(pSnode->pMeta);
  if (streamMetaCommit(pSnode->pMeta) != 0) {
    sndError("failed to commit stream meta");
  }
  streamMetaClose(pSnode->pMeta);
  taosMemoryFree(pSnode);
}

int32_t sndProcessStreamMsg(SSnode *pSnode, SRpcMsg *pMsg) {
  switch (pMsg->msgType) {
    case TDMT_STREAM_TASK_RUN:
      return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);
    case TDMT_STREAM_TASK_DISPATCH:
      return tqStreamTaskProcessDispatchReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_TASK_DISPATCH_RSP:
      return tqStreamTaskProcessDispatchRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE:
      return tqStreamTaskProcessRetrieveReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_RSP:  // 1036
      break;
    case TDMT_VND_STREAM_TASK_CHECK:
      return tqStreamTaskProcessCheckReq(pSnode->pMeta, pMsg);
    case TDMT_VND_STREAM_TASK_CHECK_RSP:
      return tqStreamTaskProcessCheckRsp(pSnode->pMeta, pMsg, true);
    case TDMT_STREAM_TASK_CHECKPOINT_READY:
      return tqStreamTaskProcessCheckpointReadyMsg(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_HEARTBEAT_RSP:
      return tqStreamProcessStreamHbRsp(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_REQ_CHKPT_RSP:
      return tqStreamProcessReqCheckpointRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_TASK_CHECKPOINT_READY_RSP:
      return tqStreamProcessCheckpointReadyRsp(pSnode->pMeta, pMsg);
    case TDMT_MND_STREAM_CHKPT_REPORT_RSP:
      return tqStreamProcessChkptReportRsp(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_TRIGGER:
      return tqStreamTaskProcessRetrieveTriggerReq(pSnode->pMeta, pMsg);
    case TDMT_STREAM_RETRIEVE_TRIGGER_RSP:
      return tqStreamTaskProcessRetrieveTriggerRsp(pSnode->pMeta, pMsg);
    default:
      sndError("invalid snode msg:%d", pMsg->msgType);
      return TSDB_CODE_INVALID_MSG;
  }
  return 0;
}

int32_t sndProcessWriteMsg(SSnode *pSnode, SRpcMsg *pMsg, SRpcMsg *pRsp) {
  switch (pMsg->msgType) {
    case TDMT_STREAM_TASK_DEPLOY: {
      void   *pReq = POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead));
      int32_t len = pMsg->contLen - sizeof(SMsgHead);
      return tqStreamTaskProcessDeployReq(pSnode->pMeta, &pSnode->msgCb, pMsg->info.conn.applyIndex, pReq, len, true,
                                          true);
    }

    case TDMT_STREAM_TASK_DROP:
      return tqStreamTaskProcessDropReq(pSnode->pMeta, pMsg->pCont, pMsg->contLen);
    case TDMT_VND_STREAM_TASK_UPDATE:
      return tqStreamTaskProcessUpdateReq(pSnode->pMeta, &pSnode->msgCb, pMsg, true);
    case TDMT_VND_STREAM_TASK_RESET:
      return tqStreamTaskProcessTaskResetReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_STREAM_TASK_PAUSE:
      return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);
    case TDMT_STREAM_TASK_RESUME:
      return tqStreamTaskProcessTaskResumeReq(pSnode->pMeta, pMsg->info.conn.applyIndex, pMsg->pCont, false);
    case TDMT_STREAM_TASK_UPDATE_CHKPT:
      return tqStreamTaskProcessUpdateCheckpointReq(pSnode->pMeta, true, pMsg->pCont);
    case TDMT_STREAM_CONSEN_CHKPT:
      return tqStreamTaskProcessConsenChkptIdReq(pSnode->pMeta, pMsg);
    default:
      return TSDB_CODE_INVALID_MSG;
  }
  return 0;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "executor.h"
17	#include "rsync.h"
18	#include "sndInt.h"
19	#include "tqCommon.h"
20	#include "tuuid.h"
21
22	// clang-format off
23	#define sndError(...) do { if (sndDebugFlag & DEBUG_ERROR) {taosPrintLog("SND ERROR ", DEBUG_ERROR, sndDebugFlag, __VA_ARGS__);}} while (0)
24	#define sndInfo(...) do { if (sndDebugFlag & DEBUG_INFO) { taosPrintLog("SND INFO ", DEBUG_INFO, sndDebugFlag, __VA_ARGS__);}} while (0)
25	#define sndDebug(...) do { if (sndDebugFlag & DEBUG_DEBUG) { taosPrintLog("SND ", DEBUG_DEBUG, sndDebugFlag, __VA_ARGS__);}} while (0)
26	// clang-format on
27
28	int32_t sndBuildStreamTask(SSnode pSnode, SStreamTask pTask, int64_t nextProcessVer) {	93✔
29	if (!(pTask->info.taskLevel == TASK_LEVEL__AGG && taosArrayGetSize(pTask->upstreamInfo.pList) != 0)) {	93!
30	return TSDB_CODE_INVALID_PARA;	×
31	}
32	int32_t code = streamTaskInit(pTask, pSnode->pMeta, &pSnode->msgCb, nextProcessVer);	93✔
33	if (code != TSDB_CODE_SUCCESS) {	93!
34	return code;	×
35	}
36
37	pTask->pBackend = NULL;	93✔
38	streamTaskOpenAllUpstreamInput(pTask);	93✔
39
40	streamTaskResetUpstreamStageInfo(pTask);	93✔
41
42	SCheckpointInfo *pChkInfo = &pTask->chkInfo;	93✔
43	tqSetRestoreVersionInfo(pTask);	93✔
44
45	char *p = streamTaskGetStatus(pTask).name;	93✔
46	if (pTask->info.fillHistory) {	93✔
47	sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64	31!
48	" nextProcessVer:%" PRId64
49	" child id:%d, level:%d, status:%s fill-history:%d, related stream task:0x%x trigger:%" PRId64 " ms",
50	SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
51	pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
52	(int32_t)pTask->streamTaskId.taskId, pTask->info.delaySchedParam);
53	} else {
54	sndInfo("vgId:%d build stream task, s-task:%s, %p checkpointId:%" PRId64 " checkpointVer:%" PRId64	62!
55	" nextProcessVer:%" PRId64
56	" child id:%d, level:%d, status:%s fill-history:%d, related fill-task:0x%x trigger:%" PRId64 " ms",
57	SNODE_HANDLE, pTask->id.idStr, pTask, pChkInfo->checkpointId, pChkInfo->checkpointVer, pChkInfo->nextProcessVer,
58	pTask->info.selfChildId, pTask->info.taskLevel, p, pTask->info.fillHistory,
59	(int32_t)pTask->hTaskInfo.id.taskId, pTask->info.delaySchedParam);
60	}
61	return 0;	93✔
62	}
63
64	SSnode sndOpen(const char path, const SSnodeOpt *pOption) {	36✔
65	int32_t code = 0;	36✔
66	SSnode *pSnode = taosMemoryCalloc(1, sizeof(SSnode));	36✔
67	if (pSnode == NULL) {	36!
68	return NULL;	×
69	}
70
71	stopRsync();	36✔
72	code = startRsync();	36✔
73	if (code != 0) {	36!
74	terrno = code;	×
75	goto FAIL;	×
76	}
77
78	pSnode->msgCb = pOption->msgCb;	36✔
79	code = streamMetaOpen(path, pSnode, (FTaskBuild *)sndBuildStreamTask, tqExpandStreamTask, SNODE_HANDLE,	72✔
80	taosGetTimestampMs(), tqStartTaskCompleteCallback, &pSnode->pMeta);
81	if (code != TSDB_CODE_SUCCESS) {	36!
82	terrno = code;	×
83	goto FAIL;	×
84	}
85
86	streamMetaLoadAllTasks(pSnode->pMeta);	36✔
87	return pSnode;	36✔
88
89	FAIL:	×
90	taosMemoryFree(pSnode);	×
91	return NULL;	×
92	}
93
94	int32_t sndInit(SSnode *pSnode) {	36✔
95	if (streamTaskSchedTask(&pSnode->msgCb, pSnode->pMeta->vgId, 0, 0, STREAM_EXEC_T_START_ALL_TASKS) != 0) {	36!
96	sndError("failed to start all tasks");	×
97	}
98	return 0;	36✔
99	}
100
101	void sndClose(SSnode *pSnode) {	36✔
102	stopRsync();	36✔
103	streamMetaNotifyClose(pSnode->pMeta);	36✔
104	if (streamMetaCommit(pSnode->pMeta) != 0) {	36!
105	sndError("failed to commit stream meta");	×
106	}
107	streamMetaClose(pSnode->pMeta);	36✔
108	taosMemoryFree(pSnode);	36✔
109	}	36✔
110
111	int32_t sndProcessStreamMsg(SSnode pSnode, SRpcMsg pMsg) {	13,341✔
112	switch (pMsg->msgType) {	13,341!
113	case TDMT_STREAM_TASK_RUN:	3,158✔
114	return tqStreamTaskProcessRunReq(pSnode->pMeta, pMsg, true);	3,158✔
115	case TDMT_STREAM_TASK_DISPATCH:	2,369✔
116	return tqStreamTaskProcessDispatchReq(pSnode->pMeta, pMsg);	2,369✔
117	case TDMT_STREAM_TASK_DISPATCH_RSP:	2,117✔
118	return tqStreamTaskProcessDispatchRsp(pSnode->pMeta, pMsg);	2,117✔
119	case TDMT_STREAM_RETRIEVE:	×
120	return tqStreamTaskProcessRetrieveReq(pSnode->pMeta, pMsg);	×
121	case TDMT_STREAM_RETRIEVE_RSP: // 1036	117✔
122	break;	117✔
123	case TDMT_VND_STREAM_TASK_CHECK:	351✔
124	return tqStreamTaskProcessCheckReq(pSnode->pMeta, pMsg);	351✔
125	case TDMT_VND_STREAM_TASK_CHECK_RSP:	295✔
126	return tqStreamTaskProcessCheckRsp(pSnode->pMeta, pMsg, true);	295✔
127	case TDMT_STREAM_TASK_CHECKPOINT_READY:	475✔
128	return tqStreamTaskProcessCheckpointReadyMsg(pSnode->pMeta, pMsg);	475✔
129	case TDMT_MND_STREAM_HEARTBEAT_RSP:	3,726✔
130	return tqStreamProcessStreamHbRsp(pSnode->pMeta, pMsg);	3,726✔
131	case TDMT_MND_STREAM_REQ_CHKPT_RSP:	29✔
132	return tqStreamProcessReqCheckpointRsp(pSnode->pMeta, pMsg);	29✔
133	case TDMT_STREAM_TASK_CHECKPOINT_READY_RSP:	478✔
134	return tqStreamProcessCheckpointReadyRsp(pSnode->pMeta, pMsg);	478✔
135	case TDMT_MND_STREAM_CHKPT_REPORT_RSP:	226✔
136	return tqStreamProcessChkptReportRsp(pSnode->pMeta, pMsg);	226✔
137	case TDMT_STREAM_RETRIEVE_TRIGGER:	×
138	return tqStreamTaskProcessRetrieveTriggerReq(pSnode->pMeta, pMsg);	×
139	case TDMT_STREAM_RETRIEVE_TRIGGER_RSP:	×
140	return tqStreamTaskProcessRetrieveTriggerRsp(pSnode->pMeta, pMsg);	×
UNCOV 141	default:	×
UNCOV 142	sndError("invalid snode msg:%d", pMsg->msgType);	×
143	return TSDB_CODE_INVALID_MSG;	×
144	}
145	return 0;	117✔
146	}
147
148	int32_t sndProcessWriteMsg(SSnode pSnode, SRpcMsg pMsg, SRpcMsg *pRsp) {	361✔
149	switch (pMsg->msgType) {	361!
150	case TDMT_STREAM_TASK_DEPLOY: {	85✔
151	void *pReq = POINTER_SHIFT(pMsg->pCont, sizeof(SMsgHead));	85✔
152	int32_t len = pMsg->contLen - sizeof(SMsgHead);	85✔
153	return tqStreamTaskProcessDeployReq(pSnode->pMeta, &pSnode->msgCb, pMsg->info.conn.applyIndex, pReq, len, true,	85✔
154	true);
155	}
156
157	case TDMT_STREAM_TASK_DROP:	49✔
158	return tqStreamTaskProcessDropReq(pSnode->pMeta, pMsg->pCont, pMsg->contLen);	49✔
159	case TDMT_VND_STREAM_TASK_UPDATE:	1✔
160	return tqStreamTaskProcessUpdateReq(pSnode->pMeta, &pSnode->msgCb, pMsg, true);	1✔
161	case TDMT_VND_STREAM_TASK_RESET:	×
162	return tqStreamTaskProcessTaskResetReq(pSnode->pMeta, pMsg->pCont);	×
UNCOV 163	case TDMT_STREAM_TASK_PAUSE:	×
UNCOV 164	return tqStreamTaskProcessTaskPauseReq(pSnode->pMeta, pMsg->pCont);	×
UNCOV 165	case TDMT_STREAM_TASK_RESUME:	×
UNCOV 166	return tqStreamTaskProcessTaskResumeReq(pSnode->pMeta, pMsg->info.conn.applyIndex, pMsg->pCont, false);	×
167	case TDMT_STREAM_TASK_UPDATE_CHKPT:	223✔
168	return tqStreamTaskProcessUpdateCheckpointReq(pSnode->pMeta, true, pMsg->pCont);	223✔
169	case TDMT_STREAM_CONSEN_CHKPT:	3✔
170	return tqStreamTaskProcessConsenChkptIdReq(pSnode->pMeta, pMsg);	3✔
171	default:	×
172	return TSDB_CODE_INVALID_MSG;	×
173	}
174	return 0;
175	}

taosdata / TDengine / #3541

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous