#3541

Committed 26 Nov 2024 03:56AM UTC coverage: 60.776% (-0.07%) from 60.846%

Build # #3541

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28920 from taosdata/fix/TD-33008-3.0

fix(query)[TD-33008]. fix error handling in tsdbCacheRead

Run Details

120076 of 252763 branches covered (47.51%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1395 existing lines in 154 files now uncovered.

200995 of 275526 relevant lines covered (72.95%)

19612328.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.99

/source/dnode/qnode/src/qnode.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "tqueue.h"

#include "executor.h"
#include "qndInt.h"
#include "query.h"
#include "qworker.h"

int32_t qndOpen(const SQnodeOpt *pOption, SQnode **pQnode) {
  *pQnode = taosMemoryCalloc(1, sizeof(SQnode));
  if (NULL == *pQnode) {
    qError("calloc SQnode failed");
    return terrno;
  }
  (*pQnode)->qndId = QNODE_HANDLE;

  int32_t code = qWorkerInit(NODE_TYPE_QNODE, (*pQnode)->qndId, (void **)&(*pQnode)->pQuery, &pOption->msgCb);
  if (TSDB_CODE_SUCCESS != code) {
    taosMemoryFreeClear(pQnode);
    return code;
  }

  (*pQnode)->msgCb = pOption->msgCb;
  return TSDB_CODE_SUCCESS;
}

void qndClose(SQnode *pQnode) {
  qWorkerDestroy((void **)&pQnode->pQuery);
  taosMemoryFree(pQnode);
}

int32_t qndGetLoad(SQnode *pQnode, SQnodeLoad *pLoad) {
  SReadHandle  handle = {.pMsgCb = &pQnode->msgCb};
  SQWorkerStat stat = {0};

  int32_t code = qWorkerGetStat(&handle, pQnode->pQuery, &stat);
  if (code) {
    return code;
  }

  pLoad->numOfQueryInQueue = stat.numOfQueryInQueue;
  pLoad->numOfFetchInQueue = stat.numOfFetchInQueue;
  pLoad->timeInQueryQueue = stat.timeInQueryQueue;
  pLoad->timeInFetchQueue = stat.timeInFetchQueue;
  pLoad->cacheDataSize = stat.cacheDataSize;
  pLoad->numOfProcessedQuery = stat.queryProcessed;
  pLoad->numOfProcessedCQuery = stat.cqueryProcessed;
  pLoad->numOfProcessedFetch = stat.fetchProcessed;
  pLoad->numOfProcessedDrop = stat.dropProcessed;
  pLoad->numOfProcessedNotify = stat.notifyProcessed;
  pLoad->numOfProcessedHb = stat.hbProcessed;
  pLoad->numOfProcessedDelete = stat.deleteProcessed;

  return 0;
}

int32_t qndPreprocessQueryMsg(SQnode *pQnode, SRpcMsg *pMsg) {
  if (TDMT_SCH_QUERY != pMsg->msgType && TDMT_SCH_MERGE_QUERY != pMsg->msgType) {
    return 0;
  }

  return qWorkerPreprocessQueryMsg(pQnode->pQuery, pMsg, false);
}

int32_t qndProcessQueryMsg(SQnode *pQnode, SQueueInfo *pInfo, SRpcMsg *pMsg) {
  int32_t     code = -1;
  int64_t     ts = pInfo->timestamp;
  SReadHandle handle = {.pMsgCb = &pQnode->msgCb, .pWorkerCb = pInfo->workerCb};
  qTrace("message in qnode queue is processing");

  switch (pMsg->msgType) {
    case TDMT_SCH_QUERY:
    case TDMT_SCH_MERGE_QUERY:
      code = qWorkerProcessQueryMsg(&handle, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_SCH_QUERY_CONTINUE:
      code = qWorkerProcessCQueryMsg(&handle, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_SCH_FETCH:
    case TDMT_SCH_MERGE_FETCH:
      code = qWorkerProcessFetchMsg(pQnode, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_SCH_CANCEL_TASK:
      // code = qWorkerProcessCancelMsg(pQnode, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_SCH_DROP_TASK:
      code = qWorkerProcessDropMsg(pQnode, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_VND_TMQ_CONSUME:
      // code =  tqProcessConsumeReq(pQnode->pTq, pMsg);
      // break;
    case TDMT_SCH_QUERY_HEARTBEAT:
      code = qWorkerProcessHbMsg(pQnode, pQnode->pQuery, pMsg, ts);
      break;
    case TDMT_SCH_TASK_NOTIFY:
      code = qWorkerProcessNotifyMsg(pQnode, pQnode->pQuery, pMsg, ts);
      break;
    default:
      qError("unknown msg type:%d in qnode queue", pMsg->msgType);
      terrno = TSDB_CODE_APP_ERROR;
  }

  if (code == 0) {
    return TSDB_CODE_ACTION_IN_PROGRESS;
  } else {
    return code;
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "tqueue.h"
17
18	#include "executor.h"
19	#include "qndInt.h"
20	#include "query.h"
21	#include "qworker.h"
22
23	int32_t qndOpen(const SQnodeOpt pOption, SQnode *pQnode) {	538✔
24	*pQnode = taosMemoryCalloc(1, sizeof(SQnode));	538✔
25	if (NULL == *pQnode) {	538!
26	qError("calloc SQnode failed");	×
27	return terrno;	×
28	}
29	(*pQnode)->qndId = QNODE_HANDLE;	538✔
30
31	int32_t code = qWorkerInit(NODE_TYPE_QNODE, (pQnode)->qndId, (void )&(pQnode)->pQuery, &pOption->msgCb);	538✔
32	if (TSDB_CODE_SUCCESS != code) {	538!
33	taosMemoryFreeClear(pQnode);	×
34	return code;	×
35	}
36
37	(*pQnode)->msgCb = pOption->msgCb;	538✔
38	return TSDB_CODE_SUCCESS;	538✔
39	}
40
41	void qndClose(SQnode *pQnode) {	538✔
42	qWorkerDestroy((void **)&pQnode->pQuery);	538✔
43	taosMemoryFree(pQnode);	538✔
44	}	538✔
45
46	int32_t qndGetLoad(SQnode pQnode, SQnodeLoad pLoad) {	42,842✔
47	SReadHandle handle = {.pMsgCb = &pQnode->msgCb};	42,842✔
48	SQWorkerStat stat = {0};	42,842✔
49
50	int32_t code = qWorkerGetStat(&handle, pQnode->pQuery, &stat);	42,842✔
51	if (code) {	42,842!
52	return code;	×
53	}
54
55	pLoad->numOfQueryInQueue = stat.numOfQueryInQueue;	42,842✔
56	pLoad->numOfFetchInQueue = stat.numOfFetchInQueue;	42,842✔
57	pLoad->timeInQueryQueue = stat.timeInQueryQueue;	42,842✔
58	pLoad->timeInFetchQueue = stat.timeInFetchQueue;	42,842✔
59	pLoad->cacheDataSize = stat.cacheDataSize;	42,842✔
60	pLoad->numOfProcessedQuery = stat.queryProcessed;	42,842✔
61	pLoad->numOfProcessedCQuery = stat.cqueryProcessed;	42,842✔
62	pLoad->numOfProcessedFetch = stat.fetchProcessed;	42,842✔
63	pLoad->numOfProcessedDrop = stat.dropProcessed;	42,842✔
64	pLoad->numOfProcessedNotify = stat.notifyProcessed;	42,842✔
65	pLoad->numOfProcessedHb = stat.hbProcessed;	42,842✔
66	pLoad->numOfProcessedDelete = stat.deleteProcessed;	42,842✔
67
68	return 0;	42,842✔
69	}
70
71	int32_t qndPreprocessQueryMsg(SQnode pQnode, SRpcMsg pMsg) {	295,503✔
72	if (TDMT_SCH_QUERY != pMsg->msgType && TDMT_SCH_MERGE_QUERY != pMsg->msgType) {	295,503!
73	return 0;	×
74	}
75
76	return qWorkerPreprocessQueryMsg(pQnode->pQuery, pMsg, false);	295,503✔
77	}
78
79	int32_t qndProcessQueryMsg(SQnode pQnode, SQueueInfo pInfo, SRpcMsg *pMsg) {	1,050,997✔
80	int32_t code = -1;	1,050,997✔
81	int64_t ts = pInfo->timestamp;	1,050,997✔
82	SReadHandle handle = {.pMsgCb = &pQnode->msgCb, .pWorkerCb = pInfo->workerCb};	1,050,997✔
83	qTrace("message in qnode queue is processing");	1,050,997✔
84
85	switch (pMsg->msgType) {	1,051,004!
86	case TDMT_SCH_QUERY:	295,539✔
87	case TDMT_SCH_MERGE_QUERY:
88	code = qWorkerProcessQueryMsg(&handle, pQnode->pQuery, pMsg, ts);	295,539✔
89	break;	295,527✔
90	case TDMT_SCH_QUERY_CONTINUE:	1,908✔
91	code = qWorkerProcessCQueryMsg(&handle, pQnode->pQuery, pMsg, ts);	1,908✔
92	break;	1,908✔
93	case TDMT_SCH_FETCH:	354,959✔
94	case TDMT_SCH_MERGE_FETCH:
95	code = qWorkerProcessFetchMsg(pQnode, pQnode->pQuery, pMsg, ts);	354,959✔
96	break;	354,959✔
97	case TDMT_SCH_CANCEL_TASK:	×
98	// code = qWorkerProcessCancelMsg(pQnode, pQnode->pQuery, pMsg, ts);
99	break;	×
100	case TDMT_SCH_DROP_TASK:	295,504✔
101	code = qWorkerProcessDropMsg(pQnode, pQnode->pQuery, pMsg, ts);	295,504✔
102	break;	295,504✔
103	case TDMT_VND_TMQ_CONSUME:	103,094✔
104	// code = tqProcessConsumeReq(pQnode->pTq, pMsg);
105	// break;
106	case TDMT_SCH_QUERY_HEARTBEAT:
107	code = qWorkerProcessHbMsg(pQnode, pQnode->pQuery, pMsg, ts);	103,094✔
108	break;	103,094✔
109	case TDMT_SCH_TASK_NOTIFY:	×
110	code = qWorkerProcessNotifyMsg(pQnode, pQnode->pQuery, pMsg, ts);	×
111	break;	×
112	default:	×
113	qError("unknown msg type:%d in qnode queue", pMsg->msgType);	×
114	terrno = TSDB_CODE_APP_ERROR;	×
115	}
116
117	if (code == 0) {	1,050,992!
118	return TSDB_CODE_ACTION_IN_PROGRESS;	1,050,992✔
119	} else {
UNCOV 120	return code;	×
121	}
122	}

taosdata / TDengine / #3541

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous