#3541

Committed 26 Nov 2024 03:56AM UTC coverage: 60.776% (-0.07%) from 60.846%

Build # #3541

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28920 from taosdata/fix/TD-33008-3.0

fix(query)[TD-33008]. fix error handling in tsdbCacheRead

Run Details

120076 of 252763 branches covered (47.51%)

Branch coverage included in aggregate %.

0 of 2 new or added lines in 1 file covered. (0.0%)

1395 existing lines in 154 files now uncovered.

200995 of 275526 relevant lines covered (72.95%)

19612328.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.0

/source/dnode/mnode/sdb/src/sdbHash.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#define _DEFAULT_SOURCE
#include "sdb.h"

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow);

const char *sdbTableName(ESdbType type) {
  switch (type) {
    case SDB_TRANS:
      return "trans";
    case SDB_CLUSTER:
      return "cluster";
    case SDB_MNODE:
      return "mnode";
    case SDB_QNODE:
      return "qnode";
    case SDB_SNODE:
      return "snode";
    case SDB_DNODE:
      return "dnode";
    case SDB_USER:
      return "user";
    case SDB_AUTH:
      return "auth";
    case SDB_ACCT:
      return "acct";
    case SDB_STREAM_CK:
      return "stream_ck";
    case SDB_STREAM:
      return "stream";
    case SDB_OFFSET:
      return "offset";
    case SDB_SUBSCRIBE:
      return "subscribe";
    case SDB_CONSUMER:
      return "consumer";
    case SDB_TOPIC:
      return "topic";
    case SDB_VGROUP:
      return "vgroup";
    case SDB_SMA:
      return "sma";
    case SDB_STB:
      return "stb";
    case SDB_DB:
      return "db";
    case SDB_FUNC:
      return "func";
    case SDB_IDX:
      return "idx";
    case SDB_VIEW:
      return "view";
    case SDB_STREAM_SEQ:
      return "stream_seq";
    case SDB_COMPACT:
      return "compact";
    case SDB_COMPACT_DETAIL:
      return "compact_detail";
    case SDB_GRANT:
      return "grant";
    case SDB_ARBGROUP:
      return "arb_group";
    case SDB_ANODE:
      return "anode";
    default:
      return "undefine";
  }
}

const char *sdbStatusName(ESdbStatus status) {
  switch (status) {
    case SDB_STATUS_CREATING:
      return "creating";
    case SDB_STATUS_DROPPING:
      return "dropping";
    case SDB_STATUS_READY:
      return "ready";
    case SDB_STATUS_DROPPED:
      return "dropped";
    case SDB_STATUS_INIT:
      return "init";
    case SDB_STATUS_UPDATE:
      return "update";
    default:
      return "undefine";
  }
}

void sdbPrintOper(SSdb *pSdb, SSdbRow *pRow, const char *oper) {
#if 1
  EKeyType keyType = pSdb->keyTypes[pRow->type];

  if (keyType == SDB_KEY_BINARY) {
    mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT32) {
    mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), *(int32_t *)pRow->pObj,
           pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else if (keyType == SDB_KEY_INT64) {
    mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),
           *(int64_t *)pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
  } else {
  }
#endif
}

static SHashObj *sdbGetHash(SSdb *pSdb, int32_t type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return NULL;
  }

  SHashObj *hash = pSdb->hashObjs[type];
  if (hash == NULL) {
    terrno = TSDB_CODE_APP_ERROR;
    return NULL;
  }

  return hash;
}

static int32_t sdbGetkeySize(SSdb *pSdb, ESdbType type, const void *pKey) {
  int32_t  keySize = 0;
  EKeyType keyType = pSdb->keyTypes[type];

  if (keyType == SDB_KEY_INT32) {
    keySize = sizeof(int32_t);
  } else if (keyType == SDB_KEY_BINARY) {
    keySize = strlen(pKey) + 1;
  } else {
    keySize = sizeof(int64_t);
  }

  return keySize;
}

static int32_t sdbInsertRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (pOldRow != NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;
    return terrno;
  }

  pRow->refCount = 0;
  pRow->status = pRaw->status;
  sdbPrintOper(pSdb, pRow, "insert");

  int32_t code = 0;
  if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    return code;
  }

  SdbInsertFp insertFp = pSdb->insertFps[pRow->type];
  if (insertFp != NULL) {
    code = (*insertFp)(pSdb, pRow->pObj);
    if (code != 0) {
      if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {
        mError("failed to remove row from hash");
      }
      sdbFreeRow(pSdb, pRow, false);
      sdbUnLock(pSdb, type);
      terrno = code;
      return terrno;
    }
  }

  sdbUnLock(pSdb, type);

  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int32_t *)pRow->pObj));
  }
  if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {
    pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], *((int64_t *)pRow->pObj));
  }
  pSdb->tableVer[pRow->type]++;

  return 0;
}

static int32_t sdbUpdateRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pNewRow, int32_t keySize) {
  int32_t type = pNewRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);
  }

  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;
  sdbPrintOper(pSdb, pOldRow, "update");

  int32_t     code = 0;
  SdbUpdateFp updateFp = pSdb->updateFps[type];
  if (updateFp != NULL) {
    code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);
  }
  sdbUnLock(pSdb, type);

  // sdbUnLock(pSdb, type);
  sdbFreeRow(pSdb, pNewRow, false);

  pSdb->tableVer[pOldRow->type]++;
  return code;
}

static int32_t sdbDeleteRow(SSdb *pSdb, SHashObj *hash, SSdbRaw *pRaw, SSdbRow *pRow, int32_t keySize) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);
  if (ppOldRow == NULL || *ppOldRow == NULL) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  SSdbRow *pOldRow = *ppOldRow;
  pOldRow->status = pRaw->status;

  (void)atomic_add_fetch_32(&pOldRow->refCount, 1);
  sdbPrintOper(pSdb, pOldRow, "delete");

  if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {
    sdbUnLock(pSdb, type);
    sdbFreeRow(pSdb, pRow, false);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return terrno;
  }
  pSdb->tableVer[pOldRow->type]++;
  sdbUnLock(pSdb, type);

  sdbFreeRow(pSdb, pRow, false);

  sdbCheckRow(pSdb, pOldRow);
  return 0;
}

int32_t sdbWriteWithoutFree(SSdb *pSdb, SSdbRaw *pRaw) {
  SHashObj *hash = sdbGetHash(pSdb, pRaw->type);
  if (hash == NULL) return terrno;

  SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];
  SSdbRow    *pRow = (*decodeFp)(pRaw);
  if (pRow == NULL) return terrno;

  pRow->type = pRaw->type;

  int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);
  int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;

  switch (pRaw->status) {
    case SDB_STATUS_CREATING:
      code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_READY:
    case SDB_STATUS_UPDATE:
    case SDB_STATUS_DROPPING:
      code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);
      break;
    case SDB_STATUS_DROPPED:
      code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);
      break;
  }

  return code;
}

int32_t sdbWrite(SSdb *pSdb, SSdbRaw *pRaw) {
  int32_t code = sdbWriteWithoutFree(pSdb, pRaw);
  sdbFreeRaw(pRaw);
  return code;
}

void *sdbAcquireAll(SSdb *pSdb, ESdbType type, const void *pKey, bool onlyReady) {
  terrno = 0;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  void   *pRet = NULL;
  int32_t keySize = sdbGetkeySize(pSdb, type, pKey);

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);
  if (ppRow == NULL || *ppRow == NULL) {
    sdbUnLock(pSdb, type);
    terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;
    return NULL;
  }

  SSdbRow *pRow = *ppRow;
  switch (pRow->status) {
    case SDB_STATUS_READY:
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
      break;
    case SDB_STATUS_CREATING:
      terrno = TSDB_CODE_SDB_OBJ_CREATING;
      break;
    case SDB_STATUS_DROPPING:
      terrno = TSDB_CODE_SDB_OBJ_DROPPING;
      break;
    default:
      terrno = TSDB_CODE_APP_ERROR;
      break;
  }

  if (pRet == NULL) {
    if (!onlyReady) {
      terrno = 0;
      (void)atomic_add_fetch_32(&pRow->refCount, 1);
      pRet = pRow->pObj;
      sdbPrintOper(pSdb, pRow, "acquire");
    }
  }

  sdbUnLock(pSdb, type);
  return pRet;
}

void *sdbAcquire(SSdb *pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }
void *sdbAcquireNotReadyObj(SSdb *pSdb, ESdbType type, const void *pKey) {
  return sdbAcquireAll(pSdb, type, pKey, false);
}

static void sdbCheckRow(SSdb *pSdb, SSdbRow *pRow) {
  int32_t type = pRow->type;
  sdbWriteLock(pSdb, type);

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "check");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  sdbUnLock(pSdb, type);
}

void sdbReleaseLock(SSdb *pSdb, void *pObj, bool lock) {
  if (pObj == NULL) return;

  SSdbRow *pRow = (SSdbRow *)((char *)pObj - sizeof(SSdbRow));
  if (pRow->type >= SDB_MAX) return;

  int32_t type = pRow->type;
  if (lock) {
    sdbWriteLock(pSdb, type);
  }

  int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);
  sdbPrintOper(pSdb, pRow, "release");
  if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {
    sdbFreeRow(pSdb, pRow, true);
  }

  if (lock) {
    sdbUnLock(pSdb, type);
  }
}

void sdbRelease(SSdb *pSdb, void *pObj) { sdbReleaseLock(pSdb, pObj, true); }

void *sdbFetch(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL || pRow->status != SDB_STATUS_READY) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    break;
  }
  sdbUnLock(pSdb, type);

  return ppRow;
}

void *sdbFetchAll(SSdb *pSdb, ESdbType type, void *pIter, void **ppObj, ESdbStatus *status, bool lock) {
  *ppObj = NULL;

  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return NULL;

  if (lock) {
    sdbReadLock(pSdb, type);
  }

  SSdbRow **ppRow = taosHashIterate(hash, pIter);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow == NULL) {
      ppRow = taosHashIterate(hash, ppRow);
      continue;
    }

    (void)atomic_add_fetch_32(&pRow->refCount, 1);
    sdbPrintOper(pSdb, pRow, "fetch");
    *ppObj = pRow->pObj;
    *status = pRow->status;
    break;
  }
  if (lock) {
    sdbUnLock(pSdb, type);
  }

  return ppRow;
}

void sdbCancelFetch(SSdb *pSdb, void *pIter) {
  if (pIter == NULL) return;
  SSdbRow  *pRow = *(SSdbRow **)pIter;
  mTrace("cancel fetch row:%p", pRow);
  SHashObj *hash = sdbGetHash(pSdb, pRow->type);
  if (hash == NULL) return;

  int32_t type = pRow->type;
  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbCancelFetchByType(SSdb *pSdb, void *pIter, ESdbType type) {
  if (pIter == NULL) return;
  if (type >= SDB_MAX || type < 0) return;
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);
  taosHashCancelIterate(hash, pIter);
  sdbUnLock(pSdb, type);
}

void sdbTraverse(SSdb *pSdb, ESdbType type, sdbTraverseFp fp, void *p1, void *p2, void *p3) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return;

  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    if (pRow->status == SDB_STATUS_READY) {
      bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);
      if (!isContinue) {
        taosHashCancelIterate(hash, ppRow);
        break;
      }
    }

    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
}

int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return 0;

  sdbReadLock(pSdb, type);
  int32_t size = taosHashGetSize(hash);
  sdbUnLock(pSdb, type);

  return size;
}

int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {
  SHashObj *hash = sdbGetHash(pSdb, type);
  if (hash == NULL) return -1;

  if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;

  int32_t maxId = 0;
  sdbReadLock(pSdb, type);

  SSdbRow **ppRow = taosHashIterate(hash, NULL);
  while (ppRow != NULL) {
    SSdbRow *pRow = *ppRow;
    int32_t  id = *(int32_t *)pRow->pObj;
    maxId = TMAX(id, maxId);
    ppRow = taosHashIterate(hash, ppRow);
  }

  sdbUnLock(pSdb, type);
  maxId = TMAX(maxId, pSdb->maxId[type]);
  return maxId + 1;
}

int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {
  if (type >= SDB_MAX || type < 0) {
    terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;
    return -1;
  }

  return pSdb->tableVer[type];
}

bool countValid(SMnode *pMnode, void *pObj, void *p1, void *p2, void *p3) {
  int32_t* pInt = p1;
  (*pInt) += 1;
  return true;
}

int32_t sdbGetValidSize(SSdb* pSdb, ESdbType type) {
  int32_t num = 0;
  sdbTraverse(pSdb, type, countValid, &num, 0, 0);
  return num;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#define _DEFAULT_SOURCE
17	#include "sdb.h"
18
19	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow);
20
21	const char *sdbTableName(ESdbType type) {	1,181,153✔
22	switch (type) {	1,181,153!
23	case SDB_TRANS:	251,231✔
24	return "trans";	251,231✔
25	case SDB_CLUSTER:	22,670✔
26	return "cluster";	22,670✔
27	case SDB_MNODE:	33,119✔
28	return "mnode";	33,119✔
29	case SDB_QNODE:	18,990✔
30	return "qnode";	18,990✔
31	case SDB_SNODE:	8,093✔
32	return "snode";	8,093✔
33	case SDB_DNODE:	115,291✔
34	return "dnode";	115,291✔
35	case SDB_USER:	45,719✔
36	return "user";	45,719✔
37	case SDB_AUTH:	2✔
38	return "auth";	2✔
39	case SDB_ACCT:	13,696✔
40	return "acct";	13,696✔
41	case SDB_STREAM_CK:	2✔
42	return "stream_ck";	2✔
43	case SDB_STREAM:	42,061✔
44	return "stream";	42,061✔
45	case SDB_OFFSET:	2✔
46	return "offset";	2✔
47	case SDB_SUBSCRIBE:	10,732✔
48	return "subscribe";	10,732✔
49	case SDB_CONSUMER:	13,408✔
50	return "consumer";	13,408✔
51	case SDB_TOPIC:	9,847✔
52	return "topic";	9,847✔
53	case SDB_VGROUP:	281,038✔
54	return "vgroup";	281,038✔
55	case SDB_SMA:	32,529✔
56	return "sma";	32,529✔
57	case SDB_STB:	85,184✔
58	return "stb";	85,184✔
59	case SDB_DB:	76,733✔
60	return "db";	76,733✔
61	case SDB_FUNC:	10,186✔
62	return "func";	10,186✔
63	case SDB_IDX:	46,888✔
64	return "idx";	46,888✔
65	case SDB_VIEW:	8,586✔
66	return "view";	8,586✔
67	case SDB_STREAM_SEQ:	7,976✔
68	return "stream_seq";	7,976✔
69	case SDB_COMPACT:	8,000✔
70	return "compact";	8,000✔
71	case SDB_COMPACT_DETAIL:	8,100✔
72	return "compact_detail";	8,100✔
73	case SDB_GRANT:	15,071✔
74	return "grant";	15,071✔
75	case SDB_ARBGROUP:	8,024✔
76	return "arb_group";	8,024✔
77	case SDB_ANODE:	7,976✔
78	return "anode";	7,976✔
UNCOV 79	default:	×
UNCOV 80	return "undefine";	×
81	}
82	}
83
84	const char *sdbStatusName(ESdbStatus status) {	670,254✔
85	switch (status) {	670,254✔
86	case SDB_STATUS_CREATING:	18,428✔
87	return "creating";	18,428✔
88	case SDB_STATUS_DROPPING:	6,378✔
89	return "dropping";	6,378✔
90	case SDB_STATUS_READY:	596,728✔
91	return "ready";	596,728✔
92	case SDB_STATUS_DROPPED:	37,985✔
93	return "dropped";	37,985✔
94	case SDB_STATUS_INIT:	10,701✔
95	return "init";	10,701✔
96	case SDB_STATUS_UPDATE:	33✔
97	return "update";	33✔
98	default:	1✔
99	return "undefine";	1✔
100	}
101	}
102
103	void sdbPrintOper(SSdb pSdb, SSdbRow pRow, const char *oper) {	379,858,090✔
104	#if 1
105	EKeyType keyType = pSdb->keyTypes[pRow->type];	379,858,090✔
106
107	if (keyType == SDB_KEY_BINARY) {	379,858,090✔
108	mTrace("%s:%s, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (char *)pRow->pObj,	45,193,095✔
109	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
110	} else if (keyType == SDB_KEY_INT32) {	334,664,995✔
111	mTrace("%s:%d, ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type), (int32_t )pRow->pObj,	334,294,975✔
112	pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
113	} else if (keyType == SDB_KEY_INT64) {	370,020!
114	mTrace("%s:%" PRId64 ", ref:%d oper:%s row:%p row->pObj:%p status:%s", sdbTableName(pRow->type),	398,573✔
115	(int64_t )pRow->pObj, pRow->refCount, oper, pRow, pRow->pObj, sdbStatusName(pRow->status));
116	} else {
117	}
118	#endif
119	}	379,858,090✔
120
121	static SHashObj sdbGetHash(SSdb pSdb, int32_t type) {	201,904,527✔
122	if (type >= SDB_MAX \|\| type < 0) {	201,904,527!
123	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	×
124	return NULL;	×
125	}
126
127	SHashObj *hash = pSdb->hashObjs[type];	201,905,782✔
128	if (hash == NULL) {	201,905,782!
129	terrno = TSDB_CODE_APP_ERROR;	×
130	return NULL;	×
131	}
132
133	return hash;	201,905,782✔
134	}
135
136	static int32_t sdbGetkeySize(SSdb pSdb, ESdbType type, const void pKey) {	32,317,549✔
137	int32_t keySize = 0;	32,317,549✔
138	EKeyType keyType = pSdb->keyTypes[type];	32,317,549✔
139
140	if (keyType == SDB_KEY_INT32) {	32,317,549✔
141	keySize = sizeof(int32_t);	20,773,425✔
142	} else if (keyType == SDB_KEY_BINARY) {	11,544,124✔
143	keySize = strlen(pKey) + 1;	11,522,330✔
144	} else {
145	keySize = sizeof(int64_t);	21,794✔
146	}
147
148	return keySize;	32,317,549✔
149	}
150
151	static int32_t sdbInsertRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	110,121✔
152	int32_t type = pRow->type;	110,121✔
153	sdbWriteLock(pSdb, type);	110,121✔
154
155	SSdbRow *pOldRow = taosHashGet(hash, pRow->pObj, keySize);	110,121✔
156	if (pOldRow != NULL) {	110,121!
157	sdbUnLock(pSdb, type);	×
158	sdbFreeRow(pSdb, pRow, false);	×
159	terrno = TSDB_CODE_SDB_OBJ_ALREADY_THERE;	×
160	return terrno;	×
161	}
162
163	pRow->refCount = 0;	110,121✔
164	pRow->status = pRaw->status;	110,121✔
165	sdbPrintOper(pSdb, pRow, "insert");	110,121✔
166
167	int32_t code = 0;	110,121✔
168	if ((code = taosHashPut(hash, pRow->pObj, keySize, &pRow, sizeof(void *))) != 0) {	110,121!
169	sdbUnLock(pSdb, type);	×
170	sdbFreeRow(pSdb, pRow, false);	×
171	return code;	×
172	}
173
174	SdbInsertFp insertFp = pSdb->insertFps[pRow->type];	110,121✔
175	if (insertFp != NULL) {	110,121!
176	code = (*insertFp)(pSdb, pRow->pObj);	110,121✔
177	if (code != 0) {	110,121!
178	if (taosHashRemove(hash, pRow->pObj, keySize) != 0) {	×
179	mError("failed to remove row from hash");	×
180	}
181	sdbFreeRow(pSdb, pRow, false);	×
182	sdbUnLock(pSdb, type);	×
183	terrno = code;	×
184	return terrno;	×
185	}
186	}
187
188	sdbUnLock(pSdb, type);	110,121✔
189
190	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT32) {	110,121✔
191	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int32_t )pRow->pObj));	67,714✔
192	}
193	if (pSdb->keyTypes[pRow->type] == SDB_KEY_INT64) {	110,121✔
194	pSdb->maxId[pRow->type] = TMAX(pSdb->maxId[pRow->type], ((int64_t )pRow->pObj));	2,626✔
195	}
196	pSdb->tableVer[pRow->type]++;	110,121✔
197
198	return 0;	110,121✔
199	}
200
201	static int32_t sdbUpdateRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pNewRow, int32_t keySize) {	191,925✔
202	int32_t type = pNewRow->type;	191,925✔
203	sdbWriteLock(pSdb, type);	191,925✔
204
205	SSdbRow **ppOldRow = taosHashGet(hash, pNewRow->pObj, keySize);	191,925✔
206	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	191,925!
207	sdbUnLock(pSdb, type);	92,746✔
208	return sdbInsertRow(pSdb, hash, pRaw, pNewRow, keySize);	92,746✔
209	}
210
211	SSdbRow pOldRow = ppOldRow;	99,179✔
212	pOldRow->status = pRaw->status;	99,179✔
213	sdbPrintOper(pSdb, pOldRow, "update");	99,179✔
214
215	int32_t code = 0;	99,179✔
216	SdbUpdateFp updateFp = pSdb->updateFps[type];	99,179✔
217	if (updateFp != NULL) {	99,179!
218	code = (*updateFp)(pSdb, pOldRow->pObj, pNewRow->pObj);	99,179✔
219	}
220	sdbUnLock(pSdb, type);	99,179✔
221
222	// sdbUnLock(pSdb, type);
223	sdbFreeRow(pSdb, pNewRow, false);	99,179✔
224
225	pSdb->tableVer[pOldRow->type]++;	99,179✔
226	return code;	99,179✔
227	}
228
229	static int32_t sdbDeleteRow(SSdb pSdb, SHashObj hash, SSdbRaw pRaw, SSdbRow pRow, int32_t keySize) {	70,201✔
230	int32_t type = pRow->type;	70,201✔
231	sdbWriteLock(pSdb, type);	70,201✔
232
233	SSdbRow **ppOldRow = taosHashGet(hash, pRow->pObj, keySize);	70,201✔
234	if (ppOldRow == NULL \|\| *ppOldRow == NULL) {	70,201!
235	sdbUnLock(pSdb, type);	44✔
236	sdbFreeRow(pSdb, pRow, false);	44✔
237	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	44✔
238	return terrno;	44✔
239	}
240	SSdbRow pOldRow = ppOldRow;	70,157✔
241	pOldRow->status = pRaw->status;	70,157✔
242
243	(void)atomic_add_fetch_32(&pOldRow->refCount, 1);	70,157✔
244	sdbPrintOper(pSdb, pOldRow, "delete");	70,157✔
245
246	if (taosHashRemove(hash, pOldRow->pObj, keySize) != 0) {	70,157!
247	sdbUnLock(pSdb, type);	×
248	sdbFreeRow(pSdb, pRow, false);	×
249	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	×
250	return terrno;	×
251	}
252	pSdb->tableVer[pOldRow->type]++;	70,157✔
253	sdbUnLock(pSdb, type);	70,157✔
254
255	sdbFreeRow(pSdb, pRow, false);	70,157✔
256
257	sdbCheckRow(pSdb, pOldRow);	70,157✔
258	return 0;	70,157✔
259	}
260
261	int32_t sdbWriteWithoutFree(SSdb pSdb, SSdbRaw pRaw) {	279,501✔
262	SHashObj *hash = sdbGetHash(pSdb, pRaw->type);	279,501✔
263	if (hash == NULL) return terrno;	279,501!
264
265	SdbDecodeFp decodeFp = pSdb->decodeFps[pRaw->type];	279,501✔
266	SSdbRow pRow = (decodeFp)(pRaw);	279,501✔
267	if (pRow == NULL) return terrno;	279,501!
268
269	pRow->type = pRaw->type;	279,501✔
270
271	int32_t keySize = sdbGetkeySize(pSdb, pRow->type, pRow->pObj);	279,501✔
272	int32_t code = TSDB_CODE_SDB_INVALID_ACTION_TYPE;	279,501✔
273
274	switch (pRaw->status) {	279,501!
275	case SDB_STATUS_CREATING:	17,375✔
276	code = sdbInsertRow(pSdb, hash, pRaw, pRow, keySize);	17,375✔
277	break;	17,375✔
278	case SDB_STATUS_READY:	191,925✔
279	case SDB_STATUS_UPDATE:
280	case SDB_STATUS_DROPPING:
281	code = sdbUpdateRow(pSdb, hash, pRaw, pRow, keySize);	191,925✔
282	break;	191,925✔
283	case SDB_STATUS_DROPPED:	70,201✔
284	code = sdbDeleteRow(pSdb, hash, pRaw, pRow, keySize);	70,201✔
285	break;	70,201✔
286	}
287
288	return code;	279,501✔
289	}
290
291	int32_t sdbWrite(SSdb pSdb, SSdbRaw pRaw) {	48,726✔
292	int32_t code = sdbWriteWithoutFree(pSdb, pRaw);	48,726✔
293	sdbFreeRaw(pRaw);	48,726✔
294	return code;	48,726✔
295	}
296
297	void sdbAcquireAll(SSdb pSdb, ESdbType type, const void *pKey, bool onlyReady) {	32,038,812✔
298	terrno = 0;	32,038,812✔
299
300	SHashObj *hash = sdbGetHash(pSdb, type);	32,038,723✔
301	if (hash == NULL) return NULL;	32,038,103!
302
303	void *pRet = NULL;	32,038,103✔
304	int32_t keySize = sdbGetkeySize(pSdb, type, pKey);	32,038,103✔
305
306	sdbReadLock(pSdb, type);	32,038,116✔
307
308	SSdbRow **ppRow = taosHashGet(hash, pKey, keySize);	32,040,126✔
309	if (ppRow == NULL \|\| *ppRow == NULL) {	32,040,825✔
310	sdbUnLock(pSdb, type);	1,910,479✔
311	terrno = TSDB_CODE_SDB_OBJ_NOT_THERE;	1,910,647✔
312	return NULL;	1,910,644✔
313	}
314
315	SSdbRow pRow = ppRow;	30,130,346✔
316	switch (pRow->status) {	30,130,346✔
317	case SDB_STATUS_READY:	30,122,789✔
318	(void)atomic_add_fetch_32(&pRow->refCount, 1);	30,122,789✔
319	pRet = pRow->pObj;	30,123,279✔
320	sdbPrintOper(pSdb, pRow, "acquire");	30,123,279✔
321	break;	30,122,477✔
322	case SDB_STATUS_CREATING:	5,460✔
323	terrno = TSDB_CODE_SDB_OBJ_CREATING;	5,460✔
324	break;	5,460✔
325	case SDB_STATUS_DROPPING:	1,936✔
326	terrno = TSDB_CODE_SDB_OBJ_DROPPING;	1,936✔
327	break;	1,936✔
328	default:	161✔
329	terrno = TSDB_CODE_APP_ERROR;	161✔
UNCOV 330	break;	×
331	}
332
333	if (pRet == NULL) {	30,129,873✔
334	if (!onlyReady) {	7,396!
335	terrno = 0;	×
336	(void)atomic_add_fetch_32(&pRow->refCount, 1);	×
337	pRet = pRow->pObj;	×
338	sdbPrintOper(pSdb, pRow, "acquire");	×
339	}
340	}
341
342	sdbUnLock(pSdb, type);	30,129,873✔
343	return pRet;	30,130,417✔
344	}
345
346	void sdbAcquire(SSdb pSdb, ESdbType type, const void *pKey) { return sdbAcquireAll(pSdb, type, pKey, true); }	32,035,962✔
347	void sdbAcquireNotReadyObj(SSdb pSdb, ESdbType type, const void *pKey) {	2,581✔
348	return sdbAcquireAll(pSdb, type, pKey, false);	2,581✔
349	}
350
351	static void sdbCheckRow(SSdb pSdb, SSdbRow pRow) {	70,157✔
352	int32_t type = pRow->type;	70,157✔
353	sdbWriteLock(pSdb, type);	70,157✔
354
355	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	70,157✔
356	sdbPrintOper(pSdb, pRow, "check");	70,157✔
357	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	70,157!
358	sdbFreeRow(pSdb, pRow, true);	20,675✔
359	}
360
361	sdbUnLock(pSdb, type);	70,157✔
362	}	70,157✔
363
364	void sdbReleaseLock(SSdb pSdb, void pObj, bool lock) {	189,983,179✔
365	if (pObj == NULL) return;	189,983,179✔
366
367	SSdbRow pRow = (SSdbRow )((char *)pObj - sizeof(SSdbRow));	189,565,208✔
368	if (pRow->type >= SDB_MAX) return;	189,565,208!
369
370	int32_t type = pRow->type;	189,565,208✔
371	if (lock) {	189,565,208!
372	sdbWriteLock(pSdb, type);	189,567,263✔
373	}
374
375	int32_t ref = atomic_sub_fetch_32(&pRow->refCount, 1);	189,588,587✔
376	sdbPrintOper(pSdb, pRow, "release");	189,600,162✔
377	if (ref <= 0 && pRow->status == SDB_STATUS_DROPPED) {	189,594,800✔
378	sdbFreeRow(pSdb, pRow, true);	49,482✔
379	}
380
381	if (lock) {	189,594,800✔
382	sdbUnLock(pSdb, type);	189,591,112✔
383	}
384	}
385
386	void sdbRelease(SSdb pSdb, void pObj) { sdbReleaseLock(pSdb, pObj, true); }	189,974,377✔
387
388	void sdbFetch(SSdb pSdb, ESdbType type, void pIter, void *ppObj) {	161,220,624✔
389	*ppObj = NULL;	161,220,624✔
390
391	SHashObj *hash = sdbGetHash(pSdb, type);	161,220,624✔
392	if (hash == NULL) return NULL;	161,219,950!
393
394	sdbReadLock(pSdb, type);	161,219,950✔
395
396	SSdbRow **ppRow = taosHashIterate(hash, pIter);	161,221,705✔
397	while (ppRow != NULL) {	161,266,774✔
398	SSdbRow pRow = ppRow;	158,651,505✔
399	if (pRow == NULL \|\| pRow->status != SDB_STATUS_READY) {	158,651,505!
400	ppRow = taosHashIterate(hash, ppRow);	37,937✔
401	continue;	37,936✔
402	}
403
404	(void)atomic_add_fetch_32(&pRow->refCount, 1);	158,613,568✔
405	sdbPrintOper(pSdb, pRow, "fetch");	158,609,522✔
406	*ppObj = pRow->pObj;	158,601,764✔
407	break;	158,601,764✔
408	}
409	sdbUnLock(pSdb, type);	161,217,033✔
410
411	return ppRow;	161,225,343✔
412	}
413
414	void sdbFetchAll(SSdb pSdb, ESdbType type, void pIter, void ppObj, ESdbStatus status, bool lock) {	964,622✔
415	*ppObj = NULL;	964,622✔
416
417	SHashObj *hash = sdbGetHash(pSdb, type);	964,622✔
418	if (hash == NULL) return NULL;	964,619!
419
420	if (lock) {	964,619✔
421	sdbReadLock(pSdb, type);	957,846✔
422	}
423
424	SSdbRow **ppRow = taosHashIterate(hash, pIter);	964,602✔
425	while (ppRow != NULL) {	964,654✔
426	SSdbRow pRow = ppRow;	866,103✔
427	if (pRow == NULL) {	866,103!
428	ppRow = taosHashIterate(hash, ppRow);	×
429	continue;	×
430	}
431
432	(void)atomic_add_fetch_32(&pRow->refCount, 1);	866,103✔
433	sdbPrintOper(pSdb, pRow, "fetch");	866,101✔
434	*ppObj = pRow->pObj;	866,074✔
435	*status = pRow->status;	866,074✔
436	break;	866,074✔
437	}
438	if (lock) {	964,625✔
439	sdbUnLock(pSdb, type);	957,849✔
440	}
441
442	return ppRow;	964,632✔
443	}
444
445	void sdbCancelFetch(SSdb pSdb, void pIter) {	5,414,576✔
446	if (pIter == NULL) return;	5,414,576✔
447	SSdbRow pRow = (SSdbRow **)pIter;	5,411,963✔
448	mTrace("cancel fetch row:%p", pRow);	5,411,963✔
449	SHashObj *hash = sdbGetHash(pSdb, pRow->type);	5,411,963✔
450	if (hash == NULL) return;	5,411,952!
451
452	int32_t type = pRow->type;	5,411,952✔
453	sdbReadLock(pSdb, type);	5,411,952✔
454	taosHashCancelIterate(hash, pIter);	5,411,985✔
455	sdbUnLock(pSdb, type);	5,412,001✔
456	}
457
458	void sdbCancelFetchByType(SSdb pSdb, void pIter, ESdbType type) {	1✔
459	if (pIter == NULL) return;	1!
460	if (type >= SDB_MAX \|\| type < 0) return;	1!
461	SHashObj *hash = sdbGetHash(pSdb, type);	1✔
462	if (hash == NULL) return;	1!
463
464	sdbReadLock(pSdb, type);	1✔
465	taosHashCancelIterate(hash, pIter);	1✔
466	sdbUnLock(pSdb, type);	1✔
467	}
468
469	void sdbTraverse(SSdb pSdb, ESdbType type, sdbTraverseFp fp, void p1, void p2, void p3) {	626,993✔
470	SHashObj *hash = sdbGetHash(pSdb, type);	626,993✔
471	if (hash == NULL) return;	626,996!
472
473	sdbReadLock(pSdb, type);	626,996✔
474
475	SSdbRow **ppRow = taosHashIterate(hash, NULL);	626,981✔
476	while (ppRow != NULL) {	28,897,461✔
477	SSdbRow pRow = ppRow;	28,275,134✔
478	if (pRow->status == SDB_STATUS_READY) {	28,275,134✔
479	bool isContinue = (*fp)(pSdb->pMnode, pRow->pObj, p1, p2, p3);	28,256,011✔
480	if (!isContinue) {	28,157,859!
481	taosHashCancelIterate(hash, ppRow);	×
482	break;	×
483	}
484	}
485
486	ppRow = taosHashIterate(hash, ppRow);	28,176,982✔
487	}
488
489	sdbUnLock(pSdb, type);	622,327✔
490	}
491
492	int32_t sdbGetSize(SSdb *pSdb, ESdbType type) {	1,330,984✔
493	SHashObj *hash = sdbGetHash(pSdb, type);	1,330,984✔
494	if (hash == NULL) return 0;	1,330,817!
495
496	sdbReadLock(pSdb, type);	1,330,817✔
497	int32_t size = taosHashGetSize(hash);	1,330,950✔
498	sdbUnLock(pSdb, type);	1,330,837✔
499
500	return size;	1,331,060✔
501	}
502
503	int32_t sdbGetMaxId(SSdb *pSdb, ESdbType type) {	61,857✔
504	SHashObj *hash = sdbGetHash(pSdb, type);	61,857✔
505	if (hash == NULL) return -1;	61,857!
506
507	if (pSdb->keyTypes[type] != SDB_KEY_INT32) return -1;	61,857!
508
509	int32_t maxId = 0;	61,857✔
510	sdbReadLock(pSdb, type);	61,857✔
511
512	SSdbRow **ppRow = taosHashIterate(hash, NULL);	61,857✔
513	while (ppRow != NULL) {	127,809✔
514	SSdbRow pRow = ppRow;	65,952✔
515	int32_t id = (int32_t )pRow->pObj;	65,952✔
516	maxId = TMAX(id, maxId);	65,952✔
517	ppRow = taosHashIterate(hash, ppRow);	65,952✔
518	}
519
520	sdbUnLock(pSdb, type);	61,857✔
521	maxId = TMAX(maxId, pSdb->maxId[type]);	61,857✔
522	return maxId + 1;	61,857✔
523	}
524
525	int64_t sdbGetTableVer(SSdb *pSdb, ESdbType type) {	591,984✔
526	if (type >= SDB_MAX \|\| type < 0) {	591,984!
527	terrno = TSDB_CODE_SDB_INVALID_TABLE_TYPE;	×
528	return -1;	×
529	}
530
531	return pSdb->tableVer[type];	591,984✔
532	}
533
534	bool countValid(SMnode pMnode, void pObj, void p1, void p2, void *p3) {	×
535	int32_t* pInt = p1;	×
536	(*pInt) += 1;	×
537	return true;	×
538	}
539
540	int32_t sdbGetValidSize(SSdb* pSdb, ESdbType type) {	×
541	int32_t num = 0;	×
542	sdbTraverse(pSdb, type, countValid, &num, 0, 0);	×
543	return num;	×
544	}

taosdata / TDengine / #3541

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous