• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3533

20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%
#3533

push

travis-ci

web-flow
Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

54.07
/source/util/src/tscalablebf.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#define _DEFAULT_SOURCE
17

18
#include "tscalablebf.h"
19
#include "taoserror.h"
20
#include "tutil.h"
21

22
#define DEFAULT_GROWTH           2
23
#define DEFAULT_TIGHTENING_RATIO 0.5
24
#define DEFAULT_MAX_BLOOMFILTERS 4
25
#define SBF_INVALID              -1
26
#define SBF_VALID                0
27

28
static int32_t tScalableBfAddFilter(SScalableBf* pSBf, uint64_t expectedEntries, double errorRate,
29
                                    SBloomFilter** ppNormalBf);
30

31
int32_t tScalableBfInit(uint64_t expectedEntries, double errorRate, SScalableBf** ppSBf) {
6,799✔
32
  int32_t        code = TSDB_CODE_SUCCESS;
6,799✔
33
  int32_t        lino = 0;
6,799✔
34
  const uint32_t defaultSize = 8;
6,799✔
35
  if (expectedEntries < 1 || errorRate <= 0 || errorRate >= 1.0) {
6,799!
36
    code = TSDB_CODE_INVALID_PARA;
×
37
    QUERY_CHECK_CODE(code, lino, _error);
×
38
  }
39
  SScalableBf* pSBf = taosMemoryCalloc(1, sizeof(SScalableBf));
6,799✔
40
  if (pSBf == NULL) {
6,801!
41
    code = terrno;
×
42
    QUERY_CHECK_CODE(code, lino, _error);
×
43
  }
44
  pSBf->maxBloomFilters = DEFAULT_MAX_BLOOMFILTERS;
6,801✔
45
  pSBf->status = SBF_VALID;
6,801✔
46
  pSBf->numBits = 0;
6,801✔
47
  pSBf->bfArray = taosArrayInit(defaultSize, sizeof(void*));
6,801✔
48
  if (!pSBf->bfArray) {
6,801!
49
    code = terrno;
×
50
    QUERY_CHECK_CODE(code, lino, _error);
×
51
  }
52

53
  SBloomFilter* pNormalBf = NULL;
6,801✔
54
  code = tScalableBfAddFilter(pSBf, expectedEntries, errorRate * DEFAULT_TIGHTENING_RATIO, &pNormalBf);
6,801✔
55
  if (code != TSDB_CODE_SUCCESS) {
6,802!
56
    tScalableBfDestroy(pSBf);
×
57
    QUERY_CHECK_CODE(code, lino, _error);
×
58
  }
59
  pSBf->growth = DEFAULT_GROWTH;
6,802✔
60
  pSBf->hashFn1 = HASH_FUNCTION_1;
6,802✔
61
  pSBf->hashFn2 = HASH_FUNCTION_2;
6,802✔
62
  (*ppSBf) = pSBf;
6,802✔
63
  return TSDB_CODE_SUCCESS;
6,802✔
64

65
_error:
×
66
  uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
67
  return code;
×
68
}
69

70
int32_t tScalableBfPutNoCheck(SScalableBf* pSBf, const void* keyBuf, uint32_t len) {
2,020,423✔
71
  int32_t code = TSDB_CODE_SUCCESS;
2,020,423✔
72
  int32_t lino = 0;
2,020,423✔
73
  if (pSBf->status == SBF_INVALID) {
2,020,423✔
74
    return code;
1,694,639✔
75
  }
76
  int32_t       size = taosArrayGetSize(pSBf->bfArray);
325,784✔
77
  SBloomFilter* pNormalBf = taosArrayGetP(pSBf->bfArray, size - 1);
325,817✔
78
  if (!pNormalBf) {
325,768!
79
    code = terrno;
×
80
    QUERY_CHECK_CODE(code, lino, _error);
×
81
  }
82
  if (tBloomFilterIsFull(pNormalBf)) {
325,768✔
83
    code = tScalableBfAddFilter(pSBf, pNormalBf->expectedEntries * pSBf->growth,
8✔
84
                                pNormalBf->errorRate * DEFAULT_TIGHTENING_RATIO, &pNormalBf);
8✔
85
    if (code != TSDB_CODE_SUCCESS) {
8✔
86
      pSBf->status = SBF_INVALID;
2✔
87
      if (code == TSDB_CODE_OUT_OF_BUFFER) {
2!
88
        code = TSDB_CODE_SUCCESS;
2✔
89
        return code;
2✔
90
      }
91
      QUERY_CHECK_CODE(code, lino, _error);
×
92
    }
93
  }
94
  return tBloomFilterPut(pNormalBf, keyBuf, len);
325,734✔
95

96
_error:
×
97
  if (code != TSDB_CODE_SUCCESS) {
×
98
    uDebug("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
99
  }
100
  return code;
×
101
}
102

103
int32_t tScalableBfPut(SScalableBf* pSBf, const void* keyBuf, uint32_t len, int32_t* winRes) {
1,105,762✔
104
  int32_t code = TSDB_CODE_SUCCESS;
1,105,762✔
105
  int32_t lino = 0;
1,105,762✔
106
  if (pSBf->status == SBF_INVALID) {
1,105,762✔
107
    (*winRes) = TSDB_CODE_FAILED;
1,103,438✔
108
    return code;
1,103,438✔
109
  }
110
  uint64_t h1 = (uint64_t)pSBf->hashFn1(keyBuf, len);
2,324✔
111
  uint64_t h2 = (uint64_t)pSBf->hashFn2(keyBuf, len);
2,412✔
112
  int32_t  size = taosArrayGetSize(pSBf->bfArray);
2,412✔
113
  for (int32_t i = size - 2; i >= 0; --i) {
2,412!
UNCOV
114
    if (tBloomFilterNoContain(taosArrayGetP(pSBf->bfArray, i), h1, h2) != TSDB_CODE_SUCCESS) {
×
UNCOV
115
      (*winRes) = TSDB_CODE_FAILED;
×
UNCOV
116
      goto _end;
×
117
    }
118
  }
119

120
  SBloomFilter* pNormalBf = taosArrayGetP(pSBf->bfArray, size - 1);
2,412✔
121
  QUERY_CHECK_NULL(pNormalBf, code, lino, _end, TSDB_CODE_INTERNAL_ERROR);
2,412!
122

123
  if (tBloomFilterIsFull(pNormalBf)) {
2,412!
UNCOV
124
    code = tScalableBfAddFilter(pSBf, pNormalBf->expectedEntries * pSBf->growth,
×
UNCOV
125
                                pNormalBf->errorRate * DEFAULT_TIGHTENING_RATIO, &pNormalBf);
×
UNCOV
126
    if (code != TSDB_CODE_SUCCESS) {
×
UNCOV
127
      pSBf->status = SBF_INVALID;
×
UNCOV
128
      if (code == TSDB_CODE_OUT_OF_BUFFER) {
×
UNCOV
129
        code = TSDB_CODE_SUCCESS;
×
UNCOV
130
        (*winRes) = TSDB_CODE_FAILED;
×
UNCOV
131
        goto _end;
×
132
      }
133
      QUERY_CHECK_CODE(code, lino, _end);
×
134
    }
135
  }
136
  (*winRes) = tBloomFilterPutHash(pNormalBf, h1, h2);
2,412✔
137

138
_end:
2,412✔
139
  if (code != TSDB_CODE_SUCCESS) {
2,412!
140
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
141
  }
142
  return code;
2,412✔
143
}
144

145
int32_t tScalableBfNoContain(const SScalableBf* pSBf, const void* keyBuf, uint32_t len) {
×
146
  if (pSBf->status == SBF_INVALID) {
×
147
    return TSDB_CODE_FAILED;
×
148
  }
149
  uint64_t h1 = (uint64_t)pSBf->hashFn1(keyBuf, len);
×
150
  uint64_t h2 = (uint64_t)pSBf->hashFn2(keyBuf, len);
×
151
  int32_t  size = taosArrayGetSize(pSBf->bfArray);
×
152
  for (int32_t i = size - 1; i >= 0; --i) {
×
153
    if (tBloomFilterNoContain(taosArrayGetP(pSBf->bfArray, i), h1, h2) != TSDB_CODE_SUCCESS) {
×
154
      return TSDB_CODE_FAILED;
×
155
    }
156
  }
157
  return TSDB_CODE_SUCCESS;
×
158
}
159

160
static int32_t tScalableBfAddFilter(SScalableBf* pSBf, uint64_t expectedEntries, double errorRate,
6,809✔
161
                                    SBloomFilter** ppNormalBf) {
162
  int32_t code = TSDB_CODE_SUCCESS;
6,809✔
163
  int32_t lino = 0;
6,809✔
164
  if (taosArrayGetSize(pSBf->bfArray) >= pSBf->maxBloomFilters) {
6,809✔
165
    code = TSDB_CODE_OUT_OF_BUFFER;
2✔
166
    QUERY_CHECK_CODE(code, lino, _error);
2!
167
  }
168

169
  SBloomFilter* pNormalBf = NULL;
6,807✔
170
  code = tBloomFilterInit(expectedEntries, errorRate, &pNormalBf);
6,807✔
171
  QUERY_CHECK_CODE(code, lino, _error);
6,808!
172

173
  if (taosArrayPush(pSBf->bfArray, &pNormalBf) == NULL) {
13,616!
174
    tBloomFilterDestroy(pNormalBf);
×
175
    code = terrno;
×
176
    QUERY_CHECK_CODE(code, lino, _error);
×
177
  }
178
  pSBf->numBits += pNormalBf->numBits;
6,808✔
179
  (*ppNormalBf) = pNormalBf;
6,808✔
180

181
_error:
6,810✔
182
  if (code != TSDB_CODE_SUCCESS) {
6,810✔
183
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
2!
184
  }
185
  return code;
6,810✔
186
}
187

188
void tScalableBfDestroy(SScalableBf* pSBf) {
7,166✔
189
  if (pSBf == NULL) {
7,166!
190
    return;
×
191
  }
192
  if (pSBf->bfArray != NULL) {
7,166✔
193
    taosArrayDestroyP(pSBf->bfArray, (FDelete)tBloomFilterDestroy);
6,958✔
194
  }
195
  taosMemoryFree(pSBf);
7,166✔
196
}
197

198
int32_t tScalableBfEncode(const SScalableBf* pSBf, SEncoder* pEncoder) {
2,654✔
199
  if (!pSBf) {
2,654✔
200
    TAOS_CHECK_RETURN(tEncodeI32(pEncoder, 0));
498!
201
    return 0;
498✔
202
  }
203
  int32_t size = taosArrayGetSize(pSBf->bfArray);
2,156✔
204
  TAOS_CHECK_RETURN(tEncodeI32(pEncoder, size));
2,156!
205
  for (int32_t i = 0; i < size; i++) {
4,325✔
206
    SBloomFilter* pBF = taosArrayGetP(pSBf->bfArray, i);
2,168✔
207
    TAOS_CHECK_RETURN(tBloomFilterEncode(pBF, pEncoder));
2,168!
208
  }
209
  TAOS_CHECK_RETURN(tEncodeU32(pEncoder, pSBf->growth));
4,314!
210
  TAOS_CHECK_RETURN(tEncodeU64(pEncoder, pSBf->numBits));
4,314!
211
  TAOS_CHECK_RETURN(tEncodeU32(pEncoder, pSBf->maxBloomFilters));
4,314!
212
  TAOS_CHECK_RETURN(tEncodeI8(pEncoder, pSBf->status));
4,314!
213
  return 0;
2,157✔
214
}
215

216
int32_t tScalableBfDecode(SDecoder* pDecoder, SScalableBf** ppSBf) {
1,258✔
217
  int32_t      code = TSDB_CODE_SUCCESS;
1,258✔
218
  int32_t      lino = 0;
1,258✔
219
  SScalableBf* pSBf = taosMemoryCalloc(1, sizeof(SScalableBf));
1,258✔
220
  if (!pSBf) {
1,259!
221
    code = terrno;
×
222
    QUERY_CHECK_CODE(code, lino, _error);
×
223
  }
224
  pSBf->hashFn1 = HASH_FUNCTION_1;
1,259✔
225
  pSBf->hashFn2 = HASH_FUNCTION_2;
1,259✔
226
  pSBf->bfArray = NULL;
1,259✔
227
  int32_t size = 0;
1,259✔
228
  if (tDecodeI32(pDecoder, &size) < 0) {
1,259!
229
    code = terrno;
×
230
    QUERY_CHECK_CODE(code, lino, _error);
×
231
  }
232
  if (size == 0) {
1,259✔
233
    (*ppSBf) = NULL;
208✔
234
    tScalableBfDestroy(pSBf);
208✔
235
    goto _error;
208✔
236
  }
237
  pSBf->bfArray = taosArrayInit(size * 2, POINTER_BYTES);
1,051✔
238
  if (!pSBf->bfArray) {
1,051!
239
    code = terrno;
×
240
    QUERY_CHECK_CODE(code, lino, _error);
×
241
  }
242

243
  for (int32_t i = 0; i < size; i++) {
2,101✔
244
    SBloomFilter* pBF = NULL;
1,051✔
245
    code = tBloomFilterDecode(pDecoder, &pBF);
1,051✔
246
    QUERY_CHECK_CODE(code, lino, _error);
1,051!
247
    void* tmpRes = taosArrayPush(pSBf->bfArray, &pBF);
1,051✔
248
    if (!tmpRes) {
1,050!
249
      code = terrno;
×
250
      QUERY_CHECK_CODE(code, lino, _error);
×
251
    }
252
  }
253
  if (tDecodeU32(pDecoder, &pSBf->growth) < 0) {
2,100!
254
    code = terrno;
×
255
    QUERY_CHECK_CODE(code, lino, _error);
×
256
  }
257
  if (tDecodeU64(pDecoder, &pSBf->numBits) < 0) {
2,100!
258
    code = terrno;
×
259
    QUERY_CHECK_CODE(code, lino, _error);
×
260
  }
261
  if (tDecodeU32(pDecoder, &pSBf->maxBloomFilters) < 0) {
2,100!
262
    code = terrno;
×
263
    QUERY_CHECK_CODE(code, lino, _error);
×
264
  }
265
  if (tDecodeI8(pDecoder, &pSBf->status) < 0) {
2,100!
266
    code = terrno;
×
267
    QUERY_CHECK_CODE(code, lino, _error);
×
268
  }
269
  (*ppSBf) = pSBf;
1,050✔
270

271
_error:
1,258✔
272

273
  if (code != TSDB_CODE_SUCCESS) {
1,258!
274
    tScalableBfDestroy(pSBf);
×
275
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
276
  }
277
  return code;
1,258✔
278
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc