• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3533

20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%
#3533

push

travis-ci

web-flow
Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.36
/source/libs/stream/src/streamUpdate.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tcompare.h"
17
#include "tdatablock.h"
18
#include "tencode.h"
19
#include "tstreamUpdate.h"
20
#include "ttime.h"
21
#include "tutil.h"
22

23
#define DEFAULT_FALSE_POSITIVE   0.01
24
#define DEFAULT_BUCKET_SIZE      131072
25
#define DEFAULT_MAP_CAPACITY     131072
26
#define DEFAULT_MAP_SIZE         (DEFAULT_MAP_CAPACITY * 100)
27
#define ROWS_PER_MILLISECOND     1
28
#define MAX_NUM_SCALABLE_BF      64
29
#define MIN_NUM_SCALABLE_BF      10
30
#define DEFAULT_PREADD_BUCKET    1
31
#define MAX_INTERVAL             MILLISECOND_PER_MINUTE
32
#define MIN_INTERVAL             (MILLISECOND_PER_SECOND * 10)
33
#define DEFAULT_EXPECTED_ENTRIES 10000
34

35
static int64_t adjustExpEntries(int64_t entries) { return TMIN(DEFAULT_EXPECTED_ENTRIES, entries); }
6,799✔
36

37
int compareKeyTs(void* pTs1, void* pTs2, void* pPkVal, __compar_fn_t cmpPkFn) {
15,552,241✔
38
  return compareInt64Val(pTs1, pTs2);
15,552,241✔
39
}
40

UNCOV
41
int compareKeyTsAndPk(void* pValue1, void* pTs, void* pPkVal, __compar_fn_t cmpPkFn) {
×
UNCOV
42
  int res = compareInt64Val(pValue1, pTs);
×
UNCOV
43
  if (res != 0) {
×
UNCOV
44
    return res;
×
45
  } else {
46
    void* pk1 = (char*)pValue1 + sizeof(TSKEY);
×
47
    return cmpPkFn(pk1, pPkVal);
×
48
  }
49
}
50

51
int32_t getKeyBuff(TSKEY ts, int64_t tbUid, void* pVal, int32_t len, char* buff) {
15,559,062✔
52
  *(TSKEY*)buff = ts;
15,559,062✔
53
  memcpy(buff + sizeof(TSKEY), &tbUid, sizeof(int64_t));
15,559,062✔
54
  if (len == 0) {
15,559,062!
55
    return sizeof(TSKEY) + sizeof(int64_t);
15,573,354✔
56
  }
UNCOV
57
  memcpy(buff, pVal, len);
×
UNCOV
58
  return sizeof(TSKEY) + sizeof(int64_t) + len;
×
59
}
60

61
int32_t getValueBuff(TSKEY ts, char* pVal, int32_t len, char* buff) {
9,988,284✔
62
  *(TSKEY*)buff = ts;
9,988,284✔
63
  if (len == 0) {
9,988,284!
64
    return sizeof(TSKEY);
9,989,801✔
65
  }
UNCOV
66
  memcpy(buff + sizeof(TSKEY), pVal, len);
×
UNCOV
67
  return sizeof(TSKEY) + len;
×
68
}
69

70
int32_t windowSBfAdd(SUpdateInfo* pInfo, uint64_t count) {
2,129✔
71
  int32_t code = TSDB_CODE_SUCCESS;
2,129✔
72
  int32_t lino = 0;
2,129✔
73
  if (pInfo->numSBFs < count) {
2,129✔
74
    count = pInfo->numSBFs;
356✔
75
  }
76
  for (uint64_t i = 0; i < count; ++i) {
8,634✔
77
    int64_t      rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
6,505✔
78
    SScalableBf* tsSBF = NULL;
6,505✔
79
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &tsSBF);
6,505✔
80
    QUERY_CHECK_CODE(code, lino, _error);
6,508!
81
    void* res = taosArrayPush(pInfo->pTsSBFs, &tsSBF);
6,508✔
82
    if (!res) {
6,505!
83
      code = terrno;
×
84
      QUERY_CHECK_CODE(code, lino, _error);
×
85
    }
86
  }
87

88
_error:
2,129✔
89
  if (code != TSDB_CODE_SUCCESS) {
2,129!
90
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
91
  }
92
  return code;
2,129✔
93
}
94

95
static void clearItemHelper(void* p) {
1,130✔
96
  SScalableBf** pBf = p;
1,130✔
97
  tScalableBfDestroy(*pBf);
1,130✔
98
}
1,130✔
99

100
void windowSBfDelete(SUpdateInfo* pInfo, uint64_t count) {
1,131✔
101
  if (count < pInfo->numSBFs) {
1,131✔
102
    for (uint64_t i = 0; i < count; ++i) {
2✔
103
      SScalableBf* pTsSBFs = taosArrayGetP(pInfo->pTsSBFs, 0);
1✔
104
      tScalableBfDestroy(pTsSBFs);
1✔
105
      taosArrayRemove(pInfo->pTsSBFs, 0);
1✔
106
    }
107
  } else {
108
    taosArrayClearEx(pInfo->pTsSBFs, clearItemHelper);
1,130✔
109
  }
110
  pInfo->minTS += pInfo->interval * count;
1,131✔
111
}
1,131✔
112

113
static int64_t adjustInterval(int64_t interval, int32_t precision) {
1,238✔
114
  int64_t val = interval;
1,238✔
115
  if (precision != TSDB_TIME_PRECISION_MILLI) {
1,238✔
116
    val = convertTimePrecision(interval, precision, TSDB_TIME_PRECISION_MILLI);
10✔
117
  }
118

119
  if (val <= 0 || val > MAX_INTERVAL) {
1,238✔
120
    val = MAX_INTERVAL;
78✔
121
  } else if (val < MIN_INTERVAL) {
1,160✔
122
    val = MIN_INTERVAL;
120✔
123
  }
124

125
  if (precision != TSDB_TIME_PRECISION_MILLI) {
1,238✔
126
    val = convertTimePrecision(val, TSDB_TIME_PRECISION_MILLI, precision);
10✔
127
  }
128
  return val;
1,238✔
129
}
130

131
static int64_t adjustWatermark(int64_t adjInterval, int64_t originInt, int64_t watermark) {
1,238✔
132
  if (watermark <= adjInterval) {
1,238✔
133
    watermark = TMAX(originInt / adjInterval, 1) * adjInterval;
1,133✔
134
  }
135

136
  if (watermark > MAX_NUM_SCALABLE_BF * adjInterval) {
1,238✔
137
    watermark = MAX_NUM_SCALABLE_BF * adjInterval;
63✔
138
  }
139
  return watermark;
1,238✔
140
}
141

142
int32_t updateInfoInitP(SInterval* pInterval, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
667✔
143
                        SUpdateInfo** ppInfo) {
144
  return updateInfoInit(pInterval->interval, pInterval->precision, watermark, igUp, pkType, pkLen, ppInfo);
667✔
145
}
146

147
int32_t updateInfoInit(int64_t interval, int32_t precision, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
1,238✔
148
                       SUpdateInfo** ppInfo) {
149
  int32_t      code = TSDB_CODE_SUCCESS;
1,238✔
150
  int32_t      lino = 0;
1,238✔
151
  SUpdateInfo* pInfo = taosMemoryCalloc(1, sizeof(SUpdateInfo));
1,238✔
152
  if (pInfo == NULL) {
1,238!
153
    code = terrno;
×
154
    QUERY_CHECK_CODE(code, lino, _end);
×
155
  }
156
  pInfo->pTsBuckets = NULL;
1,238✔
157
  pInfo->pTsSBFs = NULL;
1,238✔
158
  pInfo->minTS = INT64_MIN;
1,238✔
159
  pInfo->interval = adjustInterval(interval, precision);
1,238✔
160
  pInfo->watermark = adjustWatermark(pInfo->interval, interval, watermark);
1,238✔
161
  pInfo->numSBFs = 0;
1,238✔
162

163
  uint64_t bfSize = 0;
1,238✔
164
  if (!igUp) {
1,238✔
165
    bfSize = (uint64_t)(pInfo->watermark / pInfo->interval);
998✔
166
    pInfo->numSBFs = bfSize;
998✔
167

168
    pInfo->pTsSBFs = taosArrayInit(bfSize, sizeof(void*));
998✔
169
    if (pInfo->pTsSBFs == NULL) {
998!
170
      updateInfoDestroy(pInfo);
×
171
      code = terrno;
×
172
      QUERY_CHECK_CODE(code, lino, _end);
×
173
    }
174
    code = windowSBfAdd(pInfo, bfSize);
998✔
175
    QUERY_CHECK_CODE(code, lino, _end);
998!
176

177
    pInfo->pTsBuckets = taosArrayInit(DEFAULT_BUCKET_SIZE, sizeof(TSKEY));
998✔
178
    if (pInfo->pTsBuckets == NULL) {
998!
179
      updateInfoDestroy(pInfo);
×
180
      code = terrno;
×
181
      QUERY_CHECK_CODE(code, lino, _end);
×
182
    }
183

184
    TSKEY dumy = INT64_MIN;
998✔
185
    for (uint64_t i = 0; i < DEFAULT_BUCKET_SIZE; ++i) {
102,299,032!
186
      void* tmp = taosArrayPush(pInfo->pTsBuckets, &dumy);
102,373,505✔
187
      if (!tmp) {
102,298,034!
188
        code = terrno;
×
189
        QUERY_CHECK_CODE(code, lino, _end);
×
190
      }
191
    }
192
    pInfo->numBuckets = DEFAULT_BUCKET_SIZE;
×
193
    pInfo->pCloseWinSBF = NULL;
×
194
  }
195
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
×
196
  pInfo->pMap = taosHashInit(DEFAULT_MAP_CAPACITY, hashFn, true, HASH_NO_LOCK);
1,238✔
197
  if (!pInfo->pMap) {
1,238!
198
    code = terrno;
×
199
    QUERY_CHECK_CODE(code, lino, _end);
×
200
  }
201
  pInfo->maxDataVersion = 0;
1,238✔
202
  pInfo->pkColLen = pkLen;
1,238✔
203
  pInfo->pkColType = pkType;
1,238✔
204
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pkLen);
1,238✔
205
  if (!pInfo->pKeyBuff) {
1,238!
206
    code = terrno;
×
207
    QUERY_CHECK_CODE(code, lino, _end);
×
208
  }
209
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pkLen);
1,238✔
210
  if (!pInfo->pValueBuff) {
1,238!
211
    code = terrno;
×
212
    QUERY_CHECK_CODE(code, lino, _end);
×
213
  }
214
  if (pkLen != 0) {
1,238✔
215
    pInfo->comparePkRowFn = compareKeyTsAndPk;
3✔
216
    pInfo->comparePkCol = getKeyComparFunc(pkType, TSDB_ORDER_ASC);
3✔
217
  } else {
218
    pInfo->comparePkRowFn = compareKeyTs;
1,235✔
219
    pInfo->comparePkCol = NULL;
1,235✔
220
  }
221
  (*ppInfo) = pInfo;
1,238✔
222

223
_end:
1,238✔
224
  if (code != TSDB_CODE_SUCCESS) {
1,238!
225
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
226
  }
227
  return code;
1,238✔
228
}
229

230
static int32_t getSBf(SUpdateInfo* pInfo, TSKEY ts, SScalableBf** ppSBf) {
15,562,492✔
231
  int32_t code = TSDB_CODE_SUCCESS;
15,562,492✔
232
  int32_t lino = 0;
15,562,492✔
233
  if (pInfo->minTS == INT64_MIN) {
15,562,492✔
234
    pInfo->minTS = (TSKEY)(ts / pInfo->interval * pInfo->interval);
377✔
235
  }
236
  int64_t index = (int64_t)((ts - pInfo->minTS) / pInfo->interval);
15,562,492✔
237
  if (index < 0) {
15,562,492✔
238
    (*ppSBf) = NULL;
12,460,106✔
239
    goto _end;
12,460,106✔
240
  }
241
  if (index >= pInfo->numSBFs) {
3,102,386✔
242
    uint64_t count = index + 1 - pInfo->numSBFs;
1,130✔
243
    windowSBfDelete(pInfo, count);
1,130✔
244
    code = windowSBfAdd(pInfo, count);
1,130✔
245
    QUERY_CHECK_CODE(code, lino, _end);
1,130!
246

247
    index = pInfo->numSBFs - 1;
1,130✔
248
  }
249
  SScalableBf* res = taosArrayGetP(pInfo->pTsSBFs, index);
3,102,386✔
250
  if (res == NULL) {
3,124,959✔
251
    int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
169✔
252
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &res);
×
253
    QUERY_CHECK_CODE(code, lino, _end);
×
254

255
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &res);
×
256
    if (!tmp) {
×
257
      code = terrno;
×
258
      QUERY_CHECK_CODE(code, lino, _end);
×
259
    }
260
  }
261
  (*ppSBf) = res;
3,124,790✔
262

263
_end:
15,584,896✔
264
  if (code != TSDB_CODE_SUCCESS) {
15,584,896!
265
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
266
  }
267
  return code;
15,561,085✔
268
}
269

270
bool updateInfoIsTableInserted(SUpdateInfo* pInfo, int64_t tbUid) {
122,952✔
271
  void* pVal = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
122,952✔
272
  if (pVal || taosHashGetSize(pInfo->pMap) >= DEFAULT_MAP_SIZE) return true;
122,938!
273
  return false;
1,376✔
274
}
275

276
int32_t updateInfoFillBlockData(SUpdateInfo* pInfo, SSDataBlock* pBlock, int32_t primaryTsCol, int32_t primaryKeyCol,
98✔
277
                                TSKEY* pMaxResTs) {
278
  int32_t code = TSDB_CODE_SUCCESS;
98✔
279
  int32_t lino = 0;
98✔
280
  if (pBlock == NULL || pBlock->info.rows == 0) {
98!
281
    (*pMaxResTs) = INT64_MIN;
×
282
    goto _end;
×
283
  }
284
  TSKEY   maxTs = INT64_MIN;
98✔
285
  void*   pPkVal = NULL;
98✔
286
  void*   pMaxPkVal = NULL;
98✔
287
  int32_t maxLen = 0;
98✔
288
  int32_t len = 0;
98✔
289
  int64_t tbUid = pBlock->info.id.uid;
98✔
290

291
  SColumnInfoData* pColDataInfo = taosArrayGet(pBlock->pDataBlock, primaryTsCol);
98✔
292
  SColumnInfoData* pPkDataInfo = NULL;
98✔
293
  if (primaryKeyCol >= 0) {
98!
UNCOV
294
    pPkDataInfo = taosArrayGet(pBlock->pDataBlock, primaryKeyCol);
×
295
  }
296

297
  for (int32_t i = 0; i < pBlock->info.rows; i++) {
718✔
298
    TSKEY ts = ((TSKEY*)pColDataInfo->pData)[i];
620✔
299
    if (maxTs < ts) {
620!
300
      maxTs = ts;
620✔
301
      if (primaryKeyCol >= 0) {
620!
UNCOV
302
        pMaxPkVal = colDataGetData(pPkDataInfo, i);
×
UNCOV
303
        maxLen = colDataGetRowLength(pPkDataInfo, i);
×
304
      }
305
    }
306
    SScalableBf* pSBf = NULL;
620✔
307
    code = getSBf(pInfo, ts, &pSBf);
620✔
308
    QUERY_CHECK_CODE(code, lino, _end);
620!
309

310
    if (pSBf) {
620!
311
      if (primaryKeyCol >= 0) {
620!
UNCOV
312
        pPkVal = colDataGetData(pPkDataInfo, i);
×
UNCOV
313
        len = colDataGetRowLength(pPkDataInfo, i);
×
314
      }
315
      int32_t buffLen = getKeyBuff(ts, tbUid, pPkVal, len, pInfo->pKeyBuff);
620✔
316
      // we don't care whether the data is updated or not
317
      int32_t winRes = 0;
620✔
318
      code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &winRes);
620✔
319
      QUERY_CHECK_CODE(code, lino, _end);
620!
320
    }
321
  }
322
  void* pMaxTs = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
98✔
323
  if (pMaxTs == NULL || pInfo->comparePkRowFn(pMaxTs, &maxTs, pMaxPkVal, pInfo->comparePkCol) == -1) {
98!
324
    int32_t valueLen = getValueBuff(maxTs, pMaxPkVal, maxLen, pInfo->pValueBuff);
98✔
325
    code = taosHashPut(pInfo->pMap, &tbUid, sizeof(int64_t), pInfo->pValueBuff, valueLen);
98✔
326
    QUERY_CHECK_CODE(code, lino, _end);
98!
327
  }
328
  (*pMaxResTs) = maxTs;
98✔
329

330
_end:
98✔
331
  if (code != TSDB_CODE_SUCCESS) {
98!
332
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
333
  }
334
  return code;
98✔
335
}
336

337
bool updateInfoIsUpdated(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
15,548,143✔
338
  int32_t code = TSDB_CODE_SUCCESS;
15,548,143✔
339
  int32_t lino = 0;
15,548,143✔
340
  int32_t res = TSDB_CODE_FAILED;
15,548,143✔
341
  int32_t buffLen = 0;
15,548,143✔
342

343
  buffLen = getKeyBuff(ts, tableId, pPkVal, len, pInfo->pKeyBuff);
15,548,143✔
344
  void**   pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
15,565,861✔
345
  uint64_t index = ((uint64_t)tableId) % pInfo->numBuckets;
15,566,262✔
346
  TSKEY    maxTs = *(TSKEY*)taosArrayGet(pInfo->pTsBuckets, index);
15,566,262✔
347
  if (maxTs != INT64_MIN && ts < maxTs - pInfo->watermark) {
15,565,552!
348
    // this window has been closed.
349
    if (pInfo->pCloseWinSBF) {
×
350
      code = tScalableBfPut(pInfo->pCloseWinSBF, pInfo->pKeyBuff, buffLen, &res);
×
351
      QUERY_CHECK_CODE(code, lino, _end);
×
352
      if (res == TSDB_CODE_SUCCESS) {
×
353
        return false;
×
354
      } else {
355
        return true;
×
356
      }
357
    }
358
    return true;
×
359
  }
360

361
  SScalableBf* pSBf = NULL;
15,565,552✔
362
  code = getSBf(pInfo, ts, &pSBf);
15,565,552✔
363
  QUERY_CHECK_CODE(code, lino, _end);
15,557,077!
364

365
  int32_t size = taosHashGetSize(pInfo->pMap);
15,557,077✔
366
  if ((!pMapMaxTs && size < DEFAULT_MAP_SIZE) ||
15,552,923!
367
      (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == -1)) {
15,552,757✔
368
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
9,950,611✔
369
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
9,986,556✔
370
    QUERY_CHECK_CODE(code, lino, _end);
9,997,453!
371

372
    // pSBf may be a null pointer
373
    if (pSBf) {
9,997,453✔
374
      res = tScalableBfPutNoCheck(pSBf, pInfo->pKeyBuff, buffLen);
2,020,465✔
375
    }
376
    return false;
9,997,356✔
377
  }
378

379
  // pSBf may be a null pointer
380
  if (pSBf) {
5,588,296✔
381
    code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &res);
1,105,120✔
382
    QUERY_CHECK_CODE(code, lino, _end);
1,105,178!
383
  }
384

385
  if (!pMapMaxTs && maxTs < ts) {
5,588,354!
386
    taosArraySet(pInfo->pTsBuckets, index, &ts);
×
387
    return false;
×
388
  }
389

390
  if (ts < pInfo->minTS) {
5,588,354✔
391
    return true;
5,041,414✔
392
  } else if (res == TSDB_CODE_SUCCESS) {
546,940✔
393
    return false;
114✔
394
  }
395

396
_end:
546,826✔
397
  if (code != TSDB_CODE_SUCCESS) {
546,826!
398
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
399
  }
400
  // check from tsdb api
401
  return true;
546,842✔
402
}
403

404
void updateInfoDestroy(SUpdateInfo* pInfo) {
2,642✔
405
  if (pInfo == NULL) {
2,642✔
406
    return;
1,210✔
407
  }
408
  taosArrayDestroy(pInfo->pTsBuckets);
1,432✔
409

410
  uint64_t size = taosArrayGetSize(pInfo->pTsSBFs);
1,432✔
411
  for (uint64_t i = 0; i < size; i++) {
6,965✔
412
    SScalableBf* pSBF = taosArrayGetP(pInfo->pTsSBFs, i);
5,533✔
413
    tScalableBfDestroy(pSBF);
5,533✔
414
  }
415

416
  taosArrayDestroy(pInfo->pTsSBFs);
1,432✔
417
  taosMemoryFreeClear(pInfo->pKeyBuff);
1,432!
418
  taosMemoryFreeClear(pInfo->pValueBuff);
1,432!
419
  taosHashCleanup(pInfo->pMap);
1,432✔
420
  updateInfoDestoryColseWinSBF(pInfo);
1,432✔
421
  taosMemoryFree(pInfo);
1,432✔
422
}
423

424
void updateInfoAddCloseWindowSBF(SUpdateInfo* pInfo) {
294✔
425
  if (pInfo->pCloseWinSBF) {
294!
426
    return;
×
427
  }
428
  int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
294✔
429
  int32_t code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &pInfo->pCloseWinSBF);
294✔
430
  if (code != TSDB_CODE_SUCCESS) {
294!
431
    pInfo->pCloseWinSBF = NULL;
×
432
    uError("%s failed to add close window SBF since %s", __func__, tstrerror(code));
×
433
  }
434
}
435

436
void updateInfoDestoryColseWinSBF(SUpdateInfo* pInfo) {
9,285✔
437
  if (!pInfo || !pInfo->pCloseWinSBF) {
9,285✔
438
    return;
8,991✔
439
  }
440
  tScalableBfDestroy(pInfo->pCloseWinSBF);
294✔
441
  pInfo->pCloseWinSBF = NULL;
294✔
442
}
443

444
int32_t updateInfoSerialize(SEncoder* pEncoder, const SUpdateInfo* pInfo) {
504✔
445
  int32_t code = TSDB_CODE_SUCCESS;
504✔
446
  int32_t lino = 0;
504✔
447
  if (!pInfo) {
504✔
448
    return TSDB_CODE_SUCCESS;
6✔
449
  }
450

451
  int32_t size = taosArrayGetSize(pInfo->pTsBuckets);
498✔
452
  if (tEncodeI32(pEncoder, size) < 0) {
497!
453
    code = TSDB_CODE_FAILED;
×
454
    QUERY_CHECK_CODE(code, lino, _end);
×
455
  }
456

457
  for (int32_t i = 0; i < size; i++) {
41,985,074!
458
    TSKEY* pTs = (TSKEY*)taosArrayGet(pInfo->pTsBuckets, i);
42,177,075✔
459
    if (tEncodeI64(pEncoder, *pTs) < 0) {
83,969,154!
460
      code = TSDB_CODE_FAILED;
×
461
      QUERY_CHECK_CODE(code, lino, _end);
×
462
    }
463
  }
464

465
  if (tEncodeU64(pEncoder, pInfo->numBuckets) < 0) {
×
466
    code = TSDB_CODE_FAILED;
×
467
    QUERY_CHECK_CODE(code, lino, _end);
×
468
  }
469

470
  int32_t sBfSize = taosArrayGetSize(pInfo->pTsSBFs);
✔
471
  if (tEncodeI32(pEncoder, sBfSize) < 0) {
498!
472
    code = TSDB_CODE_FAILED;
×
473
    QUERY_CHECK_CODE(code, lino, _end);
×
474
  }
475
  for (int32_t i = 0; i < sBfSize; i++) {
2,654✔
476
    SScalableBf* pSBf = taosArrayGetP(pInfo->pTsSBFs, i);
2,156✔
477
    if (tScalableBfEncode(pSBf, pEncoder) < 0) {
2,156!
478
      code = TSDB_CODE_FAILED;
×
479
      QUERY_CHECK_CODE(code, lino, _end);
×
480
    }
481
  }
482

483
  if (tEncodeU64(pEncoder, pInfo->numSBFs) < 0) {
996!
484
    code = TSDB_CODE_FAILED;
×
485
    QUERY_CHECK_CODE(code, lino, _end);
×
486
  }
487
  if (tEncodeI64(pEncoder, pInfo->interval) < 0) {
996!
488
    code = TSDB_CODE_FAILED;
×
489
    QUERY_CHECK_CODE(code, lino, _end);
×
490
  }
491
  if (tEncodeI64(pEncoder, pInfo->watermark) < 0) {
996!
492
    code = TSDB_CODE_FAILED;
×
493
    QUERY_CHECK_CODE(code, lino, _end);
×
494
  }
495
  if (tEncodeI64(pEncoder, pInfo->minTS) < 0) {
996!
496
    code = TSDB_CODE_FAILED;
×
497
    QUERY_CHECK_CODE(code, lino, _end);
×
498
  }
499

500
  if (tScalableBfEncode(pInfo->pCloseWinSBF, pEncoder) < 0) {
498!
501
    code = TSDB_CODE_FAILED;
×
502
    QUERY_CHECK_CODE(code, lino, _end);
×
503
  }
504

505
  int32_t mapSize = taosHashGetSize(pInfo->pMap);
498✔
506
  if (tEncodeI32(pEncoder, mapSize) < 0) {
498!
507
    code = TSDB_CODE_FAILED;
×
508
    QUERY_CHECK_CODE(code, lino, _end);
×
509
  }
510
  void*  pIte = NULL;
498✔
511
  size_t keyLen = 0;
498✔
512
  while ((pIte = taosHashIterate(pInfo->pMap, pIte)) != NULL) {
2,740✔
513
    void* key = taosHashGetKey(pIte, &keyLen);
2,242✔
514
    if (tEncodeU64(pEncoder, *(uint64_t*)key) < 0) {
4,484!
515
      code = TSDB_CODE_FAILED;
×
516
      QUERY_CHECK_CODE(code, lino, _end);
×
517
    }
518
    int32_t valueSize = taosHashGetValueSize(pIte);
2,242✔
519
    if (tEncodeBinary(pEncoder, (const uint8_t*)pIte, valueSize) < 0) {
4,484!
520
      code = TSDB_CODE_FAILED;
×
521
      QUERY_CHECK_CODE(code, lino, _end);
×
522
    }
523
  }
524

525
  if (tEncodeU64(pEncoder, pInfo->maxDataVersion) < 0) {
996!
526
    code = TSDB_CODE_FAILED;
×
527
    QUERY_CHECK_CODE(code, lino, _end);
×
528
  }
529

530
  if (tEncodeI32(pEncoder, pInfo->pkColLen) < 0) {
996!
531
    code = TSDB_CODE_FAILED;
×
532
    QUERY_CHECK_CODE(code, lino, _end);
×
533
  }
534
  if (tEncodeI8(pEncoder, pInfo->pkColType) < 0) {
996!
535
    code = TSDB_CODE_FAILED;
×
536
    QUERY_CHECK_CODE(code, lino, _end);
×
537
  }
538

539
_end:
498✔
540
  if (code != TSDB_CODE_SUCCESS) {
498!
541
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
542
  }
543
  return code;
498✔
544
}
545

546
int32_t updateInfoDeserialize(SDecoder* pDeCoder, SUpdateInfo* pInfo) {
208✔
547
  int32_t code = TSDB_CODE_SUCCESS;
208✔
548
  int32_t lino = 0;
208✔
549
  QUERY_CHECK_NULL(pInfo, code, lino, _error, TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
208!
550
  
551
  int32_t size = 0;
208✔
552
  if (tDecodeI32(pDeCoder, &size) < 0) return -1;
208!
553
  pInfo->pTsBuckets = taosArrayInit(size, sizeof(TSKEY));
208✔
554
  QUERY_CHECK_NULL(pInfo->pTsBuckets, code, lino, _error, terrno);
208!
555

556
  TSKEY ts = INT64_MIN;
208✔
557
  for (int32_t i = 0; i < size; i++) {
21,295,210!
558
    if (tDecodeI64(pDeCoder, &ts) < 0) return -1;
21,372,353!
559
    void* tmp = taosArrayPush(pInfo->pTsBuckets, &ts);
21,372,353✔
560
    if (!tmp) {
21,295,002!
561
      code = terrno;
×
562
      QUERY_CHECK_CODE(code, lino, _error);
×
563
    }
564
  }
565

566
  if (tDecodeU64(pDeCoder, &pInfo->numBuckets) < 0) return -1;
×
567

568
  int32_t sBfSize = 0;
208✔
569
  if (tDecodeI32(pDeCoder, &sBfSize) < 0) return -1;
208!
570
  pInfo->pTsSBFs = taosArrayInit(sBfSize, sizeof(void*));
208✔
571
  QUERY_CHECK_NULL(pInfo->pTsSBFs, code, lino, _error, terrno);
208!
572

573
  for (int32_t i = 0; i < sBfSize; i++) {
1,258✔
574
    SScalableBf* pSBf = NULL;
1,050✔
575
    code = tScalableBfDecode(pDeCoder, &pSBf);
1,050✔
576
    QUERY_CHECK_CODE(code, lino, _error);
1,050!
577

578
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &pSBf);
1,050✔
579
    if (!tmp) {
1,050!
580
      code = terrno;
×
581
      QUERY_CHECK_CODE(code, lino, _error);
×
582
    }
583
  }
584

585
  if (tDecodeU64(pDeCoder, &pInfo->numSBFs) < 0) return -1;
416!
586
  if (tDecodeI64(pDeCoder, &pInfo->interval) < 0) return -1;
416!
587
  if (tDecodeI64(pDeCoder, &pInfo->watermark) < 0) return -1;
416!
588
  if (tDecodeI64(pDeCoder, &pInfo->minTS) < 0) return -1;
416!
589

590
  code = tScalableBfDecode(pDeCoder, &pInfo->pCloseWinSBF);
208✔
591
  if (code != TSDB_CODE_SUCCESS) {
208!
592
    pInfo->pCloseWinSBF = NULL;
×
593
    code = TSDB_CODE_SUCCESS;
×
594
  }
595

596
  int32_t mapSize = 0;
208✔
597
  if (tDecodeI32(pDeCoder, &mapSize) < 0) return -1;
208!
598
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
208✔
599
  pInfo->pMap = taosHashInit(mapSize, hashFn, true, HASH_NO_LOCK);
208✔
600
  uint64_t uid = 0;
208✔
601
  void*    pVal = NULL;
208✔
602
  uint32_t  valSize = 0;
208✔
603
  for (int32_t i = 0; i < mapSize; i++) {
306✔
604
    if (tDecodeU64(pDeCoder, &uid) < 0) return -1;
98!
605
    if (tDecodeBinary(pDeCoder, (uint8_t**)&pVal, &valSize) < 0) return -1;
98!
606
    code = taosHashPut(pInfo->pMap, &uid, sizeof(uint64_t), pVal, valSize);
98✔
607
    QUERY_CHECK_CODE(code, lino, _error);
98!
608
  }
609
  QUERY_CHECK_CONDITION((mapSize == taosHashGetSize(pInfo->pMap)), code, lino, _error,
208!
610
                        TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
611
  if (tDecodeU64(pDeCoder, &pInfo->maxDataVersion) < 0) return -1;
416!
612

613
  if (tDecodeI32(pDeCoder, &pInfo->pkColLen) < 0) return -1;
416!
614
  if (tDecodeI8(pDeCoder, &pInfo->pkColType) < 0) return -1;
416!
615

616
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pInfo->pkColLen);
208✔
617
  QUERY_CHECK_NULL(pInfo->pKeyBuff, code, lino, _error, terrno);
208!
618

619
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pInfo->pkColLen);
208✔
620
  QUERY_CHECK_NULL(pInfo->pValueBuff, code, lino, _error, terrno);
208!
621

622
  if (pInfo->pkColLen != 0) {
208!
UNCOV
623
    pInfo->comparePkRowFn = compareKeyTsAndPk;
×
UNCOV
624
    pInfo->comparePkCol = getKeyComparFunc(pInfo->pkColType, TSDB_ORDER_ASC);
×
625
  } else {
626
    pInfo->comparePkRowFn = compareKeyTs;
208✔
627
    pInfo->comparePkCol = NULL;
208✔
628
  }
629

630
_error:
208✔
631
  if (code != TSDB_CODE_SUCCESS) {
208!
632
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
633
  }
634
  return code;
208✔
635
}
636

637
bool isIncrementalTimeStamp(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
1,487✔
638
  int32_t code = TSDB_CODE_SUCCESS;
1,487✔
639
  int32_t lino = 0;
1,487✔
640
  TSKEY*  pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
1,487✔
641
  bool    res = true;
1,487✔
642
  if (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == 1) {
1,487✔
643
    res = false;
74✔
644
  } else {
645
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
1,413✔
646
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
1,413✔
647
    QUERY_CHECK_CODE(code, lino, _error);
1,413!
648
  }
649
  return res;
1,487✔
650

651
_error:
×
652
  if (code != TSDB_CODE_SUCCESS) {
×
653
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
654
  }
655
  return false;
×
656
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc