#3533

Committed 20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%

Build # #3533

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

Run Details

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.55

/source/dnode/vnode/src/vnd/vnodeBufPool.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include "vnd.h"

/* ------------------------ STRUCTURES ------------------------ */
static int32_t vnodeBufPoolCreate(SVnode *pVnode, int32_t id, int64_t size, SVBufPool **ppPool) {
  SVBufPool *pPool;

  pPool = taosMemoryMalloc(sizeof(SVBufPool) + size);
  if (pPool == NULL) {
    return terrno;
  }
  memset(pPool, 0, sizeof(SVBufPool));

  // query handle list
  (void)taosThreadMutexInit(&pPool->mutex, NULL);
  pPool->nQuery = 0;
  pPool->qList.pNext = &pPool->qList;
  pPool->qList.ppNext = &pPool->qList.pNext;

  pPool->pVnode = pVnode;
  pPool->id = id;
  pPool->ptr = pPool->node.data;
  pPool->pTail = &pPool->node;
  pPool->node.prev = NULL;
  pPool->node.pnext = &pPool->pTail;
  pPool->node.size = size;

  if (VND_IS_RSMA(pVnode)) {
    pPool->lock = taosMemoryMalloc(sizeof(TdThreadSpinlock));
    if (!pPool->lock) {
      taosMemoryFree(pPool);
      return terrno;
    }
    if (taosThreadSpinInit(pPool->lock, 0) != 0) {
      taosMemoryFree((void *)pPool->lock);
      taosMemoryFree(pPool);
      return terrno = TAOS_SYSTEM_ERROR(errno);
    }
  } else {
    pPool->lock = NULL;
  }

  *ppPool = pPool;
  return 0;
}

static void vnodeBufPoolDestroy(SVBufPool *pPool) {
  vnodeBufPoolReset(pPool);
  if (pPool->lock) {
    (void)taosThreadSpinDestroy(pPool->lock);
    taosMemoryFree((void *)pPool->lock);
  }
  (void)taosThreadMutexDestroy(&pPool->mutex);
  taosMemoryFree(pPool);
}

int vnodeOpenBufPool(SVnode *pVnode) {
  int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;

  for (int i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {
    // create pool
    int32_t code;
    if ((code = vnodeBufPoolCreate(pVnode, i, size, &pVnode->aBufPool[i]))) {
      vError("vgId:%d, failed to open vnode buffer pool since %s", TD_VID(pVnode), tstrerror(terrno));
      vnodeCloseBufPool(pVnode);
      return code;
    }

    // add to free list
    pVnode->aBufPool[i]->freeNext = pVnode->freeList;
    pVnode->freeList = pVnode->aBufPool[i];
  }

  vDebug("vgId:%d, vnode buffer pool is opened, size:%" PRId64, TD_VID(pVnode), size);
  return 0;
}

void vnodeCloseBufPool(SVnode *pVnode) {
  for (int32_t i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {
    if (pVnode->aBufPool[i]) {
      vnodeBufPoolDestroy(pVnode->aBufPool[i]);
      pVnode->aBufPool[i] = NULL;
    }
  }

  vDebug("vgId:%d, vnode buffer pool is closed", TD_VID(pVnode));
}

void vnodeBufPoolReset(SVBufPool *pPool) {
  if (pPool->nQuery != 0) {
    vError("vgId:%d, buffer pool %p of id %d has %d queries, reset it may cause problem", TD_VID(pPool->pVnode), pPool,
           pPool->id, pPool->nQuery);
  }

  for (SVBufPoolNode *pNode = pPool->pTail; pNode->prev; pNode = pPool->pTail) {
    pNode->prev->pnext = &pPool->pTail;
    pPool->pTail = pNode->prev;
    pPool->size = pPool->size - sizeof(*pNode) - pNode->size;
    taosMemoryFree(pNode);
  }

  pPool->size = 0;
  pPool->ptr = pPool->node.data;
}

void *vnodeBufPoolMallocAligned(SVBufPool *pPool, int size) {
  SVBufPoolNode *pNode;
  void          *p = NULL;
  uint8_t       *ptr = NULL;
  int            paddingLen = 0;

  if (pPool == NULL) {
    terrno = TSDB_CODE_INVALID_PARA;
    return NULL;
  }

  if (pPool->lock) taosThreadSpinLock(pPool->lock);

  ptr = pPool->ptr;
  paddingLen = (((long)ptr + 7) & ~7) - (long)ptr;

  if (pPool->node.size >= pPool->ptr - pPool->node.data + size + paddingLen) {
    // allocate from the anchor node
    p = pPool->ptr + paddingLen;
    size += paddingLen;
    pPool->ptr = pPool->ptr + size;
    pPool->size += size;
  } else {
    // allocate a new node
    pNode = taosMemoryMalloc(sizeof(*pNode) + size);
    if (pNode == NULL) {
      if (pPool->lock) {
        (void)taosThreadSpinUnlock(pPool->lock);
      }
      return NULL;
    }

    p = pNode->data;
    pNode->size = size;
    pNode->prev = pPool->pTail;
    pNode->pnext = &pPool->pTail;
    pPool->pTail->pnext = &pNode->prev;
    pPool->pTail = pNode;

    pPool->size = pPool->size + sizeof(*pNode) + size;
  }
  if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);
  return p;
}

void *vnodeBufPoolMalloc(SVBufPool *pPool, int size) {
  SVBufPoolNode *pNode;
  void          *p = NULL;

  if (pPool == NULL) {
    terrno = TSDB_CODE_INVALID_PARA;
    return NULL;
  }

  if (pPool->lock) taosThreadSpinLock(pPool->lock);
  if (pPool->node.size >= pPool->ptr - pPool->node.data + size) {
    // allocate from the anchor node
    p = pPool->ptr;
    pPool->ptr = pPool->ptr + size;
    pPool->size += size;
  } else {
    // allocate a new node
    pNode = taosMemoryMalloc(sizeof(*pNode) + size);
    if (pNode == NULL) {
      if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);
      return NULL;
    }

    p = pNode->data;
    pNode->size = size;
    pNode->prev = pPool->pTail;
    pNode->pnext = &pPool->pTail;
    pPool->pTail->pnext = &pNode->prev;
    pPool->pTail = pNode;

    pPool->size = pPool->size + sizeof(*pNode) + size;
  }
  if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);
  return p;
}

void vnodeBufPoolFree(SVBufPool *pPool, void *p) {
  // uint8_t       *ptr = (uint8_t *)p;
  // SVBufPoolNode *pNode;

  // if (ptr < pPool->node.data || ptr >= pPool->node.data + pPool->node.size) {
  //   pNode = &((SVBufPoolNode *)p)[-1];
  //   *pNode->pnext = pNode->prev;
  //   pNode->prev->pnext = pNode->pnext;

  //   pPool->size = pPool->size - sizeof(*pNode) - pNode->size;
  //   taosMemoryFree(pNode);
  // }
}

void vnodeBufPoolRef(SVBufPool *pPool) {
  int32_t nRef = atomic_fetch_add_32(&pPool->nRef, 1);
  if (nRef <= 0) {
    vError("vgId:%d, buffer pool %p of id %d is referenced by %d", TD_VID(pPool->pVnode), pPool, pPool->id, nRef);
  }
}

void vnodeBufPoolAddToFreeList(SVBufPool *pPool) {
  SVnode *pVnode = pPool->pVnode;

  int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;
  if (pPool->node.size != size) {
    SVBufPool *pNewPool = NULL;
    if (vnodeBufPoolCreate(pVnode, pPool->id, size, &pNewPool) < 0) {
      vWarn("vgId:%d, failed to change buffer pool of id %d size from %" PRId64 " to %" PRId64 " since %s",
            TD_VID(pVnode), pPool->id, pPool->node.size, size, tstrerror(errno));
    } else {
      vInfo("vgId:%d, buffer pool of id %d size changed from %" PRId64 " to %" PRId64, TD_VID(pVnode), pPool->id,
            pPool->node.size, size);

      vnodeBufPoolDestroy(pPool);
      pPool = pNewPool;
      pVnode->aBufPool[pPool->id] = pPool;
    }
  }

  // add to free list
  vDebug("vgId:%d, buffer pool %p of id %d is added to free list", TD_VID(pVnode), pPool, pPool->id);
  vnodeBufPoolReset(pPool);
  pPool->freeNext = pVnode->freeList;
  pVnode->freeList = pPool;
  (void)taosThreadCondSignal(&pVnode->poolNotEmpty);
}

void vnodeBufPoolUnRef(SVBufPool *pPool, bool proactive) {
  if (pPool == NULL) return;

  SVnode *pVnode = pPool->pVnode;

  if (proactive) {
    (void)taosThreadMutexLock(&pVnode->mutex);
  }

  if (atomic_sub_fetch_32(&pPool->nRef, 1) > 0) goto _exit;

  // remove from recycle queue or on-recycle position
  if (pVnode->onRecycle == pPool) {
    pVnode->onRecycle = NULL;
  } else {
    if (pPool->recyclePrev) {
      pPool->recyclePrev->recycleNext = pPool->recycleNext;
    } else {
      pVnode->recycleHead = pPool->recycleNext;
    }

    if (pPool->recycleNext) {
      pPool->recycleNext->recyclePrev = pPool->recyclePrev;
    } else {
      pVnode->recycleTail = pPool->recyclePrev;
    }
    pPool->recyclePrev = pPool->recycleNext = NULL;
  }

  vnodeBufPoolAddToFreeList(pPool);

_exit:
  if (proactive) {
    (void)taosThreadMutexUnlock(&pVnode->mutex);
  }
  return;
}

void vnodeBufPoolRegisterQuery(SVBufPool *pPool, SQueryNode *pQNode) {
  (void)taosThreadMutexLock(&pPool->mutex);

  pQNode->pNext = pPool->qList.pNext;
  pQNode->ppNext = &pPool->qList.pNext;
  pPool->qList.pNext->ppNext = &pQNode->pNext;
  pPool->qList.pNext = pQNode;
  pPool->nQuery++;

  (void)taosThreadMutexUnlock(&pPool->mutex);
}

void vnodeBufPoolDeregisterQuery(SVBufPool *pPool, SQueryNode *pQNode, bool proactive) {
  int32_t code = 0;

  if (proactive) {
    (void)taosThreadMutexLock(&pPool->mutex);
  }

  pQNode->pNext->ppNext = pQNode->ppNext;
  *pQNode->ppNext = pQNode->pNext;
  pPool->nQuery--;

  if (proactive) {
    (void)taosThreadMutexUnlock(&pPool->mutex);
  }
}

int32_t vnodeBufPoolRecycle(SVBufPool *pPool) {
  int32_t code = 0;

  SVnode *pVnode = pPool->pVnode;

  vDebug("vgId:%d, recycle buffer pool %p of id %d", TD_VID(pVnode), pPool, pPool->id);

  (void)taosThreadMutexLock(&pPool->mutex);

  SQueryNode *pNode = pPool->qList.pNext;
  while (pNode != &pPool->qList) {
    SQueryNode *pTNode = pNode->pNext;

    int32_t rc = pNode->reseek(pNode->pQHandle);
    if (rc == 0 || rc == TSDB_CODE_VND_QUERY_BUSY) {
      pNode = pTNode;
    } else {
      code = rc;
      goto _exit;
    }
  }

_exit:
  (void)taosThreadMutexUnlock(&pPool->mutex);
  return code;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include "vnd.h"
17
18	/* ------------------------ STRUCTURES ------------------------ */
19	static int32_t vnodeBufPoolCreate(SVnode pVnode, int32_t id, int64_t size, SVBufPool *ppPool) {	19,847✔
20	SVBufPool *pPool;
21
22	pPool = taosMemoryMalloc(sizeof(SVBufPool) + size);	19,847✔
23	if (pPool == NULL) {	19,868!
24	return terrno;	×
25	}
26	memset(pPool, 0, sizeof(SVBufPool));	19,868✔
27
28	// query handle list
29	(void)taosThreadMutexInit(&pPool->mutex, NULL);	19,868✔
30	pPool->nQuery = 0;	19,863✔
31	pPool->qList.pNext = &pPool->qList;	19,863✔
32	pPool->qList.ppNext = &pPool->qList.pNext;	19,863✔
33
34	pPool->pVnode = pVnode;	19,863✔
35	pPool->id = id;	19,863✔
36	pPool->ptr = pPool->node.data;	19,863✔
37	pPool->pTail = &pPool->node;	19,863✔
38	pPool->node.prev = NULL;	19,863✔
39	pPool->node.pnext = &pPool->pTail;	19,863✔
40	pPool->node.size = size;	19,863✔
41
42	if (VND_IS_RSMA(pVnode)) {	19,863✔
43	pPool->lock = taosMemoryMalloc(sizeof(TdThreadSpinlock));	58✔
44	if (!pPool->lock) {	51!
45	taosMemoryFree(pPool);	×
46	return terrno;	×
47	}
48	if (taosThreadSpinInit(pPool->lock, 0) != 0) {	51!
49	taosMemoryFree((void *)pPool->lock);	×
50	taosMemoryFree(pPool);	×
51	return terrno = TAOS_SYSTEM_ERROR(errno);	×
52	}
53	} else {
54	pPool->lock = NULL;	19,805✔
55	}
56
57	*ppPool = pPool;	19,857✔
58	return 0;	19,857✔
59	}
60
61	static void vnodeBufPoolDestroy(SVBufPool *pPool) {	19,875✔
62	vnodeBufPoolReset(pPool);	19,875✔
63	if (pPool->lock) {	19,875✔
64	(void)taosThreadSpinDestroy(pPool->lock);	51✔
65	taosMemoryFree((void *)pPool->lock);	51✔
66	}
67	(void)taosThreadMutexDestroy(&pPool->mutex);	19,875✔
68	taosMemoryFree(pPool);	19,875✔
69	}	19,875✔
70
71	int vnodeOpenBufPool(SVnode *pVnode) {	6,616✔
72	int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;	6,616✔
73
74	for (int i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {	26,473✔
75	// create pool
76	int32_t code;
77	if ((code = vnodeBufPoolCreate(pVnode, i, size, &pVnode->aBufPool[i]))) {	19,846✔
78	vError("vgId:%d, failed to open vnode buffer pool since %s", TD_VID(pVnode), tstrerror(terrno));	1!
79	vnodeCloseBufPool(pVnode);	1✔
80	return code;	×
81	}
82
83	// add to free list
84	pVnode->aBufPool[i]->freeNext = pVnode->freeList;	19,857✔
85	pVnode->freeList = pVnode->aBufPool[i];	19,857✔
86	}
87
88	vDebug("vgId:%d, vnode buffer pool is opened, size:%" PRId64, TD_VID(pVnode), size);	6,627✔
89	return 0;	6,624✔
90	}
91
92	void vnodeCloseBufPool(SVnode *pVnode) {	6,625✔
93	for (int32_t i = 0; i < VNODE_BUFPOOL_SEGMENTS; i++) {	26,500✔
94	if (pVnode->aBufPool[i]) {	19,875!
95	vnodeBufPoolDestroy(pVnode->aBufPool[i]);	19,875✔
96	pVnode->aBufPool[i] = NULL;	19,875✔
97	}
98	}
99
100	vDebug("vgId:%d, vnode buffer pool is closed", TD_VID(pVnode));	6,625✔
101	}	6,625✔
102
103	void vnodeBufPoolReset(SVBufPool *pPool) {	27,246✔
104	if (pPool->nQuery != 0) {	27,246!
105	vError("vgId:%d, buffer pool %p of id %d has %d queries, reset it may cause problem", TD_VID(pPool->pVnode), pPool,	×
106	pPool->id, pPool->nQuery);
107	}
108
109	for (SVBufPoolNode *pNode = pPool->pTail; pNode->prev; pNode = pPool->pTail) {	67,094✔
110	pNode->prev->pnext = &pPool->pTail;	39,848✔
111	pPool->pTail = pNode->prev;	39,848✔
112	pPool->size = pPool->size - sizeof(*pNode) - pNode->size;	39,848✔
113	taosMemoryFree(pNode);	39,848✔
114	}
115
116	pPool->size = 0;	27,246✔
117	pPool->ptr = pPool->node.data;	27,246✔
118	}	27,246✔
119
120	void vnodeBufPoolMallocAligned(SVBufPool pPool, int size) {	38,119,283✔
121	SVBufPoolNode *pNode;
122	void *p = NULL;	38,119,283✔
123	uint8_t *ptr = NULL;	38,119,283✔
124	int paddingLen = 0;	38,119,283✔
125
126	if (pPool == NULL) {	38,119,283!
127	terrno = TSDB_CODE_INVALID_PARA;	×
128	return NULL;	×
129	}
130
131	if (pPool->lock) taosThreadSpinLock(pPool->lock);	38,119,283✔
132
133	ptr = pPool->ptr;	38,125,172✔
134	paddingLen = (((long)ptr + 7) & ~7) - (long)ptr;	38,125,172✔
135
136	if (pPool->node.size >= pPool->ptr - pPool->node.data + size + paddingLen) {	38,125,172✔
137	// allocate from the anchor node
138	p = pPool->ptr + paddingLen;	38,085,324✔
139	size += paddingLen;	38,085,324✔
140	pPool->ptr = pPool->ptr + size;	38,085,324✔
141	pPool->size += size;	38,085,324✔
142	} else {
143	// allocate a new node
144	pNode = taosMemoryMalloc(sizeof(*pNode) + size);	39,848✔
145	if (pNode == NULL) {	39,848!
146	if (pPool->lock) {	×
147	(void)taosThreadSpinUnlock(pPool->lock);	×
148	}
149	return NULL;	×
150	}
151
152	p = pNode->data;	39,848✔
153	pNode->size = size;	39,848✔
154	pNode->prev = pPool->pTail;	39,848✔
155	pNode->pnext = &pPool->pTail;	39,848✔
156	pPool->pTail->pnext = &pNode->prev;	39,848✔
157	pPool->pTail = pNode;	39,848✔
158
159	pPool->size = pPool->size + sizeof(*pNode) + size;	39,848✔
160	}
161	if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);	38,125,172✔
162	return p;	38,122,756✔
163	}
164
165	void vnodeBufPoolMalloc(SVBufPool pPool, int size) {	2,529✔
166	SVBufPoolNode *pNode;
167	void *p = NULL;	2,529✔
168
169	if (pPool == NULL) {	2,529!
170	terrno = TSDB_CODE_INVALID_PARA;	×
171	return NULL;	×
172	}
173
174	if (pPool->lock) taosThreadSpinLock(pPool->lock);	2,529✔
175	if (pPool->node.size >= pPool->ptr - pPool->node.data + size) {	2,530!
176	// allocate from the anchor node
177	p = pPool->ptr;	2,530✔
178	pPool->ptr = pPool->ptr + size;	2,530✔
179	pPool->size += size;	2,530✔
180	} else {
181	// allocate a new node
182	pNode = taosMemoryMalloc(sizeof(*pNode) + size);	×
183	if (pNode == NULL) {	×
184	if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);	×
185	return NULL;	×
186	}
187
188	p = pNode->data;	×
189	pNode->size = size;	×
190	pNode->prev = pPool->pTail;	×
191	pNode->pnext = &pPool->pTail;	×
192	pPool->pTail->pnext = &pNode->prev;	×
193	pPool->pTail = pNode;	×
194
195	pPool->size = pPool->size + sizeof(*pNode) + size;	×
196	}
197	if (pPool->lock) (void)taosThreadSpinUnlock(pPool->lock);	2,530✔
198	return p;	2,530✔
199	}
200
201	void vnodeBufPoolFree(SVBufPool pPool, void p) {	146✔
202	// uint8_t ptr = (uint8_t )p;
203	// SVBufPoolNode *pNode;
204
205	// if (ptr < pPool->node.data \|\| ptr >= pPool->node.data + pPool->node.size) {
206	// pNode = &((SVBufPoolNode *)p)[-1];
207	// *pNode->pnext = pNode->prev;
208	// pNode->prev->pnext = pNode->pnext;
209
210	// pPool->size = pPool->size - sizeof(*pNode) - pNode->size;
211	// taosMemoryFree(pNode);
212	// }
213	}	146✔
214
215	void vnodeBufPoolRef(SVBufPool *pPool) {	14,060✔
216	int32_t nRef = atomic_fetch_add_32(&pPool->nRef, 1);	14,060✔
217	if (nRef <= 0) {	14,059!
218	vError("vgId:%d, buffer pool %p of id %d is referenced by %d", TD_VID(pPool->pVnode), pPool, pPool->id, nRef);	×
219	}
220	}	14,059✔
221
222	void vnodeBufPoolAddToFreeList(SVBufPool *pPool) {	7,371✔
223	SVnode *pVnode = pPool->pVnode;	7,371✔
224
225	int64_t size = pVnode->config.szBuf / VNODE_BUFPOOL_SEGMENTS;	7,371✔
226	if (pPool->node.size != size) {	7,371!
227	SVBufPool *pNewPool = NULL;	×
228	if (vnodeBufPoolCreate(pVnode, pPool->id, size, &pNewPool) < 0) {	×
229	vWarn("vgId:%d, failed to change buffer pool of id %d size from %" PRId64 " to %" PRId64 " since %s",	×
230	TD_VID(pVnode), pPool->id, pPool->node.size, size, tstrerror(errno));
231	} else {
232	vInfo("vgId:%d, buffer pool of id %d size changed from %" PRId64 " to %" PRId64, TD_VID(pVnode), pPool->id,	×
233	pPool->node.size, size);
234
235	vnodeBufPoolDestroy(pPool);	×
236	pPool = pNewPool;	×
237	pVnode->aBufPool[pPool->id] = pPool;	×
238	}
239	}
240
241	// add to free list
242	vDebug("vgId:%d, buffer pool %p of id %d is added to free list", TD_VID(pVnode), pPool, pPool->id);	7,371✔
243	vnodeBufPoolReset(pPool);	7,371✔
244	pPool->freeNext = pVnode->freeList;	7,371✔
245	pVnode->freeList = pPool;	7,371✔
246	(void)taosThreadCondSignal(&pVnode->poolNotEmpty);	7,371✔
247	}	7,371✔
248
249	void vnodeBufPoolUnRef(SVBufPool *pPool, bool proactive) {	14,060✔
250	if (pPool == NULL) return;	14,060!
251
252	SVnode *pVnode = pPool->pVnode;	14,060✔
253
254	if (proactive) {	14,060!
255	(void)taosThreadMutexLock(&pVnode->mutex);	14,060✔
256	}
257
258	if (atomic_sub_fetch_32(&pPool->nRef, 1) > 0) goto _exit;	14,060✔
259
260	// remove from recycle queue or on-recycle position
261	if (pVnode->onRecycle == pPool) {	73!
UNCOV 262	pVnode->onRecycle = NULL;	×
263	} else {
264	if (pPool->recyclePrev) {	73!
265	pPool->recyclePrev->recycleNext = pPool->recycleNext;	×
266	} else {
267	pVnode->recycleHead = pPool->recycleNext;	73✔
268	}
269
270	if (pPool->recycleNext) {	73!
UNCOV 271	pPool->recycleNext->recyclePrev = pPool->recyclePrev;	×
272	} else {
273	pVnode->recycleTail = pPool->recyclePrev;	73✔
274	}
275	pPool->recyclePrev = pPool->recycleNext = NULL;	73✔
276	}
277
278	vnodeBufPoolAddToFreeList(pPool);	73✔
279
280	_exit:	14,060✔
281	if (proactive) {	14,060!
282	(void)taosThreadMutexUnlock(&pVnode->mutex);	14,060✔
283	}
284	return;	14,060✔
285	}
286
287	void vnodeBufPoolRegisterQuery(SVBufPool pPool, SQueryNode pQNode) {	213,765✔
288	(void)taosThreadMutexLock(&pPool->mutex);	213,765✔
289
290	pQNode->pNext = pPool->qList.pNext;	213,853✔
291	pQNode->ppNext = &pPool->qList.pNext;	213,853✔
292	pPool->qList.pNext->ppNext = &pQNode->pNext;	213,853✔
293	pPool->qList.pNext = pQNode;	213,853✔
294	pPool->nQuery++;	213,853✔
295
296	(void)taosThreadMutexUnlock(&pPool->mutex);	213,853✔
297	}	213,855✔
298
299	void vnodeBufPoolDeregisterQuery(SVBufPool pPool, SQueryNode pQNode, bool proactive) {	213,844✔
300	int32_t code = 0;	213,844✔
301
302	if (proactive) {	213,844!
303	(void)taosThreadMutexLock(&pPool->mutex);	213,852✔
304	}
305
306	pQNode->pNext->ppNext = pQNode->ppNext;	213,852✔
307	*pQNode->ppNext = pQNode->pNext;	213,852✔
308	pPool->nQuery--;	213,852✔
309
310	if (proactive) {	213,852!
311	(void)taosThreadMutexUnlock(&pPool->mutex);	213,858✔
312	}
313	}	213,852✔
314
UNCOV 315	int32_t vnodeBufPoolRecycle(SVBufPool *pPool) {	×
UNCOV 316	int32_t code = 0;	×
317
UNCOV 318	SVnode *pVnode = pPool->pVnode;	×
319
UNCOV 320	vDebug("vgId:%d, recycle buffer pool %p of id %d", TD_VID(pVnode), pPool, pPool->id);	×
321
UNCOV 322	(void)taosThreadMutexLock(&pPool->mutex);	×
323
UNCOV 324	SQueryNode *pNode = pPool->qList.pNext;	×
UNCOV 325	while (pNode != &pPool->qList) {	×
UNCOV 326	SQueryNode *pTNode = pNode->pNext;	×
327
UNCOV 328	int32_t rc = pNode->reseek(pNode->pQHandle);	×
UNCOV 329	if (rc == 0 \|\| rc == TSDB_CODE_VND_QUERY_BUSY) {	×
UNCOV 330	pNode = pTNode;	×
331	} else {
332	code = rc;	×
333	goto _exit;	×
334	}
335	}
336
UNCOV 337	_exit:	×
UNCOV 338	(void)taosThreadMutexUnlock(&pPool->mutex);	×
UNCOV 339	return code;	×
340	}

taosdata / TDengine / #3533

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous