#3533

Committed 20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%

Build # #3533

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

Run Details

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

72.45

/source/client/src/clientSmlTelnet.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */

#include <ctype.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#include "clientSml.h"

int32_t is_same_child_table_telnet(const void *a, const void *b) {
  SSmlLineInfo *t1 = (SSmlLineInfo *)a;
  SSmlLineInfo *t2 = (SSmlLineInfo *)b;
  if (t1 == NULL || t2 == NULL || t1->measure == NULL || t2->measure == NULL || t1->tags == NULL || t2->tags == NULL)
    return 1;
  return (((t1->measureLen == t2->measureLen) && memcmp(t1->measure, t2->measure, t1->measureLen) == 0) &&
          ((t1->tagsLen == t2->tagsLen) && memcmp(t1->tags, t2->tags, t1->tagsLen) == 0))
             ? 0
             : 1;
}

int64_t smlParseOpenTsdbTime(SSmlHandle *info, const char *data, int32_t len) {
  uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;

  if (unlikely(!data)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "timestamp can not be null", NULL);
    return -1;
  }
  if (unlikely(len == 1 && data[0] == '0')) {
    return taosGetTimestampNs() / smlFactorNS[toPrecision];
  }
  int8_t fromPrecision = smlGetTsTypeByLen(len);
  if (unlikely(fromPrecision == -1)) {
    smlBuildInvalidDataMsg(&info->msgBuf,
                           "timestamp precision can only be seconds(10 digits) or milli seconds(13 digits)", data);
    return -1;
  }
  int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);
  if (unlikely(ts == -1)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "invalid timestamp", data);
    return -1;
  }
  return ts;
}

static void smlParseTelnetElement(char **sql, char *sqlEnd, char **data, int32_t *len) {
  while (*sql < sqlEnd) {
    if (unlikely((**sql != SPACE && !(*data)))) {
      *data = *sql;
    } else if (unlikely(**sql == SPACE && *data)) {
      *len = *sql - *data;
      break;
    }
    (*sql)++;
  }
}

static int32_t smlProcessTagTelnet(SSmlHandle *info, char *data, char *sqlEnd){
  SArray *preLineKV = info->preLineTagKV;
  taosArrayClearEx(preLineKV, freeSSmlKv);
  int     cnt = 0;

  const char *sql = data;
  while (sql < sqlEnd) {
    JUMP_SPACE(sql, sqlEnd)
    if (unlikely(*sql == '\0')) break;

    const char *key = sql;
    size_t      keyLen = 0;

    // parse key
    while (sql < sqlEnd) {
      if (unlikely(*sql == SPACE)) {
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);
        return TSDB_CODE_SML_INVALID_DATA;
      }
      if (unlikely(*sql == EQUAL)) {
        keyLen = sql - key;
        sql++;
        break;
      }
      sql++;
    }

    if (unlikely(IS_INVALID_COL_LEN(keyLen))) {
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
    }

    // parse value
    const char *value = sql;
    size_t      valueLen = 0;
    while (sql < sqlEnd) {
      // parse value
      if (unlikely(*sql == SPACE)) {
        break;
      }
      if (unlikely(*sql == EQUAL)) {
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);
        return TSDB_CODE_SML_INVALID_DATA;
      }
      sql++;
    }
    valueLen = sql - value;

    if (unlikely(valueLen == 0)) {
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);
      return TSDB_CODE_TSC_INVALID_VALUE;
    }

    if (unlikely(valueLen > (TSDB_MAX_TAGS_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {
      return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
    }

    SSmlKv kv = {.key = key,
        .keyLen = keyLen,
        .type = TSDB_DATA_TYPE_NCHAR,
        .value = value,
        .length = valueLen,
        .keyEscaped = false,
        .valueEscaped = false};
    if (taosArrayPush(preLineKV, &kv) == NULL){
      return terrno;
    }
    if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {
      return TSDB_CODE_SML_INVALID_DATA;
    }
    cnt++;
  }
  return TSDB_CODE_SUCCESS;
}

static int32_t smlParseTelnetTags(SSmlHandle *info, char *data, char *sqlEnd, SSmlLineInfo *elements) {
  if (is_same_child_table_telnet(elements, &info->preLine) == 0) {
    elements->measureTag = info->preLine.measureTag;
    return TSDB_CODE_SUCCESS;
  }

  int32_t code = 0;
  int32_t lino = 0;
  if(info->dataFormat){
    SML_CHECK_CODE(smlProcessSuperTable(info, elements));
  }
  SML_CHECK_CODE(smlProcessTagTelnet(info, data, sqlEnd));
  SML_CHECK_CODE(smlJoinMeasureTag(elements));

  code = smlProcessChildTable(info, elements);

END:
  if(info->reRun){
    return TSDB_CODE_SUCCESS;
  }
  RETURN
}

// format: <metric> <timestamp> <value> <tagk_1>=<tagv_1>[ <tagk_n>=<tagv_n>]
int32_t smlParseTelnetString(SSmlHandle *info, char *sql, char *sqlEnd, SSmlLineInfo *elements) {
  if (!sql) return TSDB_CODE_SML_INVALID_DATA;

  // parse metric
  smlParseTelnetElement(&sql, sqlEnd, &elements->measure, &elements->measureLen);
  if (unlikely((!(elements->measure) || IS_INVALID_TABLE_LEN(elements->measureLen)))) {
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid measure", sql);
    return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;
  }

  // parse timestamp
  smlParseTelnetElement(&sql, sqlEnd, &elements->timestamp, &elements->timestampLen);
  if (unlikely(!elements->timestamp || elements->timestampLen == 0)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid timestamp", sql);
    return TSDB_CODE_SML_INVALID_DATA;
  }

  bool needConverTime = false;  // get TS before parse tag(get meta), so need convert time
  if (info->dataFormat && info->currSTableMeta == NULL) {
    needConverTime = true;
  }
  int64_t ts = smlParseOpenTsdbTime(info, elements->timestamp, elements->timestampLen);
  if (unlikely(ts < 0)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet parse timestamp failed", sql);
    return TSDB_CODE_INVALID_TIMESTAMP;
  }

  // parse value
  smlParseTelnetElement(&sql, sqlEnd, &elements->cols, &elements->colsLen);
  if (unlikely(!elements->cols || elements->colsLen == 0)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid value", sql);
    return TSDB_CODE_TSC_INVALID_VALUE;
  }

  SSmlKv kv = {.key = VALUE, .keyLen = VALUE_LEN, .value = elements->cols, .length = (size_t)elements->colsLen};
  int ret = smlParseValue(&kv, &info->msgBuf);
  if (ret != TSDB_CODE_SUCCESS) {
    uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);
    return TSDB_CODE_TSC_INVALID_VALUE;
  }

  JUMP_SPACE(sql, sqlEnd)

  elements->tags = sql;
  elements->tagsLen = sqlEnd - sql;
  if (unlikely(!elements->tags || elements->tagsLen == 0)) {
    smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid tag value", sql);
    return TSDB_CODE_TSC_INVALID_VALUE;
  }

  ret = smlParseTelnetTags(info, sql, sqlEnd, elements);
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
    return ret;
  }

  if (unlikely(info->reRun)) {
    return TSDB_CODE_SUCCESS;
  }

  SSmlKv kvTs = {0};
  smlBuildTsKv(&kvTs, ts);
  if (needConverTime && info->currSTableMeta != NULL) {
    kvTs.i = convertTimePrecision(kvTs.i, TSDB_TIME_PRECISION_NANO, info->currSTableMeta->tableInfo.precision);
  }

  if (info->dataFormat){
    ret = smlParseEndTelnetJsonFormat(info, elements, &kvTs, &kv);
  } else {
    ret = smlParseEndTelnetJsonUnFormat(info, elements, &kvTs, &kv);
  }
  info->preLine = *elements;

  return ret;
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15
16	#include <ctype.h>
17	#include <stdio.h>
18	#include <stdlib.h>
19	#include <string.h>
20
21	#include "clientSml.h"
22
23	int32_t is_same_child_table_telnet(const void a, const void b) {	1,626✔
24	SSmlLineInfo t1 = (SSmlLineInfo )a;	1,626✔
25	SSmlLineInfo t2 = (SSmlLineInfo )b;	1,626✔
26	if (t1 == NULL \|\| t2 == NULL \|\| t1->measure == NULL \|\| t2->measure == NULL \|\| t1->tags == NULL \|\| t2->tags == NULL)	1,626!
27	return 1;	305✔
28	return (((t1->measureLen == t2->measureLen) && memcmp(t1->measure, t2->measure, t1->measureLen) == 0) &&	1,318!
29	((t1->tagsLen == t2->tagsLen) && memcmp(t1->tags, t2->tags, t1->tagsLen) == 0))	1,303✔
30	? 0
31	: 1;	3,942✔
32	}
33
34	int64_t smlParseOpenTsdbTime(SSmlHandle info, const char data, int32_t len) {	57✔
35	uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;	57!
36
37	if (unlikely(!data)) {	57!
38	smlBuildInvalidDataMsg(&info->msgBuf, "timestamp can not be null", NULL);	×
39	return -1;	×
40	}
41	if (unlikely(len == 1 && data[0] == '0')) {	57!
UNCOV 42	return taosGetTimestampNs() / smlFactorNS[toPrecision];	×
43	}
44	int8_t fromPrecision = smlGetTsTypeByLen(len);	57✔
45	if (unlikely(fromPrecision == -1)) {	57!
UNCOV 46	smlBuildInvalidDataMsg(&info->msgBuf,	×
47	"timestamp precision can only be seconds(10 digits) or milli seconds(13 digits)", data);
UNCOV 48	return -1;	×
49	}
50	int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);	57✔
51	if (unlikely(ts == -1)) {	57!
52	smlBuildInvalidDataMsg(&info->msgBuf, "invalid timestamp", data);	×
53	return -1;	×
54	}
55	return ts;	57✔
56	}
57
58	static void smlParseTelnetElement(char *sql, char sqlEnd, char *data, int32_t len) {	171✔
59	while (*sql < sqlEnd) {	1,921!
60	if (unlikely((*sql != SPACE && !(data)))) {	1,921✔
61	data = sql;	171✔
62	} else if (unlikely(*sql == SPACE && data)) {	1,750✔
63	len = sql - *data;	171✔
64	break;	171✔
65	}
66	(*sql)++;	1,750✔
67	}
68	}	171✔
69
70	static int32_t smlProcessTagTelnet(SSmlHandle info, char data, char *sqlEnd){	36✔
71	SArray *preLineKV = info->preLineTagKV;	36✔
72	taosArrayClearEx(preLineKV, freeSSmlKv);	36✔
73	int cnt = 0;	36✔
74
75	const char *sql = data;	36✔
76	while (sql < sqlEnd) {	178✔
77	JUMP_SPACE(sql, sqlEnd)	287✔
78	if (unlikely(*sql == '\0')) break;	151✔
79
80	const char *key = sql;	145✔
81	size_t keyLen = 0;	145✔
82
83	// parse key
84	while (sql < sqlEnd) {	644!
85	if (unlikely(*sql == SPACE)) {	644!
UNCOV 86	smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);	×
87	return TSDB_CODE_SML_INVALID_DATA;	3✔
88	}
89	if (unlikely(*sql == EQUAL)) {	644✔
90	keyLen = sql - key;	145✔
91	sql++;	145✔
92	break;	145✔
93	}
94	sql++;	499✔
95	}
96
97	if (unlikely(IS_INVALID_COL_LEN(keyLen))) {	145!
UNCOV 98	smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);	×
UNCOV 99	return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;	×
100	}
101
102	// parse value
103	const char *value = sql;	145✔
104	size_t valueLen = 0;	145✔
105	while (sql < sqlEnd) {	1,669✔
106	// parse value
107	if (unlikely(*sql == SPACE)) {	1,642✔
108	break;	118✔
109	}
110	if (unlikely(*sql == EQUAL)) {	1,524!
111	smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", sql);	×
112	return TSDB_CODE_SML_INVALID_DATA;	×
113	}
114	sql++;	1,524✔
115	}
116	valueLen = sql - value;	145✔
117
118	if (unlikely(valueLen == 0)) {	145!
119	smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);	×
120	return TSDB_CODE_TSC_INVALID_VALUE;	×
121	}
122
123	if (unlikely(valueLen > (TSDB_MAX_TAGS_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {	145!
124	return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;	×
125	}
126
127	SSmlKv kv = {.key = key,	145✔
128	.keyLen = keyLen,
129	.type = TSDB_DATA_TYPE_NCHAR,
130	.value = value,
131	.length = valueLen,
132	.keyEscaped = false,
133	.valueEscaped = false};
134	if (taosArrayPush(preLineKV, &kv) == NULL){	145!
135	return terrno;	×
136	}
137	if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {	145✔
138	return TSDB_CODE_SML_INVALID_DATA;	3✔
139	}
140	cnt++;	142✔
141	}
142	return TSDB_CODE_SUCCESS;	33✔
143	}
144
145	static int32_t smlParseTelnetTags(SSmlHandle info, char data, char sqlEnd, SSmlLineInfo elements) {	57✔
146	if (is_same_child_table_telnet(elements, &info->preLine) == 0) {	57!
UNCOV 147	elements->measureTag = info->preLine.measureTag;	×
UNCOV 148	return TSDB_CODE_SUCCESS;	×
149	}
150
151	int32_t code = 0;	57✔
152	int32_t lino = 0;	57✔
153	if(info->dataFormat){	57✔
154	SML_CHECK_CODE(smlProcessSuperTable(info, elements));	27✔
155	}
156	SML_CHECK_CODE(smlProcessTagTelnet(info, data, sqlEnd));	36✔
157	SML_CHECK_CODE(smlJoinMeasureTag(elements));	33!
158
159	code = smlProcessChildTable(info, elements);	33✔
160
161	END:	57✔
162	if(info->reRun){	57✔
163	return TSDB_CODE_SUCCESS;	21✔
164	}
165	RETURN	36!
166	}
167
168	// format: <metric> <timestamp> <value> <tagk_1>=<tagv_1>[ <tagk_n>=<tagv_n>]
169	int32_t smlParseTelnetString(SSmlHandle info, char sql, char sqlEnd, SSmlLineInfo elements) {	57✔
170	if (!sql) return TSDB_CODE_SML_INVALID_DATA;	57!
171
172	// parse metric
173	smlParseTelnetElement(&sql, sqlEnd, &elements->measure, &elements->measureLen);	57✔
174	if (unlikely((!(elements->measure) \|\| IS_INVALID_TABLE_LEN(elements->measureLen)))) {	57!
UNCOV 175	smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid measure", sql);	×
UNCOV 176	return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;	×
177	}
178
179	// parse timestamp
180	smlParseTelnetElement(&sql, sqlEnd, &elements->timestamp, &elements->timestampLen);	57✔
181	if (unlikely(!elements->timestamp \|\| elements->timestampLen == 0)) {	57!
182	smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid timestamp", sql);	×
183	return TSDB_CODE_SML_INVALID_DATA;	×
184	}
185
186	bool needConverTime = false; // get TS before parse tag(get meta), so need convert time	57✔
187	if (info->dataFormat && info->currSTableMeta == NULL) {	57!
188	needConverTime = true;	27✔
189	}
190	int64_t ts = smlParseOpenTsdbTime(info, elements->timestamp, elements->timestampLen);	57✔
191	if (unlikely(ts < 0)) {	57!
UNCOV 192	smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet parse timestamp failed", sql);	×
UNCOV 193	return TSDB_CODE_INVALID_TIMESTAMP;	×
194	}
195
196	// parse value
197	smlParseTelnetElement(&sql, sqlEnd, &elements->cols, &elements->colsLen);	57✔
198	if (unlikely(!elements->cols \|\| elements->colsLen == 0)) {	57!
UNCOV 199	smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid value", sql);	×
UNCOV 200	return TSDB_CODE_TSC_INVALID_VALUE;	×
201	}
202
203	SSmlKv kv = {.key = VALUE, .keyLen = VALUE_LEN, .value = elements->cols, .length = (size_t)elements->colsLen};	57✔
204	int ret = smlParseValue(&kv, &info->msgBuf);	57✔
205	if (ret != TSDB_CODE_SUCCESS) {	57!
UNCOV 206	uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);	×
UNCOV 207	return TSDB_CODE_TSC_INVALID_VALUE;	×
208	}
209
210	JUMP_SPACE(sql, sqlEnd)	114!
211
212	elements->tags = sql;	57✔
213	elements->tagsLen = sqlEnd - sql;	57✔
214	if (unlikely(!elements->tags \|\| elements->tagsLen == 0)) {	57!
215	smlBuildInvalidDataMsg(&info->msgBuf, "SML telnet invalid tag value", sql);	×
216	return TSDB_CODE_TSC_INVALID_VALUE;	×
217	}
218
219	ret = smlParseTelnetTags(info, sql, sqlEnd, elements);	57✔
220	if (unlikely(ret != TSDB_CODE_SUCCESS)) {	57✔
221	return ret;	3✔
222	}
223
224	if (unlikely(info->reRun)) {	54✔
225	return TSDB_CODE_SUCCESS;	21✔
226	}
227
228	SSmlKv kvTs = {0};	33✔
229	smlBuildTsKv(&kvTs, ts);	33✔
230	if (needConverTime && info->currSTableMeta != NULL) {	33!
231	kvTs.i = convertTimePrecision(kvTs.i, TSDB_TIME_PRECISION_NANO, info->currSTableMeta->tableInfo.precision);	3✔
232	}
233
234	if (info->dataFormat){	33✔
235	ret = smlParseEndTelnetJsonFormat(info, elements, &kvTs, &kv);	3✔
236	} else {
237	ret = smlParseEndTelnetJsonUnFormat(info, elements, &kvTs, &kv);	30✔
238	}
239	info->preLine = *elements;	33✔
240
241	return ret;	33✔
242	}

taosdata / TDengine / #3533

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous