• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3533

20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%
#3533

push

travis-ci

web-flow
Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

80.56
/source/client/src/clientSmlLine.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include <ctype.h>
17
#include <stdio.h>
18
#include <stdlib.h>
19
#include <string.h>
20

21
#include "clientSml.h"
22

23
#define IS_COMMA(sql,escapeChar) (*(sql) == COMMA && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
24
#define IS_SPACE(sql,escapeChar) (*(sql) == SPACE && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
25
#define IS_EQUAL(sql,escapeChar) (*(sql) == EQUAL && (*((sql)-1) != SLASH || ((sql)-1 == escapeChar)))
26

27
#define IS_SLASH_LETTER_IN_FIELD_VALUE(sql) (*((sql)-1) == SLASH && (*(sql) == QUOTE || *(sql) == SLASH))
28

29
#define IS_SLASH_LETTER_IN_TAG_FIELD_KEY(sql) \
30
  (*((sql)-1) == SLASH && (*(sql) == COMMA || *(sql) == SPACE || *(sql) == EQUAL || *(sql) == SLASH))
31

32
#define PROCESS_SLASH_IN_FIELD_VALUE(key, keyLen)  \
33
  for (int i = 1; i < keyLen; ++i) {               \
34
    if (IS_SLASH_LETTER_IN_FIELD_VALUE(key + i)) { \
35
      MOVE_FORWARD_ONE(key + i, keyLen - i);       \
36
      keyLen--;                                    \
37
    }                                              \
38
  }
39

40
#define PROCESS_SLASH_IN_TAG_FIELD_KEY(key, keyLen)  \
41
  for (int i = 1; i < keyLen; ++i) {                 \
42
    if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(key + i)) { \
43
      MOVE_FORWARD_ONE(key + i, keyLen - i);         \
44
      keyLen--;                                      \
45
    }                                                \
46
  }
47

48
#define BINARY_ADD_LEN (sizeof("\"\"")-1)    // "binary"   2 means length of ("")
49
#define NCHAR_ADD_LEN  (sizeof("L\"\"")-1)   // L"nchar"   3 means length of (L"")
50

51
uint8_t smlPrecisionConvert[] = {TSDB_TIME_PRECISION_NANO,    TSDB_TIME_PRECISION_HOURS, TSDB_TIME_PRECISION_MINUTES,
52
                                  TSDB_TIME_PRECISION_SECONDS, TSDB_TIME_PRECISION_MILLI, TSDB_TIME_PRECISION_MICRO,
53
                                  TSDB_TIME_PRECISION_NANO};
54

55
static int64_t smlParseInfluxTime(SSmlHandle *info, const char *data, int32_t len) {
1,076✔
56
  uint8_t toPrecision = info->currSTableMeta ? info->currSTableMeta->tableInfo.precision : TSDB_TIME_PRECISION_NANO;
1,076✔
57

58
  if (unlikely(len == 0 || (len == 1 && data[0] == '0'))) {
1,076!
59
    return taosGetTimestampNs() / smlFactorNS[toPrecision];
27✔
60
  }
61

62
  uint8_t fromPrecision = smlPrecisionConvert[info->precision];
1,049✔
63

64
  int64_t ts = smlGetTimeValue(data, len, fromPrecision, toPrecision);
1,049✔
65
  if (unlikely(ts == -1)) {
1,049!
UNCOV
66
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid timestamp", data);
×
UNCOV
67
    return TSDB_CODE_SML_INVALID_DATA;
×
68
  }
69
  return ts;
1,049✔
70
}
71

72
int32_t smlParseValue(SSmlKv *pVal, SSmlMsgBuf *msg) {
11,071✔
73
  if (pVal->value[0] == '"') {  // binary
11,071✔
74
    if (pVal->length >= 2 && pVal->value[pVal->length - 1] == '"') {
895!
75
      pVal->type = TSDB_DATA_TYPE_BINARY;
895✔
76
      pVal->length -= BINARY_ADD_LEN;
895✔
77
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
895!
UNCOV
78
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
79
      }
80
      pVal->value += (BINARY_ADD_LEN - 1);
895✔
81
      return TSDB_CODE_SUCCESS;
895✔
82
    }
83
    return TSDB_CODE_TSC_INVALID_VALUE;
×
84
  }
85

86
  if (pVal->value[0] == 'l' || pVal->value[0] == 'L') {  // nchar
10,176!
87
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
831!
88
      pVal->type = TSDB_DATA_TYPE_NCHAR;
847✔
89
      pVal->length -= NCHAR_ADD_LEN;
847✔
90
      if (pVal->length > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE) {
847!
UNCOV
91
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
92
      }
93
      pVal->value += (NCHAR_ADD_LEN - 1);
847✔
94
      return TSDB_CODE_SUCCESS;
847✔
95
    }
96
    return TSDB_CODE_TSC_INVALID_VALUE;
×
97
  }
98

99
  if (pVal->value[0] == 'g' || pVal->value[0] == 'G') {  // geometry
9,345✔
100
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
12!
101
      int32_t code = initCtxGeomFromText();
15✔
102
      if (code != TSDB_CODE_SUCCESS) {
15!
103
        return code;
×
104
      }
105
      char* tmp = taosMemoryCalloc(pVal->length, 1);
15✔
106
      if (tmp == NULL){
15!
107
        return terrno;
×
108
      }
109
      (void)memcpy(tmp, pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN);
15✔
110
      code = doGeomFromText(tmp, (unsigned char **)&pVal->value, &pVal->length);
15✔
111
      taosMemoryFree(tmp);
15✔
112
      if (code != TSDB_CODE_SUCCESS) {
15✔
113
        return code;
3✔
114
      }
115

116
      pVal->type = TSDB_DATA_TYPE_GEOMETRY;
12✔
117
      if (pVal->length > TSDB_MAX_BINARY_LEN - VARSTR_HEADER_SIZE) {
12!
118
        geosFreeBuffer((void*)(pVal->value));
×
119
        return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
120
      }
121
      return TSDB_CODE_SUCCESS;
12✔
122
    }
123
    return TSDB_CODE_TSC_INVALID_VALUE;
×
124
  }
125

126
  if (pVal->value[0] == 'b' || pVal->value[0] == 'B') {  // varbinary
9,333✔
127
    if (pVal->length >= NCHAR_ADD_LEN && pVal->value[1] == '"' && pVal->value[pVal->length - 1] == '"') {
30!
128
      pVal->type = TSDB_DATA_TYPE_VARBINARY;
33✔
129
      if(isHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
33✔
130
        if(!isValidateHex(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN)){
3!
131
          return TSDB_CODE_PAR_INVALID_VARBINARY;
×
132
        }
133

134
        void* data = NULL;
3✔
135
        uint32_t size = 0;
3✔
136
        if(taosHex2Ascii(pVal->value + NCHAR_ADD_LEN - 1, pVal->length - NCHAR_ADD_LEN, &data, &size) < 0){
3!
137
          return TSDB_CODE_OUT_OF_MEMORY;
×
138
        }
139

140
        if (size + VARSTR_HEADER_SIZE > TSDB_MAX_VARBINARY_LEN) {
3!
141
          taosMemoryFree(data);
×
142
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
143
        }
144
        pVal->value  = data;
3✔
145
        pVal->length = size;
3✔
146
      }else{
147
        pVal->length -= NCHAR_ADD_LEN;
30✔
148
        if (pVal->length > TSDB_MAX_VARBINARY_LEN - VARSTR_HEADER_SIZE) {
30!
149
          return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
150
        }
151
        void *data = taosMemoryMalloc(pVal->length);
30✔
152
        if(data == NULL){
30!
153
          return terrno;
×
154
        }
155
        (void)memcpy(data, pVal->value + (NCHAR_ADD_LEN - 1), pVal->length);
30✔
156
        pVal->value = data;
30✔
157
      }
158

159
      return TSDB_CODE_SUCCESS;
33✔
160
    }
161
    return TSDB_CODE_TSC_INVALID_VALUE;
×
162
  }
163

164
  if (pVal->value[0] == 't' || pVal->value[0] == 'T') {
9,303✔
165
    if (pVal->length == 1 ||
460✔
166
        (pVal->length == 4 && (pVal->value[1] == 'r' || pVal->value[1] == 'R') &&
373!
167
         (pVal->value[2] == 'u' || pVal->value[2] == 'U') && (pVal->value[3] == 'e' || pVal->value[3] == 'E'))) {
373!
168
      pVal->i = TSDB_TRUE;
462✔
169
      pVal->type = TSDB_DATA_TYPE_BOOL;
462✔
170
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
462✔
171
      return TSDB_CODE_SUCCESS;
462✔
172
    }
173
    return TSDB_CODE_TSC_INVALID_VALUE;
×
174
  }
175

176
  if (pVal->value[0] == 'f' || pVal->value[0] == 'F') {
8,843✔
177
    if (pVal->length == 1 ||
757✔
178
        (pVal->length == 5 && (pVal->value[1] == 'a' || pVal->value[1] == 'A') &&
654!
179
         (pVal->value[2] == 'l' || pVal->value[2] == 'L') && (pVal->value[3] == 's' || pVal->value[3] == 'S') &&
654!
180
         (pVal->value[4] == 'e' || pVal->value[4] == 'E'))) {
654!
181
      pVal->i = TSDB_FALSE;
765✔
182
      pVal->type = TSDB_DATA_TYPE_BOOL;
765✔
183
      pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
765✔
184
      return TSDB_CODE_SUCCESS;
765✔
185
    }
186
    return TSDB_CODE_TSC_INVALID_VALUE;
×
187
  }
188

189
  // number
190
  if (smlParseNumber(pVal, msg)) {
8,086!
191
    pVal->length = (int16_t)tDataTypes[pVal->type].bytes;
8,102✔
192
    return TSDB_CODE_SUCCESS;
8,102✔
193
  }
194

UNCOV
195
  return TSDB_CODE_TSC_INVALID_VALUE;
×
196
}
197

198
static int32_t smlProcessTagLine(SSmlHandle *info, char **sql, char *sqlEnd){
631✔
199
  SArray *preLineKV = info->preLineTagKV;
631✔
200
  taosArrayClearEx(preLineKV, freeSSmlKv);
631✔
201
  int     cnt = 0;
632✔
202

203
  while (*sql < sqlEnd) {
4,197!
204
    if (unlikely(IS_SPACE(*sql,NULL))) {
4,197!
205
      break;
603✔
206
    }
207

208
    // parse key
209
    const char *key = *sql;
4,191✔
210
    size_t      keyLen = 0;
4,191✔
211
    bool        keyEscaped = false;
4,191✔
212
    size_t      keyLenEscaped = 0;
4,191✔
213
    const char *escapeChar = NULL;
4,191✔
214

215
    while (*sql < sqlEnd) {
14,169!
216
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
14,170!
217
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
3✔
218
        return TSDB_CODE_SML_INVALID_DATA;
29✔
219
      }
220
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
14,167✔
221
        keyLen = *sql - key;
4,189✔
222
        (*sql)++;
4,189✔
223
        break;
4,189✔
224
      }
225
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
9,978!
226
        escapeChar = *sql;
15✔
227
        keyLenEscaped++;
15✔
228
        keyEscaped = true;
15✔
229
      }
230
      (*sql)++;
9,978✔
231
    }
232

233
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
4,188!
234
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid key or key is too long than 64", key);
×
235
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
236
    }
237

238
    // parse value
239
    const char *value = *sql;
4,188✔
240
    size_t      valueLen = 0;
4,188✔
241
    bool        valueEscaped = false;
4,188✔
242
    size_t      valueLenEscaped = 0;
4,188✔
243
    while (*sql < sqlEnd) {
48,005!
244
      // parse value
245
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
48,006!
246
        break;
4,186✔
247
      } else if (unlikely(IS_EQUAL(*sql,escapeChar))) {
43,820!
248
        smlBuildInvalidDataMsg(&info->msgBuf, "invalid data", *sql);
3✔
249
        return TSDB_CODE_SML_INVALID_DATA;
3✔
250
      }
251

252
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
43,817!
253
        escapeChar = *sql;
21✔
254
        valueLenEscaped++;
21✔
255
        valueEscaped = true;
21✔
256
      }
257

258
      (*sql)++;
43,817✔
259
    }
260
    valueLen = *sql - value;
4,185✔
261

262
    if (unlikely(valueLen == 0)) {
4,185!
263
      smlBuildInvalidDataMsg(&info->msgBuf, "invalid value", value);
×
264
      return TSDB_CODE_SML_INVALID_DATA;
×
265
    }
266

267
    if (unlikely(valueLen - valueLenEscaped > (TSDB_MAX_NCHAR_LEN - VARSTR_HEADER_SIZE) / TSDB_NCHAR_SIZE)) {
4,185!
268
      return TSDB_CODE_PAR_INVALID_VAR_COLUMN_LEN;
×
269
    }
270

271
    if (keyEscaped) {
4,185✔
272
      char *tmp = (char *)taosMemoryMalloc(keyLen);
6✔
273
      if (tmp == NULL){
6!
274
        return terrno;
×
275
      }
276
      (void)memcpy(tmp, key, keyLen);
6✔
277
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, keyLen);
42!
278
      key = tmp;
6✔
279
    }
280
    if (valueEscaped) {
4,185✔
281
      char *tmp = (char *)taosMemoryMalloc(valueLen);
12✔
282
      if (tmp == NULL){
12!
283
        return terrno;
×
284
      }
285
      (void)memcpy(tmp, value, valueLen);
12✔
286
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, valueLen);
57!
287
      value = tmp;
12✔
288
    }
289
    SSmlKv kv = {.key = key,
4,185✔
290
        .keyLen = keyLen,
291
        .type = TSDB_DATA_TYPE_NCHAR,
292
        .value = value,
293
        .length = valueLen,
294
        .keyEscaped = keyEscaped,
295
        .valueEscaped = valueEscaped};
296
    if(taosArrayPush(preLineKV, &kv) == NULL){
4,185!
297
      return terrno;
×
298
    }
299

300
    if (info->dataFormat && !isSmlTagAligned(info, cnt, &kv)) {
4,185✔
301
      return TSDB_CODE_SML_INVALID_DATA;
23✔
302
    }
303

304
    cnt++;
4,162✔
305
    if (IS_SPACE(*sql,escapeChar)) {
4,162!
306
      break;
307
    }
308
    (*sql)++;
3,565✔
309
  }
310
  return TSDB_CODE_SUCCESS;
603✔
311
}
312

313
static int32_t smlParseTagLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *elements) {
1,244✔
314
  int32_t code = 0;
1,244✔
315
  int32_t lino = 0;
1,244✔
316
  bool isSameCTable = IS_SAME_CHILD_TABLE;
1,244✔
317
  if(isSameCTable){
1,244✔
318
    return TSDB_CODE_SUCCESS;
494✔
319
  }
320

321
  if(info->dataFormat){
750✔
322
    SML_CHECK_CODE(smlProcessSuperTable(info, elements));
219✔
323
  }
324
  SML_CHECK_CODE(smlProcessTagLine(info, sql, sqlEnd));
629✔
325
  return smlProcessChildTable(info, elements);
603✔
326

327
END:
150✔
328
  if(info->reRun){
150✔
329
    return TSDB_CODE_SUCCESS;
138✔
330
  }
331
  RETURN
12!
332
}
333

334
static int32_t smlParseColLine(SSmlHandle *info, char **sql, char *sqlEnd, SSmlLineInfo *currElement) {
1,097✔
335
  int cnt = 0;
1,097✔
336
  while (*sql < sqlEnd) {
11,081✔
337
    if (unlikely(IS_SPACE(*sql,NULL))) {
11,050!
338
      break;
1,041✔
339
    }
340

341
    // parse key
342
    const char *key = *sql;
11,050✔
343
    size_t      keyLen = 0;
11,050✔
344
    bool        keyEscaped = false;
11,050✔
345
    size_t      keyLenEscaped = 0;
11,050✔
346
    const char *escapeChar = NULL;
11,050✔
347
    while (*sql < sqlEnd) {
37,818!
348
      if (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar))) {
37,822!
349
        smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid data", *sql);
3✔
350
        return TSDB_CODE_SML_INVALID_DATA;
21✔
351
      }
352
      if (unlikely(IS_EQUAL(*sql,escapeChar))) {
37,819✔
353
        keyLen = *sql - key;
11,051✔
354
        (*sql)++;
11,051✔
355
        break;
11,051✔
356
      }
357
      if (IS_SLASH_LETTER_IN_TAG_FIELD_KEY(*sql)) {
26,768✔
358
        escapeChar = *sql;
27✔
359
        keyLenEscaped++;
27✔
360
        keyEscaped = true;
27✔
361
      }
362
      (*sql)++;
26,768✔
363
    }
364

365
    if (unlikely(IS_INVALID_COL_LEN(keyLen - keyLenEscaped))) {
11,047!
366
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid key or key is too long than 64", key);
×
367
      return TSDB_CODE_TSC_INVALID_COLUMN_LENGTH;
×
368
    }
369

370
    // parse value
371
    const char *value = *sql;
11,047✔
372
    size_t      valueLen = 0;
11,047✔
373
    bool        valueEscaped = false;
11,047✔
374
    size_t      valueLenEscaped = 0;
11,047✔
375
    int         quoteNum = 0;
11,047✔
376
    while (*sql < sqlEnd) {
367,936✔
377
      // parse value
378
      if (unlikely(*(*sql) == QUOTE && (*(*sql - 1) != SLASH || (*sql - 1) == escapeChar))) {
367,864✔
379
        quoteNum++;
3,569✔
380
        (*sql)++;
3,569✔
381
        if(quoteNum > 2){
3,569!
382
          break;
×
383
        }
384
        continue;
3,569✔
385
      }
386
      if (quoteNum % 2 == 0 && (unlikely(IS_SPACE(*sql,escapeChar) || IS_COMMA(*sql,escapeChar)))) {
364,295!
387
        break;
10,975✔
388
      }
389
      if (IS_SLASH_LETTER_IN_FIELD_VALUE(*sql) && (*sql - 1) != escapeChar) {
353,320✔
390
        escapeChar = *sql;
258✔
391
        valueEscaped = true;
258✔
392
        valueLenEscaped++;
258✔
393
      }
394

395
      (*sql)++;
353,320✔
396
    }
397
    valueLen = *sql - value;
11,047✔
398

399
    if (unlikely(quoteNum != 0 && quoteNum != 2)) {
11,047!
400
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line unbalanced quotes", value);
×
401
      return TSDB_CODE_SML_INVALID_DATA;
×
402
    }
403
    if (unlikely(valueLen == 0)) {
11,047!
404
      smlBuildInvalidDataMsg(&info->msgBuf, "SML line invalid value", value);
×
405
      return TSDB_CODE_SML_INVALID_DATA;
×
406
    }
407

408
    SSmlKv  kv = {.key = key, .keyLen = keyLen, .value = value, .length = valueLen};
11,047✔
409
    int32_t ret = smlParseValue(&kv, &info->msgBuf);
11,047✔
410
    if (ret != TSDB_CODE_SUCCESS) {
11,048✔
411
      uError("SML:0x%" PRIx64 " %s parse value error:%d.", info->id, __FUNCTION__, ret);
2!
412
      return ret;
3✔
413
    }
414

415
    if (keyEscaped) {
11,046✔
416
      char *tmp = (char *)taosMemoryMalloc(kv.keyLen);
9✔
417
      if (tmp == NULL){
9!
418
        return terrno;
×
419
      }
420
      (void)memcpy(tmp, key, kv.keyLen);
9✔
421
      PROCESS_SLASH_IN_TAG_FIELD_KEY(tmp, kv.keyLen);
111!
422
      kv.key = tmp;
9✔
423
      kv.keyEscaped = keyEscaped;
9✔
424
    }
425

426
    if (valueEscaped) {
11,046✔
427
      char *tmp = (char *)taosMemoryMalloc(kv.length);
9✔
428
      if (tmp == NULL){
9!
429
        return terrno;
×
430
      }
431
      (void)memcpy(tmp, kv.value, kv.length);
9✔
432
      PROCESS_SLASH_IN_FIELD_VALUE(tmp, kv.length);
2,409✔
433
      if(kv.type == TSDB_DATA_TYPE_VARBINARY){
9!
434
        taosMemoryFree((void*)kv.value);
×
435
      }
436
      kv.value = tmp;
9✔
437
      kv.valueEscaped = valueEscaped;
9✔
438
    }
439

440
    if (info->dataFormat) {
11,046✔
441
      bool isAligned = isSmlColAligned(info, cnt, &kv);
4,762✔
442
      if (kv.type == TSDB_DATA_TYPE_BINARY && valueEscaped) {
4,758✔
443
        if (taosArrayPush(info->escapedStringList, &kv.value) == NULL){
6!
444
          freeSSmlKv(&kv);
×
445
          return terrno;
×
446
        }
447
        kv.value = NULL;
3✔
448
      }
449
      freeSSmlKv(&kv);
4,758✔
450
      if(!isAligned){
4,758✔
451
        return TSDB_CODE_SUCCESS;
15✔
452
      }
453
    } else {
454
      if (currElement->colArray == NULL) {
6,284✔
455
        currElement->colArray = taosArrayInit_s(sizeof(SSmlKv), 1);
707✔
456
        if (currElement->colArray == NULL) {
707!
457
          freeSSmlKv(&kv);
×
458
          return terrno;
×
459
        }
460
      }
461
      if (taosArrayPush(currElement->colArray, &kv) == NULL){  // reserve for timestamp
12,566!
462
        freeSSmlKv(&kv);
×
463
        return terrno;
×
464
      }
465
    }
466

467
    cnt++;
11,025✔
468
    if (IS_SPACE(*sql,escapeChar)) {
11,025!
469
      break;
470
    }
471
    (*sql)++;
9,984✔
472
  }
473

474
  return TSDB_CODE_SUCCESS;
1,072✔
475
}
476

477
int32_t smlParseInfluxString(SSmlHandle *info, char *sql, char *sqlEnd, SSmlLineInfo *elements) {
1,244✔
478
  if (!sql) return TSDB_CODE_SML_INVALID_DATA;
1,244!
479
  JUMP_SPACE(sql, sqlEnd)
1,244!
480
  if (unlikely(*sql == COMMA)) return TSDB_CODE_SML_INVALID_DATA;
1,244!
481
  elements->measure = sql;
1,244✔
482
  // parse measure
483
  size_t measureLenEscaped = 0;
1,244✔
484
  const char *escapeChar = NULL;
1,244✔
485
  while (sql < sqlEnd) {
8,448!
486
    if (unlikely(IS_COMMA(sql,escapeChar) || IS_SPACE(sql,escapeChar))) {
8,451!
487
      break;
1,247✔
488
    }
489

490
    if (unlikely((sql != elements->measure) && IS_SLASH_LETTER_IN_MEASUREMENT(sql))) {
7,204✔
491
      elements->measureEscaped = true;
27✔
492
      escapeChar = sql;
27✔
493
      measureLenEscaped++;
27✔
494
      sql++;
27✔
495
      continue;
27✔
496
    }
497
    sql++;
7,177✔
498
  }
499
  elements->measureLen = sql - elements->measure;
1,244✔
500
  if (unlikely(IS_INVALID_TABLE_LEN(elements->measureLen - measureLenEscaped))) {
1,244!
501
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line measure is empty or too large than 192", NULL);
×
502
    return TSDB_CODE_TSC_INVALID_TABLE_ID_LENGTH;
×
503
  }
504

505
  // to get measureTagsLen before
506
  const char *tmp = sql;
1,244✔
507
  while (tmp < sqlEnd) {
154,734!
508
    if (unlikely(IS_SPACE(tmp,escapeChar))) {
154,736✔
509
      break;
1,246✔
510
    }
511
    if(unlikely(IS_SLASH_LETTER_IN_TAG_FIELD_KEY(tmp))){
153,490!
512
      escapeChar = tmp;
84✔
513
    }
514
    tmp++;
153,490✔
515
  }
516
  elements->measureTagsLen = tmp - elements->measure;
1,244✔
517
  elements->measureTag = elements->measure;
1,244✔
518
  // parse tag
519
  if (*sql == COMMA) sql++;
1,244✔
520
  elements->tags = sql;
1,244✔
521

522
  int ret = smlParseTagLine(info, &sql, sqlEnd, elements);
1,244✔
523
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
1,247✔
524
    return ret;
12✔
525
  }
526
  if (unlikely(info->reRun)) {
1,235✔
527
    return TSDB_CODE_SUCCESS;
138✔
528
  }
529

530
  sql = elements->measure + elements->measureTagsLen;
1,097✔
531
  elements->tagsLen = sql - elements->tags;
1,097✔
532

533
  // parse cols
534
  JUMP_SPACE(sql, sqlEnd)
2,194!
535
  elements->cols = sql;
1,097✔
536

537
  ret = smlParseColLine(info, &sql, sqlEnd, elements);
1,097✔
538
  if (unlikely(ret != TSDB_CODE_SUCCESS)) {
1,097✔
539
    return ret;
6✔
540
  }
541

542
  if (unlikely(info->reRun)) {
1,091✔
543
    return TSDB_CODE_SUCCESS;
15✔
544
  }
545

546
  elements->colsLen = sql - elements->cols;
1,076✔
547
  if (unlikely(elements->colsLen == 0)) {
1,076!
548
    smlBuildInvalidDataMsg(&info->msgBuf, "SML line cols is empty", NULL);
×
549
    return TSDB_CODE_SML_INVALID_DATA;
×
550
  }
551

552
  // parse timestamp
553
  JUMP_SPACE(sql, sqlEnd)
2,125✔
554
  elements->timestamp = sql;
1,076✔
555
  while (sql < sqlEnd) {
17,315✔
556
    if (unlikely(isspace(*sql))) {
16,239!
UNCOV
557
      break;
×
558
    }
559
    sql++;
16,239✔
560
  }
561
  elements->timestampLen = sql - elements->timestamp;
1,076✔
562

563
  int64_t ts = smlParseInfluxTime(info, elements->timestamp, elements->timestampLen);
1,076✔
564
  if (unlikely(ts <= 0)) {
1,076!
UNCOV
565
    uError("SML:0x%" PRIx64 " %s error:%" PRId64, info->id, __FUNCTION__, ts);
×
UNCOV
566
    return TSDB_CODE_INVALID_TIMESTAMP;
×
567
  }
568

569
  SSmlKv kvTs = {0};
1,076✔
570
  smlBuildTsKv(&kvTs, ts);
1,076✔
571

572
  return smlParseEndLine(info, elements, &kvTs);
1,076✔
573
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc