#3533

Committed 20 Nov 2024 07:11AM UTC coverage: 58.848% (-1.9%) from 60.78%

Build # #3533

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge pull request #28823 from taosdata/fix/3.0/TD-32587

fix:[TD-32587]fix stmt segmentation fault

Run Details

115578 of 252434 branches covered (45.79%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

8038 existing lines in 233 files now uncovered.

194926 of 275199 relevant lines covered (70.83%)

1494459.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

58.49

/source/client/src/clientMonitorSlow.c

/*
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
 *
 * This program is free software: you can use, redistribute, and/or modify
 * it under the terms of the GNU Affero General Public License, version 3
 * or later ("AGPL"), as published by the Free Software Foundation.
 *
 * This program is distributed in the hope that it will be useful, but WITHOUT
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 * FITNESS FOR A PARTICULAR PURPOSE.
 *
 * You should have received a copy of the GNU Affero General Public License
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
 */
#include "clientInt.h"
#include "clientMonitor.h"
#include "clientLog.h"
#include "tglobal.h"

const char* slowQueryName = "taos_slow_sql:count";
const char* slowQueryHelp = "slow query log when cost over than config duration";
const int   slowQueryLabelCount = 4;
const char* slowQueryLabels[] = {"cluster_id", "username", "result", "duration"};

const int64_t usInSeconds = 1000 * 1000;
const int64_t msInMinutes = 60 * 1000;

static const char* getSlowQueryLableCostDesc(int64_t cost) {
  if (cost >= 1000 * usInSeconds) {
    return "1000s-";
  } else if (cost >= 100 * usInSeconds) {
    return "100-1000s";
  } else if (cost >= 10 * usInSeconds) {
    return "10-100s";
  } else if (cost >= 3 * usInSeconds) {
    return "3-10s";
  }
  return "0-3s";
}

void monitorClientSlowQueryInit(int64_t clusterid) {
  monitorCreateClient(clusterid);
  monitorCreateClientCounter(clusterid, slowQueryName, slowQueryHelp, slowQueryLabelCount, slowQueryLabels);
}

void clientSlowQueryLog(int64_t clusterId, const char* user, SQL_RESULT_CODE result, int32_t cost) {
  char clusterIdStr[32] = {0};
  if (snprintf(clusterIdStr, sizeof(clusterIdStr), "%" PRId64, clusterId) < 0){
    uError("failed to generate clusterId:%" PRId64, clusterId);
  }
  const char* slowQueryLabelValues[] = {clusterIdStr, user, monitorResultStr(result), getSlowQueryLableCostDesc(cost)};
  monitorCounterInc(clusterId, slowQueryName, slowQueryLabelValues);
}

void slowQueryLog(int64_t rid, bool killed, int32_t code, int32_t cost) {
  SQL_RESULT_CODE result = SQL_RESULT_SUCCESS;
  if (TSDB_CODE_SUCCESS != code) {
    result = SQL_RESULT_FAILED;
  }
  // to do Distinguish active Kill events
  // else if (killed) {
  //   result = SQL_RESULT_CANCEL;
  // }

  STscObj* pTscObj = acquireTscObj(rid);
  if (pTscObj != NULL) {
    if(pTscObj->pAppInfo == NULL) {
      tscLog("slowQueryLog, not found pAppInfo");
    } else {
      clientSlowQueryLog(pTscObj->pAppInfo->clusterId, pTscObj->user, result, cost);
    }
    (void)releaseTscObj(rid);
  } else {
    tscLog("slowQueryLog, not found rid");
  }
}

1	/*
2	* Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3	*
4	* This program is free software: you can use, redistribute, and/or modify
5	* it under the terms of the GNU Affero General Public License, version 3
6	* or later ("AGPL"), as published by the Free Software Foundation.
7	*
8	* This program is distributed in the hope that it will be useful, but WITHOUT
9	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10	* FITNESS FOR A PARTICULAR PURPOSE.
11	*
12	* You should have received a copy of the GNU Affero General Public License
13	* along with this program. If not, see <http://www.gnu.org/licenses/>.
14	*/
15	#include "clientInt.h"
16	#include "clientMonitor.h"
17	#include "clientLog.h"
18	#include "tglobal.h"
19
20	const char* slowQueryName = "taos_slow_sql:count";
21	const char* slowQueryHelp = "slow query log when cost over than config duration";
22	const int slowQueryLabelCount = 4;
23	const char* slowQueryLabels[] = {"cluster_id", "username", "result", "duration"};
24
25	const int64_t usInSeconds = 1000 * 1000;
26	const int64_t msInMinutes = 60 * 1000;
27
28	static const char* getSlowQueryLableCostDesc(int64_t cost) {	1✔
29	if (cost >= 1000 * usInSeconds) {	1!
30	return "1000s-";	×
31	} else if (cost >= 100 * usInSeconds) {	1!
32	return "100-1000s";	×
33	} else if (cost >= 10 * usInSeconds) {	1!
34	return "10-100s";	1✔
35	} else if (cost >= 3 * usInSeconds) {	×
36	return "3-10s";	×
37	}
38	return "0-3s";	×
39	}
40
41	void monitorClientSlowQueryInit(int64_t clusterid) {	1,582✔
42	monitorCreateClient(clusterid);	1,582✔
43	monitorCreateClientCounter(clusterid, slowQueryName, slowQueryHelp, slowQueryLabelCount, slowQueryLabels);	1,582✔
44	}	1,582✔
45
46	void clientSlowQueryLog(int64_t clusterId, const char* user, SQL_RESULT_CODE result, int32_t cost) {	1✔
47	char clusterIdStr[32] = {0};	1✔
48	if (snprintf(clusterIdStr, sizeof(clusterIdStr), "%" PRId64, clusterId) < 0){	1!
49	uError("failed to generate clusterId:%" PRId64, clusterId);	×
50	}
51	const char* slowQueryLabelValues[] = {clusterIdStr, user, monitorResultStr(result), getSlowQueryLableCostDesc(cost)};	1✔
52	monitorCounterInc(clusterId, slowQueryName, slowQueryLabelValues);	1✔
53	}	1✔
54
55	void slowQueryLog(int64_t rid, bool killed, int32_t code, int32_t cost) {	1✔
56	SQL_RESULT_CODE result = SQL_RESULT_SUCCESS;	1✔
57	if (TSDB_CODE_SUCCESS != code) {	1!
UNCOV 58	result = SQL_RESULT_FAILED;	×
59	}
60	// to do Distinguish active Kill events
61	// else if (killed) {
62	// result = SQL_RESULT_CANCEL;
63	// }
64
65	STscObj* pTscObj = acquireTscObj(rid);	1✔
66	if (pTscObj != NULL) {	1!
67	if(pTscObj->pAppInfo == NULL) {	1!
68	tscLog("slowQueryLog, not found pAppInfo");	×
69	} else {
70	clientSlowQueryLog(pTscObj->pAppInfo->clusterId, pTscObj->user, result, cost);	1✔
71	}
72	(void)releaseTscObj(rid);	1✔
73	} else {
74	tscLog("slowQueryLog, not found rid");	×
75	}
76	}	1✔

taosdata / TDengine / #3533

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous