74d330cc7e1393f5f95b4f316783c13de9df323b

Committed 20 Nov 2024 10:57AM UTC coverage: 57.113% (-0.003%) from 57.116%

Build # 74d330cc7e1393f5f95b4f316783c13de9df323b

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #21840 from Yoast/338-dashboard-clear-category-in-case-another-post-type-was-selected

Dashboard: clear category in case another post type was selected

Run Details

7593 of 13666 branches covered (55.56%)

Branch coverage included in aggregate %.

0 of 4 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

13348 of 23000 relevant lines covered (58.03%)

99780.42 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/packages/js/src/dashboard/scores/seo/seo-scores.js

import { useEffect, useState } from "@wordpress/element";
import { __ } from "@wordpress/i18n";
import { Paper, Title } from "@yoast/ui-library";
import { useFetch } from "../../hooks/use-fetch";
import { ContentTypeFilter } from "../components/content-type-filter";
import { ScoreContent } from "../components/score-content";
import { TermFilter } from "../components/term-filter";
import { SCORE_DESCRIPTIONS } from "../score-meta";

/**
 * @type {import("../index").ContentType} ContentType
 * @type {import("../index").Taxonomy} Taxonomy
 * @type {import("../index").Term} Term
 */

/**
 * @param {ContentType[]} contentTypes The content types. May not be empty.
 * @returns {JSX.Element} The element.
 */
export const SeoScores = ( { contentTypes } ) => {
        const [ selectedContentType, setSelectedContentType ] = useState( contentTypes[ 0 ] );
        const [ selectedTerm, setSelectedTerm ] = useState();

        const { data: scores, isPending } = useFetch( {
                dependencies: [ selectedContentType.name, selectedTerm?.name ],
                url: "/wp-content/plugins/wordpress-seo/packages/js/src/dashboard/scores/seo/scores.json",
                //                url: `/wp-json/yoast/v1/scores/${ contentType.name }/${ term?.name }`,
                options: { headers: { "Content-Type": "application/json" } },
                fetchDelay: 0,
                doFetch: async( url, options ) => {
                        await new Promise( ( resolve ) => setTimeout( resolve, 1000 ) );
                        return [ "good", "ok", "bad", "notAnalyzed" ].map( ( name ) => ( {
                                name,
                                amount: Math.ceil( Math.random() * 10 ),
                                links: Math.random() > 0.5 ? {} : { view: `edit.php?seo_filter=${ name }` },
                        } ) );
                        // eslint-disable-next-line no-unreachable
                        try {
                                const response = await fetch( url, options );
                                if ( ! response.ok ) {
                                        // From the perspective of the results, we want to reject this as an error.
                                        throw new Error( "Not ok" );
                                }
                                return response.json();
                        } catch ( error ) {
                                return Promise.reject( error );
                        }
                },
        } );

        useEffect( () => {
                // Reset the selected term when the selected content type changes.
                setSelectedTerm( undefined ); // eslint-disable-line no-undefined
        }, [ selectedContentType.name ] );

        return (
                <Paper className="yst-@container yst-grow yst-max-w-screen-sm yst-p-8">
                        <Title as="h2">{ __( "SEO scores", "wordpress-seo" ) }</Title>
                        <div className="yst-grid yst-grid-cols-1 @md:yst-grid-cols-2 yst-gap-6 yst-mt-4">
                                <ContentTypeFilter
                                        idSuffix="seo"
                                        contentTypes={ contentTypes }
                                        selected={ selectedContentType }
                                        onChange={ setSelectedContentType }
                                />
                                { selectedContentType.taxonomy && selectedContentType.taxonomy?.links?.search &&
                                        <TermFilter
                                                idSuffix="seo"
                                                taxonomy={ selectedContentType.taxonomy }
                                                selected={ selectedTerm }
                                                onChange={ setSelectedTerm }
                                        />
                                }
                        </div>
                        <ScoreContent scores={ scores } isLoading={ isPending } descriptions={ SCORE_DESCRIPTIONS.seo } />
                </Paper>
        );
};

1	import { useEffect, useState } from "@wordpress/element";
2	import { __ } from "@wordpress/i18n";
3	import { Paper, Title } from "@yoast/ui-library";
4	import { useFetch } from "../../hooks/use-fetch";
5	import { ContentTypeFilter } from "../components/content-type-filter";
6	import { ScoreContent } from "../components/score-content";
7	import { TermFilter } from "../components/term-filter";
8	import { SCORE_DESCRIPTIONS } from "../score-meta";
9
10	/**
11	* @type {import("../index").ContentType} ContentType
12	* @type {import("../index").Taxonomy} Taxonomy
13	* @type {import("../index").Term} Term
14	*/
15
16	/**
17	* @param {ContentType[]} contentTypes The content types. May not be empty.
18	* @returns {JSX.Element} The element.
19	*/
20	export const SeoScores = ( { contentTypes } ) => {	×
21	const [ selectedContentType, setSelectedContentType ] = useState( contentTypes[ 0 ] );	×
22	const [ selectedTerm, setSelectedTerm ] = useState();	×
23
24	const { data: scores, isPending } = useFetch( {	×
25	dependencies: [ selectedContentType.name, selectedTerm?.name ],
26	url: "/wp-content/plugins/wordpress-seo/packages/js/src/dashboard/scores/seo/scores.json",
27	// url: `/wp-json/yoast/v1/scores/${ contentType.name }/${ term?.name }`,
28	options: { headers: { "Content-Type": "application/json" } },
29	fetchDelay: 0,
30	doFetch: async( url, options ) => {
31	await new Promise( ( resolve ) => setTimeout( resolve, 1000 ) );	×
32	return [ "good", "ok", "bad", "notAnalyzed" ].map( ( name ) => ( {	×
33	name,
34	amount: Math.ceil( Math.random() * 10 ),
35	links: Math.random() > 0.5 ? {} : { view: `edit.php?seo_filter=${ name }` },	×
36	} ) );
37	// eslint-disable-next-line no-unreachable
38	try {	×
39	const response = await fetch( url, options );	×
40	if ( ! response.ok ) {	×
41	// From the perspective of the results, we want to reject this as an error.
42	throw new Error( "Not ok" );	×
43	}
44	return response.json();	×
45	} catch ( error ) {
46	return Promise.reject( error );	×
47	}
48	},
49	} );
50
NEW 51	useEffect( () => {	×
52	// Reset the selected term when the selected content type changes.
NEW 53	setSelectedTerm( undefined ); // eslint-disable-line no-undefined	×
54	}, [ selectedContentType.name ] );
55
UNCOV 56	return (	×
57	<Paper className="yst-@container yst-grow yst-max-w-screen-sm yst-p-8">
58	<Title as="h2">{ __( "SEO scores", "wordpress-seo" ) }</Title>
59	<div className="yst-grid yst-grid-cols-1 @md:yst-grid-cols-2 yst-gap-6 yst-mt-4">
60	<ContentTypeFilter
61	idSuffix="seo"
62	contentTypes={ contentTypes }
63	selected={ selectedContentType }
64	onChange={ setSelectedContentType }
65	/>
66	{ selectedContentType.taxonomy && selectedContentType.taxonomy?.links?.search &&	×
67	<TermFilter
68	idSuffix="seo"
69	taxonomy={ selectedContentType.taxonomy }
70	selected={ selectedTerm }
71	onChange={ setSelectedTerm }
72	/>
73	}
74	</div>
75	<ScoreContent scores={ scores } isLoading={ isPending } descriptions={ SCORE_DESCRIPTIONS.seo } />
76	</Paper>
77	);
78	};

Yoast / wordpress-seo / 74d330cc7e1393f5f95b4f316783c13de9df323b

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous