11897928487

Committed 18 Nov 2024 05:37PM UTC coverage: 31.133% (-0.001%) from 31.134%

Build # 11897928487

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #10027 from ForumMagnum/voting-portal-account-age-limit

Voting portal minimum account age

Run Details

5087 of 43323 branches covered (11.74%)

Branch coverage included in aggregate %.

4 of 6 new or added lines in 3 files covered. (66.67%)

1 existing line in 1 file now uncovered.

29982 of 69319 relevant lines covered (43.25%)

172.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

20.0

/packages/lesswrong/server/givingSeason/resolvers.ts

import { Posts } from "@/lib/collections/posts";
import { Comments } from "@/lib/collections/comments";
import { addGraphQLMutation, addGraphQLQuery, addGraphQLResolvers } from "@/lib/vulcan-lib";
import {
  defineFeedResolver,
  mergeFeedQueries,
  viewBasedSubquery,
} from "../utils/feedUtil";
import ElectionVotes from "@/lib/collections/electionVotes/collection";
import { ACTIVE_DONATION_ELECTION, DONATION_ELECTION_AGE_CUTOFF } from "@/lib/givingSeason";
import { instantRunoffAllPossibleResults, IRVote } from "@/lib/givingSeason/instantRunoff";

addGraphQLResolvers({
  Query: {
    GivingSeason2024DonationTotal: (
      _root: void,
      _args: {},
      context: ResolverContext,
    ) => context.repos.databaseMetadata.getGivingSeason2024DonationTotal(),
    GivingSeason2024VoteCounts: async (
      _root: void,
      _args: {},
      _context: ResolverContext,
    ) => {
      const dbVotes = await ElectionVotes.find({ electionName: ACTIVE_DONATION_ELECTION }).fetch();
      const votes: IRVote[] = dbVotes.map((vote) => vote.vote);

      return instantRunoffAllPossibleResults(votes as IRVote[]);
    },
    GivingSeason2024MyVote: async (
      _root: void,
      _args: {},
      {currentUser}: ResolverContext,
    ) => {
      if (!currentUser) {
        return {};
      }
      const vote = await ElectionVotes.findOne({
        electionName: ACTIVE_DONATION_ELECTION,
        userId: currentUser?._id,
      });
      return vote?.vote ?? {};
    },
  },
  Mutation: {
    GivingSeason2024Vote: async (
      _root: void,
      {vote}: {vote: Record<string, number>},
      {currentUser, repos}: ResolverContext,
    ) => {
      if (
        !currentUser ||
        currentUser.banned ||
        currentUser.createdAt > DONATION_ELECTION_AGE_CUTOFF
      ) {
        throw new Error("Unauthorized");
      }
      if (!vote || typeof vote !== "object") {
        throw new Error("Missing vote");
      }
      const keys = Object.keys(vote);
      if (keys.length > 100) {
        throw new Error("Malformed vote object");
      }
      for (const key of keys) {
        if (!Number.isInteger(vote[key]) || vote[key] < 1 || vote[key] > 100) {
          throw new Error("Malformed vote");
        }
      }
      await repos.electionVotes.upsertVote(
        ACTIVE_DONATION_ELECTION,
        currentUser._id,
        vote,
      );
      return true;
    },
  },
});

addGraphQLQuery("GivingSeason2024DonationTotal: Float!");
addGraphQLQuery("GivingSeason2024VoteCounts: JSON!");
addGraphQLQuery("GivingSeason2024MyVote: JSON!");
addGraphQLMutation("GivingSeason2024Vote(vote: JSON!): Boolean");

defineFeedResolver<Date>({
  name: "GivingSeasonTagFeed",
  args: "tagId: String!",
  cutoffTypeGraphQL: "Date",
  resultTypesGraphQL: `
    newPost: Post
    newComment: Comment
  `,
  resolver: async ({limit = 3, cutoff, offset, args, context}: {
    limit?: number,
    cutoff?: Date,
    offset?: number,
    args: {tagId: string},
    context: ResolverContext
  }) => {
    const {tagId} = args;
    const relevantPostIds = await context.repos.posts.getViewablePostsIdsWithTag(tagId);
    return mergeFeedQueries<Date>({
      limit,
      cutoff,
      offset,
      subqueries: [
        viewBasedSubquery({
          type: "newPost",
          collection: Posts,
          sortField: "createdAt",
          context,
          selector: {
            _id: {$in: relevantPostIds},
          },
        }),
        viewBasedSubquery({
          type: "newComment",
          collection: Comments,
          sortField: "createdAt",
          context,
          selector: {
            postId: {$in: relevantPostIds},
            baseScore: {$gte: 5},
          },
        }),
      ],
    });
  }
});

1	import { Posts } from "@/lib/collections/posts";	18✔
2	import { Comments } from "@/lib/collections/comments";	18✔
3	import { addGraphQLMutation, addGraphQLQuery, addGraphQLResolvers } from "@/lib/vulcan-lib";	18✔
4	import {
5	defineFeedResolver,
6	mergeFeedQueries,
7	viewBasedSubquery,
8	} from "../utils/feedUtil";	18✔
9	import ElectionVotes from "@/lib/collections/electionVotes/collection";	18✔
10	import { ACTIVE_DONATION_ELECTION, DONATION_ELECTION_AGE_CUTOFF } from "@/lib/givingSeason";	18✔
11	import { instantRunoffAllPossibleResults, IRVote } from "@/lib/givingSeason/instantRunoff";	18✔
12
13	addGraphQLResolvers({
14	Query: {
15	GivingSeason2024DonationTotal: (
16	_root: void,
17	_args: {},
18	context: ResolverContext,
19	) => context.repos.databaseMetadata.getGivingSeason2024DonationTotal(),	×
20	GivingSeason2024VoteCounts: async (
21	_root: void,
22	_args: {},
23	_context: ResolverContext,
24	) => {
25	const dbVotes = await ElectionVotes.find({ electionName: ACTIVE_DONATION_ELECTION }).fetch();	×
26	const votes: IRVote[] = dbVotes.map((vote) => vote.vote);	×
27
28	return instantRunoffAllPossibleResults(votes as IRVote[]);	×
29	},
30	GivingSeason2024MyVote: async (
31	_root: void,
32	_args: {},
33	{currentUser}: ResolverContext,
34	) => {
35	if (!currentUser) {	×
36	return {};	×
37	}
38	const vote = await ElectionVotes.findOne({	×
39	electionName: ACTIVE_DONATION_ELECTION,
40	userId: currentUser?._id,	×
41	});
42	return vote?.vote ?? {};	×
43	},
44	},
45	Mutation: {
46	GivingSeason2024Vote: async (
47	_root: void,
48	{vote}: {vote: Record<string, number>},
49	{currentUser, repos}: ResolverContext,
50	) => {
NEW 51	if (	×
52	!currentUser \|\|	×
53	currentUser.banned \|\|
54	currentUser.createdAt > DONATION_ELECTION_AGE_CUTOFF
55	) {
UNCOV 56	throw new Error("Unauthorized");	×
57	}
58	if (!vote \|\| typeof vote !== "object") {	×
59	throw new Error("Missing vote");	×
60	}
61	const keys = Object.keys(vote);	×
62	if (keys.length > 100) {	×
63	throw new Error("Malformed vote object");	×
64	}
65	for (const key of keys) {	×
66	if (!Number.isInteger(vote[key]) \|\| vote[key] < 1 \|\| vote[key] > 100) {	×
67	throw new Error("Malformed vote");	×
68	}
69	}
70	await repos.electionVotes.upsertVote(	×
71	ACTIVE_DONATION_ELECTION,
72	currentUser._id,
73	vote,
74	);
75	return true;	×
76	},
77	},
78	});	18✔
79
80	addGraphQLQuery("GivingSeason2024DonationTotal: Float!");	18✔
81	addGraphQLQuery("GivingSeason2024VoteCounts: JSON!");	18✔
82	addGraphQLQuery("GivingSeason2024MyVote: JSON!");	18✔
83	addGraphQLMutation("GivingSeason2024Vote(vote: JSON!): Boolean");	18✔
84
85	defineFeedResolver<Date>({
86	name: "GivingSeasonTagFeed",
87	args: "tagId: String!",
88	cutoffTypeGraphQL: "Date",
89	resultTypesGraphQL: `
90	newPost: Post
91	newComment: Comment
92	`,
93	resolver: async ({limit = 3, cutoff, offset, args, context}: {	×
94	limit?: number,
95	cutoff?: Date,
96	offset?: number,
97	args: {tagId: string},
98	context: ResolverContext
99	}) => {
100	const {tagId} = args;	×
101	const relevantPostIds = await context.repos.posts.getViewablePostsIdsWithTag(tagId);	×
102	return mergeFeedQueries<Date>({	×
103	limit,
104	cutoff,
105	offset,
106	subqueries: [
107	viewBasedSubquery({
108	type: "newPost",
109	collection: Posts,
110	sortField: "createdAt",
111	context,
112	selector: {
113	_id: {$in: relevantPostIds},
114	},
115	}),
116	viewBasedSubquery({
117	type: "newComment",
118	collection: Comments,
119	sortField: "createdAt",
120	context,
121	selector: {
122	postId: {$in: relevantPostIds},
123	baseScore: {$gte: 5},
124	},
125	}),
126	],
127	});
128	}
129	});

ForumMagnum / ForumMagnum / 11897928487

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous