11816395839

Committed 13 Nov 2024 11:32AM UTC coverage: 89.304% (-0.04%) from 89.348%

Build # 11816395839

Build Type

push

github

Committed by

web-flow

Commit Message

Don't allow empty/hex strings to be validated as numeric strings (#2109)

Run Details

2710 of 3384 branches covered (80.08%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

9037 of 9770 relevant lines covered (92.5%)

429.22 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

93.75

/src/datasources/transaction-api/transaction-api.manager.ts

import { Inject, Injectable } from '@nestjs/common';
import { IConfigurationService } from '@/config/configuration.service.interface';
import { CacheFirstDataSource } from '@/datasources/cache/cache.first.data.source';
import {
  CacheService,
  ICacheService,
} from '@/datasources/cache/cache.service.interface';
import { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
import {
  INetworkService,
  NetworkService,
} from '@/datasources/network/network.service.interface';
import { TransactionApi } from '@/datasources/transaction-api/transaction-api.service';
import { ChainSchema } from '@/domain/chains/entities/schemas/chain.schema';
import { IConfigApi } from '@/domain/interfaces/config-api.interface';
import { ITransactionApiManager } from '@/domain/interfaces/transaction-api.manager.interface';
import { ILoggingService, LoggingService } from '@/logging/logging.interface';

@Injectable()
export class TransactionApiManager implements ITransactionApiManager {
  private transactionApiMap: Record<string, TransactionApi> = {};

  private readonly useVpcUrl: boolean;

  constructor(
    @Inject(IConfigurationService)
    private readonly configurationService: IConfigurationService,
    @Inject(IConfigApi) private readonly configApi: IConfigApi,
    private readonly dataSource: CacheFirstDataSource,
    @Inject(CacheService) private readonly cacheService: ICacheService,
    private readonly httpErrorFactory: HttpErrorFactory,
    @Inject(NetworkService) private readonly networkService: INetworkService,
    @Inject(LoggingService) private readonly loggingService: ILoggingService,
  ) {
    this.useVpcUrl = this.configurationService.getOrThrow<boolean>(
      'safeTransaction.useVpcUrl',
    );
  }

  async getApi(chainId: string): Promise<TransactionApi> {
    const transactionApi = this.transactionApiMap[chainId];
    if (transactionApi !== undefined) return transactionApi;

    const chain = await this.configApi
      .getChain(chainId)
      .then(ChainSchema.parse);
    this.transactionApiMap[chainId] = new TransactionApi(
      chainId,
      this.useVpcUrl ? chain.vpcTransactionService : chain.transactionService,
      this.dataSource,
      this.cacheService,
      this.configurationService,
      this.httpErrorFactory,
      this.networkService,
      this.loggingService,
    );
    return this.transactionApiMap[chainId];
  }

  destroyApi(chainId: string): void {
    if (this.transactionApiMap[chainId] !== undefined) {
      delete this.transactionApiMap[chainId];
    }
  }
}

1	import { Inject, Injectable } from '@nestjs/common';	148✔
2	import { IConfigurationService } from '@/config/configuration.service.interface';	148✔
3	import { CacheFirstDataSource } from '@/datasources/cache/cache.first.data.source';	148✔
4	import {	148✔
5	CacheService,
6	ICacheService,
7	} from '@/datasources/cache/cache.service.interface';
8	import { HttpErrorFactory } from '@/datasources/errors/http-error-factory';	148✔
9	import {	148✔
10	INetworkService,
11	NetworkService,
12	} from '@/datasources/network/network.service.interface';
13	import { TransactionApi } from '@/datasources/transaction-api/transaction-api.service';	148✔
14	import { ChainSchema } from '@/domain/chains/entities/schemas/chain.schema';	148✔
15	import { IConfigApi } from '@/domain/interfaces/config-api.interface';	148✔
16	import { ITransactionApiManager } from '@/domain/interfaces/transaction-api.manager.interface';
17	import { ILoggingService, LoggingService } from '@/logging/logging.interface';	148✔
18
19	@Injectable()
20	export class TransactionApiManager implements ITransactionApiManager {	148✔
21	private transactionApiMap: Record<string, TransactionApi> = {};	1,190✔
22
23	private readonly useVpcUrl: boolean;
24
25	constructor(
26	@Inject(IConfigurationService)
27	private readonly configurationService: IConfigurationService,	1,190✔
28	@Inject(IConfigApi) private readonly configApi: IConfigApi,	1,190✔
29	private readonly dataSource: CacheFirstDataSource,	1,190✔
30	@Inject(CacheService) private readonly cacheService: ICacheService,	1,190✔
31	private readonly httpErrorFactory: HttpErrorFactory,	1,190✔
32	@Inject(NetworkService) private readonly networkService: INetworkService,	1,190✔
33	@Inject(LoggingService) private readonly loggingService: ILoggingService,	1,190✔
34	) {
35	this.useVpcUrl = this.configurationService.getOrThrow<boolean>(	1,190✔
36	'safeTransaction.useVpcUrl',
37	);
38	}
39
40	async getApi(chainId: string): Promise<TransactionApi> {
41	const transactionApi = this.transactionApiMap[chainId];	3,520✔
42	if (transactionApi !== undefined) return transactionApi;	3,520✔
43
44	const chain = await this.configApi	908✔
45	.getChain(chainId)
46	.then(ChainSchema.parse);
47	this.transactionApiMap[chainId] = new TransactionApi(	876✔
48	chainId,
49	this.useVpcUrl ? chain.vpcTransactionService : chain.transactionService,	438✔
50	this.dataSource,
51	this.cacheService,
52	this.configurationService,
53	this.httpErrorFactory,
54	this.networkService,
55	this.loggingService,
56	);
57	return this.transactionApiMap[chainId];	876✔
58	}
59
60	destroyApi(chainId: string): void {
61	if (this.transactionApiMap[chainId] !== undefined) {	2!
UNCOV 62	delete this.transactionApiMap[chainId];	×
63	}
64	}
65	}

safe-global / safe-client-gateway / 11816395839

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous