• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3526

10 Nov 2024 03:50AM UTC coverage: 60.225% (-0.6%) from 60.818%
#3526

push

travis-ci

web-flow
Merge pull request #28709 from taosdata/main

merge: from main to 3.0 branch

117031 of 249004 branches covered (47.0%)

Branch coverage included in aggregate %.

130 of 169 new or added lines in 23 files covered. (76.92%)

4149 existing lines in 176 files now uncovered.

197577 of 273386 relevant lines covered (72.27%)

5840219.36 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.63
/source/libs/executor/src/filloperator.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "filter.h"
17
#include "os.h"
18
#include "query.h"
19
#include "taosdef.h"
20
#include "tmsg.h"
21
#include "ttypes.h"
22

23
#include "executorInt.h"
24
#include "tcommon.h"
25
#include "thash.h"
26
#include "ttime.h"
27

28
#include "function.h"
29
#include "operator.h"
30
#include "querynodes.h"
31
#include "querytask.h"
32
#include "tdatablock.h"
33
#include "tfill.h"
34

35
typedef struct STimeRange {
36
  TSKEY    skey;
37
  TSKEY    ekey;
38
  uint64_t groupId;
39
} STimeRange;
40

41
typedef struct SFillOperatorInfo {
42
  struct SFillInfo* pFillInfo;
43
  SSDataBlock*      pRes;
44
  SSDataBlock*      pFinalRes;
45
  int64_t           totalInputRows;
46
  void**            p;
47
  SSDataBlock*      existNewGroupBlock;
48
  STimeWindow       win;
49
  SColMatchInfo     matchInfo;
50
  int32_t           primaryTsCol;
51
  int32_t           primarySrcSlotId;
52
  uint64_t          curGroupId;  // current handled group id
53
  SExprInfo*        pExprInfo;
54
  int32_t           numOfExpr;
55
  SExprSupp         noFillExprSupp;
56
  SExprSupp         fillNullExprSupp;
57
} SFillOperatorInfo;
58

59
static void destroyFillOperatorInfo(void* param);
60
static void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag);
61
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo);
62
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order);
63

64
static void doHandleRemainBlockForNewGroupImpl(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
7,358✔
65
                                               SResultInfo* pResultInfo, int32_t order) {
66
  pInfo->totalInputRows = pInfo->existNewGroupBlock->info.rows;
7,358✔
67
  SSDataBlock*   pResBlock = pInfo->pFinalRes;
7,358✔
68
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
7,358✔
69

70
  //  int32_t order = TSDB_ORDER_ASC;
71
  int32_t scanFlag = MAIN_SCAN;
7,358✔
72
  //  getTableScanInfo(pOperator, &order, &scanFlag, false);
73
  taosResetFillInfo(pInfo->pFillInfo, getFillInfoStart(pInfo->pFillInfo));
7,358✔
74

75
  blockDataCleanup(pInfo->pRes);
7,358✔
76
  doApplyScalarCalculation(pOperator, pInfo->existNewGroupBlock, order, scanFlag);
7,358✔
77

78
  reviseFillStartAndEndKey(pOperator->info, order);
7,359✔
79

80
  int64_t ts = (order == TSDB_ORDER_ASC) ? pInfo->existNewGroupBlock->info.window.ekey
14,718✔
81
                                         : pInfo->existNewGroupBlock->info.window.skey;
7,359!
82
  taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
7,359✔
83

84
  taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
7,359✔
85
  if (pInfo->pFillInfo->type == TSDB_FILL_PREV || pInfo->pFillInfo->type == TSDB_FILL_LINEAR) {
7,359✔
86
    int32_t code = fillResetPrevForNewGroup(pInfo->pFillInfo);
104✔
87
    if (code != TSDB_CODE_SUCCESS) {
104!
88
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
89
      T_LONG_JMP(pTaskInfo->env, code);
×
90
    }
91
  }
92

93
  int32_t numOfResultRows = pResultInfo->capacity - pResBlock->info.rows;
7,359✔
94
  int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
7,359✔
95
  if (code != TSDB_CODE_SUCCESS) {
7,359!
96
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
97
    T_LONG_JMP(pTaskInfo->env, code);
×
98
  }
99

100
  pInfo->curGroupId = pInfo->existNewGroupBlock->info.id.groupId;
7,359✔
101
  pInfo->existNewGroupBlock = NULL;
7,359✔
102
}
7,359✔
103

104
static void doHandleRemainBlockFromNewGroup(SOperatorInfo* pOperator, SFillOperatorInfo* pInfo,
52,293✔
105
                                            SResultInfo* pResultInfo, int32_t order) {
106
  SExecTaskInfo* pTaskInfo = pOperator->pTaskInfo;
52,293✔
107
  if (taosFillHasMoreResults(pInfo->pFillInfo)) {
52,293✔
108
    int32_t numOfResultRows = pResultInfo->capacity - pInfo->pFinalRes->info.rows;
1,672✔
109
    int32_t code = taosFillResultDataBlock(pInfo->pFillInfo, pInfo->pFinalRes, numOfResultRows);
1,672✔
110
    if (code != TSDB_CODE_SUCCESS) {
1,672!
111
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
112
      T_LONG_JMP(pTaskInfo->env, code);
×
113
    }
114
    pInfo->pRes->info.id.groupId = pInfo->curGroupId;
1,672✔
115
    return;
1,672✔
116
  }
117

118
  // handle the cached new group data block
119
  if (pInfo->existNewGroupBlock) {
50,622✔
120
    doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
6,368✔
121
  }
122
}
123

124
void doApplyScalarCalculation(SOperatorInfo* pOperator, SSDataBlock* pBlock, int32_t order, int32_t scanFlag) {
31,663✔
125
  int32_t            code = TSDB_CODE_SUCCESS;
31,663✔
126
  int32_t            lino = 0;
31,663✔
127
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
31,663✔
128
  SFillOperatorInfo* pInfo = pOperator->info;
31,663✔
129
  SExprSupp*         pSup = &pOperator->exprSupp;
31,663✔
130
  code = setInputDataBlock(pSup, pBlock, order, scanFlag, false);
31,663✔
131
  QUERY_CHECK_CODE(code, lino, _end);
31,663!
132
  code = projectApplyFunctions(pSup->pExprInfo, pInfo->pRes, pBlock, pSup->pCtx, pSup->numOfExprs, NULL);
31,663✔
133
  QUERY_CHECK_CODE(code, lino, _end);
31,665!
134

135
  // reset the row value before applying the no-fill functions to the input data block, which is "pBlock" in this case.
136
  pInfo->pRes->info.rows = 0;
31,665✔
137
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
31,665✔
138
  code = setInputDataBlock(pNoFillSupp, pBlock, order, scanFlag, false);
31,665✔
139
  QUERY_CHECK_CODE(code, lino, _end);
31,665!
140

141
  code = projectApplyFunctions(pNoFillSupp->pExprInfo, pInfo->pRes, pBlock, pNoFillSupp->pCtx, pNoFillSupp->numOfExprs,
31,665✔
142
                               NULL);
143
  QUERY_CHECK_CODE(code, lino, _end);
31,666!
144

145
  if (pInfo->fillNullExprSupp.pExprInfo) {
31,666✔
146
    pInfo->pRes->info.rows = 0;
118✔
147
    code = setInputDataBlock(&pInfo->fillNullExprSupp, pBlock, order, scanFlag, false);
118✔
148
    QUERY_CHECK_CODE(code, lino, _end);
118!
149
    code = projectApplyFunctions(pInfo->fillNullExprSupp.pExprInfo, pInfo->pRes, pBlock, pInfo->fillNullExprSupp.pCtx,
118✔
150
        pInfo->fillNullExprSupp.numOfExprs, NULL);
151
  }
152

153
  pInfo->pRes->info.id.groupId = pBlock->info.id.groupId;
31,666✔
154

155
_end:
31,666✔
156
  if (code != TSDB_CODE_SUCCESS) {
31,666!
157
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
158
    T_LONG_JMP(pTaskInfo->env, code);
×
159
  }
160
}
31,666✔
161

162
static int32_t fillResetPrevForNewGroup(SFillInfo* pFillInfo) {
104✔
163
  int32_t code = TSDB_CODE_SUCCESS;
104✔
164
  int32_t lino = 0;
104✔
165
  for (int32_t colIdx = 0; colIdx < pFillInfo->numOfCols; ++colIdx) {
863✔
166
    if (!pFillInfo->pFillCol[colIdx].notFillCol) {
759✔
167
      SGroupKeys* key = taosArrayGet(pFillInfo->prev.pRowVal, colIdx);
571✔
168
      QUERY_CHECK_NULL(key, code, lino, _end, terrno);
571!
169
      key->isNull = true;
571✔
170
    }
171
  }
172

173
_end:
104✔
174
  if (code != TSDB_CODE_SUCCESS) {
104!
175
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
176
  }
177
  return code;
104✔
178
}
179

180
static SSDataBlock* doFillImpl(SOperatorInfo* pOperator) {
36,804✔
181
  int32_t            code = TSDB_CODE_SUCCESS;
36,804✔
182
  int32_t            lino = 0;
36,804✔
183
  SFillOperatorInfo* pInfo = pOperator->info;
36,804✔
184
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
36,804✔
185

186
  SResultInfo* pResultInfo = &pOperator->resultInfo;
36,804✔
187
  SSDataBlock* pResBlock = pInfo->pFinalRes;
36,804✔
188

189
  blockDataCleanup(pResBlock);
36,804✔
190

191
  int32_t order = pInfo->pFillInfo->order;
36,805✔
192

193
  SOperatorInfo* pDownstream = pOperator->pDownstream[0];
36,805✔
194
#if 0
195
  // the scan order may be different from the output result order for agg interval operator.
196
  if (pDownstream->operatorType == QUERY_NODE_PHYSICAL_PLAN_HASH_INTERVAL) {
197
    order = ((SIntervalAggOperatorInfo*) pDownstream->info)->resultTsOrder;
198
  } else {
199
    order = pInfo->pFillInfo->order;
200
  }
201
#endif
202

203
  doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
36,805✔
204
  if (pResBlock->info.rows > 0) {
36,803✔
205
    pResBlock->info.id.groupId = pInfo->curGroupId;
8,041✔
206
    return pResBlock;
8,041✔
207
  }
208

209
  while (1) {
16,440✔
210
    SSDataBlock* pBlock = getNextBlockFromDownstream(pOperator, 0);
45,202✔
211
    if (pBlock == NULL) {
45,199✔
212
      if (pInfo->totalInputRows == 0 &&
20,892✔
213
          (pInfo->pFillInfo->type != TSDB_FILL_NULL_F && pInfo->pFillInfo->type != TSDB_FILL_SET_VALUE_F)) {
8,934✔
214
        setOperatorCompleted(pOperator);
8,910✔
215
        return NULL;
8,910✔
216
      } else if (pInfo->totalInputRows == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
11,982✔
217
        reviseFillStartAndEndKey(pInfo, order);
12✔
218
      }
219

220
      taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
11,982✔
221
    } else {
222
      pResBlock->info.scanFlag = pBlock->info.scanFlag;
24,307✔
223
      pBlock->info.dataLoad = 1;
24,307✔
224
      code = blockDataUpdateTsWindow(pBlock, pInfo->primarySrcSlotId);
24,307✔
225
      QUERY_CHECK_CODE(code, lino, _end);
24,307!
226

227
      blockDataCleanup(pInfo->pRes);
24,307✔
228
      code = blockDataEnsureCapacity(pInfo->pRes, pBlock->info.rows);
24,307✔
229
      QUERY_CHECK_CODE(code, lino, _end);
24,306!
230
      code = blockDataEnsureCapacity(pInfo->pFinalRes, pBlock->info.rows);
24,306✔
231
      QUERY_CHECK_CODE(code, lino, _end);
24,306!
232
      doApplyScalarCalculation(pOperator, pBlock, order, pBlock->info.scanFlag);
24,306✔
233

234
      if (pInfo->curGroupId == 0 || (pInfo->curGroupId == pInfo->pRes->info.id.groupId)) {
41,256✔
235
        if (pInfo->curGroupId == 0 && taosFillNotStarted(pInfo->pFillInfo)) {
16,949✔
236
          reviseFillStartAndEndKey(pInfo, order);
6,510✔
237
        }
238

239
        pInfo->curGroupId = pInfo->pRes->info.id.groupId;  // the first data block
16,948✔
240
        pInfo->totalInputRows += pInfo->pRes->info.rows;
16,948✔
241

242
        int64_t ts = (order == TSDB_ORDER_ASC) ? pBlock->info.window.ekey : pBlock->info.window.skey;
16,948✔
243
        taosFillSetStartInfo(pInfo->pFillInfo, pInfo->pRes->info.rows, ts);
16,948✔
244
        taosFillSetInputDataBlock(pInfo->pFillInfo, pInfo->pRes);
16,948✔
245
      } else if (pInfo->curGroupId != pBlock->info.id.groupId) {  // the new group data block
7,359!
246
        pInfo->existNewGroupBlock = pBlock;
7,359✔
247

248
        // Fill the previous group data block, before handle the data block of new group.
249
        // Close the fill operation for previous group data block
250
        taosFillSetStartInfo(pInfo->pFillInfo, 0, pInfo->win.ekey);
7,359✔
251
        pInfo->pFillInfo->prev.key = 0;
7,359✔
252
      }
253
    }
254

255
    int32_t numOfResultRows = pOperator->resultInfo.capacity - pResBlock->info.rows;
36,291✔
256
    code = taosFillResultDataBlock(pInfo->pFillInfo, pResBlock, numOfResultRows);
36,291✔
257
    QUERY_CHECK_CODE(code, lino, _end);
36,290!
258

259
    // current group has no more result to return
260
    if (pResBlock->info.rows > 0) {
36,290✔
261
      // 1. The result in current group not reach the threshold of output result, continue
262
      // 2. If multiple group results existing in one SSDataBlock is not allowed, return immediately
263
      if (pResBlock->info.rows > pResultInfo->threshold || pBlock == NULL || pInfo->existNewGroupBlock != NULL) {
28,871✔
264
        pResBlock->info.id.groupId = pInfo->curGroupId;
13,378✔
265
        return pResBlock;
13,378✔
266
      }
267

268
      doHandleRemainBlockFromNewGroup(pOperator, pInfo, pResultInfo, order);
15,493✔
269
      if (pResBlock->info.rows >= pOperator->resultInfo.threshold || pBlock == NULL) {
15,494!
270
        pResBlock->info.id.groupId = pInfo->curGroupId;
44✔
271
        return pResBlock;
44✔
272
      }
273
    } else if (pInfo->existNewGroupBlock) {  // try next group
7,419✔
274
      blockDataCleanup(pResBlock);
990✔
275

276
      doHandleRemainBlockForNewGroupImpl(pOperator, pInfo, pResultInfo, order);
990✔
277
      if (pResBlock->info.rows > pResultInfo->threshold) {
990!
278
        pResBlock->info.id.groupId = pInfo->curGroupId;
×
279
        return pResBlock;
×
280
      }
281
    } else {
282
      return NULL;
6,429✔
283
    }
284
  }
285

286
_end:
×
287
  if (code != TSDB_CODE_SUCCESS) {
×
288
    qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
289
    T_LONG_JMP(pTaskInfo->env, code);
×
290
  }
291
  return NULL;
×
292
}
293

294
static int32_t doFillNext(SOperatorInfo* pOperator, SSDataBlock** ppRes) {
36,766✔
295
  int32_t            code = TSDB_CODE_SUCCESS;
36,766✔
296
  SFillOperatorInfo* pInfo = pOperator->info;
36,766✔
297
  SExecTaskInfo*     pTaskInfo = pOperator->pTaskInfo;
36,766✔
298

299
  if (pOperator->status == OP_EXEC_DONE) {
36,766!
300
    (*ppRes) = NULL;
×
301
    return code;
×
302
  }
303

304
  SSDataBlock* fillResult = NULL;
36,766✔
305
  while (true) {
306
    fillResult = doFillImpl(pOperator);
36,804✔
307
    if (fillResult == NULL) {
36,802✔
308
      setOperatorCompleted(pOperator);
15,340✔
309
      break;
15,339✔
310
    }
311

312
    code = doFilter(fillResult, pOperator->exprSupp.pFilterInfo, &pInfo->matchInfo);
21,462✔
313
    if (code != TSDB_CODE_SUCCESS) {
21,464!
314
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
315
      pTaskInfo->code = code;
×
316
      T_LONG_JMP(pTaskInfo->env, code);
×
317
    }
318
    if (fillResult->info.rows > 0) {
21,464✔
319
      break;
21,426✔
320
    }
321
  }
322

323
  if (fillResult != NULL) {
36,765✔
324
    pOperator->resultInfo.totalRows += fillResult->info.rows;
21,426✔
325
  }
326

327
  (*ppRes) = fillResult;
36,765✔
328
  return code;
36,765✔
329
}
330

331
void destroyFillOperatorInfo(void* param) {
15,433✔
332
  SFillOperatorInfo* pInfo = (SFillOperatorInfo*)param;
15,433✔
333
  pInfo->pFillInfo = taosDestroyFillInfo(pInfo->pFillInfo);
15,433✔
334
  blockDataDestroy(pInfo->pRes);
15,433✔
335
  pInfo->pRes = NULL;
15,433✔
336
  blockDataDestroy(pInfo->pFinalRes);
15,433✔
337
  pInfo->pFinalRes = NULL;
15,433✔
338

339
  cleanupExprSupp(&pInfo->noFillExprSupp);
15,433✔
340
  cleanupExprSupp(&pInfo->fillNullExprSupp);
15,432✔
341

342
  taosMemoryFreeClear(pInfo->p);
15,431!
343
  taosArrayDestroy(pInfo->matchInfo.pList);
15,433✔
344
  taosMemoryFreeClear(param);
15,433!
345
}
15,433✔
346

347
static int32_t initFillInfo(SFillOperatorInfo* pInfo, SExprInfo* pExpr, int32_t numOfCols, SExprInfo* pNotFillExpr,
15,429✔
348
                            int32_t numOfNotFillCols, SExprInfo* pFillNullExpr, int32_t numOfFillNullExprs,
349
                            SNodeListNode* pValNode, STimeWindow win, int32_t capacity, const char* id,
350
                            SInterval* pInterval, int32_t fillType, int32_t order, SExecTaskInfo* pTaskInfo) {
351
  SFillColInfo* pColInfo =
352
      createFillColInfo(pExpr, numOfCols, pNotFillExpr, numOfNotFillCols, pFillNullExpr, numOfFillNullExprs, pValNode);
15,429✔
353
  if (!pColInfo) {
15,429!
UNCOV
354
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(terrno));
×
UNCOV
355
    return terrno;
×
356
  }
357

358
  int64_t startKey = (order == TSDB_ORDER_ASC) ? win.skey : win.ekey;
15,429✔
359

360
  //  STimeWindow w = {0};
361
  //  getInitialStartTimeWindow(pInterval, startKey, &w, order == TSDB_ORDER_ASC);
362
  pInfo->pFillInfo = NULL;
15,429✔
363
  int32_t code = taosCreateFillInfo(startKey, numOfCols, numOfNotFillCols, numOfFillNullExprs, capacity, pInterval,
15,429✔
364
                                    fillType, pColInfo, pInfo->primaryTsCol, order, id, pTaskInfo, &pInfo->pFillInfo);
15,429✔
365
  if (code != TSDB_CODE_SUCCESS) {
15,431✔
366
    qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
2!
367
    return code;
×
368
  }
369

370
  if (order == TSDB_ORDER_ASC) {
15,429✔
371
    pInfo->win.skey = win.skey;
13,589✔
372
    pInfo->win.ekey = win.ekey;
13,589✔
373
  } else {
374
    pInfo->win.skey = win.ekey;
1,840✔
375
    pInfo->win.ekey = win.skey;
1,840✔
376
  }
377
  pInfo->p = taosMemoryCalloc(numOfCols, POINTER_BYTES);
15,429✔
378
  if (!pInfo->p) {
15,433!
379
    return terrno;
×
380
  }
381

382
  if (pInfo->pFillInfo == NULL || pInfo->p == NULL) {
15,433!
383
    taosMemoryFree(pInfo->pFillInfo);
2✔
384
    taosMemoryFree(pInfo->p);
×
385
    return TSDB_CODE_OUT_OF_MEMORY;
×
386
  } else {
387
    return TSDB_CODE_SUCCESS;
15,431✔
388
  }
389
}
390

391
static bool isWstartColumnExist(SFillOperatorInfo* pInfo) {
15,430✔
392
  if (pInfo->noFillExprSupp.numOfExprs == 0) {
15,430✔
393
    return false;
234✔
394
  }
395

396
  for (int32_t i = 0; i < pInfo->noFillExprSupp.numOfExprs; ++i) {
15,797✔
397
    SExprInfo* exprInfo = pInfo->noFillExprSupp.pExprInfo + i;
15,730✔
398
    if (exprInfo->pExpr->nodeType == QUERY_NODE_COLUMN && exprInfo->base.numOfParams == 1 &&
15,730!
399
        exprInfo->base.pParam[0].pCol->colType == COLUMN_TYPE_WINDOW_START) {
15,730✔
400
      return true;
15,129✔
401
    }
402
  }
403
  return false;
67✔
404
}
405

406
static int32_t createPrimaryTsExprIfNeeded(SFillOperatorInfo* pInfo, SFillPhysiNode* pPhyFillNode, SExprSupp* pExprSupp,
15,427✔
407
                                           const char* idStr) {
408
  bool wstartExist = isWstartColumnExist(pInfo);
15,427✔
409

410
  if (wstartExist == false) {
15,432✔
411
    if (pPhyFillNode->pWStartTs->type != QUERY_NODE_TARGET) {
303!
412
      qError("pWStartTs of fill physical node is not a target node, %s", idStr);
×
413
      return TSDB_CODE_QRY_SYS_ERROR;
×
414
    }
415

416
    SExprInfo* pExpr = taosMemoryRealloc(pExprSupp->pExprInfo, (pExprSupp->numOfExprs + 1) * sizeof(SExprInfo));
303✔
417
    if (pExpr == NULL) {
303!
418
      return terrno;
×
419
    }
420

421
    int32_t code = createExprFromTargetNode(&pExpr[pExprSupp->numOfExprs], (STargetNode*)pPhyFillNode->pWStartTs);
303✔
422
    if (code != TSDB_CODE_SUCCESS) {
303!
423
      qError("%s failed at line %d since %s", __func__, __LINE__, tstrerror(code));
×
424
      pExprSupp->numOfExprs += 1;
×
425
      pExprSupp->pExprInfo = pExpr;
×
426
      return code;
×
427
    }
428

429
    pExprSupp->numOfExprs += 1;
303✔
430
    pExprSupp->pExprInfo = pExpr;
303✔
431
  }
432

433
  return TSDB_CODE_SUCCESS;
15,432✔
434
}
435

436
int32_t createFillOperatorInfo(SOperatorInfo* downstream, SFillPhysiNode* pPhyFillNode,
15,425✔
437
                                      SExecTaskInfo* pTaskInfo, SOperatorInfo** pOptrInfo) {
438
  QRY_PARAM_CHECK(pOptrInfo);
15,425!
439
  int32_t code = 0;
15,425✔
440
  int32_t lino = 0;
15,425✔
441

442
  SFillOperatorInfo* pInfo = taosMemoryCalloc(1, sizeof(SFillOperatorInfo));
15,425✔
443
  SOperatorInfo*     pOperator = taosMemoryCalloc(1, sizeof(SOperatorInfo));
15,431✔
444
  if (pInfo == NULL || pOperator == NULL) {
15,431!
445
    code = terrno;
×
446
    goto _error;
×
447
  }
448

449
  pInfo->pRes = createDataBlockFromDescNode(pPhyFillNode->node.pOutputDataBlockDesc);
15,432✔
450
  QUERY_CHECK_NULL(pInfo->pRes, code, lino, _error, terrno);
15,432!
451
  SExprInfo* pExprInfo = NULL;
15,432✔
452

453
  code = createExprInfo(pPhyFillNode->pFillExprs, NULL, &pExprInfo, &pInfo->numOfExpr);
15,432✔
454
  QUERY_CHECK_CODE(code, lino, _error);
15,431!
455

456
  pOperator->exprSupp.pExprInfo = pExprInfo;
15,431✔
457
  pOperator->exprSupp.numOfExprs = pInfo->numOfExpr;
15,431✔
458

459
  SExprSupp* pNoFillSupp = &pInfo->noFillExprSupp;
15,431✔
460
  code = createExprInfo(pPhyFillNode->pNotFillExprs, NULL, &pNoFillSupp->pExprInfo, &pNoFillSupp->numOfExprs);
15,431✔
461
  QUERY_CHECK_CODE(code, lino, _error);
15,432!
462

463
  code = createPrimaryTsExprIfNeeded(pInfo, pPhyFillNode, pNoFillSupp, pTaskInfo->id.str);
15,432✔
464
  QUERY_CHECK_CODE(code, lino, _error);
15,432!
465

466
  code =
467
      initExprSupp(pNoFillSupp, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs, &pTaskInfo->storageAPI.functionStore);
15,432✔
468
  QUERY_CHECK_CODE(code, lino, _error);
15,429!
469

470
  code = createExprInfo(pPhyFillNode->pFillNullExprs, NULL, &pInfo->fillNullExprSupp.pExprInfo,
15,429✔
471
                        &pInfo->fillNullExprSupp.numOfExprs);
472
  QUERY_CHECK_CODE(code, lino, _error);
15,431!
473
  code = initExprSupp(&pInfo->fillNullExprSupp, pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
15,431✔
474
                      &pTaskInfo->storageAPI.functionStore);
475
  QUERY_CHECK_CODE(code, lino, _error);
15,432!
476

477
  SInterval* pInterval =
15,432✔
478
      QUERY_NODE_PHYSICAL_PLAN_MERGE_ALIGNED_INTERVAL == downstream->operatorType
15,432✔
479
          ? &((SMergeAlignedIntervalAggOperatorInfo*)downstream->info)->intervalAggOperatorInfo->interval
5,384✔
480
          : &((SIntervalAggOperatorInfo*)downstream->info)->interval;
15,432✔
481

482
  int32_t order = (pPhyFillNode->node.inputTsOrder == ORDER_ASC) ? TSDB_ORDER_ASC : TSDB_ORDER_DESC;
15,432✔
483
  int32_t type = convertFillType(pPhyFillNode->mode);
15,432✔
484

485
  SResultInfo* pResultInfo = &pOperator->resultInfo;
15,428✔
486

487
  initResultSizeInfo(&pOperator->resultInfo, 4096);
15,428✔
488
  code = blockDataEnsureCapacity(pInfo->pRes, pOperator->resultInfo.capacity);
15,429✔
489
  if (code != TSDB_CODE_SUCCESS) {
15,432!
490
    goto _error;
×
491
  }
492
  code = initExprSupp(&pOperator->exprSupp, pExprInfo, pInfo->numOfExpr, &pTaskInfo->storageAPI.functionStore);
15,432✔
493
  if (code != TSDB_CODE_SUCCESS) {
15,431!
494
    goto _error;
×
495
  }
496

497
  pInfo->primaryTsCol = ((STargetNode*)pPhyFillNode->pWStartTs)->slotId;
15,431✔
498
  pInfo->primarySrcSlotId = ((SColumnNode*)((STargetNode*)pPhyFillNode->pWStartTs)->pExpr)->slotId;
15,431✔
499

500
  int32_t numOfOutputCols = 0;
15,431✔
501
  code = extractColMatchInfo(pPhyFillNode->pFillExprs, pPhyFillNode->node.pOutputDataBlockDesc, &numOfOutputCols,
15,431✔
502
                             COL_MATCH_FROM_SLOT_ID, &pInfo->matchInfo);
503

504
  QUERY_CHECK_CODE(code, lino, _error);
15,431!
505
  code = initFillInfo(pInfo, pExprInfo, pInfo->numOfExpr, pNoFillSupp->pExprInfo, pNoFillSupp->numOfExprs,
15,431✔
506
                      pInfo->fillNullExprSupp.pExprInfo, pInfo->fillNullExprSupp.numOfExprs,
507
                      (SNodeListNode*)pPhyFillNode->pValues, pPhyFillNode->timeRange, pResultInfo->capacity,
15,431✔
508
                      pTaskInfo->id.str, pInterval, type, order, pTaskInfo);
15,431✔
509
  if (code != TSDB_CODE_SUCCESS) {
15,430!
510
    goto _error;
×
511
  }
512

513
  pInfo->pFinalRes = NULL;
15,430✔
514

515
  code = createOneDataBlock(pInfo->pRes, false, &pInfo->pFinalRes);
15,430✔
516
  if (code) {
15,433!
517
    goto _error;
×
518
  }
519

520
  code = blockDataEnsureCapacity(pInfo->pFinalRes, pOperator->resultInfo.capacity);
15,433✔
521
  if (code != TSDB_CODE_SUCCESS) {
15,431!
522
    goto _error;
×
523
  }
524

525
  code = filterInitFromNode((SNode*)pPhyFillNode->node.pConditions, &pOperator->exprSupp.pFilterInfo, 0);
15,431✔
526
  if (code != TSDB_CODE_SUCCESS) {
15,431!
527
    goto _error;
×
528
  }
529

530
  setOperatorInfo(pOperator, "FillOperator", QUERY_NODE_PHYSICAL_PLAN_FILL, false, OP_NOT_OPENED, pInfo, pTaskInfo);
15,431✔
531
  pOperator->fpSet = createOperatorFpSet(optrDummyOpenFn, doFillNext, NULL, destroyFillOperatorInfo, optrDefaultBufFn, NULL,
15,431✔
532
                                         optrDefaultGetNextExtFn, NULL);
533

534
  code = appendDownstream(pOperator, &downstream, 1);
15,433✔
535
  if (code != TSDB_CODE_SUCCESS) {
15,433!
536
    goto _error;
×
537
  }
538

539
  *pOptrInfo = pOperator;
15,433✔
540
  return TSDB_CODE_SUCCESS;
15,433✔
541

542
_error:
×
543
  qError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
544

545
  if (pInfo != NULL) {
×
546
    destroyFillOperatorInfo(pInfo);
×
547
  }
548
  destroyOperatorAndDownstreams(pOperator, &downstream, 1);
×
549
  pTaskInfo->code = code;
×
550
  return code;
×
551
}
552

553
static void reviseFillStartAndEndKey(SFillOperatorInfo* pInfo, int32_t order) {
13,880✔
554
  int64_t skey, ekey, next;
555
  if (order == TSDB_ORDER_ASC) {
13,880✔
556
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
12,970✔
557
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
12,971✔
558

559
    ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
12,970✔
560
    next = ekey;
12,971✔
561
    while (next < pInfo->win.ekey) {
80,288✔
562
      next = taosTimeAdd(ekey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
67,317✔
563
                         pInfo->pFillInfo->interval.precision);
67,317✔
564
      ekey = next > pInfo->win.ekey ? ekey : next;
67,317✔
565
    }
566
    pInfo->win.ekey = ekey;
12,971✔
567
  } else {
568
    skey = taosTimeTruncate(pInfo->win.skey, &pInfo->pFillInfo->interval);
910✔
569
    next = skey;
910✔
570
    while (next < pInfo->win.skey) {
7,431✔
571
      next = taosTimeAdd(skey, pInfo->pFillInfo->interval.sliding, pInfo->pFillInfo->interval.slidingUnit,
6,521✔
572
                         pInfo->pFillInfo->interval.precision);
6,521✔
573
      skey = next > pInfo->win.skey ? skey : next;
6,521✔
574
    }
575
    taosFillUpdateStartTimestampInfo(pInfo->pFillInfo, skey);
910✔
576
    pInfo->win.ekey = taosTimeTruncate(pInfo->win.ekey, &pInfo->pFillInfo->interval);
910✔
577
  }
578
}
13,881✔
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc