11774677434

Committed 11 Nov 2024 08:16AM CUT coverage: 89.083%. Remained the same

Build # 11774677434

Build Type

Pull #1305

github

Committed by

web-flow

Commit Message

Merge 8d745996e into ef88a3194

Pull Request Pull Request #1305: chore(deps): update eslint

Run Details

1387 of 1773 branches covered (78.23%)

Branch coverage included in aggregate %.

3411 of 3613 relevant lines covered (94.41%)

60.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

35.29

/src/utils/scrollIntoViewIfNeeded.js

/** TODO: extend this function to check on parent scroll container if we have a use case.
 * That implementation is hard to test in storybook because of the iframe situation,
 * hence relevant code is now disabled here
 */

// const REGEXP_SCROLL_PARENT = /^(visible|hidden)/;

// const getScrollParent = el => {
//     if (!(el instanceof HTMLElement) || typeof window.getComputedStyle !== 'function') {
//         return null;
//     }
//     if (
//         el.scrollHeight >= el.clientHeight &&
//         !REGEXP_SCROLL_PARENT.test(window.getComputedStyle(el).overflowY || 'visible')
//     ) {
//         return el;
//     }
//     return getScrollParent(el.parentElement) || document.body;
// };

export const scrollIntoViewIfNeeded = (el, alignTo = 'bottom') => {
    // check if we can scroll at all
    if (!el || !el.scrollIntoView) {
        return;
    }

    // check if element is visible:
    const elRect = el.getBoundingClientRect();
    // const scrollParent = getScrollParent(el);
    // const parentRect = scrollParent.getBoundingClientRect();

    const isVisible = elRect.top >= 0 && elRect.bottom <= window.innerHeight;
    // const isVisible = elRect.top >= parentRect.top && elRect.bottom <= parentRect.bottom;

    if (!isVisible) {
        const alignToTop = alignTo !== 'bottom';
        el.scrollIntoView(alignToTop);
    }
};

1	/** TODO: extend this function to check on parent scroll container if we have a use case.
2	* That implementation is hard to test in storybook because of the iframe situation,
3	* hence relevant code is now disabled here
4	*/
5
6	// const REGEXP_SCROLL_PARENT = /^(visible\|hidden)/;
7
8	// const getScrollParent = el => {
9	// if (!(el instanceof HTMLElement) \|\| typeof window.getComputedStyle !== 'function') {
10	// return null;
11	// }
12	// if (
13	// el.scrollHeight >= el.clientHeight &&
14	// !REGEXP_SCROLL_PARENT.test(window.getComputedStyle(el).overflowY \|\| 'visible')
15	// ) {
16	// return el;
17	// }
18	// return getScrollParent(el.parentElement) \|\| document.body;
19	// };
20
21	export const scrollIntoViewIfNeeded = (el, alignTo = 'bottom') => {	101!
22	// check if we can scroll at all
23	if (!el \|\| !el.scrollIntoView) {	14!
24	return;	14✔
25	}
26
27	// check if element is visible:
28	const elRect = el.getBoundingClientRect();	×
29	// const scrollParent = getScrollParent(el);
30	// const parentRect = scrollParent.getBoundingClientRect();
31
32	const isVisible = elRect.top >= 0 && elRect.bottom <= window.innerHeight;	×
33	// const isVisible = elRect.top >= parentRect.top && elRect.bottom <= parentRect.bottom;
34
35	if (!isVisible) {	×
36	const alignToTop = alignTo !== 'bottom';	×
37	el.scrollIntoView(alignToTop);	×
38	}
39	};

textkernel / oneui / 11774677434

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous