• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3524

08 Nov 2024 04:27AM UTC coverage: 60.898% (+5.0%) from 55.861%
#3524

push

travis-ci

web-flow
Merge pull request #28647 from taosdata/fix/3.0/TD-32519_drop_ctb

fix TD-32519 drop child table with tsma caused crash

118687 of 248552 branches covered (47.75%)

Branch coverage included in aggregate %.

286 of 337 new or added lines in 18 files covered. (84.87%)

9647 existing lines in 190 files now uncovered.

199106 of 273291 relevant lines covered (72.85%)

15236719.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.23
/source/libs/stream/src/streamUpdate.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "tcompare.h"
17
#include "tdatablock.h"
18
#include "tencode.h"
19
#include "tstreamUpdate.h"
20
#include "ttime.h"
21
#include "tutil.h"
22

23
#define DEFAULT_FALSE_POSITIVE   0.01
24
#define DEFAULT_BUCKET_SIZE      131072
25
#define DEFAULT_MAP_CAPACITY     131072
26
#define DEFAULT_MAP_SIZE         (DEFAULT_MAP_CAPACITY * 100)
27
#define ROWS_PER_MILLISECOND     1
28
#define MAX_NUM_SCALABLE_BF      64
29
#define MIN_NUM_SCALABLE_BF      10
30
#define DEFAULT_PREADD_BUCKET    1
31
#define MAX_INTERVAL             MILLISECOND_PER_MINUTE
32
#define MIN_INTERVAL             (MILLISECOND_PER_SECOND * 10)
33
#define DEFAULT_EXPECTED_ENTRIES 10000
34

35
static int64_t adjustExpEntries(int64_t entries) { return TMIN(DEFAULT_EXPECTED_ENTRIES, entries); }
124,263,974✔
36

37
int compareKeyTs(void* pTs1, void* pTs2, void* pPkVal, __compar_fn_t cmpPkFn) {
20,030,917✔
38
  return compareInt64Val(pTs1, pTs2);
20,030,917✔
39
}
40

41
int compareKeyTsAndPk(void* pValue1, void* pTs, void* pPkVal, __compar_fn_t cmpPkFn) {
33,850,517✔
42
  int res = compareInt64Val(pValue1, pTs);
33,850,517✔
43
  if (res != 0) {
33,850,517✔
44
    return res;
33,850,512✔
45
  } else {
46
    void* pk1 = (char*)pValue1 + sizeof(TSKEY);
5✔
47
    return cmpPkFn(pk1, pPkVal);
5✔
48
  }
49
}
50

51
int32_t getKeyBuff(TSKEY ts, int64_t tbUid, void* pVal, int32_t len, char* buff) {
115,722,402✔
52
  *(TSKEY*)buff = ts;
115,722,402✔
53
  memcpy(buff + sizeof(TSKEY), &tbUid, sizeof(int64_t));
115,722,402✔
54
  if (len == 0) {
115,722,402✔
55
    return sizeof(TSKEY) + sizeof(int64_t);
26,994,885✔
56
  }
57
  memcpy(buff, pVal, len);
88,727,517✔
58
  return sizeof(TSKEY) + sizeof(int64_t) + len;
88,727,517✔
59
}
60

61
int32_t getValueBuff(TSKEY ts, char* pVal, int32_t len, char* buff) {
53,946,438✔
62
  *(TSKEY*)buff = ts;
53,946,438✔
63
  if (len == 0) {
53,946,438✔
64
    return sizeof(TSKEY);
20,034,442✔
65
  }
66
  memcpy(buff + sizeof(TSKEY), pVal, len);
33,911,996✔
67
  return sizeof(TSKEY) + len;
33,911,996✔
68
}
69

70
int32_t windowSBfAdd(SUpdateInfo* pInfo, uint64_t count) {
3,823,208✔
71
  int32_t code = TSDB_CODE_SUCCESS;
3,823,208✔
72
  int32_t lino = 0;
3,823,208✔
73
  if (pInfo->numSBFs < count) {
3,823,208✔
74
    count = pInfo->numSBFs;
3,794,533✔
75
  }
76
  for (uint64_t i = 0; i < count; ++i) {
127,843,446✔
77
    int64_t      rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
124,352,167✔
78
    SScalableBf* tsSBF = NULL;
123,657,642✔
79
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &tsSBF);
123,657,642✔
80
    QUERY_CHECK_CODE(code, lino, _error);
126,043,727!
81
    void* res = taosArrayPush(pInfo->pTsSBFs, &tsSBF);
126,043,727✔
82
    if (!res) {
124,020,238!
83
      code = terrno;
×
84
      QUERY_CHECK_CODE(code, lino, _error);
×
85
    }
86
  }
87

88
_error:
3,491,279✔
89
  if (code != TSDB_CODE_SUCCESS) {
3,491,279!
90
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
91
  }
92
  return code;
3,807,549✔
93
}
94

95
static void clearItemHelper(void* p) {
128,359,493✔
96
  SScalableBf** pBf = p;
128,359,493✔
97
  tScalableBfDestroy(*pBf);
128,359,493✔
98
}
128,498,119✔
99

100
void windowSBfDelete(SUpdateInfo* pInfo, uint64_t count) {
3,790,270✔
101
  if (count < pInfo->numSBFs) {
3,790,270✔
102
    for (uint64_t i = 0; i < count; ++i) {
46,413✔
103
      SScalableBf* pTsSBFs = taosArrayGetP(pInfo->pTsSBFs, 0);
25,626✔
104
      tScalableBfDestroy(pTsSBFs);
25,624✔
105
      taosArrayRemove(pInfo->pTsSBFs, 0);
25,630✔
106
    }
107
  } else {
108
    taosArrayClearEx(pInfo->pTsSBFs, clearItemHelper);
3,769,488✔
109
  }
110
  pInfo->minTS += pInfo->interval * count;
3,819,111✔
111
}
3,819,111✔
112

113
static int64_t adjustInterval(int64_t interval, int32_t precision) {
5,658✔
114
  int64_t val = interval;
5,658✔
115
  if (precision != TSDB_TIME_PRECISION_MILLI) {
5,658✔
116
    val = convertTimePrecision(interval, precision, TSDB_TIME_PRECISION_MILLI);
118✔
117
  }
118

119
  if (val <= 0 || val > MAX_INTERVAL) {
5,659✔
120
    val = MAX_INTERVAL;
1,761✔
121
  } else if (val < MIN_INTERVAL) {
3,898✔
122
    val = MIN_INTERVAL;
513✔
123
  }
124

125
  if (precision != TSDB_TIME_PRECISION_MILLI) {
5,659✔
126
    val = convertTimePrecision(val, TSDB_TIME_PRECISION_MILLI, precision);
118✔
127
  }
128
  return val;
5,659✔
129
}
130

131
static int64_t adjustWatermark(int64_t adjInterval, int64_t originInt, int64_t watermark) {
5,658✔
132
  if (watermark <= adjInterval) {
5,658✔
133
    watermark = TMAX(originInt / adjInterval, 1) * adjInterval;
5,424✔
134
  }
135

136
  if (watermark > MAX_NUM_SCALABLE_BF * adjInterval) {
5,658✔
137
    watermark = MAX_NUM_SCALABLE_BF * adjInterval;
234✔
138
  }
139
  return watermark;
5,658✔
140
}
141

142
int32_t updateInfoInitP(SInterval* pInterval, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
3,557✔
143
                        SUpdateInfo** ppInfo) {
144
  return updateInfoInit(pInterval->interval, pInterval->precision, watermark, igUp, pkType, pkLen, ppInfo);
3,557✔
145
}
146

147
int32_t updateInfoInit(int64_t interval, int32_t precision, int64_t watermark, bool igUp, int8_t pkType, int32_t pkLen,
5,658✔
148
                       SUpdateInfo** ppInfo) {
149
  int32_t      code = TSDB_CODE_SUCCESS;
5,658✔
150
  int32_t      lino = 0;
5,658✔
151
  SUpdateInfo* pInfo = taosMemoryCalloc(1, sizeof(SUpdateInfo));
5,658✔
152
  if (pInfo == NULL) {
5,659!
153
    code = terrno;
×
154
    QUERY_CHECK_CODE(code, lino, _end);
×
155
  }
156
  pInfo->pTsBuckets = NULL;
5,659✔
157
  pInfo->pTsSBFs = NULL;
5,659✔
158
  pInfo->minTS = INT64_MIN;
5,659✔
159
  pInfo->interval = adjustInterval(interval, precision);
5,659✔
160
  pInfo->watermark = adjustWatermark(pInfo->interval, interval, watermark);
5,658✔
161
  pInfo->numSBFs = 0;
5,659✔
162

163
  uint64_t bfSize = 0;
5,659✔
164
  if (!igUp) {
5,659✔
165
    bfSize = (uint64_t)(pInfo->watermark / pInfo->interval);
5,262✔
166
    pInfo->numSBFs = bfSize;
5,262✔
167

168
    pInfo->pTsSBFs = taosArrayInit(bfSize, sizeof(void*));
5,262✔
169
    if (pInfo->pTsSBFs == NULL) {
5,262!
170
      updateInfoDestroy(pInfo);
×
171
      code = terrno;
×
172
      QUERY_CHECK_CODE(code, lino, _end);
×
173
    }
174
    code = windowSBfAdd(pInfo, bfSize);
5,262✔
175
    QUERY_CHECK_CODE(code, lino, _end);
5,261!
176

177
    pInfo->pTsBuckets = taosArrayInit(DEFAULT_BUCKET_SIZE, sizeof(TSKEY));
5,261✔
178
    if (pInfo->pTsBuckets == NULL) {
5,262!
179
      updateInfoDestroy(pInfo);
×
180
      code = terrno;
×
181
      QUERY_CHECK_CODE(code, lino, _end);
×
182
    }
183

184
    TSKEY dumy = INT64_MIN;
5,262✔
185
    for (uint64_t i = 0; i < DEFAULT_BUCKET_SIZE; ++i) {
488,364,043!
186
      void* tmp = taosArrayPush(pInfo->pTsBuckets, &dumy);
489,003,429✔
187
      if (!tmp) {
488,358,781!
188
        code = terrno;
×
189
        QUERY_CHECK_CODE(code, lino, _end);
×
190
      }
191
    }
192
    pInfo->numBuckets = DEFAULT_BUCKET_SIZE;
×
193
    pInfo->pCloseWinSBF = NULL;
×
194
  }
195
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
×
196
  pInfo->pMap = taosHashInit(DEFAULT_MAP_CAPACITY, hashFn, true, HASH_NO_LOCK);
5,659✔
197
  if (!pInfo->pMap) {
5,659!
198
    code = terrno;
×
199
    QUERY_CHECK_CODE(code, lino, _end);
×
200
  }
201
  pInfo->maxDataVersion = 0;
5,659✔
202
  pInfo->pkColLen = pkLen;
5,659✔
203
  pInfo->pkColType = pkType;
5,659✔
204
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pkLen);
5,659✔
205
  if (!pInfo->pKeyBuff) {
5,659!
206
    code = terrno;
×
207
    QUERY_CHECK_CODE(code, lino, _end);
×
208
  }
209
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pkLen);
5,659✔
210
  if (!pInfo->pValueBuff) {
5,659!
211
    code = terrno;
×
212
    QUERY_CHECK_CODE(code, lino, _end);
×
213
  }
214
  if (pkLen != 0) {
5,659✔
215
    pInfo->comparePkRowFn = compareKeyTsAndPk;
122✔
216
    pInfo->comparePkCol = getKeyComparFunc(pkType, TSDB_ORDER_ASC);
122✔
217
  } else {
218
    pInfo->comparePkRowFn = compareKeyTs;
5,537✔
219
    pInfo->comparePkCol = NULL;
5,537✔
220
  }
221
  (*ppInfo) = pInfo;
5,659✔
222

223
_end:
5,659✔
224
  if (code != TSDB_CODE_SUCCESS) {
5,659!
UNCOV
225
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
226
  }
227
  return code;
5,659✔
228
}
229

230
static int32_t getSBf(SUpdateInfo* pInfo, TSKEY ts, SScalableBf** ppSBf) {
341,726,177✔
231
  int32_t code = TSDB_CODE_SUCCESS;
341,726,177✔
232
  int32_t lino = 0;
341,726,177✔
233
  if (pInfo->minTS == INT64_MIN) {
341,726,177✔
234
    pInfo->minTS = (TSKEY)(ts / pInfo->interval * pInfo->interval);
1,868✔
235
  }
236
  int64_t index = (int64_t)((ts - pInfo->minTS) / pInfo->interval);
341,726,177✔
237
  if (index < 0) {
341,726,177✔
238
    (*ppSBf) = NULL;
256,216,721✔
239
    goto _end;
256,216,721✔
240
  }
241
  if (index >= pInfo->numSBFs) {
85,509,456✔
242
    uint64_t count = index + 1 - pInfo->numSBFs;
3,790,481✔
243
    windowSBfDelete(pInfo, count);
3,790,481✔
244
    code = windowSBfAdd(pInfo, count);
3,819,032✔
245
    QUERY_CHECK_CODE(code, lino, _end);
3,801,387!
246

247
    index = pInfo->numSBFs - 1;
3,801,387✔
248
  }
249
  SScalableBf* res = taosArrayGetP(pInfo->pTsSBFs, index);
85,520,362✔
250
  if (res == NULL) {
86,071,471✔
251
    int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
5,115✔
252
    code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &res);
×
253
    QUERY_CHECK_CODE(code, lino, _end);
×
254

UNCOV
255
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &res);
×
256
    if (!tmp) {
×
257
      code = terrno;
×
258
      QUERY_CHECK_CODE(code, lino, _end);
×
259
    }
260
  }
261
  (*ppSBf) = res;
86,066,356✔
262

263
_end:
342,283,077✔
264
  if (code != TSDB_CODE_SUCCESS) {
342,283,077!
UNCOV
265
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
266
  }
267
  return code;
341,682,584✔
268
}
269

270
bool updateInfoIsTableInserted(SUpdateInfo* pInfo, int64_t tbUid) {
364,122✔
271
  void* pVal = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
364,122✔
272
  if (pVal || taosHashGetSize(pInfo->pMap) >= DEFAULT_MAP_SIZE) return true;
364,137!
273
  return false;
12,434✔
274
}
275

276
int32_t updateInfoFillBlockData(SUpdateInfo* pInfo, SSDataBlock* pBlock, int32_t primaryTsCol, int32_t primaryKeyCol,
169,478✔
277
                                TSKEY* pMaxResTs) {
278
  int32_t code = TSDB_CODE_SUCCESS;
169,478✔
279
  int32_t lino = 0;
169,478✔
280
  if (pBlock == NULL || pBlock->info.rows == 0) {
169,478!
UNCOV
281
    (*pMaxResTs) = INT64_MIN;
×
282
    goto _end;
×
283
  }
284
  TSKEY   maxTs = INT64_MIN;
169,478✔
285
  void*   pPkVal = NULL;
169,478✔
286
  void*   pMaxPkVal = NULL;
169,478✔
287
  int32_t maxLen = 0;
169,478✔
288
  int32_t len = 0;
169,478✔
289
  int64_t tbUid = pBlock->info.id.uid;
169,478✔
290

291
  SColumnInfoData* pColDataInfo = taosArrayGet(pBlock->pDataBlock, primaryTsCol);
169,478✔
292
  SColumnInfoData* pPkDataInfo = NULL;
169,478✔
293
  if (primaryKeyCol >= 0) {
169,478✔
294
    pPkDataInfo = taosArrayGet(pBlock->pDataBlock, primaryKeyCol);
163,716✔
295
  }
296

297
  for (int32_t i = 0; i < pBlock->info.rows; i++) {
288,296,052✔
298
    TSKEY ts = ((TSKEY*)pColDataInfo->pData)[i];
288,184,004✔
299
    if (maxTs < ts) {
288,184,004✔
300
      maxTs = ts;
288,143,084✔
301
      if (primaryKeyCol >= 0) {
288,143,084✔
302
        pMaxPkVal = colDataGetData(pPkDataInfo, i);
272,276,666!
303
        maxLen = colDataGetRowLength(pPkDataInfo, i);
272,276,666✔
304
      }
305
    }
306
    SScalableBf* pSBf = NULL;
288,111,305✔
307
    code = getSBf(pInfo, ts, &pSBf);
288,111,305✔
308
    QUERY_CHECK_CODE(code, lino, _end);
288,108,741!
309

310
    if (pSBf) {
288,108,741✔
311
      if (primaryKeyCol >= 0) {
62,003,534✔
312
        pPkVal = colDataGetData(pPkDataInfo, i);
55,051,726!
313
        len = colDataGetRowLength(pPkDataInfo, i);
55,051,726✔
314
      }
315
      int32_t buffLen = getKeyBuff(ts, tbUid, pPkVal, len, pInfo->pKeyBuff);
62,001,299✔
316
      // we don't care whether the data is updated or not
317
      int32_t winRes = 0;
61,995,823✔
318
      code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &winRes);
61,995,823✔
319
      QUERY_CHECK_CODE(code, lino, _end);
62,021,368!
320
    }
321
  }
322
  void* pMaxTs = taosHashGet(pInfo->pMap, &tbUid, sizeof(int64_t));
112,048✔
323
  if (pMaxTs == NULL || pInfo->comparePkRowFn(pMaxTs, &maxTs, pMaxPkVal, pInfo->comparePkCol) == -1) {
169,478!
324
    int32_t valueLen = getValueBuff(maxTs, pMaxPkVal, maxLen, pInfo->pValueBuff);
169,478✔
325
    code = taosHashPut(pInfo->pMap, &tbUid, sizeof(int64_t), pInfo->pValueBuff, valueLen);
169,478✔
326
    QUERY_CHECK_CODE(code, lino, _end);
169,478!
327
  }
328
  (*pMaxResTs) = maxTs;
169,478✔
329

330
_end:
169,478✔
331
  if (code != TSDB_CODE_SUCCESS) {
169,478!
UNCOV
332
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
333
  }
334
  return code;
169,478✔
335
}
336

337
bool updateInfoIsUpdated(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
53,776,566✔
338
  int32_t code = TSDB_CODE_SUCCESS;
53,776,566✔
339
  int32_t lino = 0;
53,776,566✔
340
  int32_t res = TSDB_CODE_FAILED;
53,776,566✔
341
  int32_t buffLen = 0;
53,776,566✔
342

343
  buffLen = getKeyBuff(ts, tableId, pPkVal, len, pInfo->pKeyBuff);
53,776,566✔
344
  void**   pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
53,781,907✔
345
  uint64_t index = ((uint64_t)tableId) % pInfo->numBuckets;
53,784,929✔
346
  TSKEY    maxTs = *(TSKEY*)taosArrayGet(pInfo->pTsBuckets, index);
53,784,929✔
347
  if (maxTs != INT64_MIN && ts < maxTs - pInfo->watermark) {
53,786,915!
348
    // this window has been closed.
UNCOV
349
    if (pInfo->pCloseWinSBF) {
×
350
      code = tScalableBfPut(pInfo->pCloseWinSBF, pInfo->pKeyBuff, buffLen, &res);
×
351
      QUERY_CHECK_CODE(code, lino, _end);
×
352
      if (res == TSDB_CODE_SUCCESS) {
×
353
        return false;
×
354
      } else {
UNCOV
355
        return true;
×
356
      }
357
    }
UNCOV
358
    return true;
×
359
  }
360

361
  SScalableBf* pSBf = NULL;
53,786,915✔
362
  code = getSBf(pInfo, ts, &pSBf);
53,786,915✔
363
  QUERY_CHECK_CODE(code, lino, _end);
53,781,260!
364

365
  int32_t size = taosHashGetSize(pInfo->pMap);
53,781,260✔
366
  if ((!pMapMaxTs && size < DEFAULT_MAP_SIZE) ||
53,772,373!
367
      (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == -1)) {
53,768,090✔
368
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
53,749,969✔
369
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
53,769,661✔
370
    QUERY_CHECK_CODE(code, lino, _end);
53,781,350!
371

372
    // pSBf may be a null pointer
373
    if (pSBf) {
53,781,350✔
374
      res = tScalableBfPutNoCheck(pSBf, pInfo->pKeyBuff, buffLen);
24,109,270✔
375
    }
376
    return false;
53,781,306✔
377
  }
378

379
  // pSBf may be a null pointer
380
  if (pSBf) {
7,793✔
381
    code = tScalableBfPut(pSBf, pInfo->pKeyBuff, buffLen, &res);
4,688✔
382
    QUERY_CHECK_CODE(code, lino, _end);
4,689!
383
  }
384

385
  if (!pMapMaxTs && maxTs < ts) {
7,794!
UNCOV
386
    taosArraySet(pInfo->pTsBuckets, index, &ts);
×
387
    return false;
×
388
  }
389

390
  if (ts < pInfo->minTS) {
7,794✔
391
    return true;
4,121✔
392
  } else if (res == TSDB_CODE_SUCCESS) {
3,673✔
393
    return false;
570✔
394
  }
395

396
_end:
3,103✔
397
  if (code != TSDB_CODE_SUCCESS) {
3,103!
UNCOV
398
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
399
  }
400
  // check from tsdb api
401
  return true;
3,102✔
402
}
403

404
void updateInfoDestroy(SUpdateInfo* pInfo) {
10,105✔
405
  if (pInfo == NULL) {
10,105✔
406
    return;
2,775✔
407
  }
408
  taosArrayDestroy(pInfo->pTsBuckets);
7,330✔
409

410
  uint64_t size = taosArrayGetSize(pInfo->pTsSBFs);
7,332✔
411
  for (uint64_t i = 0; i < size; i++) {
88,705✔
412
    SScalableBf* pSBF = taosArrayGetP(pInfo->pTsSBFs, i);
81,372✔
413
    tScalableBfDestroy(pSBF);
81,356✔
414
  }
415

416
  taosArrayDestroy(pInfo->pTsSBFs);
7,333✔
417
  taosMemoryFreeClear(pInfo->pKeyBuff);
7,333!
418
  taosMemoryFreeClear(pInfo->pValueBuff);
7,333!
419
  taosHashCleanup(pInfo->pMap);
7,333✔
420
  updateInfoDestoryColseWinSBF(pInfo);
7,333✔
421
  taosMemoryFree(pInfo);
7,333✔
422
}
423

424
void updateInfoAddCloseWindowSBF(SUpdateInfo* pInfo) {
539✔
425
  if (pInfo->pCloseWinSBF) {
539!
UNCOV
426
    return;
×
427
  }
428
  int64_t rows = adjustExpEntries(pInfo->interval * ROWS_PER_MILLISECOND);
539✔
429
  int32_t code = tScalableBfInit(rows, DEFAULT_FALSE_POSITIVE, &pInfo->pCloseWinSBF);
539✔
430
  if (code != TSDB_CODE_SUCCESS) {
539!
UNCOV
431
    pInfo->pCloseWinSBF = NULL;
×
432
    uError("%s failed to add close window SBF since %s", __func__, tstrerror(code));
×
433
  }
434
}
435

436
void updateInfoDestoryColseWinSBF(SUpdateInfo* pInfo) {
54,866✔
437
  if (!pInfo || !pInfo->pCloseWinSBF) {
54,866✔
438
    return;
54,327✔
439
  }
440
  tScalableBfDestroy(pInfo->pCloseWinSBF);
539✔
441
  pInfo->pCloseWinSBF = NULL;
539✔
442
}
443

444
int32_t updateInfoSerialize(SEncoder* pEncoder, const SUpdateInfo* pInfo) {
3,679✔
445
  int32_t code = TSDB_CODE_SUCCESS;
3,679✔
446
  int32_t lino = 0;
3,679✔
447
  if (!pInfo) {
3,679✔
448
    return TSDB_CODE_SUCCESS;
18✔
449
  }
450

451
  int32_t size = taosArrayGetSize(pInfo->pTsBuckets);
3,661✔
452
  if (tEncodeI32(pEncoder, size) < 0) {
3,660!
UNCOV
453
    code = TSDB_CODE_FAILED;
×
UNCOV
454
    QUERY_CHECK_CODE(code, lino, _end);
×
455
  }
456

457
  for (int32_t i = 0; i < size; i++) {
313,471,489!
458
    TSKEY* pTs = (TSKEY*)taosArrayGet(pInfo->pTsBuckets, i);
314,026,558✔
459
    if (tEncodeI64(pEncoder, *pTs) < 0) {
626,935,658!
UNCOV
460
      code = TSDB_CODE_FAILED;
×
461
      QUERY_CHECK_CODE(code, lino, _end);
×
462
    }
463
  }
464

UNCOV
465
  if (tEncodeU64(pEncoder, pInfo->numBuckets) < 0) {
×
UNCOV
466
    code = TSDB_CODE_FAILED;
×
UNCOV
467
    QUERY_CHECK_CODE(code, lino, _end);
×
468
  }
469

UNCOV
470
  int32_t sBfSize = taosArrayGetSize(pInfo->pTsSBFs);
✔
471
  if (tEncodeI32(pEncoder, sBfSize) < 0) {
3,662!
UNCOV
472
    code = TSDB_CODE_FAILED;
×
473
    QUERY_CHECK_CODE(code, lino, _end);
×
474
  }
475
  for (int32_t i = 0; i < sBfSize; i++) {
54,532✔
476
    SScalableBf* pSBf = taosArrayGetP(pInfo->pTsSBFs, i);
50,869✔
477
    if (tScalableBfEncode(pSBf, pEncoder) < 0) {
50,861!
478
      code = TSDB_CODE_FAILED;
×
UNCOV
479
      QUERY_CHECK_CODE(code, lino, _end);
×
480
    }
481
  }
482

483
  if (tEncodeU64(pEncoder, pInfo->numSBFs) < 0) {
7,326!
UNCOV
484
    code = TSDB_CODE_FAILED;
×
UNCOV
485
    QUERY_CHECK_CODE(code, lino, _end);
×
486
  }
487
  if (tEncodeI64(pEncoder, pInfo->interval) < 0) {
7,326!
UNCOV
488
    code = TSDB_CODE_FAILED;
×
UNCOV
489
    QUERY_CHECK_CODE(code, lino, _end);
×
490
  }
491
  if (tEncodeI64(pEncoder, pInfo->watermark) < 0) {
7,326!
492
    code = TSDB_CODE_FAILED;
×
493
    QUERY_CHECK_CODE(code, lino, _end);
×
494
  }
495
  if (tEncodeI64(pEncoder, pInfo->minTS) < 0) {
7,326!
496
    code = TSDB_CODE_FAILED;
×
497
    QUERY_CHECK_CODE(code, lino, _end);
×
498
  }
499

500
  if (tScalableBfEncode(pInfo->pCloseWinSBF, pEncoder) < 0) {
3,663!
501
    code = TSDB_CODE_FAILED;
×
UNCOV
502
    QUERY_CHECK_CODE(code, lino, _end);
×
503
  }
504

505
  int32_t mapSize = taosHashGetSize(pInfo->pMap);
3,661✔
506
  if (tEncodeI32(pEncoder, mapSize) < 0) {
3,662!
UNCOV
507
    code = TSDB_CODE_FAILED;
×
UNCOV
508
    QUERY_CHECK_CODE(code, lino, _end);
×
509
  }
510
  void*  pIte = NULL;
3,662✔
511
  size_t keyLen = 0;
3,662✔
512
  while ((pIte = taosHashIterate(pInfo->pMap, pIte)) != NULL) {
44,693✔
513
    void* key = taosHashGetKey(pIte, &keyLen);
41,055✔
514
    if (tEncodeU64(pEncoder, *(uint64_t*)key) < 0) {
82,110!
515
      code = TSDB_CODE_FAILED;
×
516
      QUERY_CHECK_CODE(code, lino, _end);
×
517
    }
518
    int32_t valueSize = taosHashGetValueSize(pIte);
41,055✔
519
    if (tEncodeBinary(pEncoder, (const uint8_t*)pIte, valueSize) < 0) {
82,062!
UNCOV
520
      code = TSDB_CODE_FAILED;
×
UNCOV
521
      QUERY_CHECK_CODE(code, lino, _end);
×
522
    }
523
  }
524

525
  if (tEncodeU64(pEncoder, pInfo->maxDataVersion) < 0) {
7,324!
UNCOV
526
    code = TSDB_CODE_FAILED;
×
UNCOV
527
    QUERY_CHECK_CODE(code, lino, _end);
×
528
  }
529

530
  if (tEncodeI32(pEncoder, pInfo->pkColLen) < 0) {
7,324!
UNCOV
531
    code = TSDB_CODE_FAILED;
×
UNCOV
532
    QUERY_CHECK_CODE(code, lino, _end);
×
533
  }
534
  if (tEncodeI8(pEncoder, pInfo->pkColType) < 0) {
7,324!
535
    code = TSDB_CODE_FAILED;
×
UNCOV
536
    QUERY_CHECK_CODE(code, lino, _end);
×
537
  }
538

539
_end:
3,662✔
540
  if (code != TSDB_CODE_SUCCESS) {
3,662!
UNCOV
541
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
542
  }
543
  return code;
3,661✔
544
}
545

546
int32_t updateInfoDeserialize(SDecoder* pDeCoder, SUpdateInfo* pInfo) {
1,792✔
547
  int32_t code = TSDB_CODE_SUCCESS;
1,792✔
548
  int32_t lino = 0;
1,792✔
549
  QUERY_CHECK_NULL(pInfo, code, lino, _error, TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
1,792!
550
  
551
  int32_t size = 0;
1,792✔
552
  if (tDecodeI32(pDeCoder, &size) < 0) return -1;
1,792!
553
  pInfo->pTsBuckets = taosArrayInit(size, sizeof(TSKEY));
1,792✔
554
  QUERY_CHECK_NULL(pInfo->pTsBuckets, code, lino, _error, terrno);
1,791!
555

556
  TSKEY ts = INT64_MIN;
1,791✔
557
  for (int32_t i = 0; i < size; i++) {
183,467,374!
558
    if (tDecodeI64(pDeCoder, &ts) < 0) return -1;
183,404,103!
559
    void* tmp = taosArrayPush(pInfo->pTsBuckets, &ts);
183,404,103✔
560
    if (!tmp) {
183,465,583!
UNCOV
561
      code = terrno;
×
UNCOV
562
      QUERY_CHECK_CODE(code, lino, _error);
×
563
    }
564
  }
565

UNCOV
566
  if (tDecodeU64(pDeCoder, &pInfo->numBuckets) < 0) return -1;
×
567

568
  int32_t sBfSize = 0;
1,792✔
569
  if (tDecodeI32(pDeCoder, &sBfSize) < 0) return -1;
1,792!
570
  pInfo->pTsSBFs = taosArrayInit(sBfSize, sizeof(void*));
1,792✔
571
  QUERY_CHECK_NULL(pInfo->pTsSBFs, code, lino, _error, terrno);
1,792✔
572

573
  for (int32_t i = 0; i < sBfSize; i++) {
27,204✔
574
    SScalableBf* pSBf = NULL;
25,414✔
575
    code = tScalableBfDecode(pDeCoder, &pSBf);
25,414✔
576
    QUERY_CHECK_CODE(code, lino, _error);
25,414!
577

578
    void* tmp = taosArrayPush(pInfo->pTsSBFs, &pSBf);
25,414✔
579
    if (!tmp) {
25,414!
UNCOV
580
      code = terrno;
×
UNCOV
581
      QUERY_CHECK_CODE(code, lino, _error);
×
582
    }
583
  }
584

585
  if (tDecodeU64(pDeCoder, &pInfo->numSBFs) < 0) return -1;
3,580!
586
  if (tDecodeI64(pDeCoder, &pInfo->interval) < 0) return -1;
3,580!
587
  if (tDecodeI64(pDeCoder, &pInfo->watermark) < 0) return -1;
3,580!
588
  if (tDecodeI64(pDeCoder, &pInfo->minTS) < 0) return -1;
3,580!
589

590
  code = tScalableBfDecode(pDeCoder, &pInfo->pCloseWinSBF);
1,790✔
591
  if (code != TSDB_CODE_SUCCESS) {
1,790!
UNCOV
592
    pInfo->pCloseWinSBF = NULL;
×
UNCOV
593
    code = TSDB_CODE_SUCCESS;
×
594
  }
595

596
  int32_t mapSize = 0;
1,790✔
597
  if (tDecodeI32(pDeCoder, &mapSize) < 0) return -1;
1,790!
598
  _hash_fn_t hashFn = taosGetDefaultHashFunction(TSDB_DATA_TYPE_UBIGINT);
1,790✔
599
  pInfo->pMap = taosHashInit(mapSize, hashFn, true, HASH_NO_LOCK);
1,790✔
600
  uint64_t uid = 0;
1,790✔
601
  void*    pVal = NULL;
1,790✔
602
  uint32_t  valSize = 0;
1,790✔
603
  for (int32_t i = 0; i < mapSize; i++) {
16,190✔
604
    if (tDecodeU64(pDeCoder, &uid) < 0) return -1;
14,400!
605
    if (tDecodeBinary(pDeCoder, (uint8_t**)&pVal, &valSize) < 0) return -1;
14,400!
606
    code = taosHashPut(pInfo->pMap, &uid, sizeof(uint64_t), pVal, valSize);
14,400✔
607
    QUERY_CHECK_CODE(code, lino, _error);
14,400!
608
  }
609
  QUERY_CHECK_CONDITION((mapSize == taosHashGetSize(pInfo->pMap)), code, lino, _error,
1,790!
610
                        TSDB_CODE_QRY_EXECUTOR_INTERNAL_ERROR);
611
  if (tDecodeU64(pDeCoder, &pInfo->maxDataVersion) < 0) return -1;
3,580!
612

613
  if (tDecodeI32(pDeCoder, &pInfo->pkColLen) < 0) return -1;
3,580!
614
  if (tDecodeI8(pDeCoder, &pInfo->pkColType) < 0) return -1;
3,580!
615

616
  pInfo->pKeyBuff = taosMemoryCalloc(1, sizeof(TSKEY) + sizeof(int64_t) + pInfo->pkColLen);
1,790✔
617
  QUERY_CHECK_NULL(pInfo->pKeyBuff, code, lino, _error, terrno);
1,790!
618

619
  pInfo->pValueBuff = taosMemoryCalloc(1, sizeof(TSKEY) + pInfo->pkColLen);
1,790✔
620
  QUERY_CHECK_NULL(pInfo->pValueBuff, code, lino, _error, terrno);
1,790!
621

622
  if (pInfo->pkColLen != 0) {
1,790✔
623
    pInfo->comparePkRowFn = compareKeyTsAndPk;
3✔
624
    pInfo->comparePkCol = getKeyComparFunc(pInfo->pkColType, TSDB_ORDER_ASC);
3✔
625
  } else {
626
    pInfo->comparePkRowFn = compareKeyTs;
1,787✔
627
    pInfo->comparePkCol = NULL;
1,787✔
628
  }
629

630
_error:
1,792✔
631
  if (code != TSDB_CODE_SUCCESS) {
1,792✔
632
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
2!
633
  }
634
  return code;
1,792✔
635
}
636

637
bool isIncrementalTimeStamp(SUpdateInfo* pInfo, uint64_t tableId, TSKEY ts, void* pPkVal, int32_t len) {
7,296✔
638
  int32_t code = TSDB_CODE_SUCCESS;
7,296✔
639
  int32_t lino = 0;
7,296✔
640
  TSKEY*  pMapMaxTs = taosHashGet(pInfo->pMap, &tableId, sizeof(uint64_t));
7,296✔
641
  bool    res = true;
7,299✔
642
  if (pMapMaxTs && pInfo->comparePkRowFn(pMapMaxTs, &ts, pPkVal, pInfo->comparePkCol) == 1) {
7,299✔
643
    res = false;
289✔
644
  } else {
645
    int32_t valueLen = getValueBuff(ts, pPkVal, len, pInfo->pValueBuff);
7,010✔
646
    code = taosHashPut(pInfo->pMap, &tableId, sizeof(uint64_t), pInfo->pValueBuff, valueLen);
7,010✔
647
    QUERY_CHECK_CODE(code, lino, _error);
7,012!
648
  }
649
  return res;
7,301✔
650

UNCOV
651
_error:
×
UNCOV
652
  if (code != TSDB_CODE_SUCCESS) {
×
653
    uError("%s failed at line %d since %s", __func__, lino, tstrerror(code));
×
654
  }
UNCOV
655
  return false;
×
656
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc