• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

taosdata / TDengine / #3524

08 Nov 2024 04:27AM UTC coverage: 60.898% (+5.0%) from 55.861%
#3524

push

travis-ci

web-flow
Merge pull request #28647 from taosdata/fix/3.0/TD-32519_drop_ctb

fix TD-32519 drop child table with tsma caused crash

118687 of 248552 branches covered (47.75%)

Branch coverage included in aggregate %.

286 of 337 new or added lines in 18 files covered. (84.87%)

9647 existing lines in 190 files now uncovered.

199106 of 273291 relevant lines covered (72.85%)

15236719.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

70.76
/source/dnode/vnode/src/meta/metaEntry.c
1
/*
2
 * Copyright (c) 2019 TAOS Data, Inc. <jhtao@taosdata.com>
3
 *
4
 * This program is free software: you can use, redistribute, and/or modify
5
 * it under the terms of the GNU Affero General Public License, version 3
6
 * or later ("AGPL"), as published by the Free Software Foundation.
7
 *
8
 * This program is distributed in the hope that it will be useful, but WITHOUT
9
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
10
 * FITNESS FOR A PARTICULAR PURPOSE.
11
 *
12
 * You should have received a copy of the GNU Affero General Public License
13
 * along with this program. If not, see <http://www.gnu.org/licenses/>.
14
 */
15

16
#include "meta.h"
17

18
int meteEncodeColCmprEntry(SEncoder *pCoder, const SMetaEntry *pME) {
583,171✔
19
  const SColCmprWrapper *pw = &pME->colCmpr;
583,171✔
20
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->nCols));
1,166,342!
21
  TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pw->version));
1,166,342!
22
  uDebug("encode cols:%d", pw->nCols);
583,171✔
23

24
  for (int32_t i = 0; i < pw->nCols; i++) {
3,648,828✔
25
    SColCmpr *p = &pw->pColCmpr[i];
3,065,159✔
26
    TAOS_CHECK_RETURN(tEncodeI16v(pCoder, p->id));
6,130,318!
27
    TAOS_CHECK_RETURN(tEncodeU32(pCoder, p->alg));
6,130,318!
28
  }
29
  return 0;
583,669✔
30
}
31
int meteDecodeColCmprEntry(SDecoder *pDecoder, SMetaEntry *pME) {
5,371,826✔
32
  SColCmprWrapper *pWrapper = &pME->colCmpr;
5,371,826✔
33
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->nCols));
10,743,399!
34
  if (pWrapper->nCols == 0) {
5,371,573!
35
    return 0;
×
36
  }
37

38
  TAOS_CHECK_RETURN(tDecodeI32v(pDecoder, &pWrapper->version));
10,744,188!
39
  uDebug("dencode cols:%d", pWrapper->nCols);
5,372,615✔
40
  pWrapper->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pWrapper->nCols * sizeof(SColCmpr));
5,372,717✔
41
  if (pWrapper->pColCmpr == NULL) {
5,374,918!
UNCOV
42
    return terrno;
×
43
  }
44

45
  for (int i = 0; i < pWrapper->nCols; i++) {
107,596,123✔
46
    SColCmpr *p = &pWrapper->pColCmpr[i];
102,235,541✔
47
    TAOS_CHECK_RETURN(tDecodeI16v(pDecoder, &p->id));
204,473,120!
48
    TAOS_CHECK_RETURN(tDecodeU32(pDecoder, &p->alg));
204,458,784!
49
  }
50
  return 0;
5,360,582✔
51
}
52
static FORCE_INLINE int32_t metatInitDefaultSColCmprWrapper(SDecoder *pDecoder, SColCmprWrapper *pCmpr,
53
                                                            SSchemaWrapper *pSchema) {
54
  pCmpr->nCols = pSchema->nCols;
8,762,633✔
55
  if ((pCmpr->pColCmpr = (SColCmpr *)tDecoderMalloc(pDecoder, pCmpr->nCols * sizeof(SColCmpr))) == NULL) {
8,761,528!
UNCOV
56
    return terrno;
×
57
  }
58

59
  for (int32_t i = 0; i < pCmpr->nCols; i++) {
226,872,057!
60
    SColCmpr *pColCmpr = &pCmpr->pColCmpr[i];
218,215,564✔
61
    SSchema  *pColSchema = &pSchema->pSchema[i];
218,215,564✔
62
    pColCmpr->id = pColSchema->colId;
218,215,564✔
63
    pColCmpr->alg = createDefaultColCmprByType(pColSchema->type);
218,215,564✔
64
  }
65
  return 0;
8,656,493✔
66
}
67

68
int metaEncodeEntry(SEncoder *pCoder, const SMetaEntry *pME) {
583,406✔
69
  TAOS_CHECK_RETURN(tStartEncode(pCoder));
583,406✔
70
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->version));
1,167,622!
71
  TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->type));
1,167,622!
72
  TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->uid));
1,167,622!
73

74
  if (pME->name == NULL) {
583,811!
75
    return TSDB_CODE_INVALID_PARA;
×
76
  }
77

78
  TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->name));
1,167,622!
79

80
  if (pME->type == TSDB_SUPER_TABLE) {
583,811✔
81
    TAOS_CHECK_RETURN(tEncodeI8(pCoder, pME->flags));
151,936!
82
    TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaRow));
151,936!
83
    TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->stbEntry.schemaTag));
151,936!
84
    if (TABLE_IS_ROLLUP(pME->flags)) {
75,968✔
85
      TAOS_CHECK_RETURN(tEncodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
14!
86
    }
87
  } else if (pME->type == TSDB_CHILD_TABLE) {
507,843✔
88
    TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.btime));
950,294!
89
    TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ctbEntry.ttlDays));
950,294!
90
    TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ctbEntry.commentLen));
950,294!
91
    if (pME->ctbEntry.commentLen > 0) {
475,147✔
92
      TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ctbEntry.comment));
156!
93
    }
94
    TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ctbEntry.suid));
950,294!
95
    TAOS_CHECK_RETURN(tEncodeTag(pCoder, (const STag *)pME->ctbEntry.pTags));
475,147!
96
  } else if (pME->type == TSDB_NORMAL_TABLE) {
32,696✔
97
    TAOS_CHECK_RETURN(tEncodeI64(pCoder, pME->ntbEntry.btime));
65,108!
98
    TAOS_CHECK_RETURN(tEncodeI32(pCoder, pME->ntbEntry.ttlDays));
65,108!
99
    TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.commentLen));
65,108!
100
    if (pME->ntbEntry.commentLen > 0) {
32,554✔
101
      TAOS_CHECK_RETURN(tEncodeCStr(pCoder, pME->ntbEntry.comment));
156!
102
    }
103
    TAOS_CHECK_RETURN(tEncodeI32v(pCoder, pME->ntbEntry.ncid));
65,108!
104
    TAOS_CHECK_RETURN(tEncodeSSchemaWrapper(pCoder, &pME->ntbEntry.schemaRow));
65,108!
105
  } else if (pME->type == TSDB_TSMA_TABLE) {
142✔
106
    TAOS_CHECK_RETURN(tEncodeTSma(pCoder, pME->smaEntry.tsma));
66!
107
  } else {
108
    metaError("meta/entry: invalide table type: %" PRId8 " encode failed.", pME->type);
76!
109
    return TSDB_CODE_INVALID_PARA;
×
110
  }
111
  TAOS_CHECK_RETURN(meteEncodeColCmprEntry(pCoder, pME));
583,696!
112

113
  tEndEncode(pCoder);
583,602✔
114
  return 0;
583,616✔
115
}
116

117
int metaDecodeEntry(SDecoder *pCoder, SMetaEntry *pME) {
19,252,514✔
118
  TAOS_CHECK_RETURN(tStartDecode(pCoder));
19,252,514!
119
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->version));
38,543,395!
120
  TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->type));
38,535,636!
121
  TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->uid));
38,531,803!
122
  TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->name));
38,519,134!
123

124
  if (pME->type == TSDB_SUPER_TABLE) {
19,255,472✔
125
    TAOS_CHECK_RETURN(tDecodeI8(pCoder, &pME->flags));
26,559,534!
126
    TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaRow));
26,470,006!
127
    TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->stbEntry.schemaTag));
26,423,713!
128
    if (TABLE_IS_ROLLUP(pME->flags)) {
13,236,083✔
129
      TAOS_CHECK_RETURN(tDecodeSRSmaParam(pCoder, &pME->stbEntry.rsmaParam));
268!
130
    }
131
  } else if (pME->type == TSDB_CHILD_TABLE) {
5,978,314✔
132
    TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.btime));
10,251,668!
133
    TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ctbEntry.ttlDays));
10,251,191!
134
    TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ctbEntry.commentLen));
10,250,857!
135
    if (pME->ctbEntry.commentLen > 0) {
5,125,248✔
136
      TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ctbEntry.comment));
266!
137
    }
138
    TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ctbEntry.suid));
10,250,368!
139
    TAOS_CHECK_RETURN(tDecodeTag(pCoder, (STag **)&pME->ctbEntry.pTags));
5,125,120!
140
  } else if (pME->type == TSDB_NORMAL_TABLE) {
852,228!
141
    TAOS_CHECK_RETURN(tDecodeI64(pCoder, &pME->ntbEntry.btime));
1,711,865!
142
    TAOS_CHECK_RETURN(tDecodeI32(pCoder, &pME->ntbEntry.ttlDays));
1,711,738!
143
    TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.commentLen));
1,711,644!
144
    if (pME->ntbEntry.commentLen > 0) {
855,729✔
145
      TAOS_CHECK_RETURN(tDecodeCStr(pCoder, &pME->ntbEntry.comment));
316!
146
    }
147
    TAOS_CHECK_RETURN(tDecodeI32v(pCoder, &pME->ntbEntry.ncid));
1,711,300!
148
    TAOS_CHECK_RETURN(tDecodeSSchemaWrapperEx(pCoder, &pME->ntbEntry.schemaRow));
1,708,863!
149
  } else if (pME->type == TSDB_TSMA_TABLE) {
×
150
    pME->smaEntry.tsma = tDecoderMalloc(pCoder, sizeof(STSma));
4✔
151
    if (!pME->smaEntry.tsma) {
4!
152
      return terrno;
×
153
    }
154
    TAOS_CHECK_RETURN(tDecodeTSma(pCoder, pME->smaEntry.tsma, true));
4!
155
  } else {
156
    metaError("meta/entry: invalide table type: %" PRId8 " decode failed.", pME->type);
×
157
    return TSDB_CODE_INVALID_PARA;
×
158
  }
159
  if (pME->type == TSDB_SUPER_TABLE) {
19,260,575✔
160
    if (TABLE_IS_COL_COMPRESSED(pME->flags)) {
13,279,812✔
161
      TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
4,517,094!
162

163
      if (pME->colCmpr.nCols == 0) {
4,518,107!
164
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
×
165
      }
166
    } else {
167
      TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->stbEntry.schemaRow));
17,419,211!
168
      TABLE_SET_COL_COMPRESSED(pME->flags);
8,656,493✔
169
    }
170
  } else if (pME->type == TSDB_NORMAL_TABLE) {
5,980,763✔
171
    if (!tDecodeIsEnd(pCoder)) {
856,001!
172
      uDebug("set type: %d, tableName:%s", pME->type, pME->name);
856,086✔
173
      TAOS_CHECK_RETURN(meteDecodeColCmprEntry(pCoder, pME));
856,091✔
174
      if (pME->colCmpr.nCols == 0) {
855,979!
175
        TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
176
      }
177
    } else {
178
      uDebug("set default type: %d, tableName:%s", pME->type, pME->name);
×
179
      TAOS_CHECK_RETURN(metatInitDefaultSColCmprWrapper(pCoder, &pME->colCmpr, &pME->ntbEntry.schemaRow));
×
180
    }
181
    TABLE_SET_COL_COMPRESSED(pME->flags);
855,979✔
182
  }
183

184
  tEndDecode(pCoder);
19,155,341✔
185
  return 0;
19,258,712✔
186
}
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc