11746464759

Committed 08 Nov 2024 05:11PM UTC coverage: 75.337% (-0.2%) from 75.582%

Build # 11746464759

Build Type

push

github

Committed by

web-flow

Commit Message

chore(core): Continued simplification of CanvasContext and AnimationLoop (#2286)

Run Details

2017 of 2644 branches covered (76.29%)

Branch coverage included in aggregate %.

67 of 87 new or added lines in 7 files covered. (77.01%)

80 existing lines in 2 files now uncovered.

26226 of 34845 relevant lines covered (75.26%)

50.21 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

13.86

/modules/engine/src/modules/picking/legacy-picking-manager.ts

// luma.gl
// SPDX-License-Identifier: MIT
// Copyright (c) vis.gl contributors

import {Device, Framebuffer} from '@luma.gl/core';
import {picking} from '@luma.gl/shadertools';
import {ShaderInputs} from '../../shader-inputs';
import {NumberArray3} from '@math.gl/types';

/**
 * Helper class for using the legacy picking module
 */
export class LegacyPickingManager {
  device: Device;
  framebuffer: Framebuffer | null = null;
  shaderInputs: ShaderInputs<{picking: typeof picking.props}>;

  constructor(device: Device, shaderInputs: ShaderInputs) {
    this.device = device;
    this.shaderInputs = shaderInputs as ShaderInputs<{picking: typeof picking.props}>;
  }

  destroy() {
    this.framebuffer?.destroy();
  }

  getFramebuffer() {
    if (!this.framebuffer) {
      this.framebuffer = this.device.createFramebuffer({
        colorAttachments: ['rgba8unorm'],
        depthStencilAttachment: 'depth24plus'
      });
    }
    return this.framebuffer;
  }

  /** Clear highlighted / picked object */
  clearPickState() {
    this.shaderInputs.setProps({picking: {highlightedObjectColor: null}});
  }

  /** Prepare for rendering picking colors */
  beginRenderPass() {
    const framebuffer = this.getFramebuffer();
    framebuffer.resize(this.device.getCanvasContext().getDevicePixelSize());

    this.shaderInputs.setProps({picking: {isActive: true}});

    const pickingPass = this.device.beginRenderPass({
      framebuffer,
      clearColor: [0, 0, 0, 0],
      clearDepth: 1
    });

    return pickingPass;
  }

  updatePickState(mousePosition: [number, number]) {
    const framebuffer = this.getFramebuffer();

    // use the center pixel location in device pixel range
    const [pickX, pickY] = this.getPickPosition(mousePosition);

    // Read back
    const color255 = this.device.readPixelsToArrayWebGL(framebuffer, {
      sourceX: pickX,
      sourceY: pickY,
      sourceWidth: 1,
      sourceHeight: 1
    });
    // console.log(color255);

    // Check if we have
    let highlightedObjectColor: NumberArray3 | null = [...color255].map(
      x => x / 255
    ) as NumberArray3;
    const isHighlightActive =
      highlightedObjectColor[0] + highlightedObjectColor[1] + highlightedObjectColor[2] > 0;

    if (!isHighlightActive) {
      highlightedObjectColor = null;
    }

    this.shaderInputs.setProps({
      picking: {isActive: false, highlightedObjectColor}
    });
  }

  /**
   * Get pick position in device pixel range
   * use the center pixel location in device pixel range
   */
  getPickPosition(mousePosition: [number, number]): [number, number] {
    const devicePixels = this.device.getCanvasContext().cssToDevicePixels(mousePosition);
    const pickX = devicePixels.x + Math.floor(devicePixels.width / 2);
    const pickY = devicePixels.y + Math.floor(devicePixels.height / 2);
    return [pickX, pickY];
  }
}

1	// luma.gl	1✔
2	// SPDX-License-Identifier: MIT	1✔
3	// Copyright (c) vis.gl contributors	1✔
4		1✔
5	import {Device, Framebuffer} from '@luma.gl/core';	1✔
6	import {picking} from '@luma.gl/shadertools';	1✔
7	import {ShaderInputs} from '../../shader-inputs';	1✔
8	import {NumberArray3} from '@math.gl/types';	1✔
9		1✔
10	/**	1✔
11	* Helper class for using the legacy picking module	1✔
12	*/	1✔
13	export class LegacyPickingManager {	1!
14	device: Device;	×
15	framebuffer: Framebuffer \| null = null;	×
16	shaderInputs: ShaderInputs<{picking: typeof picking.props}>;	×
17		×
18	constructor(device: Device, shaderInputs: ShaderInputs) {	×
19	this.device = device;	×
20	this.shaderInputs = shaderInputs as ShaderInputs<{picking: typeof picking.props}>;	×
21	}	×
22		×
23	destroy() {	×
24	this.framebuffer?.destroy();	×
25	}	×
26		×
27	getFramebuffer() {	×
28	if (!this.framebuffer) {	×
29	this.framebuffer = this.device.createFramebuffer({	×
30	colorAttachments: ['rgba8unorm'],	×
31	depthStencilAttachment: 'depth24plus'	×
32	});	×
33	}	×
34	return this.framebuffer;	×
35	}	×
36		×
37	/** Clear highlighted / picked object */	×
38	clearPickState() {	×
39	this.shaderInputs.setProps({picking: {highlightedObjectColor: null}});	×
40	}	×
41		×
42	/** Prepare for rendering picking colors */	×
43	beginRenderPass() {	×
44	const framebuffer = this.getFramebuffer();	×
NEW 45	framebuffer.resize(this.device.getCanvasContext().getDevicePixelSize());	×
46		×
47	this.shaderInputs.setProps({picking: {isActive: true}});	×
48		×
49	const pickingPass = this.device.beginRenderPass({	×
50	framebuffer,	×
51	clearColor: [0, 0, 0, 0],	×
52	clearDepth: 1	×
53	});	×
54		×
55	return pickingPass;	×
56	}	×
57		×
58	updatePickState(mousePosition: [number, number]) {	×
59	const framebuffer = this.getFramebuffer();	×
60		×
61	// use the center pixel location in device pixel range	×
62	const [pickX, pickY] = this.getPickPosition(mousePosition);	×
63		×
64	// Read back	×
65	const color255 = this.device.readPixelsToArrayWebGL(framebuffer, {	×
66	sourceX: pickX,	×
67	sourceY: pickY,	×
68	sourceWidth: 1,	×
69	sourceHeight: 1	×
70	});	×
71	// console.log(color255);	×
72		×
73	// Check if we have	×
74	let highlightedObjectColor: NumberArray3 \| null = [...color255].map(	×
75	x => x / 255	×
76	) as NumberArray3;	×
77	const isHighlightActive =	×
78	highlightedObjectColor[0] + highlightedObjectColor[1] + highlightedObjectColor[2] > 0;	×
79		×
80	if (!isHighlightActive) {	×
81	highlightedObjectColor = null;	×
82	}	×
83		×
84	this.shaderInputs.setProps({	×
85	picking: {isActive: false, highlightedObjectColor}	×
86	});	×
87	}	×
88		×
89	/**	×
90	* Get pick position in device pixel range	×
91	* use the center pixel location in device pixel range	×
92	*/	×
93	getPickPosition(mousePosition: [number, number]): [number, number] {	×
94	const devicePixels = this.device.getCanvasContext().cssToDevicePixels(mousePosition);	×
95	const pickX = devicePixels.x + Math.floor(devicePixels.width / 2);	×
96	const pickY = devicePixels.y + Math.floor(devicePixels.height / 2);	×
97	return [pickX, pickY];	×
98	}	×
99	}	×

visgl / luma.gl / 11746464759

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous