11665554436

Committed 04 Nov 2024 01:49PM UTC coverage: 64.661% (+0.04%) from 64.626%

Build # 11665554436

Build Type

Pull #14807

github

Committed by

web-flow

Commit Message

Merge 8ea3723d0 into 43fd49b33

Pull Request Pull Request #14807: rec: drop ref in mtasker when it is no longer needed

Run Details

37150 of 88268 branches covered (42.09%)

Branch coverage included in aggregate %.

62 of 67 new or added lines in 2 files covered. (92.54%)

35 existing lines in 11 files now uncovered.

124881 of 162317 relevant lines covered (76.94%)

5250724.43 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

71.85

/pdns/communicator.cc

/*
 * This file is part of PowerDNS or dnsdist.
 * Copyright -- PowerDNS.COM B.V. and its contributors
 *
 * This program is free software; you can redistribute it and/or modify
 * it under the terms of version 2 of the GNU General Public License as
 * published by the Free Software Foundation.
 *
 * In addition, for the avoidance of any doubt, permission is granted to
 * link this program with OpenSSL and to (re)distribute the binaries
 * produced as the result of such linking.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 *
 * You should have received a copy of the GNU General Public License
 * along with this program; if not, write to the Free Software
 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 */
#ifdef HAVE_CONFIG_H
#include "config.h"
#endif

#include <set>
#include <thread>
#include <boost/utility.hpp>

#include "packetcache.hh"
#include "utility.hh"
#include "communicator.hh"
#include "dnsbackend.hh"
#include "ueberbackend.hh"
#include "packethandler.hh"
#include "logger.hh"
#include "dns.hh"
#include "arguments.hh"
#include "packetcache.hh"
#include "threadname.hh"

// there can be MANY OF THESE
void CommunicatorClass::retrievalLoopThread()
{
  setThreadName("pdns/comm-retri");
  for (;;) {
    d_suck_sem.wait();
    SuckRequest sr;
    {
      auto data = d_data.lock();
      if (data->d_suckdomains.empty()) {
        continue;
      }

      auto firstItem = data->d_suckdomains.begin();

      sr = *firstItem;
      data->d_suckdomains.erase(firstItem);
      if (data->d_suckdomains.empty()) {
        data->d_sorthelper = 0;
      }
    }
    suck(sr.domain, sr.primary, sr.force);
  }
}

void CommunicatorClass::loadArgsIntoSet(const char* listname, set<string>& listset)
{
  vector<string> parts;
  stringtok(parts, ::arg()[listname], ", \t");
  for (const auto& part : parts) {
    try {
      ComboAddress caIp(part, 53);
      listset.insert(caIp.toStringWithPort());
    }
    catch (PDNSException& e) {
      g_log << Logger::Error << "Unparseable IP in " << listname << ". Error: " << e.reason << endl;
      _exit(1);
    }
  }
}

void CommunicatorClass::go()
{
  try {
    PacketHandler::s_allowNotifyFrom.toMasks(::arg()["allow-notify-from"]);
  }
  catch (PDNSException& e) {
    g_log << Logger::Error << "Unparseable IP in allow-notify-from. Error: " << e.reason << endl;
    _exit(1);
  }

  std::thread mainT([this]() { mainloop(); });
  mainT.detach();

  for (int nthreads = 0; nthreads < ::arg().asNum("retrieval-threads", 1); ++nthreads) {
    std::thread retrieve([this]() { retrievalLoopThread(); });
    retrieve.detach();
  }

  d_preventSelfNotification = ::arg().mustDo("prevent-self-notification");

  auto delay = ::arg().asNum("delay-notifications");
  if (delay > 0) {
    d_delayNotifications = static_cast<time_t>(delay);
  }

  try {
    d_onlyNotify.toMasks(::arg()["only-notify"]);
  }
  catch (PDNSException& e) {
    g_log << Logger::Error << "Unparseable IP in only-notify. Error: " << e.reason << endl;
    _exit(1);
  }

  loadArgsIntoSet("also-notify", d_alsoNotify);

  loadArgsIntoSet("forward-notify", PacketHandler::s_forwardNotify);
}

void CommunicatorClass::mainloop()
{
  try {
    setThreadName("pdns/comm-main");
    signal(SIGPIPE, SIG_IGN);
    g_log << Logger::Warning << "Primary/secondary communicator launching" << endl;

    d_tickinterval = ::arg().asNum("xfr-cycle-interval");

    int rc;
    time_t next;
    PacketHandler P;

    makeNotifySockets();

    for (;;) {
      secondaryRefresh(&P);
      primaryUpdateCheck(&P);
      doNotifications(&P); // this processes any notification acknowledgements and actually send out our own notifications

      next = time(nullptr) + d_tickinterval;

      while (time(nullptr) < next) {
        rc = d_any_sem.tryWait();

        if (rc != 0) {
          bool extraSecondaryRefresh = false;
          Utility::sleep(1);
          {
            auto data = d_data.lock();
            if (data->d_tocheck.size()) {
              extraSecondaryRefresh = true;
            }
          }
          if (extraSecondaryRefresh)
            secondaryRefresh(&P);
        }
        else {
          // eat up extra posts to avoid busy looping if many posts were done
          while (d_any_sem.tryWait() == 0) {
          }
          break; // something happened
        }
        // this gets executed about once per second
        doNotifications(&P);
      }
    }
  }
  catch (PDNSException& ae) {
    g_log << Logger::Error << "Exiting because communicator thread died with error: " << ae.reason << endl;
    Utility::sleep(1);
    _exit(1);
  }
  catch (std::exception& e) {
    g_log << Logger::Error << "Exiting because communicator thread died with STL error: " << e.what() << endl;
    _exit(1);
  }
  catch (...) {
    g_log << Logger::Error << "Exiting because communicator caught unknown exception." << endl;
    _exit(1);
  }
}

1	/*
2	* This file is part of PowerDNS or dnsdist.
3	* Copyright -- PowerDNS.COM B.V. and its contributors
4	*
5	* This program is free software; you can redistribute it and/or modify
6	* it under the terms of version 2 of the GNU General Public License as
7	* published by the Free Software Foundation.
8	*
9	* In addition, for the avoidance of any doubt, permission is granted to
10	* link this program with OpenSSL and to (re)distribute the binaries
11	* produced as the result of such linking.
12	*
13	* This program is distributed in the hope that it will be useful,
14	* but WITHOUT ANY WARRANTY; without even the implied warranty of
15	* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16	* GNU General Public License for more details.
17	*
18	* You should have received a copy of the GNU General Public License
19	* along with this program; if not, write to the Free Software
20	* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21	*/
22	#ifdef HAVE_CONFIG_H
23	#include "config.h"
24	#endif
25
26	#include <set>
27	#include <thread>
28	#include <boost/utility.hpp>
29
30	#include "packetcache.hh"
31	#include "utility.hh"
32	#include "communicator.hh"
33	#include "dnsbackend.hh"
34	#include "ueberbackend.hh"
35	#include "packethandler.hh"
36	#include "logger.hh"
37	#include "dns.hh"
38	#include "arguments.hh"
39	#include "packetcache.hh"
40	#include "threadname.hh"
41
42	// there can be MANY OF THESE
43	void CommunicatorClass::retrievalLoopThread()
44	{	240✔
45	setThreadName("pdns/comm-retri");	240✔
46	for (;;) {	688✔
47	d_suck_sem.wait();	688✔
48	SuckRequest sr;	688✔
49	{	688✔
50	auto data = d_data.lock();	688✔
51	if (data->d_suckdomains.empty()) {	688!
52	continue;	×
53	}	×
54
55	auto firstItem = data->d_suckdomains.begin();	688✔
56
57	sr = *firstItem;	688✔
58	data->d_suckdomains.erase(firstItem);	688✔
59	if (data->d_suckdomains.empty()) {	688✔
60	data->d_sorthelper = 0;	122✔
61	}	122✔
62	}	688✔
63	suck(sr.domain, sr.primary, sr.force);	×
64	}	688✔
65	}	240✔
66
67	void CommunicatorClass::loadArgsIntoSet(const char* listname, set<string>& listset)
68	{	216✔
69	vector<string> parts;	216✔
70	stringtok(parts, ::arg()[listname], ", \t");	216✔
71	for (const auto& part : parts) {	216!
72	try {	×
73	ComboAddress caIp(part, 53);	×
74	listset.insert(caIp.toStringWithPort());	×
75	}	×
76	catch (PDNSException& e) {	×
77	g_log << Logger::Error << "Unparseable IP in " << listname << ". Error: " << e.reason << endl;	×
78	_exit(1);	×
79	}	×
80	}	×
81	}	216✔
82
83	void CommunicatorClass::go()
84	{	108✔
85	try {	108✔
86	PacketHandler::s_allowNotifyFrom.toMasks(::arg()["allow-notify-from"]);	108✔
87	}	108✔
88	catch (PDNSException& e) {	108✔
89	g_log << Logger::Error << "Unparseable IP in allow-notify-from. Error: " << e.reason << endl;	×
90	_exit(1);	×
91	}	×
92
93	std::thread mainT([this]() { mainloop(); });	108✔
94	mainT.detach();	108✔
95
96	for (int nthreads = 0; nthreads < ::arg().asNum("retrieval-threads", 1); ++nthreads) {	348✔
97	std::thread retrieve([this]() { retrievalLoopThread(); });	240✔
98	retrieve.detach();	240✔
99	}	240✔
100
101	d_preventSelfNotification = ::arg().mustDo("prevent-self-notification");	108✔
102
103	auto delay = ::arg().asNum("delay-notifications");	108✔
104	if (delay > 0) {	108!
105	d_delayNotifications = static_cast<time_t>(delay);	×
106	}	×
107
108	try {	108✔
109	d_onlyNotify.toMasks(::arg()["only-notify"]);	108✔
110	}	108✔
111	catch (PDNSException& e) {	108✔
112	g_log << Logger::Error << "Unparseable IP in only-notify. Error: " << e.reason << endl;	×
113	_exit(1);	×
114	}	×
115
116	loadArgsIntoSet("also-notify", d_alsoNotify);	108✔
117
118	loadArgsIntoSet("forward-notify", PacketHandler::s_forwardNotify);	108✔
119	}	108✔
120
121	void CommunicatorClass::mainloop()
122	{	108✔
123	try {	108✔
124	setThreadName("pdns/comm-main");	108✔
125	signal(SIGPIPE, SIG_IGN);	108✔
126	g_log << Logger::Warning << "Primary/secondary communicator launching" << endl;	108✔
127
128	d_tickinterval = ::arg().asNum("xfr-cycle-interval");	108✔
129
130	int rc;	108✔
131	time_t next;	108✔
132	PacketHandler P;	108✔
133
134	makeNotifySockets();	108✔
135
136	for (;;) {	134✔
137	secondaryRefresh(&P);	134✔
138	primaryUpdateCheck(&P);	134✔
139	doNotifications(&P); // this processes any notification acknowledgements and actually send out our own notifications	134✔
140
141	next = time(nullptr) + d_tickinterval;	134✔
142
143	while (time(nullptr) < next) {	2,339✔
144	rc = d_any_sem.tryWait();	2,209✔
145
146	if (rc != 0) {	2,209✔
147	bool extraSecondaryRefresh = false;	2,205✔
148	Utility::sleep(1);	2,205✔
149	{	2,205✔
150	auto data = d_data.lock();	2,205✔
151	if (data->d_tocheck.size()) {	2,205!
UNCOV 152	extraSecondaryRefresh = true;	×
UNCOV 153	}	×
154	}	2,205✔
155	if (extraSecondaryRefresh)	2,205!
UNCOV 156	secondaryRefresh(&P);	×
157	}	2,205✔
158	else {	4✔
159	// eat up extra posts to avoid busy looping if many posts were done
160	while (d_any_sem.tryWait() == 0) {	6✔
161	}	2✔
162	break; // something happened	4✔
163	}	4✔
164	// this gets executed about once per second
165	doNotifications(&P);	2,205✔
166	}	2,205✔
167	}	134✔
168	}	108✔
169	catch (PDNSException& ae) {	108✔
170	g_log << Logger::Error << "Exiting because communicator thread died with error: " << ae.reason << endl;	×
171	Utility::sleep(1);	×
172	_exit(1);	×
173	}	×
174	catch (std::exception& e) {	108✔
175	g_log << Logger::Error << "Exiting because communicator thread died with STL error: " << e.what() << endl;	×
176	_exit(1);	×
177	}	×
178	catch (...) {	108✔
179	g_log << Logger::Error << "Exiting because communicator caught unknown exception." << endl;	×
180	_exit(1);	×
181	}	×
182	}	108✔

PowerDNS / pdns / 11665554436

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous