11599096886

Committed 30 Oct 2024 06:06PM UTC coverage: 31.328% (-0.005%) from 31.333%

Build # 11599096886

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9918 from ForumMagnum/noDuplicates

No Duplicate Jargons

Run Details

5031 of 42392 branches covered (11.87%)

Branch coverage included in aggregate %.

3 of 19 new or added lines in 2 files covered. (15.79%)

1 existing line in 1 file now uncovered.

29647 of 68303 relevant lines covered (43.41%)

173.83 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

21.74

/packages/lesswrong/components/jargon/GlossaryEditorPage.tsx

// TODO: Import component in components.ts
import React from 'react';
import { Components, registerComponent } from '../../lib/vulcan-lib';
import { useMulti } from '@/lib/crud/withMulti';
import { useCurrentUser } from '../common/withUser';
import { userWillPassivelyGenerateJargonTerms } from '@/lib/betas';
import { useLocation } from '@/lib/routeUtil';

const styles = (theme: ThemeType) => ({
  root: {
    ...theme.typography.commentStyle
  },
  glossary: {
    marginTop: 4,
    background: theme.palette.background.pageActiveAreaBackground,
    padding: theme.spacing.unit * 2,
    paddingBottom: theme.spacing.unit * 4,
  },
  post: {
    marginBottom: theme.spacing.unit * 4,
  }
});

export const GlossaryEditorPage = ({classes}: {
  classes: ClassesType<typeof styles>,
}) => {
  const currentUser = useCurrentUser();

  const { query } = useLocation();
  const limit = query.limit ? parseInt(query.limit) : 5;
  const showAll = query.all === 'true' && currentUser?.isAdmin;
  const view: PostsViewName = ["new", "top"].includes(query.view ?? '') ? query.view as PostsViewName : 'new'

  const { results: posts = [], loadMoreProps, refetch } = useMulti({
    terms: {
      view: "top",
      userId: showAll ? undefined : currentUser?._id,
      limit: limit
    },
    itemsPerPage: 50,
    collectionName: "Posts",
    fragmentName: 'PostsPage',
  })

  const { GlossaryEditForm, SingleColumnSection, PostsTitle, LoadMore, SectionTitle, ContentStyles, ErrorAccessDenied, Row, UsersNameDisplay } = Components
  

  if (!currentUser) {
    return <SingleColumnSection><ErrorAccessDenied/></SingleColumnSection>;
  }
  if (!userWillPassivelyGenerateJargonTerms(currentUser)) {
    return <SingleColumnSection>
      Currently, the Glossary Editor is only available to users with over 100 karma.
    </SingleColumnSection>;
  }

  return <div className={classes.root}>
    <SingleColumnSection>
      <SectionTitle title="Glossary Editor" />
      <ContentStyles contentType="post">
        <><p>Edit the glossary for your posts.</p><br/><br/></>
      </ContentStyles>
      {posts.map(post => <div key={post._id} className={classes.post}>
        <Row justifyContent="space-between">
          <PostsTitle post={post} showIcons={false}/>
          {showAll && <UsersNameDisplay user={post.user}/>}
        </Row>
        <div className={classes.glossary}>
          <GlossaryEditForm document={post} showTitle={false}/>
        </div>
      </div>)}
      {posts.length === 0 && <div>No posts found</div>}
      <LoadMore {...loadMoreProps} />
    </SingleColumnSection>
  </div>;
}

const GlossaryEditorPageComponent = registerComponent('GlossaryEditorPage', GlossaryEditorPage, {styles});

declare global {
  interface ComponentTypes {
    GlossaryEditorPage: typeof GlossaryEditorPageComponent
  }
}

1	// TODO: Import component in components.ts	3✔
2	import React from 'react';	1✔
3	import { Components, registerComponent } from '../../lib/vulcan-lib';	1✔
4	import { useMulti } from '@/lib/crud/withMulti';	1✔
5	import { useCurrentUser } from '../common/withUser';	1✔
6	import { userWillPassivelyGenerateJargonTerms } from '@/lib/betas';	1✔
7	import { useLocation } from '@/lib/routeUtil';	1✔
8
9	const styles = (theme: ThemeType) => ({	1✔
10	root: {
11	...theme.typography.commentStyle
12	},
13	glossary: {
14	marginTop: 4,
15	background: theme.palette.background.pageActiveAreaBackground,
16	padding: theme.spacing.unit * 2,
17	paddingBottom: theme.spacing.unit * 4,
18	},
19	post: {
20	marginBottom: theme.spacing.unit * 4,
21	}
22	});
23
24	export const GlossaryEditorPage = ({classes}: {	1✔
25	classes: ClassesType<typeof styles>,
26	}) => {
27	const currentUser = useCurrentUser();	×
28
NEW 29	const { query } = useLocation();	×
NEW 30	const limit = query.limit ? parseInt(query.limit) : 5;	×
NEW 31	const showAll = query.all === 'true' && currentUser?.isAdmin;	×
NEW 32	const view: PostsViewName = ["new", "top"].includes(query.view ?? '') ? query.view as PostsViewName : 'new'	×
33
UNCOV 34	const { results: posts = [], loadMoreProps, refetch } = useMulti({	×
35	terms: {
36	view: "top",
37	userId: showAll ? undefined : currentUser?._id,	×
38	limit: limit
39	},
40	itemsPerPage: 50,
41	collectionName: "Posts",
42	fragmentName: 'PostsPage',
43	})
44
NEW 45	const { GlossaryEditForm, SingleColumnSection, PostsTitle, LoadMore, SectionTitle, ContentStyles, ErrorAccessDenied, Row, UsersNameDisplay } = Components	×
46
47
48	if (!currentUser) {	×
49	return <SingleColumnSection><ErrorAccessDenied/></SingleColumnSection>;	×
50	}
51	if (!userWillPassivelyGenerateJargonTerms(currentUser)) {	×
52	return <SingleColumnSection>	×
53	Currently, the Glossary Editor is only available to users with over 100 karma.
54	</SingleColumnSection>;
55	}
56
57	return <div className={classes.root}>	×
58	<SingleColumnSection>
59	<SectionTitle title="Glossary Editor" />
60	<ContentStyles contentType="post">
61	<><p>Edit the glossary for your posts.</p><br/><br/></>
62	</ContentStyles>
63	{posts.map(post => <div key={post._id} className={classes.post}>	×
64	<Row justifyContent="space-between">
65	<PostsTitle post={post} showIcons={false}/>
66	{showAll && <UsersNameDisplay user={post.user}/>}	×
67	</Row>
68	<div className={classes.glossary}>
69	<GlossaryEditForm document={post} showTitle={false}/>
70	</div>
71	</div>)}
72	{posts.length === 0 && <div>No posts found</div>}	×
73	<LoadMore {...loadMoreProps} />
74	</SingleColumnSection>
75	</div>;
76	}
77
78	const GlossaryEditorPageComponent = registerComponent('GlossaryEditorPage', GlossaryEditorPage, {styles});	1✔
79
80	declare global {
81	interface ComponentTypes {
82	GlossaryEditorPage: typeof GlossaryEditorPageComponent
83	}
84	}

ForumMagnum / ForumMagnum / 11599096886

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous