11577992356

Committed 29 Oct 2024 04:11PM UTC coverage: 89.15% (+0.04%) from 89.111%

Build # 11577992356

Build Type

Pull #2079

github

Committed by

iamacook

Commit Message

Type Swap-related responses as "raw"

Pull Request Pull Request #2079: Type Swap-related responses as "raw"

Run Details

2615 of 3280 branches covered (79.73%)

Branch coverage included in aggregate %.

2 of 3 new or added lines in 1 file covered. (66.67%)

1 existing line in 1 file now uncovered.

8872 of 9605 relevant lines covered (92.37%)

401.05 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

68.42

/src/datasources/swaps-api/cowswap-api.service.ts

import type { INetworkService } from '@/datasources/network/network.service.interface';
import type { Order } from '@/domain/swaps/entities/order.entity';
import type { ISwapsApi } from '@/domain/interfaces/swaps-api.interface';
import type { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
import type { FullAppData } from '@/domain/swaps/entities/full-app-data.entity';
import type { Raw } from '@/validation/entities/raw.entity';

/**
 * TODO: Move all usage of Raw to NetworkService after fully migrated
 * to "Raw" type implementation.
 */
export class CowSwapApi implements ISwapsApi {
  constructor(
    private readonly baseUrl: string,
    private readonly networkService: INetworkService,
    private readonly httpErrorFactory: HttpErrorFactory,
  ) {}

  async getOrder(uid: string): Promise<Raw<Order>> {
    try {
      const url = `${this.baseUrl}/api/v1/orders/${uid}`;
      const { data } = await this.networkService.get<Raw<Order>>({ url });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }

  async getOrders(txHash: string): Promise<Raw<Array<Order>>> {
    try {
      const url = `${this.baseUrl}/api/v1/transactions/${txHash}/orders`;
      const { data } = await this.networkService.get<Raw<Array<Order>>>({
        url,
      });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }

  async getFullAppData(appDataHash: `0x${string}`): Promise<Raw<FullAppData>> {
    try {
      const url = `${this.baseUrl}/api/v1/app_data/${appDataHash}`;
      const { data } = await this.networkService.get<Raw<FullAppData>>({ url });
      return data;
    } catch (error) {
      throw this.httpErrorFactory.from(error);
    }
  }
}

1	import type { INetworkService } from '@/datasources/network/network.service.interface';
2	import type { Order } from '@/domain/swaps/entities/order.entity';
3	import type { ISwapsApi } from '@/domain/interfaces/swaps-api.interface';
4	import type { HttpErrorFactory } from '@/datasources/errors/http-error-factory';
5	import type { FullAppData } from '@/domain/swaps/entities/full-app-data.entity';
6	import type { Raw } from '@/validation/entities/raw.entity';
7
8	/**
9	* TODO: Move all usage of Raw to NetworkService after fully migrated
10	* to "Raw" type implementation.
11	*/
12	export class CowSwapApi implements ISwapsApi {	126✔
13	constructor(
14	private readonly baseUrl: string,	42✔
15	private readonly networkService: INetworkService,	42✔
16	private readonly httpErrorFactory: HttpErrorFactory,	42✔
17	) {}
18
19	async getOrder(uid: string): Promise<Raw<Order>> {
20	try {	30✔
21	const url = `${this.baseUrl}/api/v1/orders/${uid}`;	30✔
22	const { data } = await this.networkService.get<Raw<Order>>({ url });	30✔
23	return data;	26✔
24	} catch (error) {
25	throw this.httpErrorFactory.from(error);	4✔
26	}
27	}
28
29	async getOrders(txHash: string): Promise<Raw<Array<Order>>> {
30	try {	×
31	const url = `${this.baseUrl}/api/v1/transactions/${txHash}/orders`;	×
NEW 32	const { data } = await this.networkService.get<Raw<Array<Order>>>({	×
33	url,
34	});
UNCOV 35	return data;	×
36	} catch (error) {
37	throw this.httpErrorFactory.from(error);	×
38	}
39	}
40
41	async getFullAppData(appDataHash: `0x${string}`): Promise<Raw<FullAppData>> {
42	try {	12✔
43	const url = `${this.baseUrl}/api/v1/app_data/${appDataHash}`;	12✔
44	const { data } = await this.networkService.get<Raw<FullAppData>>({ url });	12✔
45	return data;	12✔
46	} catch (error) {
47	throw this.httpErrorFactory.from(error);	×
48	}
49	}
50	}

safe-global / safe-client-gateway / 11577992356

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous