• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

randombit / botan / 11540997855

27 Oct 2024 01:42PM UTC coverage: 91.074% (-0.06%) from 91.135%
11540997855

push

github

web-flow
Merge pull request #4385 from randombit/jack/remove-old-nist-redc

Remove the BigInt based NIST reduction functions

90362 of 99218 relevant lines covered (91.07%)

9565315.37 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

96.39
/src/tests/test_ec_group.cpp
1
/*
2
* (C) 2007 Falko Strenzke
3
*     2007 Manuel Hartl
4
*     2009,2015,2018,2021 Jack Lloyd
5
*
6
* Botan is released under the Simplified BSD License (see license.txt)
7
*/
8

9
#include "tests.h"
10

11
#if defined(BOTAN_HAS_ECC_GROUP)
12
   #include <botan/bigint.h>
13
   #include <botan/data_src.h>
14
   #include <botan/ec_group.h>
15
   #include <botan/ec_point.h>
16
   #include <botan/hex.h>
17
   #include <botan/numthry.h>
18
   #include <botan/pk_keys.h>
19
   #include <botan/reducer.h>
20
   #include <botan/x509_key.h>
21
#endif
22

23
namespace Botan_Tests {
24

25
namespace {
26

27
#if defined(BOTAN_HAS_ECC_GROUP)
28

29
Botan::BigInt test_integer(Botan::RandomNumberGenerator& rng, size_t bits, const BigInt& max) {
560✔
30
   /*
31
   Produces integers with long runs of ones and zeros, for testing for
32
   carry handling problems.
33
   */
34
   Botan::BigInt x = 0;
560✔
35

36
   auto flip_prob = [](size_t i) -> double {
154,040✔
37
      if(i % 64 == 0) {
153,480✔
38
         return .5;
39
      }
40
      if(i % 32 == 0) {
150,980✔
41
         return .4;
42
      }
43
      if(i % 8 == 0) {
148,560✔
44
         return .05;
14,360✔
45
      }
46
      return .01;
47
   };
48

49
   bool active = (rng.next_byte() > 128) ? true : false;
560✔
50
   for(size_t i = 0; i != bits; ++i) {
154,040✔
51
      x <<= 1;
153,480✔
52
      x += static_cast<int>(active);
153,480✔
53

54
      const double prob = flip_prob(i);
153,480✔
55
      const double sample = double(rng.next_byte() % 100) / 100.0;  // biased
153,480✔
56

57
      if(sample < prob) {
153,480✔
58
         active = !active;
5,022✔
59
      }
60
   }
61

62
   if(max > 0) {
560✔
63
      while(x >= max) {
622✔
64
         const size_t b = x.bits() - 1;
62✔
65
         BOTAN_ASSERT(x.get_bit(b) == true, "Set");
124✔
66
         x.clear_bit(b);
62✔
67
      }
68
   }
69

70
   return x;
560✔
71
}
×
72

73
Botan::EC_Point create_random_point(Botan::RandomNumberGenerator& rng, const Botan::EC_Group& group) {
112✔
74
   const Botan::BigInt& p = group.get_p();
112✔
75
   const Botan::Modular_Reducer mod_p(p);
112✔
76

77
   for(;;) {
276✔
78
      const Botan::BigInt x = Botan::BigInt::random_integer(rng, 1, p);
194✔
79
      const Botan::BigInt x3 = mod_p.multiply(x, mod_p.square(x));
194✔
80
      const Botan::BigInt ax = mod_p.multiply(group.get_a(), x);
194✔
81
      const Botan::BigInt y = mod_p.reduce(x3 + ax + group.get_b());
388✔
82
      const Botan::BigInt sqrt_y = Botan::sqrt_modulo_prime(y, p);
194✔
83

84
      if(sqrt_y > 1) {
194✔
85
         BOTAN_ASSERT_EQUAL(mod_p.square(sqrt_y), y, "Square root is correct");
336✔
86
         return group.point(x, sqrt_y);
224✔
87
      }
88
   }
858✔
89
}
112✔
90

91
class ECC_Randomized_Tests final : public Test {
×
92
   public:
93
      std::vector<Test::Result> run() override;
94
};
95

96
std::vector<Test::Result> ECC_Randomized_Tests::run() {
1✔
97
   std::vector<Test::Result> results;
1✔
98
   for(const std::string& group_name : Botan::EC_Group::known_named_groups()) {
29✔
99
      Test::Result result("ECC randomized " + group_name);
28✔
100

101
      result.start_timer();
28✔
102

103
      auto group = Botan::EC_Group::from_name(group_name);
28✔
104

105
      const Botan::EC_Point pt = create_random_point(this->rng(), group);
28✔
106

107
      std::vector<Botan::BigInt> blind_ws;
28✔
108

109
      try {
28✔
110
         const size_t trials = (Test::run_long_tests() ? 10 : 3);
28✔
111
         for(size_t i = 0; i < trials; ++i) {
308✔
112
            const Botan::BigInt a = test_integer(rng(), group.get_order_bits(), group.get_order());
280✔
113
            const Botan::BigInt b = test_integer(rng(), group.get_order_bits(), group.get_order());
280✔
114
            const Botan::BigInt c = group.mod_order(a + b);
280✔
115

116
            const Botan::EC_Point P = pt * a;
280✔
117
            const Botan::EC_Point Q = pt * b;
280✔
118
            const Botan::EC_Point R = pt * c;
280✔
119

120
            Botan::EC_Point P1 = group.blinded_var_point_multiply(pt, a, this->rng(), blind_ws);
280✔
121
            Botan::EC_Point Q1 = group.blinded_var_point_multiply(pt, b, this->rng(), blind_ws);
280✔
122
            Botan::EC_Point R1 = group.blinded_var_point_multiply(pt, c, this->rng(), blind_ws);
280✔
123

124
            Botan::EC_Point A1 = P + Q;
280✔
125
            Botan::EC_Point A2 = Q + P;
280✔
126

127
            result.test_eq("p + q", A1, R);
280✔
128
            result.test_eq("q + p", A2, R);
280✔
129

130
            A1.force_affine();
280✔
131
            A2.force_affine();
280✔
132
            result.test_eq("p + q", A1, R);
280✔
133
            result.test_eq("q + p", A2, R);
280✔
134

135
            result.test_eq("p on the curve", P.on_the_curve(), true);
280✔
136
            result.test_eq("q on the curve", Q.on_the_curve(), true);
280✔
137
            result.test_eq("r on the curve", R.on_the_curve(), true);
280✔
138

139
            result.test_eq("P1", P1, P);
280✔
140
            result.test_eq("Q1", Q1, Q);
280✔
141
            result.test_eq("R1", R1, R);
280✔
142

143
            P1.force_affine();
280✔
144
            Q1.force_affine();
280✔
145
            R1.force_affine();
280✔
146
            result.test_eq("P1", P1, P);
280✔
147
            result.test_eq("Q1", Q1, Q);
280✔
148
            result.test_eq("R1", R1, R);
280✔
149
         }
1,120✔
150
      } catch(std::exception& e) {
×
151
         result.test_failure(group_name, e.what());
×
152
      }
×
153
      result.end_timer();
28✔
154
      results.push_back(result);
28✔
155
   }
28✔
156

157
   return results;
1✔
158
}
×
159

160
BOTAN_REGISTER_TEST("pubkey", "ecc_randomized", ECC_Randomized_Tests);
161

162
class EC_Group_Tests : public Test {
×
163
   public:
164
      std::vector<Test::Result> run() override {
1✔
165
         std::vector<Test::Result> results;
1✔
166

167
         for(const std::string& group_name : Botan::EC_Group::known_named_groups()) {
29✔
168
            Test::Result result("EC_Group " + group_name);
28✔
169

170
            result.start_timer();
28✔
171

172
            const auto group = Botan::EC_Group::from_name(group_name);
28✔
173

174
            result.confirm("EC_Group is known", group.get_curve_oid().has_value());
56✔
175
            result.confirm("EC_Group is considered valid", group.verify_group(this->rng(), true));
56✔
176
            result.confirm("EC_Group is not considered explict encoding", !group.used_explicit_encoding());
56✔
177

178
            result.test_eq("EC_Group has correct bit size", group.get_p().bits(), group.get_p_bits());
28✔
179
            result.test_eq("EC_Group has byte size", group.get_p().bytes(), group.get_p_bytes());
28✔
180

181
            result.test_eq("EC_Group has cofactor == 1", group.get_cofactor(), 1);
56✔
182

183
            const Botan::OID from_order = Botan::EC_Group::EC_group_identity_from_order(group.get_order());
28✔
184

185
            result.test_eq(
56✔
186
               "EC_group_identity_from_order works", from_order.to_string(), group.get_curve_oid().to_string());
56✔
187

188
            result.confirm("Same group is same", group == Botan::EC_Group::from_name(group_name));
56✔
189

190
            try {
28✔
191
               const Botan::EC_Group copy(group.get_curve_oid(),
28✔
192
                                          group.get_p(),
193
                                          group.get_a(),
194
                                          group.get_b(),
195
                                          group.get_g_x(),
196
                                          group.get_g_y(),
197
                                          group.get_order());
28✔
198

199
               result.confirm("Same group is same even with copy", group == copy);
40✔
200
            } catch(Botan::Invalid_Argument&) {}
28✔
201

202
            const auto group_der_oid = group.DER_encode();
28✔
203
            const Botan::EC_Group group_via_oid(group_der_oid);
28✔
204
            result.confirm("EC_Group via OID is not considered explict encoding",
56✔
205
                           !group_via_oid.used_explicit_encoding());
28✔
206

207
            const auto group_der_explicit = group.DER_encode(Botan::EC_Group_Encoding::Explicit);
28✔
208
            const Botan::EC_Group group_via_explicit(group_der_explicit);
28✔
209
            result.confirm("EC_Group via explicit DER is considered explict encoding",
56✔
210
                           group_via_explicit.used_explicit_encoding());
28✔
211

212
            const auto pt_mult_by_order = group.get_base_point() * group.get_order();
28✔
213
            result.confirm("Multiplying point by the order results in zero point", pt_mult_by_order.is_zero());
56✔
214

215
            if(group.a_is_minus_3()) {
28✔
216
               result.test_eq("Group A equals -3", group.get_a(), group.get_p() - 3);
51✔
217
            } else {
218
               result.test_ne("Group " + group_name + " A does not equal -3", group.get_a(), group.get_p() - 3);
44✔
219
            }
220

221
            if(group.a_is_zero()) {
28✔
222
               result.test_eq("Group A is zero", group.get_a(), BigInt(0));
8✔
223
            } else {
224
               result.test_ne("Group " + group_name + " A does not equal zero", group.get_a(), BigInt(0));
72✔
225
            }
226

227
            // get a valid point
228
            Botan::EC_Point p = group.get_base_point() * this->rng().next_nonzero_byte();
28✔
229

230
            // get a copy
231
            Botan::EC_Point q = p;
28✔
232

233
            p.randomize_repr(this->rng());
28✔
234
            q.randomize_repr(this->rng());
28✔
235

236
            result.test_eq("affine x after copy", p.get_affine_x(), q.get_affine_x());
84✔
237
            result.test_eq("affine y after copy", p.get_affine_y(), q.get_affine_y());
84✔
238

239
            q.force_affine();
28✔
240

241
            result.test_eq("affine x after copy", p.get_affine_x(), q.get_affine_x());
84✔
242
            result.test_eq("affine y after copy", p.get_affine_y(), q.get_affine_y());
84✔
243

244
            test_ser_der(result, group);
28✔
245
            test_basic_math(result, group);
28✔
246
            test_point_swap(result, group);
28✔
247
            test_zeropoint(result, group);
28✔
248

249
            result.end_timer();
28✔
250

251
            results.push_back(result);
28✔
252
         }
84✔
253

254
         return results;
1✔
255
      }
×
256

257
   private:
258
      void test_ser_der(Test::Result& result, const Botan::EC_Group& group) {
28✔
259
         // generate point
260
         const Botan::EC_Point pt = create_random_point(this->rng(), group);
28✔
261
         const Botan::EC_Point zero = group.zero_point();
28✔
262

263
         for(auto scheme : {Botan::EC_Point_Format::Uncompressed,
196✔
264
                            Botan::EC_Point_Format::Compressed,
265
                            Botan::EC_Point_Format::Hybrid}) {
112✔
266
            result.test_eq("encoded/decode rt works", group.OS2ECP(pt.encode(scheme)), pt);
168✔
267
            result.test_eq("encoded/decode rt works", group.OS2ECP(zero.encode(scheme)), zero);
252✔
268
         }
269
      }
28✔
270

271
      static void test_basic_math(Test::Result& result, const Botan::EC_Group& group) {
28✔
272
         const Botan::EC_Point& G = group.get_base_point();
28✔
273

274
         Botan::EC_Point p1 = G * 2;
56✔
275
         p1 += G;
28✔
276

277
         result.test_eq("point addition", p1, G * 3);
84✔
278

279
         p1 -= G * 2;
56✔
280

281
         result.test_eq("point subtraction", p1, G);
28✔
282

283
         // The scalar multiplication algorithm relies on this being true:
284
         try {
28✔
285
            Botan::EC_Point zero_coords = group.point(0, 0);
56✔
286
            result.confirm("point (0,0) is not on the curve", !zero_coords.on_the_curve());
×
287
         } catch(Botan::Exception&) {
28✔
288
            result.test_success("point (0,0) is rejected");
28✔
289
         }
28✔
290
      }
28✔
291

292
      void test_point_swap(Test::Result& result, const Botan::EC_Group& group) {
28✔
293
         Botan::EC_Point a(create_random_point(this->rng(), group));
28✔
294
         Botan::EC_Point b(create_random_point(this->rng(), group));
28✔
295
         b *= Botan::BigInt(this->rng(), 20);
28✔
296

297
         Botan::EC_Point c(a);
28✔
298
         Botan::EC_Point d(b);
28✔
299

300
         d.swap(c);
28✔
301
         result.test_eq("swap correct", a, d);
28✔
302
         result.test_eq("swap correct", b, c);
28✔
303
      }
28✔
304

305
      static void test_zeropoint(Test::Result& result, const Botan::EC_Group& group) {
28✔
306
         Botan::EC_Point zero = group.zero_point();
28✔
307

308
         result.test_throws("Zero point throws", "Cannot convert zero point to affine", [&]() { zero.get_affine_x(); });
84✔
309
         result.test_throws("Zero point throws", "Cannot convert zero point to affine", [&]() { zero.get_affine_y(); });
84✔
310

311
         const Botan::EC_Point p1 = group.get_base_point() * 2;
28✔
312

313
         result.confirm("point is on the curve", p1.on_the_curve());
56✔
314
         result.confirm("point is not zero", !p1.is_zero());
56✔
315

316
         Botan::EC_Point p2 = p1;
28✔
317
         p2 -= p1;
28✔
318

319
         result.confirm("p - q with q = p results in zero", p2.is_zero());
56✔
320

321
         const Botan::EC_Point minus_p1 = -p1;
28✔
322
         result.confirm("point is on the curve", minus_p1.on_the_curve());
56✔
323
         const Botan::EC_Point shouldBeZero = p1 + minus_p1;
28✔
324
         result.confirm("point is on the curve", shouldBeZero.on_the_curve());
56✔
325
         result.confirm("point is zero", shouldBeZero.is_zero());
56✔
326

327
         result.test_eq("minus point x", minus_p1.get_affine_x(), p1.get_affine_x());
84✔
328
         result.test_eq("minus point y", minus_p1.get_affine_y(), group.get_p() - p1.get_affine_y());
112✔
329

330
         result.confirm("zero point is zero", zero.is_zero());
56✔
331
         result.confirm("zero point is on the curve", zero.on_the_curve());
56✔
332
         result.test_eq("addition of zero does nothing", p1, p1 + zero);
56✔
333
         result.test_eq("addition of zero does nothing", p1, zero + p1);
56✔
334
         result.test_eq("addition of zero does nothing", p1, p1 - zero);
56✔
335
         result.confirm("zero times anything is the zero point", (zero * 39193).is_zero());
84✔
336

337
         for(auto scheme : {Botan::EC_Point_Format::Uncompressed,
196✔
338
                            Botan::EC_Point_Format::Compressed,
339
                            Botan::EC_Point_Format::Hybrid}) {
112✔
340
            const std::vector<uint8_t> v = zero.encode(scheme);
84✔
341
            result.test_eq("encoded/decode rt works", group.OS2ECP(v), zero);
168✔
342
         }
84✔
343
      }
28✔
344
};
345

346
BOTAN_REGISTER_TEST("pubkey", "ec_group", EC_Group_Tests);
347

348
Test::Result test_decoding_with_seed() {
1✔
349
   Test::Result result("ECC Unit");
1✔
350

351
   const auto secp384r1_with_seed = Botan::EC_Group::from_PEM(Test::read_data_file("x509/ecc/secp384r1_seed.pem"));
2✔
352

353
   result.confirm("decoding worked", secp384r1_with_seed.initialized());
2✔
354

355
   const auto secp384r1 = Botan::EC_Group::from_name("secp384r1");
1✔
356

357
   result.test_eq("P-384 prime", secp384r1_with_seed.get_p(), secp384r1.get_p());
1✔
358

359
   return result;
1✔
360
}
1✔
361

362
Test::Result test_mixed_points() {
1✔
363
   Test::Result result("ECC Unit");
1✔
364

365
   const auto secp256r1 = Botan::EC_Group::from_name("secp256r1");
1✔
366
   const auto secp384r1 = Botan::EC_Group::from_name("secp384r1");
1✔
367

368
   const Botan::EC_Point& G256 = secp256r1.get_base_point();
1✔
369
   const Botan::EC_Point& G384 = secp384r1.get_base_point();
1✔
370

371
   result.test_throws("Mixing points from different groups", [&] { Botan::EC_Point p = G256 + G384; });
3✔
372
   return result;
1✔
373
}
1✔
374

375
Test::Result test_basic_operations() {
1✔
376
   Test::Result result("ECC Unit");
1✔
377

378
   // precalculation
379
   const auto secp160r1 = Botan::EC_Group::from_name("secp160r1");
1✔
380
   const Botan::EC_Point& p_G = secp160r1.get_base_point();
1✔
381

382
   const Botan::EC_Point& p0 = p_G;
1✔
383
   const Botan::EC_Point p1 = p_G * 2;
2✔
384

385
   result.test_eq("p1 affine x", p1.get_affine_x(), Botan::BigInt("16984103820118642236896513183038186009872590470"));
3✔
386
   result.test_eq("p1 affine y", p1.get_affine_y(), Botan::BigInt("1373093393927139016463695321221277758035357890939"));
3✔
387

388
   const Botan::EC_Point simplePlus = p1 + p0;
1✔
389
   const Botan::EC_Point exp_simplePlus =
1✔
390
      secp160r1.point(Botan::BigInt("704859595002530890444080436569091156047721708633"),
2✔
391
                      Botan::BigInt("1147993098458695153857594941635310323215433166682"));
2✔
392

393
   result.test_eq("point addition", simplePlus, exp_simplePlus);
1✔
394

395
   const Botan::EC_Point simpleMinus = p1 - p0;
1✔
396
   result.test_eq("point subtraction", simpleMinus, p_G);
1✔
397

398
   const Botan::EC_Point simpleMult = p1 * 123456789;
2✔
399

400
   result.test_eq("point mult affine x",
3✔
401
                  simpleMult.get_affine_x(),
2✔
402
                  Botan::BigInt("43638877777452195295055270548491599621118743290"));
1✔
403
   result.test_eq("point mult affine y",
3✔
404
                  simpleMult.get_affine_y(),
2✔
405
                  Botan::BigInt("56841378500012376527163928510402662349220202981"));
1✔
406

407
   return result;
1✔
408
}
1✔
409

410
Test::Result test_enc_dec_compressed_160() {
1✔
411
   Test::Result result("ECC Unit");
1✔
412

413
   // Test for compressed conversion (02/03) 160bit
414
   const auto secp160r1 = Botan::EC_Group::from_name("secp160r1");
1✔
415
   const std::vector<uint8_t> G_comp = Botan::hex_decode("024A96B5688EF573284664698968C38BB913CBFC82");
1✔
416
   const Botan::EC_Point p = secp160r1.OS2ECP(G_comp);
1✔
417
   const std::vector<uint8_t> sv_result = p.encode(Botan::EC_Point_Format::Compressed);
1✔
418

419
   result.test_eq("result", sv_result, G_comp);
1✔
420
   return result;
2✔
421
}
2✔
422

423
Test::Result test_enc_dec_compressed_256() {
1✔
424
   Test::Result result("ECC Unit");
1✔
425

426
   const auto group = Botan::EC_Group::from_name("secp256r1");
1✔
427

428
   const std::string G_secp_comp = "036B17D1F2E12C4247F8BCE6E563A440F277037D812DEB33A0F4A13945D898C296";
1✔
429
   const std::vector<uint8_t> sv_G_secp_comp = Botan::hex_decode(G_secp_comp);
1✔
430

431
   Botan::EC_Point p_G = group.OS2ECP(sv_G_secp_comp);
1✔
432
   std::vector<uint8_t> sv_result = p_G.encode(Botan::EC_Point_Format::Compressed);
1✔
433

434
   result.test_eq("compressed_256", sv_result, sv_G_secp_comp);
1✔
435
   return result;
2✔
436
}
2✔
437

438
Test::Result test_enc_dec_uncompressed_112() {
1✔
439
   Test::Result result("ECC Unit");
1✔
440

441
   // Test for uncompressed conversion (04) 112bit
442

443
   // Curve is secp112r2
444

445
   const Botan::BigInt p("0xdb7c2abf62e35e668076bead208b");
1✔
446
   const Botan::BigInt a("0x6127C24C05F38A0AAAF65C0EF02C");
1✔
447
   const Botan::BigInt b("0x51DEF1815DB5ED74FCC34C85D709");
1✔
448

449
   const Botan::BigInt g_x("0x4BA30AB5E892B4E1649DD0928643");
1✔
450
   const Botan::BigInt g_y("0xADCD46F5882E3747DEF36E956E97");
1✔
451

452
   const Botan::BigInt order("0x36DF0AAFD8B8D7597CA10520D04B");
1✔
453
   const Botan::BigInt cofactor("4");  // !
1✔
454

455
   // This uses the deprecated constructor due to making use of cofactor > 1
456
   const Botan::EC_Group group(p, a, b, g_x, g_y, order, cofactor);
1✔
457

458
   const std::string G_secp_uncomp = "044BA30AB5E892B4E1649DD0928643ADCD46F5882E3747DEF36E956E97";
1✔
459
   const std::vector<uint8_t> sv_G_secp_uncomp = Botan::hex_decode(G_secp_uncomp);
1✔
460

461
   Botan::EC_Point p_G = group.OS2ECP(sv_G_secp_uncomp);
1✔
462
   std::vector<uint8_t> sv_result = p_G.encode(Botan::EC_Point_Format::Uncompressed);
1✔
463

464
   result.test_eq("uncompressed_112", sv_result, sv_G_secp_uncomp);
1✔
465
   return result;
1✔
466
}
9✔
467

468
Test::Result test_enc_dec_uncompressed_521() {
1✔
469
   Test::Result result("ECC Unit");
1✔
470

471
   // Test for uncompressed conversion(04) with big values(521 bit)
472

473
   const std::string G_secp_uncomp =
1✔
474
      "0400C6858E06B70404E9CD9E3ECB662395B4429C648139053FB521F828AF606B4D3DBAA14B5E77EFE75928FE1DC127A2ffA8DE3348B3C1856A429BF97E7E31C2E5BD66011839296A789A3BC0045C8A5FB42C7D1BD998F54449579B446817AFBD17273E662C97EE72995EF42640C550B9013FAD0761353C7086A272C24088BE94769FD16650";
1✔
475

476
   const std::vector<uint8_t> sv_G_secp_uncomp = Botan::hex_decode(G_secp_uncomp);
1✔
477

478
   const auto group = Botan::EC_Group::from_name("secp521r1");
1✔
479

480
   Botan::EC_Point p_G = group.OS2ECP(sv_G_secp_uncomp);
1✔
481

482
   std::vector<uint8_t> sv_result = p_G.encode(Botan::EC_Point_Format::Uncompressed);
1✔
483

484
   result.test_eq("expected", sv_result, sv_G_secp_uncomp);
1✔
485
   return result;
1✔
486
}
2✔
487

488
Test::Result test_ecc_registration() {
1✔
489
   Test::Result result("ECC registration");
1✔
490

491
   // secp128r1
492
   const Botan::BigInt p("0xfffffffdffffffffffffffffffffffff");
1✔
493
   const Botan::BigInt a("0xfffffffdfffffffffffffffffffffffc");
1✔
494
   const Botan::BigInt b("0xe87579c11079f43dd824993c2cee5ed3");
1✔
495

496
   const Botan::BigInt g_x("0x161ff7528b899b2d0c28607ca52c5b86");
1✔
497
   const Botan::BigInt g_y("0xcf5ac8395bafeb13c02da292dded7a83");
1✔
498
   const Botan::BigInt order("0xfffffffe0000000075a30d1b9038a115");
1✔
499

500
   const Botan::OID oid("1.3.132.0.28");
1✔
501

502
   // Creating this object implicitly registers the curve for future use ...
503
   Botan::EC_Group reg_group(oid, p, a, b, g_x, g_y, order);
1✔
504

505
   auto group = Botan::EC_Group::from_OID(oid);
1✔
506

507
   result.test_eq("Group registration worked", group.get_p(), p);
1✔
508

509
   return result;
2✔
510
}
7✔
511

512
Test::Result test_ec_group_from_params() {
1✔
513
   Test::Result result("EC_Group from params");
1✔
514

515
   Botan::EC_Group::clear_registered_curve_data();
1✔
516

517
   // secp256r1
518
   const Botan::BigInt p("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF");
1✔
519
   const Botan::BigInt a("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFC");
1✔
520
   const Botan::BigInt b("0x5AC635D8AA3A93E7B3EBBD55769886BC651D06B0CC53B0F63BCE3C3E27D2604B");
1✔
521

522
   const Botan::BigInt g_x("0x6B17D1F2E12C4247F8BCE6E563A440F277037D812DEB33A0F4A13945D898C296");
1✔
523
   const Botan::BigInt g_y("0x4FE342E2FE1A7F9B8EE7EB4A7C0F9E162BCE33576B315ECECBB6406837BF51F5");
1✔
524
   const Botan::BigInt order("0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551");
1✔
525

526
   const Botan::OID oid("1.2.840.10045.3.1.7");
1✔
527

528
   // This uses the deprecated constructor to verify we dedup even without an OID
529
   // This whole test can be removed once explicit curve support is removed
530
   Botan::EC_Group reg_group(p, a, b, g_x, g_y, order, 1);
2✔
531
   result.confirm("Group has correct OID", reg_group.get_curve_oid() == oid);
2✔
532

533
   return result;
2✔
534
}
7✔
535

536
Test::Result test_ec_group_bad_registration() {
1✔
537
   Test::Result result("EC_Group registering non-match");
1✔
538

539
   Botan::EC_Group::clear_registered_curve_data();
1✔
540

541
   // secp256r1 params except with a bad B param
542
   const Botan::BigInt p("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF");
1✔
543
   const Botan::BigInt a("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFC");
1✔
544
   const Botan::BigInt b("0x5AC635D8AA3A93E7B3EBBD55769886BC651D06B0CC53B0F63BCE3C3E27D2604C");
1✔
545

546
   const Botan::BigInt g_x("0x6B17D1F2E12C4247F8BCE6E563A440F277037D812DEB33A0F4A13945D898C296");
1✔
547
   const Botan::BigInt g_y("0x4FE342E2FE1A7F9B8EE7EB4A7C0F9E162BCE33576B315ECECBB6406837BF51F5");
1✔
548
   const Botan::BigInt order("0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551");
1✔
549

550
   const Botan::OID oid("1.2.840.10045.3.1.7");
1✔
551

552
   try {
1✔
553
      Botan::EC_Group reg_group(oid, p, a, b, g_x, g_y, order);
1✔
554
      result.test_failure("Should have failed");
×
555
   } catch(Botan::Invalid_Argument&) {
1✔
556
      result.test_success("Got expected exception");
1✔
557
   }
1✔
558

559
   return result;
1✔
560
}
7✔
561

562
Test::Result test_ec_group_duplicate_orders() {
1✔
563
   Test::Result result("EC_Group with duplicate group order");
1✔
564

565
   Botan::EC_Group::clear_registered_curve_data();
1✔
566

567
   // secp256r1
568
   const Botan::BigInt p("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF");
1✔
569
   const Botan::BigInt a("0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFC");
1✔
570
   const Botan::BigInt b("0x5AC635D8AA3A93E7B3EBBD55769886BC651D06B0CC53B0F63BCE3C3E27D2604B");
1✔
571

572
   const Botan::BigInt g_x("0x6B17D1F2E12C4247F8BCE6E563A440F277037D812DEB33A0F4A13945D898C296");
1✔
573
   const Botan::BigInt g_y("0x4FE342E2FE1A7F9B8EE7EB4A7C0F9E162BCE33576B315ECECBB6406837BF51F5");
1✔
574
   const Botan::BigInt order("0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551");
1✔
575

576
   const Botan::OID oid("1.3.6.1.4.1.25258.100.0");  // some other random OID
1✔
577

578
   Botan::EC_Group reg_group(oid, p, a, b, g_x, g_y, order);
1✔
579
   result.test_success("Registration success");
1✔
580
   result.confirm("Group has correct OID", reg_group.get_curve_oid() == oid);
2✔
581

582
   // We can now get it by OID:
583
   const auto hc_group = Botan::EC_Group::from_OID(oid);
1✔
584
   result.confirm("Group has correct OID", hc_group.get_curve_oid() == oid);
2✔
585

586
   // Existing secp256r1 unmodified:
587
   const Botan::OID secp160r1("1.2.840.10045.3.1.7");
1✔
588
   const auto other_group = Botan::EC_Group::from_OID(secp160r1);
1✔
589
   result.confirm("Group has correct OID", other_group.get_curve_oid() == secp160r1);
2✔
590

591
   return result;
2✔
592
}
7✔
593

594
class ECC_Unit_Tests final : public Test {
×
595
   public:
596
      std::vector<Test::Result> run() override {
1✔
597
         std::vector<Test::Result> results;
1✔
598

599
         results.push_back(test_decoding_with_seed());
2✔
600
         results.push_back(test_mixed_points());
2✔
601
         results.push_back(test_basic_operations());
2✔
602
         results.push_back(test_enc_dec_compressed_160());
2✔
603
         results.push_back(test_enc_dec_compressed_256());
2✔
604
         results.push_back(test_enc_dec_uncompressed_112());
2✔
605
         results.push_back(test_enc_dec_uncompressed_521());
2✔
606
         results.push_back(test_ecc_registration());
2✔
607
         results.push_back(test_ec_group_from_params());
2✔
608
         results.push_back(test_ec_group_bad_registration());
2✔
609
         results.push_back(test_ec_group_duplicate_orders());
2✔
610

611
         return results;
1✔
612
      }
×
613
};
614

615
BOTAN_REGISTER_SERIALIZED_TEST("pubkey", "ecc_unit", ECC_Unit_Tests);
616

617
   #if defined(BOTAN_HAS_ECDSA)
618

619
class ECC_Invalid_Key_Tests final : public Text_Based_Test {
×
620
   public:
621
      ECC_Invalid_Key_Tests() : Text_Based_Test("pubkey/ecc_invalid.vec", "SubjectPublicKey") {}
2✔
622

623
      bool clear_between_callbacks() const override { return false; }
5✔
624

625
      Test::Result run_one_test(const std::string& /*header*/, const VarMap& vars) override {
5✔
626
         Test::Result result("ECC invalid keys");
5✔
627

628
         const std::string encoded = vars.get_req_str("SubjectPublicKey");
5✔
629
         Botan::DataSource_Memory key_data(Botan::hex_decode(encoded));
10✔
630

631
         try {
5✔
632
            auto key = Botan::X509::load_key(key_data);
5✔
633
            result.test_eq("public key fails check", key->check_key(this->rng(), false), false);
×
634
         } catch(Botan::Decoding_Error&) {
5✔
635
            result.test_success("Decoding invalid ECC key results in decoding error exception");
5✔
636
         }
5✔
637

638
         return result;
5✔
639
      }
5✔
640
};
641

642
BOTAN_REGISTER_TEST("pubkey", "ecc_invalid", ECC_Invalid_Key_Tests);
643

644
   #endif
645

646
#endif
647

648
}  // namespace
649

650
}  // namespace Botan_Tests
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc