#546

Committed 25 Oct 2024 07:55AM UTC coverage: 87.201% (+0.1%) from 87.068%

Build # #546

Build Type

push

Committed by

Commit Message

Fix bad request handling (#179)

* update controller to use ParameterObject

As used in the metadata endpoint we want Swagger to be  able to interpret and automatically generate pagination parameters like page, size, and sort.

* Add error handling for incorrect sort value

* Add test for error handling

* Fix workflow to only release main branch to maven central

* Update CHANGELOG.md

* Add unit test for BeeekeeperExceptionHandler

Testing the request response and the errorResponses

* Implement builder pattern for ErrorResponse

---------

Co-authored-by: Hamza Jugon <hjugon@expediagroup.com>
Co-authored-by: Jay Green-Stevens <jgreenstevens@expediagroup.com>

Run Details

15 of 15 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

1274 of 1461 relevant lines covered (87.2%)

0.87 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/BeekeeperApiApplication.java

/**
 * Copyright (C) 2019-2021 Expedia, Inc.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
package com.expediagroup.beekeeper.api;

import org.springframework.boot.autoconfigure.SpringBootApplication;
import org.springframework.boot.autoconfigure.domain.EntityScan;
import org.springframework.boot.builder.SpringApplicationBuilder;
import org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.ComponentScan;
import org.springframework.data.jpa.repository.config.EnableJpaRepositories;

@SpringBootApplication
@EnableConfigurationProperties
@EntityScan(basePackages = { "com.expediagroup.beekeeper.core.model" })
@EnableJpaRepositories(basePackages = { "com.expediagroup.beekeeper.core.repository" })
@ComponentScan(basePackages = {
    "com.expediagroup.beekeeper.api.conf",
    "com.expediagroup.beekeeper.api.controller",
    "com.expediagroup.beekeeper.api.service",
    "com.expediagroup.beekeeper.api.error" })
public class BeekeeperApiApplication {
  public static void main(String[] args) {
    new SpringApplicationBuilder(BeekeeperApiApplication.class)
        .properties("server.port:${endpoint.port:7008}")
        .build()
        .run(args);
  }
}

1	/**
2	* Copyright (C) 2019-2021 Expedia, Inc.
3	*
4	* Licensed under the Apache License, Version 2.0 (the "License");
5	* you may not use this file except in compliance with the License.
6	* You may obtain a copy of the License at
7	*
8	* http://www.apache.org/licenses/LICENSE-2.0
9	*
10	* Unless required by applicable law or agreed to in writing, software
11	* distributed under the License is distributed on an "AS IS" BASIS,
12	* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	* See the License for the specific language governing permissions and
14	* limitations under the License.
15	*/
16	package com.expediagroup.beekeeper.api;
17
18	import org.springframework.boot.autoconfigure.SpringBootApplication;
19	import org.springframework.boot.autoconfigure.domain.EntityScan;
20	import org.springframework.boot.builder.SpringApplicationBuilder;
21	import org.springframework.boot.context.properties.EnableConfigurationProperties;
22	import org.springframework.context.annotation.ComponentScan;
23	import org.springframework.data.jpa.repository.config.EnableJpaRepositories;
24
25	@SpringBootApplication
26	@EnableConfigurationProperties
27	@EntityScan(basePackages = { "com.expediagroup.beekeeper.core.model" })
28	@EnableJpaRepositories(basePackages = { "com.expediagroup.beekeeper.core.repository" })
29	@ComponentScan(basePackages = {
30	"com.expediagroup.beekeeper.api.conf",
31	"com.expediagroup.beekeeper.api.controller",
32	"com.expediagroup.beekeeper.api.service",
33	"com.expediagroup.beekeeper.api.error" })
UNCOV 34	public class BeekeeperApiApplication {	×
35	public static void main(String[] args) {
36	new SpringApplicationBuilder(BeekeeperApiApplication.class)	×
37	.properties("server.port:${endpoint.port:7008}")	×
38	.build()	×
39	.run(args);	×
40	}	×
41	}

ExpediaGroup / beekeeper / #546

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous