23a72bf1994dab30060181382d0556bd26d909a7

Committed 21 Oct 2024 12:22PM UTC coverage: 54.571% (+0.002%) from 54.569%

Build # 23a72bf1994dab30060181382d0556bd26d909a7

Build Type

Pull #21691

github

Committed by

web-flow

Commit Message

Merge 6fe61e5b5 into 8a4aceaf1

Pull Request Pull Request #21691: Remove conditional and rename dashboard to general page.

Run Details

7549 of 13564 branches covered (55.65%)

Branch coverage included in aggregate %.

14 of 35 new or added lines in 17 files covered. (40.0%)

538 existing lines in 3 files now uncovered.

29672 of 54642 relevant lines covered (54.3%)

41714.17 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.67

/src/integrations/admin/old-configuration-integration.php

<?php

namespace Yoast\WP\SEO\Integrations\Admin;

use Yoast\WP\SEO\Conditionals\Admin_Conditional;
use Yoast\WP\SEO\Integrations\Integration_Interface;

/**
 * Old_Configuration_Integration class
 */
class Old_Configuration_Integration implements Integration_Interface {

        /**
         * {@inheritDoc}
         */
        public static function get_conditionals() {
                return [ Admin_Conditional::class ];
        }

        /**
         * {@inheritDoc}
         */
        public function register_hooks() {
                \add_filter( 'admin_menu', [ $this, 'add_submenu_page' ], 11 );
                \add_action( 'admin_init', [ $this, 'redirect_to_new_configuration' ] );
        }

        /**
         * Adds the old configuration submenu page.
         *
         * @param array $submenu_pages The Yoast SEO submenu pages.
         *
         * @return array the filtered submenu pages.
         */
        public function add_submenu_page( $submenu_pages ) {
                \add_submenu_page(
                        '',
                        \__( 'Old Configuration Wizard', 'wordpress-seo' ),
                        '',
                        'manage_options',
                        'wpseo_configurator',
                        [ $this, 'render_page' ]
                );

                return $submenu_pages;
        }

        /**
         * Renders the old configuration page.
         *
         * @return void
         */
        public function render_page() {
                // This page is never to be displayed.
        }

        /**
         * Redirects from the old configuration page to the new configuration page.
         *
         * @return void
         */
        public function redirect_to_new_configuration() {
                // phpcs:ignore WordPress.Security.NonceVerification.Recommended -- Data is not processed or saved.
                if ( ! isset( $_GET['page'] ) || $_GET['page'] !== 'wpseo_configurator' ) {
                        return;
                }
                $redirect_url = 'admin.php?page=wpseo_dashboard#/first-time-configuration';
                \wp_safe_redirect( \admin_url( $redirect_url ), 302, 'Yoast SEO' );
                exit;
        }
}

1	<?php
2
3	namespace Yoast\WP\SEO\Integrations\Admin;
4
5	use Yoast\WP\SEO\Conditionals\Admin_Conditional;
6	use Yoast\WP\SEO\Integrations\Integration_Interface;
7
8	/**
9	* Old_Configuration_Integration class
10	*/
11	class Old_Configuration_Integration implements Integration_Interface {
12
13	/**
14	* {@inheritDoc}
15	*/
16	public static function get_conditionals() {	2✔
17	return [ Admin_Conditional::class ];	2✔
18	}
19
20	/**
21	* {@inheritDoc}
22	*/
23	public function register_hooks() {	2✔
24	\add_filter( 'admin_menu', [ $this, 'add_submenu_page' ], 11 );	2✔
25	\add_action( 'admin_init', [ $this, 'redirect_to_new_configuration' ] );	2✔
26	}	1✔
27
28	/**
29	* Adds the old configuration submenu page.
30	*
31	* @param array $submenu_pages The Yoast SEO submenu pages.
32	*
33	* @return array the filtered submenu pages.
34	*/
35	public function add_submenu_page( $submenu_pages ) {	2✔
36	\add_submenu_page(	2✔
37	'',	2✔
38	\__( 'Old Configuration Wizard', 'wordpress-seo' ),	2✔
39	'',	2✔
40	'manage_options',	2✔
41	'wpseo_configurator',	2✔
42	[ $this, 'render_page' ]	2✔
43	);	1✔
44
45	return $submenu_pages;	2✔
46	}
47
48	/**
49	* Renders the old configuration page.
50	*
51	* @return void
52	*/
53	public function render_page() {	×
54	// This page is never to be displayed.
55	}	×
56
57	/**
58	* Redirects from the old configuration page to the new configuration page.
59	*
60	* @return void
61	*/
62	public function redirect_to_new_configuration() {	×
63	// phpcs:ignore WordPress.Security.NonceVerification.Recommended -- Data is not processed or saved.
64	if ( ! isset( $_GET['page'] ) \|\| $_GET['page'] !== 'wpseo_configurator' ) {	×
65	return;	×
66	}
NEW 67	$redirect_url = 'admin.php?page=wpseo_dashboard#/first-time-configuration';	×
68	\wp_safe_redirect( \admin_url( $redirect_url ), 302, 'Yoast SEO' );	×
69	exit;	×
70	}
71	}

Yoast / wordpress-seo / 23a72bf1994dab30060181382d0556bd26d909a7

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous