11381930658

Committed 17 Oct 2024 09:12AM UTC coverage: 44.603% (-0.09%) from 44.695%

Build # 11381930658

Build Type

push

github

Committed by

web-flow

Commit Message

fix: handling library id deleted (#378)

Run Details

348 of 898 branches covered (38.75%)

Branch coverage included in aggregate %.

3 of 12 new or added lines in 3 files covered. (25.0%)

1 existing line in 1 file now uncovered.

528 of 1066 relevant lines covered (49.53%)

49.41 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0

/src/master-item-subscriber.js

import { LIBRARY_ID_DELETED } from './constants';
import util from './utils/util';

export default function MasterItemSubscriber({ model, callback }) {
  let subscriptions = {};
  let effectiveMeasureLibraryIds = {};
  let effectiveDimensionLibraryIds = {};
  const mainProperties = {
    dimension: ['qDim.qFieldDefs'],
    measure: ['qMeasure.qDef', 'qMeasure.qLabel', 'qMeasure.qLabelExpression', 'qMeasure.coloring', 'qMeasure.qNumFormat', 'qMeasure.isCustomFormatted'],
  };

  function getPropertiesString(layout) {
    const properties = {};
    const type = util.getValue(layout, 'qInfo.qType');
    if (type && mainProperties[type]) {
      mainProperties[type].forEach((item) => {
        properties[item] = util.getValue(layout, item);
      });
    }
    return JSON.stringify(properties);
  }

  function onMasterItemChange(itemLayout) {
    const { qId } = itemLayout.qInfo;
    if (subscriptions[qId]) {
      const properties = getPropertiesString(itemLayout);
      if (subscriptions[qId].properties !== properties) {
        subscriptions[qId].properties = properties;
        if (typeof callback === 'function' && subscriptions[qId].enabled) {
          callback(itemLayout);
        }
      }
      subscriptions[qId].enabled = true;
    }
  }

  function setEffectiveLibraryIds({ measureLibraryIds, dimensionLibraryIds }) {
    effectiveMeasureLibraryIds = {};
    measureLibraryIds.forEach((libraryId) => {
      effectiveMeasureLibraryIds[libraryId] = true;
    });
    effectiveDimensionLibraryIds = {};
    dimensionLibraryIds.forEach((libraryId) => {
      effectiveDimensionLibraryIds[libraryId] = true;
    });
  }

  function unsubscribeUnusedIds() {
    Object.keys(subscriptions).forEach((libraryId) => {
      if (!effectiveMeasureLibraryIds[libraryId] && !effectiveDimensionLibraryIds[libraryId]) {
        subscriptions[libraryId].listener.dispose();
        subscriptions[libraryId].unbindCloseListnener();
        delete subscriptions[libraryId];
      }
    });
  }
  const onDeletingLibraryId = (id) => {
    callback(LIBRARY_ID_DELETED);
    delete subscriptions[id];
    unsubscribeUnusedIds();
  };

  const subscribeClose = (itemModel, onClose) => {
    itemModel.once('closed', onClose);
    return () => itemModel.removeListener('closed', onClose);
  };

  function subscribeLibraryId(libraryId, methodName) {
    return model.app[methodName](libraryId).then((itemModel) => {
      subscriptions[libraryId] = {
        listener: itemModel.layoutSubscribe(onMasterItemChange),
        unbindCloseListnener: subscribeClose(itemModel, () => onDeletingLibraryId(itemModel.id)),
        enabled: false,
        properties: getPropertiesString(itemModel.layout),
      };
    }).catch(() => { /* ignore missing library items */ });
  }

  return {
    subscribe({ measureLibraryIds, dimensionLibraryIds }) {
      const dfds = [];

      setEffectiveLibraryIds({ measureLibraryIds, dimensionLibraryIds });
      unsubscribeUnusedIds();

      if (model.app) {
        Object.keys(effectiveMeasureLibraryIds).forEach((libraryId) => {
          if (effectiveMeasureLibraryIds[libraryId] && !subscriptions[libraryId]) {
            dfds.push(subscribeLibraryId(libraryId, 'getMeasure'));
          }
        });
        Object.keys(effectiveDimensionLibraryIds).forEach((libraryId) => {
          if (effectiveDimensionLibraryIds[libraryId] && !subscriptions[libraryId]) {
            dfds.push(subscribeLibraryId(libraryId, 'getDimension'));
          }
        });
      }

      return Promise.all(dfds);
    },

    unsubscribe() {
      Object.keys(subscriptions).forEach((libraryId) => {
        subscriptions[libraryId].listener.dispose();
      });
      subscriptions = {};
    },
  };
}

1	import { LIBRARY_ID_DELETED } from './constants';
2	import util from './utils/util';
3
4	export default function MasterItemSubscriber({ model, callback }) {
5	let subscriptions = {};	×
6	let effectiveMeasureLibraryIds = {};	×
7	let effectiveDimensionLibraryIds = {};	×
8	const mainProperties = {	×
9	dimension: ['qDim.qFieldDefs'],
10	measure: ['qMeasure.qDef', 'qMeasure.qLabel', 'qMeasure.qLabelExpression', 'qMeasure.coloring', 'qMeasure.qNumFormat', 'qMeasure.isCustomFormatted'],
11	};
12
13	function getPropertiesString(layout) {
14	const properties = {};	×
15	const type = util.getValue(layout, 'qInfo.qType');	×
16	if (type && mainProperties[type]) {	×
17	mainProperties[type].forEach((item) => {	×
18	properties[item] = util.getValue(layout, item);	×
19	});
20	}
21	return JSON.stringify(properties);	×
22	}
23
24	function onMasterItemChange(itemLayout) {
25	const { qId } = itemLayout.qInfo;	×
26	if (subscriptions[qId]) {	×
27	const properties = getPropertiesString(itemLayout);	×
28	if (subscriptions[qId].properties !== properties) {	×
29	subscriptions[qId].properties = properties;	×
30	if (typeof callback === 'function' && subscriptions[qId].enabled) {	×
31	callback(itemLayout);	×
32	}
33	}
34	subscriptions[qId].enabled = true;	×
35	}
36	}
37
38	function setEffectiveLibraryIds({ measureLibraryIds, dimensionLibraryIds }) {
39	effectiveMeasureLibraryIds = {};	×
40	measureLibraryIds.forEach((libraryId) => {	×
41	effectiveMeasureLibraryIds[libraryId] = true;	×
42	});
43	effectiveDimensionLibraryIds = {};	×
44	dimensionLibraryIds.forEach((libraryId) => {	×
45	effectiveDimensionLibraryIds[libraryId] = true;	×
46	});
47	}
48
49	function unsubscribeUnusedIds() {
50	Object.keys(subscriptions).forEach((libraryId) => {	×
51	if (!effectiveMeasureLibraryIds[libraryId] && !effectiveDimensionLibraryIds[libraryId]) {	×
52	subscriptions[libraryId].listener.dispose();	×
NEW 53	subscriptions[libraryId].unbindCloseListnener();	×
UNCOV 54	delete subscriptions[libraryId];	×
55	}
56	});
57	}
NEW 58	const onDeletingLibraryId = (id) => {	×
NEW 59	callback(LIBRARY_ID_DELETED);	×
NEW 60	delete subscriptions[id];	×
NEW 61	unsubscribeUnusedIds();	×
62	};
63
NEW 64	const subscribeClose = (itemModel, onClose) => {	×
NEW 65	itemModel.once('closed', onClose);	×
NEW 66	return () => itemModel.removeListener('closed', onClose);	×
67	};
68
69	function subscribeLibraryId(libraryId, methodName) {
70	return model.app[methodName](libraryId).then((itemModel) => {	×
71	subscriptions[libraryId] = {	×
72	listener: itemModel.layoutSubscribe(onMasterItemChange),
NEW 73	unbindCloseListnener: subscribeClose(itemModel, () => onDeletingLibraryId(itemModel.id)),	×
74	enabled: false,
75	properties: getPropertiesString(itemModel.layout),
76	};
77	}).catch(() => { /* ignore missing library items */ });
78	}
79
80	return {	×
81	subscribe({ measureLibraryIds, dimensionLibraryIds }) {
82	const dfds = [];	×
83
84	setEffectiveLibraryIds({ measureLibraryIds, dimensionLibraryIds });	×
85	unsubscribeUnusedIds();	×
86
87	if (model.app) {	×
88	Object.keys(effectiveMeasureLibraryIds).forEach((libraryId) => {	×
89	if (effectiveMeasureLibraryIds[libraryId] && !subscriptions[libraryId]) {	×
90	dfds.push(subscribeLibraryId(libraryId, 'getMeasure'));	×
91	}
92	});
93	Object.keys(effectiveDimensionLibraryIds).forEach((libraryId) => {	×
94	if (effectiveDimensionLibraryIds[libraryId] && !subscriptions[libraryId]) {	×
95	dfds.push(subscribeLibraryId(libraryId, 'getDimension'));	×
96	}
97	});
98	}
99
100	return Promise.all(dfds);	×
101	},
102
103	unsubscribe() {
104	Object.keys(subscriptions).forEach((libraryId) => {	×
105	subscriptions[libraryId].listener.dispose();	×
106	});
107	subscriptions = {};	×
108	},
109	};
110	}

qlik-oss / qlik-modifiers / 11381930658

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous