11278983730

Committed 10 Oct 2024 05:25PM UTC coverage: 31.651% (-0.001%) from 31.652%

Build # 11278983730

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9865 from ForumMagnum/master

[EA] Deploy debate week improvements

Run Details

5063 of 41812 branches covered (12.11%)

Branch coverage included in aggregate %.

9 of 36 new or added lines in 6 files covered. (25.0%)

2 existing lines in 2 files now uncovered.

29588 of 67666 relevant lines covered (43.73%)

180.86 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

15.56

/packages/lesswrong/components/quickTakes/useQuickTakesTags.ts

import { useCallback, useState } from "react";
import { useMulti } from "../../lib/crud/withMulti";
import type { ChecklistTag } from "../tagging/TagsChecklist";
import { useCurrentForumEvent } from "../hooks/useCurrentForumEvent";

const filterDefined = <T>(values: (T | null | undefined)[]): T[] =>
  values.filter((value) => value !== null && value !== undefined) as T[];

const FRONTPAGE_TAG_ID = "frontpage" as const;
const FRONTPAGE_DUMMY_TAG: ChecklistTag = {
  _id: FRONTPAGE_TAG_ID,
  name: "Frontpage",
  shortName: null,
} as const;

export type SelectedTag = {
  tagId: string,
  tagName: string,
  parentTagId?: string,
};

export type QuickTakesTag = ChecklistTag | TagFragment;

export type QuickTakesTags = {
  loading: true,
  frontpage?: never,
  selectedTagIds?: never,
  tags?: never,
  frontpageTagId?: never,
  onTagSelected?: never,
  onTagRemoved?: never,
} | {
  loading: false,
  frontpage: boolean,
  selectedTagIds: string[],
  tags: QuickTakesTag[],
  frontpageTagId: typeof FRONTPAGE_TAG_ID,
  onTagSelected: (
    tag: SelectedTag,
    existingTagIds: string[],
  ) => void,
  onTagRemoved: (
    tag: SelectedTag,
    existingTagIds: string[],
  ) => void,
};

export const useQuickTakesTags = (initialSelectedTagIds: string[] = []): QuickTakesTags => {
  const [frontpage, setFrontpage] = useState(true);
  const [selectedTagIds, setSelectedTagIds] = useState<string[]>(initialSelectedTagIds);

  const {currentForumEvent} = useCurrentForumEvent();

  const {results, loading} = useMulti({
    terms: {
      view: "coreAndSubforumTags",
    },
    collectionName: "Tags",
    fragmentName: "TagFragment",
    limit: 100,
  });

  const tags: QuickTakesTag[] = [
    FRONTPAGE_DUMMY_TAG,
    ...(currentForumEvent?.tag ? [currentForumEvent.tag] : []),
    ...(results ?? [])
  ];

  const onTagSelected = useCallback((
    tag: SelectedTag,
    existingTagIds: string[],
  ) => {
    if (tag.tagId === FRONTPAGE_TAG_ID) {
      setFrontpage(true);
    } else {
      setSelectedTagIds(filterDefined(Array.from(new Set([
        ...existingTagIds.filter((id) => id !== FRONTPAGE_TAG_ID),
        tag.tagId,
        tag.parentTagId,
      ]))));
    }
  }, []);

  const onTagRemoved = useCallback((
    tag: SelectedTag,
    existingTagIds: string[],
  ) => {
    if (tag.tagId === FRONTPAGE_TAG_ID) {
      setFrontpage(false);
    } else {
      setSelectedTagIds(existingTagIds.filter(
        (id) => id !== tag.tagId && id !== FRONTPAGE_TAG_ID,
      ));
    }
  }, []);

  if (loading) {
    return {loading};
  }

  return {
    loading: false,
    frontpage,
    selectedTagIds,
    tags: tags ?? [],
    frontpageTagId: FRONTPAGE_TAG_ID,
    onTagSelected,
    onTagRemoved,
  };
}

1	import { useCallback, useState } from "react";	3✔
2	import { useMulti } from "../../lib/crud/withMulti";	1✔
3	import type { ChecklistTag } from "../tagging/TagsChecklist";
4	import { useCurrentForumEvent } from "../hooks/useCurrentForumEvent";	1✔
5
6	const filterDefined = <T>(values: (T \| null \| undefined)[]): T[] =>	1✔
7	values.filter((value) => value !== null && value !== undefined) as T[];	×
8
9	const FRONTPAGE_TAG_ID = "frontpage" as const;	1✔
10	const FRONTPAGE_DUMMY_TAG: ChecklistTag = {	1✔
11	_id: FRONTPAGE_TAG_ID,
12	name: "Frontpage",
13	shortName: null,
14	} as const;
15
16	export type SelectedTag = {
17	tagId: string,
18	tagName: string,
19	parentTagId?: string,
20	};
21
22	export type QuickTakesTag = ChecklistTag \| TagFragment;
23
24	export type QuickTakesTags = {
25	loading: true,
26	frontpage?: never,
27	selectedTagIds?: never,
28	tags?: never,
29	frontpageTagId?: never,
30	onTagSelected?: never,
31	onTagRemoved?: never,
32	} \| {
33	loading: false,
34	frontpage: boolean,
35	selectedTagIds: string[],
36	tags: QuickTakesTag[],
37	frontpageTagId: typeof FRONTPAGE_TAG_ID,
38	onTagSelected: (
39	tag: SelectedTag,
40	existingTagIds: string[],
41	) => void,
42	onTagRemoved: (
43	tag: SelectedTag,
44	existingTagIds: string[],
45	) => void,
46	};
47
48	export const useQuickTakesTags = (initialSelectedTagIds: string[] = []): QuickTakesTags => {	1!
49	const [frontpage, setFrontpage] = useState(true);	×
50	const [selectedTagIds, setSelectedTagIds] = useState<string[]>(initialSelectedTagIds);	×
51
NEW 52	const {currentForumEvent} = useCurrentForumEvent();	×
53
UNCOV 54	const {results, loading} = useMulti({	×
55	terms: {
56	view: "coreAndSubforumTags",
57	},
58	collectionName: "Tags",
59	fragmentName: "TagFragment",
60	limit: 100,
61	});
62
NEW 63	const tags: QuickTakesTag[] = [	×
64	FRONTPAGE_DUMMY_TAG,
65	...(currentForumEvent?.tag ? [currentForumEvent.tag] : []),	×
66	...(results ?? [])	×
67	];
68
69	const onTagSelected = useCallback((	×
70	tag: SelectedTag,
71	existingTagIds: string[],
72	) => {
73	if (tag.tagId === FRONTPAGE_TAG_ID) {	×
74	setFrontpage(true);	×
75	} else {
76	setSelectedTagIds(filterDefined(Array.from(new Set([	×
77	...existingTagIds.filter((id) => id !== FRONTPAGE_TAG_ID),	×
78	tag.tagId,
79	tag.parentTagId,
80	]))));
81	}
82	}, []);
83
84	const onTagRemoved = useCallback((	×
85	tag: SelectedTag,
86	existingTagIds: string[],
87	) => {
88	if (tag.tagId === FRONTPAGE_TAG_ID) {	×
89	setFrontpage(false);	×
90	} else {
91	setSelectedTagIds(existingTagIds.filter(	×
92	(id) => id !== tag.tagId && id !== FRONTPAGE_TAG_ID,	×
93	));
94	}
95	}, []);
96
97	if (loading) {	×
98	return {loading};	×
99	}
100
101	return {	×
102	loading: false,
103	frontpage,
104	selectedTagIds,
105	tags: tags ?? [],	×
106	frontpageTagId: FRONTPAGE_TAG_ID,
107	onTagSelected,
108	onTagRemoved,
109	};
110	}

ForumMagnum / ForumMagnum / 11278983730

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous