11253390128

Committed 09 Oct 2024 10:27AM UTC coverage: 31.5% (-0.2%) from 31.669%

Build # 11253390128

Build Type

Pull #9861

github

Committed by

oetherington

Commit Message

Fix 'create' command in migrate script

Pull Request Pull Request #9861: Simplify migration workflow

Run Details

5012 of 41752 branches covered (12.0%)

Branch coverage included in aggregate %.

6 of 10 new or added lines in 2 files covered. (60.0%)

9 existing lines in 3 files now uncovered.

29403 of 67502 relevant lines covered (43.56%)

174.66 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

63.83

/packages/lesswrong/server/postgresView.ts

import { getSqlClientOrThrow } from "./sql/sqlClient";
import { queryWithLock } from "./queryWithLock";
import { addCronJob, CronJobSpec } from "./cronUtil";

type PostgresViewRefreshSpec = {
  interval: string,
  query: string,
}

export class PostgresView {
  constructor(
    private name: string,
    private createViewQuery: string,
    private createIndexQueries: string[] = [],
    private refreshSpec?: PostgresViewRefreshSpec,
    private dependencies?: SchemaDependency[],
    private queryTimeout = 60,
  ) {}

  getName(): string {
    return this.name;
  }

  getCreateViewQuery() {
    return this.createViewQuery;
  }

  getCreateIndexQueries() {
    return this.createIndexQueries;
  }

  getDependencies() {
    return this.dependencies;
  }

  async refresh(db: SqlClient) {
    if (this.refreshSpec) {
      await queryWithLock(db, this.refreshSpec.query, this.queryTimeout);
    }
  }

  registerCronJob() {
    if (this.refreshSpec) {
      addCronJob({
        name: `refreshPostgresView-${this.name}`,
        interval: this.refreshSpec.interval,
        job: () => this.refresh(getSqlClientOrThrow()),
      });
    }
  }
}

const postgresViews: PostgresView[] = [];

export const createPostgresView = (
  name: string,
  createViewQuery: string,
  createIndexQueries: string[] = [],
  refreshSpec?: PostgresViewRefreshSpec,
  dependencies?: SchemaDependency[],
) => {
  for (const view of postgresViews) {
    if (view.getCreateViewQuery() === createViewQuery) {
      return;
    }
  }
  const view = new PostgresView(
    name,
    createViewQuery,
    createIndexQueries,
    refreshSpec,
    dependencies,
  );
  postgresViews.push(view);
}

export const getPostgresViewByName = (name: string): PostgresView => {
  const view = postgresViews.find((view) => view.getName() === name);
  if (!view) {
    throw new Error(`Postgres view not found: ${name}`);
  }
  return view;
}

export const getAllPostgresViews = (): PostgresView[] => postgresViews;


export function registerViewCronJobs() {
  try {
    for (const view of getAllPostgresViews()) {
      view.registerCronJob();
    }
  } catch (e) {
    // eslint-disable-next-line no-console
    console.error("Failed to ensure Postgres views exist:", e);
  }
}

1	import { getSqlClientOrThrow } from "./sql/sqlClient";	20✔
2	import { queryWithLock } from "./queryWithLock";	20✔
3	import { addCronJob, CronJobSpec } from "./cronUtil";	20✔
4
5	type PostgresViewRefreshSpec = {
6	interval: string,
7	query: string,
8	}
9
10	export class PostgresView {
11	constructor(
12	private name: string,
13	private createViewQuery: string,
14	private createIndexQueries: string[] = [],
15	private refreshSpec?: PostgresViewRefreshSpec,
16	private dependencies?: SchemaDependency[],
17	private queryTimeout = 60,
18	) {}	162!
19
20	getName(): string {
UNCOV 21	return this.name;	×
22	}
23
24	getCreateViewQuery() {
25	return this.createViewQuery;	54✔
26	}
27
28	getCreateIndexQueries() {
UNCOV 29	return this.createIndexQueries;	×
30	}
31
32	getDependencies() {
33	return this.dependencies;	×
34	}
35
36	async refresh(db: SqlClient) {
37	if (this.refreshSpec) {
38	await queryWithLock(db, this.refreshSpec.query, this.queryTimeout);	×
39	}
40	}
41
42	registerCronJob() {	51✔
43	if (this.refreshSpec) {	51✔
44	addCronJob({	34✔
45	name: `refreshPostgresView-${this.name}`,
46	interval: this.refreshSpec.interval,
47	job: () => this.refresh(getSqlClientOrThrow()),	×
48	});
49	}
50	}
51	}
52
53	const postgresViews: PostgresView[] = [];	20✔
54
55	export const createPostgresView = (	20✔
56	name: string,
57	createViewQuery: string,
58	createIndexQueries: string[] = [],
59	refreshSpec?: PostgresViewRefreshSpec,
60	dependencies?: SchemaDependency[],
61	) => {	270!
62	for (const view of postgresViews) {	54✔
63	if (view.getCreateViewQuery() === createViewQuery) {	54!
64	return;	×
65	}
66	}
67	const view = new PostgresView(	54✔
68	name,
69	createViewQuery,
70	createIndexQueries,
71	refreshSpec,
72	dependencies,
73	);
74	postgresViews.push(view);	54✔
75	}
76
77	export const getPostgresViewByName = (name: string): PostgresView => {	20✔
78	const view = postgresViews.find((view) => view.getName() === name);	×
79	if (!view) {	×
80	throw new Error(`Postgres view not found: ${name}`);	×
81	}
82	return view;	×
83	}
84
85	export const getAllPostgresViews = (): PostgresView[] => postgresViews;	20✔
86
87
88	export function registerViewCronJobs() {
89	try {	51✔
90	for (const view of getAllPostgresViews()) {	51✔
91	view.registerCronJob();	51✔
92	}
93	} catch (e) {
94	// eslint-disable-next-line no-console
95	console.error("Failed to ensure Postgres views exist:", e);	×
96	}
97	}

ForumMagnum / ForumMagnum / 11253390128

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous