11239291532

Committed 08 Oct 2024 04:00PM UTC coverage: 85.934% (+0.003%) from 85.931%

Build # 11239291532

Build Type

push

github

Committed by

locker

Commit Message

box: log error that caused initial checkpoint failure

Currently, we just panic without providing any additional information
if we failed to create the initial checkpoint on bootstrap. This
complicates trouble shooting. Let's replace `panic()` with `say_error()`
and raise the exception that caused the failure. The exception will be
caught by `box_cfg()`, which will log it and then panic.

NO_DOC=error logging
NO_TEST=error logging
NO_CHANGELOG=error logging

(cherry picked from commit e1b5114d9)

Run Details

63101 of 114407 branches covered (55.15%)

2 of 6 new or added lines in 1 file covered. (33.33%)

20 existing lines in 8 files now uncovered.

93972 of 109354 relevant lines covered (85.93%)

2764748.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/src/lib/core/tt_sigaction.c

/*
 * SPDX-License-Identifier: BSD-2-Clause
 *
 * Copyright 2010-2022, Tarantool AUTHORS, please see AUTHORS file.
 */
#include <assert.h>
#include <pthread.h>
#include <stdbool.h>
#include "tt_sigaction.h"

#define SIGMAX 32

/** Flag is set if main_thread_id variable is initialized. */
static bool main_thread_initialized;
/** Main thread id, it is set on first tt_sigaction call. */
static pthread_t main_thread_id;

static void (*sighandlers[SIGMAX])(int signum);

/**
 * Check that signal has been delivered to the main thread
 * and call signal handler or redirect it if thread is not main.
 */
static void
sighandler_dispatcher(int signum)
{
        if (!pthread_equal(pthread_self(), main_thread_id)) {
                pthread_kill(main_thread_id, signum);
                return;
        }
        assert(sighandlers[signum] != NULL);
        sighandlers[signum](signum);
}

int
tt_sigaction(int signum, struct sigaction *sa, struct sigaction *osa)
{
        assert(signum < SIGMAX);
        assert(sa != NULL);

        /* Memorize id of main thread at the first call. */
        if (!main_thread_initialized) {
                main_thread_id = pthread_self();
                main_thread_initialized = true;
        }

        void (*old_handler)(int) = sighandlers[signum];
        if (sa->sa_handler == SIG_DFL || sa->sa_handler == SIG_IGN) {
                sighandlers[signum] = NULL;
        } else {
                sighandlers[signum] = sa->sa_handler;
                sa->sa_handler = sighandler_dispatcher;
        }
        int rc = sigaction(signum, sa, osa);
        if (osa != NULL && old_handler != NULL)
                osa->sa_handler = old_handler;
        return rc;
}

1	/*
2	* SPDX-License-Identifier: BSD-2-Clause
3	*
4	* Copyright 2010-2022, Tarantool AUTHORS, please see AUTHORS file.
5	*/
6	#include <assert.h>
7	#include <pthread.h>
8	#include <stdbool.h>
9	#include "tt_sigaction.h"
10
11	#define SIGMAX 32
12
13	/** Flag is set if main_thread_id variable is initialized. */
14	static bool main_thread_initialized;
15	/** Main thread id, it is set on first tt_sigaction call. */
16	static pthread_t main_thread_id;
17
18	static void (*sighandlers[SIGMAX])(int signum);
19
20	/**
21	* Check that signal has been delivered to the main thread
22	* and call signal handler or redirect it if thread is not main.
23	*/
24	static void
25	sighandler_dispatcher(int signum)	1,497,650✔
26	{
27	if (!pthread_equal(pthread_self(), main_thread_id)) {	1,497,650!
UNCOV 28	pthread_kill(main_thread_id, signum);	×
UNCOV 29	return;	×
30	}
31	assert(sighandlers[signum] != NULL);	1,497,650!
32	sighandlers[signum](signum);	1,497,650✔
33	}
34
35	int
36	tt_sigaction(int signum, struct sigaction sa, struct sigaction osa)	8,203✔
37	{
38	assert(signum < SIGMAX);	8,203!
39	assert(sa != NULL);	8,203!
40
41	/* Memorize id of main thread at the first call. */
42	if (!main_thread_initialized) {	8,203✔
43	main_thread_id = pthread_self();	4,091✔
44	main_thread_initialized = true;	4,091✔
45	}
46
47	void (*old_handler)(int) = sighandlers[signum];	8,203✔
48	if (sa->sa_handler == SIG_DFL \|\| sa->sa_handler == SIG_IGN) {	8,203!
49	sighandlers[signum] = NULL;	12✔
50	} else {
51	sighandlers[signum] = sa->sa_handler;	8,191✔
52	sa->sa_handler = sighandler_dispatcher;	8,191✔
53	}
54	int rc = sigaction(signum, sa, osa);	8,203✔
55	if (osa != NULL && old_handler != NULL)	8,203!
56	osa->sa_handler = old_handler;	×
57	return rc;	8,203✔
58	}

tarantool / tarantool / 11239291532

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous