11231754676

Committed 08 Oct 2024 08:40AM UTC coverage: 31.641% (-0.1%) from 31.751%

Build # 11231754676

Build Type

Pull #9851

github

Committed by

web-flow

Commit Message

Merge 6c8cbaa73 into b73db2ac9

Pull Request Pull Request #9851: Merge master to lw-deploy 2024 10 07

Run Details

5063 of 41830 branches covered (12.1%)

Branch coverage included in aggregate %.

166 of 562 new or added lines in 69 files covered. (29.54%)

24 existing lines in 13 files now uncovered.

29588 of 67684 relevant lines covered (43.71%)

180.85 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

34.78

/packages/lesswrong/server/callbacks/intercomCallbacks.ts

import { captureException } from '@sentry/core';
import { getIntercomClient } from '../intercomSetup';
import { getCollectionHooks } from '../mutationCallbacks';

getCollectionHooks("LWEvents").newAsync.add(async function sendIntercomEvent (event: DbLWEvent, user: DbUser) {
  try {
    const intercomClient = getIntercomClient();
    if (!intercomClient) {
      return;
    }
    if (!user || !event?.intercom) {
      return;
    }
    // Append documentId to metadata passed to intercom
    event.properties = {
      ...event.properties,
      documentId: event.documentId,
    }
    let currentTime = new Date();
    await intercomClient.events.create({
      eventName: event.name ?? "",
      createdAt: Math.floor((currentTime.getTime()/1000)),
      userId: user._id,
      metadata: event.properties
    });
  } catch(e) {
    // `intercomClient.events.create` involves a request to Intercom's servers,
    // which can fail. We had an issue where the request to Intercom's server
    // would fail with a 401 (unauthorized), the exception would bubble out of
    // this callback, and an LW user's request to `/graphql`, containing a
    // page-view event and also some requests for data, would return that 401.
    // This would cause the user to see a spurious login prompt, and also the
    // request itself would fail.
    captureException(e);
  }
});

1	import { captureException } from '@sentry/core';	19✔
2	import { getIntercomClient } from '../intercomSetup';	19✔
3	import { getCollectionHooks } from '../mutationCallbacks';	19✔
4
5	getCollectionHooks("LWEvents").newAsync.add(async function sendIntercomEvent (event: DbLWEvent, user: DbUser) {
6	try {	25✔
7	const intercomClient = getIntercomClient();	25✔
8	if (!intercomClient) {	25!
9	return;	25✔
10	}
11	if (!user \|\| !event?.intercom) {	×
12	return;	×
13	}
14	// Append documentId to metadata passed to intercom
15	event.properties = {	×
16	...event.properties,
17	documentId: event.documentId,
18	}
19	let currentTime = new Date();	×
NEW 20	await intercomClient.events.create({	×
21	eventName: event.name ?? "",	×
22	createdAt: Math.floor((currentTime.getTime()/1000)),
23	userId: user._id,
24	metadata: event.properties
25	});
26	} catch(e) {
27	// `intercomClient.events.create` involves a request to Intercom's servers,
28	// which can fail. We had an issue where the request to Intercom's server
29	// would fail with a 401 (unauthorized), the exception would bubble out of
30	// this callback, and an LW user's request to `/graphql`, containing a
31	// page-view event and also some requests for data, would return that 401.
32	// This would cause the user to see a spurious login prompt, and also the
33	// request itself would fail.
34	captureException(e);	×
35	}
36	});

ForumMagnum / ForumMagnum / 11231754676

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous