11213166769

Committed 07 Oct 2024 10:01AM UTC coverage: 64.733% (+0.08%) from 64.656%

Build # 11213166769

Build Type

Pull #14693

github

Committed by

web-flow

Commit Message

Merge 18169f0d0 into ec0e381c2

Pull Request Pull Request #14693: rec: implement rfc6303 special zones (mostly v6 reverse mappings)

Run Details

37127 of 88056 branches covered (42.16%)

Branch coverage included in aggregate %.

29 of 31 new or added lines in 2 files covered. (93.55%)

1593 existing lines in 27 files now uncovered.

125040 of 162462 relevant lines covered (76.97%)

4981436.88 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

89.66

/ext/lmdb-safe/lmdb-typed.cc

#include "lmdb-typed.hh"
#include "pdns/dns_random.hh"

unsigned int MDBGetMaxID(MDBRWTransaction& txn, MDBDbi& dbi)
{
  auto cursor = txn->getRWCursor(dbi);
  MDBOutVal maxidval{};
  MDBOutVal maxcontent{};
  unsigned int maxid{0};
  if (cursor.get(maxidval, maxcontent, MDB_LAST) == 0) {
    maxid = maxidval.getNoStripHeader<unsigned int>();
  }
  return maxid;
}

unsigned int MDBGetRandomID(MDBRWTransaction& txn, MDBDbi& dbi)
{
  auto cursor = txn->getRWCursor(dbi);
  unsigned int newID = 0;
  for (int attempts = 0; attempts < 20; attempts++) {
    MDBOutVal key{};
    MDBOutVal content{};

    // dns_random generates a random number in [0..signed_int_max-1]. We add 1 to avoid 0 and allow type_max.
    // 0 is avoided because the put() interface uses it to mean "please allocate a number for me"
    newID = dns_random(std::numeric_limits<signed int>::max()) + 1;
    if (cursor.find(MDBInVal(newID), key, content) != 0) {
      return newID;
    }
  }
  throw std::runtime_error("MDBGetRandomID() could not assign an unused random ID");
}

1	#include "lmdb-typed.hh"
2	#include "pdns/dns_random.hh"
3
4	unsigned int MDBGetMaxID(MDBRWTransaction& txn, MDBDbi& dbi)
5	{	497✔
6	auto cursor = txn->getRWCursor(dbi);	497✔
7	MDBOutVal maxidval{};	497✔
8	MDBOutVal maxcontent{};	497✔
9	unsigned int maxid{0};	497✔
10	if (cursor.get(maxidval, maxcontent, MDB_LAST) == 0) {	497✔
11	maxid = maxidval.getNoStripHeader<unsigned int>();	470✔
12	}	470✔
13	return maxid;	497✔
14	}	497✔
15
16	unsigned int MDBGetRandomID(MDBRWTransaction& txn, MDBDbi& dbi)
17	{	276✔
18	auto cursor = txn->getRWCursor(dbi);	276✔
19	unsigned int newID = 0;	276✔
20	for (int attempts = 0; attempts < 20; attempts++) {	276!
21	MDBOutVal key{};	276✔
22	MDBOutVal content{};	276✔
23
24	// dns_random generates a random number in [0..signed_int_max-1]. We add 1 to avoid 0 and allow type_max.
25	// 0 is avoided because the put() interface uses it to mean "please allocate a number for me"
26	newID = dns_random(std::numeric_limits<signed int>::max()) + 1;	276✔
27	if (cursor.find(MDBInVal(newID), key, content) != 0) {	276!
28	return newID;	276✔
29	}	276✔
30	}	276✔
UNCOV 31	throw std::runtime_error("MDBGetRandomID() could not assign an unused random ID");	×
32	}	276✔

PowerDNS / pdns / 11213166769

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous