1478

pending completion

Build # 1478

Build Type

Pull #586

travis-ci

Committed by

elmart

Commit Message

Broken build on 32 bit: Fix -Wtautological-constant-out-of-range-compare.

Problem:

[ 51%] Building C object src/CMakeFiles/nvim.dir/os/rstream.c.o
/Users/eliseo/projects/os/neovim/src/os/rstream.c:237:24: error: comparison of constant
      9223372036854775807 with expression of type 'size_t' (aka 'unsigned long') is always true
      [-Werror,-Wtautological-constant-out-of-range-compare]
  assert(rstream->fpos <= INT64_MAX);
         ~~~~~~~~~~~~~ ^  ~~~~~~~~~
/usr/include/assert.h:93:25: note: expanded from macro 'assert'
    (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __FILE__, __LINE__, #e) : (void)0)
                        ^

Solution:

Upcast rstream->fpos to (uintmax_t) to avoid warning in this particular
case (libuv strangely not using usual types for sizes/offsets).
By @aktau (Nicolas Hillegeer).

Pull Request Pull Request #586: [RFC] Broken build 32bit

Run Details

2 of 2 new or added lines in 2 files covered. (100.0%)

64955 of 113380 relevant lines covered (57.29%)

90572.57 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

51.8

/src/os/rstream.c

Build SHA Not Found

The commit SHA "633c0c081c7e15e5e003be0c5f4e8ca9c78c33e9" was not found in your repository, so the file cannot be loaded. This may be because you posted from a local development environment, or your CI created an ephemeral commit.

neovim / neovim / 1478

Source File Press 'n' to go to next uncovered line, 'b' for previous

Build SHA Not Found

Source File
Press 'n' to go to next uncovered line, 'b' for previous