11150219109

Committed 02 Oct 2024 07:20PM UTC coverage: 70.905% (-0.009%) from 70.914%

Build # 11150219109

Build Type

push

github

Committed by

web-flow

Commit Message

[Chore] Adding application config (#2658)

* [unfork] Adding application config (proposal for discussion) (#862)

* Application config

* Update kepler-gl.tsx

* Trying to fix failing tests

* Move applicationConfig to separate file to avoid test errors

* Revert "Trying to fix failing tests"

This reverts commit 1ee283aaa.

* Moving export to the end

* Adding missing dependency

* Comment and more explicit export

* Try to fix import errors

* Remove unnecessary change

* Moved applicationConfig to utils in another attempt to avoid errors in CI

* Reorg

* update demo-app yarn.ock

Signed-off-by: Shan He <heshan0131@gmail.com>

---------

Signed-off-by: Shan He <heshan0131@gmail.com>
Co-authored-by: Ilya Boyandin <iboyandin@foursquare.com>

Run Details

4882 of 8035 branches covered (60.76%)

Branch coverage included in aggregate %.

3 of 7 new or added lines in 3 files covered. (42.86%)

10332 of 13422 relevant lines covered (76.98%)

97.68 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

60.0

/src/utils/src/application-config.ts

/**
 * A mechanism to override default Kepler values/settings so that we
 * without having to make application-specific changes to the kepler repo.
 */
export type KeplerApplicationConfig = {
  /** Default name of export HTML file, can be overridden by user */
  defaultHtmlName?: string;
  defaultImageName?: string;
  defaultJsonName?: string;
  defaultDataName?: string;
  defaultExportJsonSettings?: {
    hasData?: boolean;
  };
};

const DEFAULT_APPLICATION_CONFIG: Required<KeplerApplicationConfig> = {
  defaultHtmlName: 'kepler.gl.html',
  defaultImageName: 'kepler.gl.png',
  defaultJsonName: 'kepler.gl.json',
  defaultDataName: 'kepler.gl',
  defaultExportJsonSettings: {
    hasData: true
  }
};

const applicationConfig: Required<KeplerApplicationConfig> = DEFAULT_APPLICATION_CONFIG;

export const getApplicationConfig = (): Required<KeplerApplicationConfig> => applicationConfig;

export function initApplicationConfig(appConfig: KeplerApplicationConfig = {}) {
  Object.assign(applicationConfig, appConfig);
}

1	/**
2	* A mechanism to override default Kepler values/settings so that we
3	* without having to make application-specific changes to the kepler repo.
4	*/
5	export type KeplerApplicationConfig = {
6	/** Default name of export HTML file, can be overridden by user */
7	defaultHtmlName?: string;
8	defaultImageName?: string;
9	defaultJsonName?: string;
10	defaultDataName?: string;
11	defaultExportJsonSettings?: {
12	hasData?: boolean;
13	};
14	};
15
16	const DEFAULT_APPLICATION_CONFIG: Required<KeplerApplicationConfig> = {	11✔
17	defaultHtmlName: 'kepler.gl.html',
18	defaultImageName: 'kepler.gl.png',
19	defaultJsonName: 'kepler.gl.json',
20	defaultDataName: 'kepler.gl',
21	defaultExportJsonSettings: {
22	hasData: true
23	}
24	};
25
26	const applicationConfig: Required<KeplerApplicationConfig> = DEFAULT_APPLICATION_CONFIG;	11✔
27
28	export const getApplicationConfig = (): Required<KeplerApplicationConfig> => applicationConfig;	11✔
29
30	export function initApplicationConfig(appConfig: KeplerApplicationConfig = {}) {	×
NEW 31	Object.assign(applicationConfig, appConfig);	×
32	}

keplergl / kepler.gl / 11150219109

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous