11061713363

Committed 26 Sep 2024 11:20PM UTC coverage: 31.749% (-0.02%) from 31.766%

Build # 11061713363

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9808 from ForumMagnum/moveImageDownIfPetrov

Petrov Fixes (adjust image size, add spotlight)

Run Details

5073 of 41652 branches covered (12.18%)

Branch coverage included in aggregate %.

1 of 2 new or added lines in 1 file covered. (50.0%)

1 existing line in 1 file now uncovered.

29564 of 67445 relevant lines covered (43.83%)

183.35 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

43.33

/packages/lesswrong/components/common/LWHome.tsx

import { Components, registerComponent } from '../../lib/vulcan-lib';
import React, { useEffect } from 'react';
import { AnalyticsContext } from "../../lib/analyticsEvents";
import { getReviewPhase, reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils';
import { showReviewOnFrontPageIfActive } from '../../lib/publicSettings';
import { useCookiesWithConsent } from '../hooks/useCookiesWithConsent';
import { LAST_VISITED_FRONTPAGE_COOKIE } from '../../lib/cookies/cookies';
import moment from 'moment';
import { visitorGetsDynamicFrontpage } from '../../lib/betas';
import { useSingle } from '@/lib/crud/withSingle';

const LWHome = () => {
  const { DismissibleSpotlightItem, RecentDiscussionFeed, AnalyticsInViewTracker, FrontpageReviewWidget,
    SingleColumnSection, FrontpageBestOfLWWidget, EAPopularCommentsSection,
    QuickTakesSection, LWHomePosts
  } = Components;

  const { document } = useSingle({
    collectionName: 'Spotlights',
    documentId: 'ezMAfa72gSy8HDHfX',
    fragmentName: "SpotlightDisplay",
  });

  return (
      <AnalyticsContext pageContext="homePage">
        <React.Fragment>
          <UpdateLastVisitCookie />

          {reviewIsActive() && getReviewPhase() === "RESULTS" && <SingleColumnSection>
            <FrontpageBestOfLWWidget reviewYear={REVIEW_YEAR}/>
          </SingleColumnSection>}
          {reviewIsActive() && getReviewPhase() !== "RESULTS" && showReviewOnFrontPageIfActive.get() && <SingleColumnSection>
            <FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
          </SingleColumnSection>}
          <SingleColumnSection>
            {/* change this to "current" after Petrov Day period */}
            <DismissibleSpotlightItem spotlight={document}/>
          </SingleColumnSection> 
          <AnalyticsInViewTracker
            eventProps={{inViewType: "homePosts"}}
            observerProps={{threshold:[0, 0.5, 1]}}
          >
            <LWHomePosts>
              <QuickTakesSection />
    
              <EAPopularCommentsSection />
    
              <RecentDiscussionFeed
                af={false}
                commentsLimit={4}
                maxAgeHours={18}
              />
            </LWHomePosts>
          </AnalyticsInViewTracker>
        </React.Fragment>
      </AnalyticsContext>
  )
}

const UpdateLastVisitCookie = () => {
  const [_, setCookie] = useCookiesWithConsent([LAST_VISITED_FRONTPAGE_COOKIE]);

  useEffect(() => {
    if (visitorGetsDynamicFrontpage(null)) {
      setCookie(LAST_VISITED_FRONTPAGE_COOKIE, new Date().toISOString(), { path: "/", expires: moment().add(1, 'year').toDate() });
    }
  }, [setCookie])
  
  return <></>
}

const LWHomeComponent = registerComponent('LWHome', LWHome);

declare global {
  interface ComponentTypes {
    LWHome: typeof LWHomeComponent
  }
}

1	import { Components, registerComponent } from '../../lib/vulcan-lib';	1✔
2	import React, { useEffect } from 'react';	1✔
3	import { AnalyticsContext } from "../../lib/analyticsEvents";	1✔
4	import { getReviewPhase, reviewIsActive, REVIEW_YEAR } from '../../lib/reviewUtils';	1✔
5	import { showReviewOnFrontPageIfActive } from '../../lib/publicSettings';	1✔
6	import { useCookiesWithConsent } from '../hooks/useCookiesWithConsent';	1✔
7	import { LAST_VISITED_FRONTPAGE_COOKIE } from '../../lib/cookies/cookies';	1✔
8	import moment from 'moment';	1✔
9	import { visitorGetsDynamicFrontpage } from '../../lib/betas';	1✔
10	import { useSingle } from '@/lib/crud/withSingle';	1✔
11
12	const LWHome = () => {	1✔
13	const { DismissibleSpotlightItem, RecentDiscussionFeed, AnalyticsInViewTracker, FrontpageReviewWidget,
14	SingleColumnSection, FrontpageBestOfLWWidget, EAPopularCommentsSection,
15	QuickTakesSection, LWHomePosts
16	} = Components;	×
17
NEW 18	const { document } = useSingle({	×
19	collectionName: 'Spotlights',
20	documentId: 'ezMAfa72gSy8HDHfX',
21	fragmentName: "SpotlightDisplay",
22	});
23
UNCOV 24	return (	×
25	<AnalyticsContext pageContext="homePage">
26	<React.Fragment>
27	<UpdateLastVisitCookie />	×
28
29	{reviewIsActive() && getReviewPhase() === "RESULTS" && <SingleColumnSection>
30	<FrontpageBestOfLWWidget reviewYear={REVIEW_YEAR}/>
31	</SingleColumnSection>}	×
32	{reviewIsActive() && getReviewPhase() !== "RESULTS" && showReviewOnFrontPageIfActive.get() && <SingleColumnSection>
33	<FrontpageReviewWidget reviewYear={REVIEW_YEAR}/>
34	</SingleColumnSection>}
35	<SingleColumnSection>
36	{/* change this to "current" after Petrov Day period */}
37	<DismissibleSpotlightItem spotlight={document}/>
38	</SingleColumnSection>
39	<AnalyticsInViewTracker
40	eventProps={{inViewType: "homePosts"}}
41	observerProps={{threshold:[0, 0.5, 1]}}
42	>
43	<LWHomePosts>
44	<QuickTakesSection />
45
46	<EAPopularCommentsSection />
47
48	<RecentDiscussionFeed
49	af={false}
50	commentsLimit={4}
51	maxAgeHours={18}
52	/>
53	</LWHomePosts>
54	</AnalyticsInViewTracker>
55	</React.Fragment>
56	</AnalyticsContext>
57	)
58	}
59
60	const UpdateLastVisitCookie = () => {	1✔
61	const [_, setCookie] = useCookiesWithConsent([LAST_VISITED_FRONTPAGE_COOKIE]);	×
62
63	useEffect(() => {	×
64	if (visitorGetsDynamicFrontpage(null)) {	×
65	setCookie(LAST_VISITED_FRONTPAGE_COOKIE, new Date().toISOString(), { path: "/", expires: moment().add(1, 'year').toDate() });	×
66	}
67	}, [setCookie])
68
69	return <></>	×
70	}
71
72	const LWHomeComponent = registerComponent('LWHome', LWHome);	1✔
73
74	declare global {
75	interface ComponentTypes {
76	LWHome: typeof LWHomeComponent
77	}
78	}

ForumMagnum / ForumMagnum / 11061713363

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous