84d6e391-ead8-4226-b9d6-29cd9224a73b

Committed 23 Sep 2024 03:28AM UTC coverage: 96.132% (+0.5%) from 95.601%

Build # 84d6e391-ead8-4226-b9d6-29cd9224a73b

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[MAINTENANCE] Remove dead code - Hyrax 1.x Actor Stack compatibility

**RATIONALE**
During the migration of the application from Hyrax 1.x to Hyrax 2.x,
a compatibility layer was implemented to allow the Hyrax 2 application
to support Hyrax 1 style actor calls while the codebase was
inrementally updated.

see changes to `config/initializers/hyrax.rb` in https://github.com/curationexperts/laevigata/commit/bec8dd11a for more context.

The application updates to Hyrax 2 style actor calls were completed,
but the shim code was never removed.

This change removes the no longer used compatibility layer.

Run Details

2858 of 2973 relevant lines covered (96.13%)

53.62 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

100.0

/app/validators/my_files_validator.rb

class MyFilesValidator < ActiveModel::Validator
  def validate(record)
    return unless current_tab?(record)
    record.errors.add('files', "A thesis or dissertation file is required") if parsed_data(record)['files'].nil?

    record.errors.add('supplementalFiles', "A title, description and file type are required for each Supplemental File.") if file_without_metadata(record)
  end

  def parsed_data(record)
    return {} unless record.data
    JSON.parse(record.data)
  end

  def current_tab?(record)
    parsed_data(record)['currentTab'] == "My Files"
  end

  def file_without_metadata(record)
    return false if parsed_data(record)['supplemental_files'].nil?
    return true if parsed_data(record)['supplemental_file_metadata'].nil?

    meta_missing = false
    parsed_data(record)['supplemental_file_metadata'].each do |sf|
      meta_missing = sf[1]['title'].blank? || sf[1]['description'].blank? || sf[1]['file_type'].blank? ? true : false
    end
    meta_missing
  end
end

1	class MyFilesValidator < ActiveModel::Validator	4✔
2	def validate(record)	4✔
3	return unless current_tab?(record)	91✔
4	record.errors.add('files', "A thesis or dissertation file is required") if parsed_data(record)['files'].nil?	7✔
5
6	record.errors.add('supplementalFiles', "A title, description and file type are required for each Supplemental File.") if file_without_metadata(record)	7✔
7	end
8
9	def parsed_data(record)	4✔
10	return {} unless record.data	112✔
11	JSON.parse(record.data)	86✔
12	end
13
14	def current_tab?(record)	4✔
15	parsed_data(record)['currentTab'] == "My Files"	91✔
16	end
17
18	def file_without_metadata(record)	4✔
19	return false if parsed_data(record)['supplemental_files'].nil?	7✔
20	return true if parsed_data(record)['supplemental_file_metadata'].nil?	4✔
21
22	meta_missing = false	3✔
23	parsed_data(record)['supplemental_file_metadata'].each do \|sf\|	3✔
24	meta_missing = sf[1]['title'].blank? \|\| sf[1]['description'].blank? \|\| sf[1]['file_type'].blank? ? true : false	3✔
25	end
26	meta_missing	3✔
27	end
28	end

curationexperts / laevigata / 84d6e391-ead8-4226-b9d6-29cd9224a73b

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous