7be21e87-9845-428e-8213-10afa6852869

Committed 20 Sep 2024 01:28AM UTC coverage: 95.066% (+0.03%) from 95.036%

Build # 7be21e87-9845-428e-8213-10afa6852869

Build Type

push

circleci

Committed by

mark-dce

Commit Message

[REFACTOR] SupplementalFile metadata processing in ETD Controlleri

**ISSUE**
The controller has logging code related to an issue in the now
obsolete Rails form. See:
https://github.com/curationexperts/laevigata/commit/82452b536

The Honeybadger notification is no longer relevant with the
JavaScript submission form.

We've also slightly modified the call structure of supporting
calls and made the respective methods private since they should
not be called outside the controller request context.

Run Details

13 of 13 new or added lines in 1 file covered. (100.0%)

318 existing lines in 32 files now uncovered.

2890 of 3040 relevant lines covered (95.07%)

52.69 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

87.5

/app/models/solr_document.rb

# frozen_string_literal: true
class SolrDocument
  include Blacklight::Solr::Document
  include Blacklight::Gallery::OpenseadragonSolrDocument

  # Adds Hyrax behaviors to the SolrDocument.
  include Hyrax::SolrDocumentBehavior

  # self.unique_key = 'id'

  # Email uses the semantic field mappings below to generate the body of an email.
  SolrDocument.use_extension(Blacklight::Document::Email)

  # SMS uses the semantic field mappings below to generate the body of an SMS email.
  SolrDocument.use_extension(Blacklight::Document::Sms)

  # DublinCore uses the semantic field mappings below to assemble an OAI-compliant Dublin Core document
  # Semantic mappings of solr stored fields. Fields may be multi or
  # single valued. See Blacklight::Document::SemanticFields#field_semantics
  # and Blacklight::Document::SemanticFields#to_semantic_values
  # Recommendation: Use field names from Dublin Core
  use_extension(Blacklight::Document::DublinCore)

  # Do content negotiation for AF models.

  use_extension(Hydra::ContentNegotiation)

  def abstract
    self[Solrizer.solr_name('abstract')]
  end

  # If this is a boolean, return the boolean value
  # If this is a string, transform it into a boolean
  # If the value is nil or can't be determined, assume it is NOT embargoed
  def abstract_embargoed
    return self['abstract_embargoed_bsi'] unless self['abstract_embargoed_bsi'].nil?
    return self['abstract_embargoed_tesim'].first.to_s == "true" if self['abstract_embargoed_tesim']
    false
  end

  # If this is a boolean, return the boolean value
  # If this is a string, transform it into a boolean
  # If the value is nil or can't be determined, assume it is NOT embargoed
  def toc_embargoed
    return self['toc_embargoed_bsi'] unless self['toc_embargoed_bsi'].nil?
    return self['toc_embargoed_tesim'].first.to_s == "true" if self['toc_embargoed_tesim']
    false
  end

  # If this is a boolean, return the boolean value
  # If this is a string, transform it into a boolean
  # If the value is nil or can't be determined, assume it is NOT embargoed
  def files_embargoed
    return self['files_embargoed_bsi'] unless self['files_embargoed_bsi'].nil?
    return self['files_embargoed_tesim'].first.to_s == "true" if self['files_embargoed_tesim']
    false
  end

  def table_of_contents
    self[Solrizer.solr_name('table_of_contents')]
  end

  def committee_chair_name
    self[Solrizer.solr_name('committee_chair_name')]
  end

  def committee_members_names
    self[Solrizer.solr_name('committee_members_names')]
  end

  def date_modified
    ActiveSupport::TimeZone['US/Eastern'].parse(fetch('date_modified_dtsi', ''))
  end

  def date_uploaded
    ActiveSupport::TimeZone['US/Eastern'].parse(fetch('date_uploaded_dtsi', ''))
  end

  def degree
    self[Solrizer.solr_name('degree')]
  end

  # @return [DateTime] - the day recorded by the Registrar that a degree wqs granted - time value it typically truncated
  # see `graduation_date` for the semester and year value used for faceting
  def degree_awarded
    self['degree_awarded_dtsi'] || self['degree_awarded_ssi'] || self['degree_awarded_dtsim']&.first || self['degree_awarded_tesim']&.first
  end

  # @return [String] - the semester and year (or just year for legacy records) of graduation - e.g. "2018", "Fall 2021"
  # see `degree_awarded` for the timestamp representing the day the degree was recorded by the Emory Registrar
  def graduation_date
    self[Solrizer.solr_name('graduation_date', :stored_sortable)] || self[Solrizer.solr_name('graduation_date', :stored_searchable)]&.first
  end

  def department
    self[Solrizer.solr_name('department')]
  end

  def description
    self[Solrizer.solr_name('description')] || []
  end

  def embargo_length
    self['embargo_length_ssi']
  end

  def hidden?
    self[Solrizer.solr_name('hidden?', type: :boolean)]
  end

  def school
    self[Solrizer.solr_name('school')]
  end

  def subfield
    self[Solrizer.solr_name('subfield')]
  end

  def partnering_agency
    self[Solrizer.solr_name('partnering_agency')]
  end

  def pcdm_use
    self[Solrizer.solr_name('pcdm_use')]
  end

  def submitting_type
    self[Solrizer.solr_name('submitting_type')]
  end

  def research_field
    self[Solrizer.solr_name('research_field')]
  end

  def rights_statement
    self[Solrizer.solr_name('rights_statement')]
  end

  def requires_permissions
    self[Solrizer.solr_name('requires_permissions')]
  end

  def other_copyrights
    self[Solrizer.solr_name('other_copyrights')]
  end

  def patents
    self[Solrizer.solr_name('patents')]
  end

  def proquest_submission_date
    self[Solrizer.solr_name('proquest_submission_date')]
  end

  def visibility
    VisibilityTranslator
      .new(obj: self)
      .visibility
  end

  def under_embargo?
    embargo_release_date.present? && embargo_release_date > Time.current
  end
end

1	# frozen_string_literal: true
2	class SolrDocument	4✔
3	include Blacklight::Solr::Document	4✔
4	include Blacklight::Gallery::OpenseadragonSolrDocument	4✔
5
6	# Adds Hyrax behaviors to the SolrDocument.
7	include Hyrax::SolrDocumentBehavior	4✔
8
9	# self.unique_key = 'id'
10
11	# Email uses the semantic field mappings below to generate the body of an email.
12	SolrDocument.use_extension(Blacklight::Document::Email)	4✔
13
14	# SMS uses the semantic field mappings below to generate the body of an SMS email.
15	SolrDocument.use_extension(Blacklight::Document::Sms)	4✔
16
17	# DublinCore uses the semantic field mappings below to assemble an OAI-compliant Dublin Core document
18	# Semantic mappings of solr stored fields. Fields may be multi or
19	# single valued. See Blacklight::Document::SemanticFields#field_semantics
20	# and Blacklight::Document::SemanticFields#to_semantic_values
21	# Recommendation: Use field names from Dublin Core
22	use_extension(Blacklight::Document::DublinCore)	4✔
23
24	# Do content negotiation for AF models.
25
26	use_extension(Hydra::ContentNegotiation)	4✔
27
28	def abstract	4✔
29	self[Solrizer.solr_name('abstract')]	102✔
30	end
31
32	# If this is a boolean, return the boolean value
33	# If this is a string, transform it into a boolean
34	# If the value is nil or can't be determined, assume it is NOT embargoed
35	def abstract_embargoed	4✔
36	return self['abstract_embargoed_bsi'] unless self['abstract_embargoed_bsi'].nil?	51✔
37	return self['abstract_embargoed_tesim'].first.to_s == "true" if self['abstract_embargoed_tesim']	×
38	false	×
39	end
40
41	# If this is a boolean, return the boolean value
42	# If this is a string, transform it into a boolean
43	# If the value is nil or can't be determined, assume it is NOT embargoed
44	def toc_embargoed	4✔
45	return self['toc_embargoed_bsi'] unless self['toc_embargoed_bsi'].nil?	33✔
46	return self['toc_embargoed_tesim'].first.to_s == "true" if self['toc_embargoed_tesim']	×
47	false	×
48	end
49
50	# If this is a boolean, return the boolean value
51	# If this is a string, transform it into a boolean
52	# If the value is nil or can't be determined, assume it is NOT embargoed
53	def files_embargoed	4✔
54	return self['files_embargoed_bsi'] unless self['files_embargoed_bsi'].nil?	49✔
55	return self['files_embargoed_tesim'].first.to_s == "true" if self['files_embargoed_tesim']	×
56	false	×
57	end
58
59	def table_of_contents	4✔
60	self[Solrizer.solr_name('table_of_contents')]	100✔
61	end
62
63	def committee_chair_name	4✔
64	self[Solrizer.solr_name('committee_chair_name')]	32✔
65	end
66
67	def committee_members_names	4✔
68	self[Solrizer.solr_name('committee_members_names')]	32✔
69	end
70
71	def date_modified	4✔
72	ActiveSupport::TimeZone['US/Eastern'].parse(fetch('date_modified_dtsi', ''))	31✔
73	end
74
75	def date_uploaded	4✔
76	ActiveSupport::TimeZone['US/Eastern'].parse(fetch('date_uploaded_dtsi', ''))	21✔
77	end
78
79	def degree	4✔
80	self[Solrizer.solr_name('degree')]	32✔
81	end
82
83	# @return [DateTime] - the day recorded by the Registrar that a degree wqs granted - time value it typically truncated
84	# see `graduation_date` for the semester and year value used for faceting
85	def degree_awarded	4✔
86	self['degree_awarded_dtsi'] \|\| self['degree_awarded_ssi'] \|\| self['degree_awarded_dtsim']&.first \|\| self['degree_awarded_tesim']&.first	80✔
87	end
88
89	# @return [String] - the semester and year (or just year for legacy records) of graduation - e.g. "2018", "Fall 2021"
90	# see `degree_awarded` for the timestamp representing the day the degree was recorded by the Emory Registrar
91	def graduation_date	4✔
UNCOV 92	self[Solrizer.solr_name('graduation_date', :stored_sortable)] \|\| self[Solrizer.solr_name('graduation_date', :stored_searchable)]&.first	25✔
93	end
94
95	def department	4✔
96	self[Solrizer.solr_name('department')]	32✔
97	end
98
99	def description	4✔
100	self[Solrizer.solr_name('description')] \|\| []	65✔
101	end
102
103	def embargo_length	4✔
104	self['embargo_length_ssi']	55✔
105	end
106
107	def hidden?	4✔
108	self[Solrizer.solr_name('hidden?', type: :boolean)]	40✔
109	end
110
111	def school	4✔
112	self[Solrizer.solr_name('school')]	98✔
113	end
114
115	def subfield	4✔
116	self[Solrizer.solr_name('subfield')]	×
117	end
118
119	def partnering_agency	4✔
UNCOV 120	self[Solrizer.solr_name('partnering_agency')]	4✔
121	end
122
123	def pcdm_use	4✔
124	self[Solrizer.solr_name('pcdm_use')]	×
125	end
126
127	def submitting_type	4✔
128	self[Solrizer.solr_name('submitting_type')]	195✔
129	end
130
131	def research_field	4✔
132	self[Solrizer.solr_name('research_field')]	60✔
133	end
134
135	def rights_statement	4✔
136	self[Solrizer.solr_name('rights_statement')]	32✔
137	end
138
139	def requires_permissions	4✔
140	self[Solrizer.solr_name('requires_permissions')]	13✔
141	end
142
143	def other_copyrights	4✔
144	self[Solrizer.solr_name('other_copyrights')]	13✔
145	end
146
147	def patents	4✔
148	self[Solrizer.solr_name('patents')]	13✔
149	end
150
151	def proquest_submission_date	4✔
152	self[Solrizer.solr_name('proquest_submission_date')]	×
153	end
154
155	def visibility	4✔
156	VisibilityTranslator	39✔
157	.new(obj: self)
158	.visibility
159	end
160
161	def under_embargo?	4✔
162	embargo_release_date.present? && embargo_release_date > Time.current	230✔
163	end
164	end

curationexperts / laevigata / 7be21e87-9845-428e-8213-10afa6852869

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous