10924354562

Committed 18 Sep 2024 02:33PM UTC coverage: 13.805% (-0.03%) from 13.838%

Build # 10924354562

Build Type

Pull #9265

github

Committed by

web-flow

Commit Message

Merge 8913c82cb into cd47111a4

Pull Request Pull Request #9265: Safe URI Decoding + Profile Bio Decoding

Run Details

3045 of 20411 branches covered (14.92%)

Branch coverage included in aggregate %.

3 of 38 new or added lines in 8 files covered. (7.89%)

1 existing line in 1 file now uncovered.

3960 of 30330 relevant lines covered (13.06%)

3.97 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

1.69

/packages/commonwealth/server/routes/feed.ts

import { AppError } from '@hicommonwealth/core';
import { Thread, ThreadAttributes, type DB } from '@hicommonwealth/model';
import { getDecodedString, slugify } from '@hicommonwealth/shared';
import { Feed } from 'feed';
import { GetBulkThreadsResult } from '../controllers/server_threads_methods/get_bulk_threads';
import { ServerControllers } from '../routing/router';
import { TypedRequestQuery, TypedResponse } from '../types';
import { formatErrorPretty } from '../util/errorFormat';
import {
  ActiveThreadsRequestQuery,
  BulkThreadsRequestQuery,
  GetThreadsRequestQuery,
  GetThreadsResponse,
  SearchThreadsRequestQuery,
} from './threads/get_threads_handler';

function toDate(t: ThreadAttributes): Date {
  // @ts-expect-error StrictNullChecks
  return t.last_edited ?? t.created_at;
}

function sortByDateDesc(a: ThreadAttributes, b: ThreadAttributes) {
  return toDate(b).getTime() - toDate(a).getTime();
}

function computeUpdated(bulkThreads: GetBulkThreadsResult): Date {
  if (bulkThreads.threads.length === 0) {
    // there are no threads
    return new Date();
  }

  const sortedByDateDesc = [...bulkThreads.threads].sort(sortByDateDesc);

  // return the most recent thread and get its date
  return toDate(sortedByDateDesc[0]);
}
export const getFeedHandler = async (
  models: DB,
  controllers: ServerControllers,
  req: TypedRequestQuery<
    GetThreadsRequestQuery &
      (
        | ActiveThreadsRequestQuery
        | SearchThreadsRequestQuery
        | BulkThreadsRequestQuery
      )
  >,
  res: TypedResponse<GetThreadsResponse>,
) => {
  const queryValidationResult = Thread.GetThreadsParamsSchema.safeParse(
    req.query,
  );

  if (queryValidationResult.success === false) {
    throw new AppError(formatErrorPretty(queryValidationResult));
  }

  const { thread_ids, bulk, active, search, community_id } =
    queryValidationResult.data;

  if (active || search || thread_ids) {
    throw new Error('Not implemented');
  }

  // get bulk threads
  if (bulk) {
    const bulkQueryValidationResult =
      Thread.GetBulkThreadsParamsSchema.safeParse(req.query);

    if (bulkQueryValidationResult.success === false) {
      throw new AppError(formatErrorPretty(bulkQueryValidationResult));
    }

    const {
      stage,
      topic_id,
      includePinnedThreads,
      limit,
      page,
      orderBy,
      from_date,
      to_date,
      archived,
      contestAddress,
      status,
    } = bulkQueryValidationResult.data;

    const bulkThreads = await controllers.threads.getBulkThreads({
      communityId: community_id,
      // @ts-expect-error StrictNullChecks
      stage,
      // @ts-expect-error StrictNullChecks
      topicId: topic_id,
      // @ts-expect-error StrictNullChecks
      includePinnedThreads,
      // @ts-expect-error StrictNullChecks
      page,
      // @ts-expect-error StrictNullChecks
      limit,
      // @ts-expect-error StrictNullChecks
      orderBy,
      // @ts-expect-error StrictNullChecks
      fromDate: from_date,
      // @ts-expect-error StrictNullChecks
      toDate: to_date,
      // @ts-expect-error StrictNullChecks
      archived: archived,
      // @ts-expect-error StrictNullChecks
      contestAddress,
      // @ts-expect-error StrictNullChecks
      status,
    });

    const community = await models.Community.findOne({
      where: {
        id: community_id,
      },
    });
    const updated = computeUpdated(bulkThreads);
    // const self = `${req.protocol}://${req.get('host')}${req.originalUrl}`;

    const feed = new Feed({
      // @ts-expect-error StrictNullChecks
      title: community.name,
      // @ts-expect-error StrictNullChecks
      description: community.description,
      id: `https://common.xyz/${community_id}/discussions`,
      link: `https://common.xyz/${community_id}/discussions`,
      // @ts-expect-error StrictNullChecks
      image: community.icon_url,
      copyright: 'All rights Reserved 2024, common.xyz',
      updated,
      generator: 'common.xyz',
      feedLinks: {
        // atom: self
      },
    });

    bulkThreads.threads.forEach((thread) => {
      const title = getDecodedString(thread.title);
      const slug = slugify(title);
      feed.addItem({
        title: title,
        // @ts-expect-error StrictNullChecks
        id: thread.url,
        link: `https://common.xyz/${community_id}/discussions/${thread.id}-${slug}`,
        date: toDate(thread),
        // @ts-expect-error StrictNullChecks
        content: thread.body,
        // @ts-expect-error StrictNullChecks
        description: thread.plaintext,
        author: [
          {
            // @ts-expect-error StrictNullChecks
            name: thread.profile_name,
          },
        ],
      });
    });

    // set the content type in the response header.
    // res.setHeader('content-type', 'text/xml.');
    res.setHeader('content-type', 'application/atom+xml.');

    res.write(feed.atom1());
    res.end();
  }
};

1	import { AppError } from '@hicommonwealth/core';
2	import { Thread, ThreadAttributes, type DB } from '@hicommonwealth/model';
3	import { getDecodedString, slugify } from '@hicommonwealth/shared';
4	import { Feed } from 'feed';
5	import { GetBulkThreadsResult } from '../controllers/server_threads_methods/get_bulk_threads';
6	import { ServerControllers } from '../routing/router';
7	import { TypedRequestQuery, TypedResponse } from '../types';
8	import { formatErrorPretty } from '../util/errorFormat';
9	import {
10	ActiveThreadsRequestQuery,
11	BulkThreadsRequestQuery,
12	GetThreadsRequestQuery,
13	GetThreadsResponse,
14	SearchThreadsRequestQuery,
15	} from './threads/get_threads_handler';
16
17	function toDate(t: ThreadAttributes): Date {
18	// @ts-expect-error StrictNullChecks
19	return t.last_edited ?? t.created_at;	×
20	}
21
22	function sortByDateDesc(a: ThreadAttributes, b: ThreadAttributes) {
23	return toDate(b).getTime() - toDate(a).getTime();	×
24	}
25
26	function computeUpdated(bulkThreads: GetBulkThreadsResult): Date {
27	if (bulkThreads.threads.length === 0) {	×
28	// there are no threads
29	return new Date();	×
30	}
31
32	const sortedByDateDesc = [...bulkThreads.threads].sort(sortByDateDesc);	×
33
34	// return the most recent thread and get its date
35	return toDate(sortedByDateDesc[0]);	×
36	}
37	export const getFeedHandler = async (	17✔
38	models: DB,
39	controllers: ServerControllers,
40	req: TypedRequestQuery<
41	GetThreadsRequestQuery &
42	(
43	\| ActiveThreadsRequestQuery
44	\| SearchThreadsRequestQuery
45	\| BulkThreadsRequestQuery
46	)
47	>,
48	res: TypedResponse<GetThreadsResponse>,
49	) => {
50	const queryValidationResult = Thread.GetThreadsParamsSchema.safeParse(	×
51	req.query,
52	);
53
54	if (queryValidationResult.success === false) {	×
55	throw new AppError(formatErrorPretty(queryValidationResult));	×
56	}
57
58	const { thread_ids, bulk, active, search, community_id } =
59	queryValidationResult.data;	×
60
61	if (active \|\| search \|\| thread_ids) {	×
62	throw new Error('Not implemented');	×
63	}
64
65	// get bulk threads
66	if (bulk) {	×
67	const bulkQueryValidationResult =
68	Thread.GetBulkThreadsParamsSchema.safeParse(req.query);	×
69
70	if (bulkQueryValidationResult.success === false) {	×
71	throw new AppError(formatErrorPretty(bulkQueryValidationResult));	×
72	}
73
74	const {
75	stage,
76	topic_id,
77	includePinnedThreads,
78	limit,
79	page,
80	orderBy,
81	from_date,
82	to_date,
83	archived,
84	contestAddress,
85	status,
86	} = bulkQueryValidationResult.data;	×
87
88	const bulkThreads = await controllers.threads.getBulkThreads({	×
89	communityId: community_id,
90	// @ts-expect-error StrictNullChecks
91	stage,
92	// @ts-expect-error StrictNullChecks
93	topicId: topic_id,
94	// @ts-expect-error StrictNullChecks
95	includePinnedThreads,
96	// @ts-expect-error StrictNullChecks
97	page,
98	// @ts-expect-error StrictNullChecks
99	limit,
100	// @ts-expect-error StrictNullChecks
101	orderBy,
102	// @ts-expect-error StrictNullChecks
103	fromDate: from_date,
104	// @ts-expect-error StrictNullChecks
105	toDate: to_date,
106	// @ts-expect-error StrictNullChecks
107	archived: archived,
108	// @ts-expect-error StrictNullChecks
109	contestAddress,
110	// @ts-expect-error StrictNullChecks
111	status,
112	});
113
114	const community = await models.Community.findOne({	×
115	where: {
116	id: community_id,
117	},
118	});
119	const updated = computeUpdated(bulkThreads);	×
120	// const self = `${req.protocol}://${req.get('host')}${req.originalUrl}`;
121
122	const feed = new Feed({	×
123	// @ts-expect-error StrictNullChecks
124	title: community.name,
125	// @ts-expect-error StrictNullChecks
126	description: community.description,
127	id: `https://common.xyz/${community_id}/discussions`,
128	link: `https://common.xyz/${community_id}/discussions`,
129	// @ts-expect-error StrictNullChecks
130	image: community.icon_url,
131	copyright: 'All rights Reserved 2024, common.xyz',
132	updated,
133	generator: 'common.xyz',
134	feedLinks: {
135	// atom: self
136	},
137	});
138
139	bulkThreads.threads.forEach((thread) => {	×
NEW 140	const title = getDecodedString(thread.title);	×
141	const slug = slugify(title);	×
142	feed.addItem({	×
143	title: title,
144	// @ts-expect-error StrictNullChecks
145	id: thread.url,
146	link: `https://common.xyz/${community_id}/discussions/${thread.id}-${slug}`,
147	date: toDate(thread),
148	// @ts-expect-error StrictNullChecks
149	content: thread.body,
150	// @ts-expect-error StrictNullChecks
151	description: thread.plaintext,
152	author: [
153	{
154	// @ts-expect-error StrictNullChecks
155	name: thread.profile_name,
156	},
157	],
158	});
159	});
160
161	// set the content type in the response header.
162	// res.setHeader('content-type', 'text/xml.');
163	res.setHeader('content-type', 'application/atom+xml.');	×
164
165	res.write(feed.atom1());	×
166	res.end();	×
167	}
168	};

hicommonwealth / commonwealth / 10924354562

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous