10909002435

Committed 17 Sep 2024 06:36PM UTC coverage: 13.72% (-0.009%) from 13.729%

Build # 10909002435

Build Type

Pull #9256

github

Committed by

web-flow

Commit Message

Merge a32e58a64 into e48016d6c

Pull Request Pull Request #9256: Refactors delete thread

Run Details

3026 of 20520 branches covered (14.75%)

Branch coverage included in aggregate %.

40 of 59 new or added lines in 14 files covered. (67.8%)

41 existing lines in 5 files now uncovered.

3963 of 30419 relevant lines covered (13.03%)

3.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

56.25

/packages/commonwealth/server/controllers/server_topics_methods/update_topic_channel.ts

import { AppError } from '@hicommonwealth/core';
import { UserInstance } from '@hicommonwealth/model';
import { Op } from 'sequelize';
import { validateOwner } from '../../util/validateOwner';
import { ServerTopicsController } from '../server_topics_controller';

const Errors = {
  MissingTopic: 'Invalid topic ID',
  Failed: 'Unable to save',
  NotAdmin: 'Not an admin',
};

export type UpdateTopicChannelOptions = {
  user: UserInstance;
  topicId: number;
  channelId: string;
};

export type UpdateTopicChannelResult = void;

export async function __updateTopicChannel(
  this: ServerTopicsController,
  { user, topicId, channelId }: UpdateTopicChannelOptions,
): Promise<UpdateTopicChannelResult> {
  const topic = await this.models.Topic.findByPk(topicId);
  if (!topic) {
    throw new AppError(Errors.MissingTopic);
  }

  const isAdmin = await validateOwner({
    models: this.models,
    user: user,
    communityId: topic.community_id,
    allowMod: true,
    allowAdmin: true,
    allowSuperAdmin: true,
  });

  if (!isAdmin) {
    throw new AppError(Errors.NotAdmin);
  }

  // Find previous topic associated with channel
  const topicWithChannel = await this.models.Topic.findOne({
    where: {
      channel_id: channelId ? channelId : topic.channel_id,
    },
  });

  // Either we are removing a connect (channel_id is null) or we are connecting to a new channel
  if (topicWithChannel && (topicWithChannel.id !== topic.id || !channelId)) {
    // Previous threads on topic from discord bot
    const threadsOnTopicFromDiscordBot = await this.models.Thread.findAll({
      where: {
        topic_id: topicWithChannel.id,
        // discord meta is not null
        discord_meta: {
          [Op.ne]: null,
        },
      },
    });

    // batch update threads to have new topic id
    await this.models.Thread.update(
      {
        topic_id: channelId ? topic.id : null,
      },
      {
        // @ts-expect-error StrictNullChecks
        where: {
          id: {
            [Op.in]: threadsOnTopicFromDiscordBot.map((thread) => thread.id),
          },
        },
      },
    );

    // Remove channel_id from old topic
    topicWithChannel.channel_id = null;
    await topicWithChannel.save();
  } else {
    // No previous topic associated with channel. Set all threads with channel id to new topic
    const threadsOnTopicFromDiscordBot = await this.models.Thread.findAll({
      where: {
        community_id: topic.community_id,
        // discord meta is not null
        discord_meta: {
          channel_id: channelId,
        },
      },
    });

    // batch update threads to have new topic id
    await this.models.Thread.update(
      {
        topic_id: topic.id,
      },
      {
        // @ts-expect-error StrictNullChecks
        where: {
          id: {
            [Op.in]: threadsOnTopicFromDiscordBot.map((thread) => thread.id),
          },
        },
      },
    );
  }

  try {
    topic.channel_id = channelId;
    await topic.save();
  } catch (e) {
    console.log(e);
    throw new AppError(Errors.Failed);
  }
}

1	import { AppError } from '@hicommonwealth/core';
2	import { UserInstance } from '@hicommonwealth/model';
3	import { Op } from 'sequelize';
4	import { validateOwner } from '../../util/validateOwner';
5	import { ServerTopicsController } from '../server_topics_controller';
6
7	const Errors = {	18✔
8	MissingTopic: 'Invalid topic ID',
9	Failed: 'Unable to save',
10	NotAdmin: 'Not an admin',
11	};
12
13	export type UpdateTopicChannelOptions = {
14	user: UserInstance;
15	topicId: number;
16	channelId: string;
17	};
18
19	export type UpdateTopicChannelResult = void;
20
21	export async function __updateTopicChannel(
22	this: ServerTopicsController,
23	{ user, topicId, channelId }: UpdateTopicChannelOptions,
24	): Promise<UpdateTopicChannelResult> {
25	const topic = await this.models.Topic.findByPk(topicId);	1✔
26	if (!topic) {	1!
27	throw new AppError(Errors.MissingTopic);	×
28	}
29
30	const isAdmin = await validateOwner({	1✔
31	models: this.models,
32	user: user,
33	communityId: topic.community_id,
34	allowMod: true,
35	allowAdmin: true,
36	allowSuperAdmin: true,
37	});
38
39	if (!isAdmin) {	1!
40	throw new AppError(Errors.NotAdmin);	×
41	}
42
43	// Find previous topic associated with channel
44	const topicWithChannel = await this.models.Topic.findOne({	1✔
45	where: {
46	channel_id: channelId ? channelId : topic.channel_id,	2!
47	},
48	});
49
50	// Either we are removing a connect (channel_id is null) or we are connecting to a new channel
51	if (topicWithChannel && (topicWithChannel.id !== topic.id \|\| !channelId)) {	1!
52	// Previous threads on topic from discord bot
53	const threadsOnTopicFromDiscordBot = await this.models.Thread.findAll({	×
54	where: {
55	topic_id: topicWithChannel.id,
56	// discord meta is not null
57	discord_meta: {
58	[Op.ne]: null,
59	},
60	},
61	});
62
63	// batch update threads to have new topic id
64	await this.models.Thread.update(	×
65	{
66	topic_id: channelId ? topic.id : null,	×
67	},
68	{
69	// @ts-expect-error StrictNullChecks
70	where: {
71	id: {
72	[Op.in]: threadsOnTopicFromDiscordBot.map((thread) => thread.id),	×
73	},
74	},
75	},
76	);
77
78	// Remove channel_id from old topic
UNCOV 79	topicWithChannel.channel_id = null;	×
80	await topicWithChannel.save();	×
81	} else {
82	// No previous topic associated with channel. Set all threads with channel id to new topic
83	const threadsOnTopicFromDiscordBot = await this.models.Thread.findAll({	1✔
84	where: {
85	community_id: topic.community_id,
86	// discord meta is not null
87	discord_meta: {
88	channel_id: channelId,
89	},
90	},
91	});
92
93	// batch update threads to have new topic id
94	await this.models.Thread.update(	1✔
95	{
96	topic_id: topic.id,
97	},
98	{
99	// @ts-expect-error StrictNullChecks
100	where: {
101	id: {
102	[Op.in]: threadsOnTopicFromDiscordBot.map((thread) => thread.id),	1✔
103	},
104	},
105	},
106	);
107	}
108
109	try {	1✔
110	topic.channel_id = channelId;	1✔
111	await topic.save();	1✔
112	} catch (e) {
113	console.log(e);	×
114	throw new AppError(Errors.Failed);	×
115	}
116	}

hicommonwealth / commonwealth / 10909002435

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous