10907929025

Committed 17 Sep 2024 05:20PM UTC coverage: 31.848% (-0.03%) from 31.878%

Build # 10907929025

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9602 from ForumMagnum/crossposting-refactor

Crossposting refactor (Part 1 - deploy new routes)

Run Details

5073 of 41360 branches covered (12.27%)

Branch coverage included in aggregate %.

39 of 151 new or added lines in 10 files covered. (25.83%)

6 existing lines in 3 files now uncovered.

29438 of 67000 relevant lines covered (43.94%)

184.59 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

29.41

/packages/lesswrong/server/fmCrosspost/requestHandlers.ts

import type { Request } from "express";
import Posts from "../../lib/collections/posts/collection";
import Users from "../../lib/collections/users/collection";
import { getGraphQLQueryFromOptions, getResolverNameFromOptions } from "../../lib/crud/withSingle";
import { Utils } from "../../lib/vulcan-lib";
import { createClient } from "../vulcan-lib/apollo-ssr/apolloClient";
import { createAnonymousContext } from "../vulcan-lib/query";
import { extractDenormalizedData } from "./denormalizedFields";
import { InvalidUserError, UnauthorizedError } from "./errors";
import { validateCrosspostingKarmaThreshold } from "./helpers";
import type { GetRouteOf, PostRouteOf } from "./routes";
import { verifyToken } from "./tokens";
import { getAllRepos } from "@/server/repos";
import {
  ConnectCrossposterPayloadValidator,
  CrosspostPayloadValidator,
  UnlinkCrossposterPayloadValidator,
  UpdateCrosspostPayloadValidator,
} from "./types";
import { connectCrossposterToken } from "../crossposting/tokens";

export const onCrosspostTokenRequest: GetRouteOf<'crosspostToken'> = async (req: Request) => {
  const {user} = req;
  if (!user) {
    throw new UnauthorizedError();
  }

  // Throws an error if user doesn't have enough karma on the source forum (which is the current execution environment)
  validateCrosspostingKarmaThreshold(user);

  const token = await connectCrossposterToken.create({userId: user._id});
  return {token};
};

export const onConnectCrossposterRequest: PostRouteOf<'connectCrossposter'> = async (req) => {
  const { token, localUserId } = req;
  const payload = await verifyToken(token, ConnectCrossposterPayloadValidator.is);
  const {userId: foreignUserId} = payload;
  await Users.rawUpdateOne({_id: foreignUserId}, {
    $set: {fmCrosspostUserId: localUserId},
  });
  return {
    status: "connected",
    foreignUserId,
    localUserId,
  };
};

export const onUnlinkCrossposterRequest: PostRouteOf<'unlinkCrossposter'> = async (req) => {
  const { token } = req;
  const payload = await verifyToken(token, UnlinkCrossposterPayloadValidator.is);
  const {userId} = payload;
  await Users.rawUpdateOne({_id: userId}, {
    $unset: {fmCrosspostUserId: ""},
  });
  return { status: 'unlinked' };
};

export const onCrosspostRequest: PostRouteOf<'crosspost'> = async (req) => {
  const { token } = req;
  const payload = await verifyToken(token, CrosspostPayloadValidator.is);
  const {localUserId, foreignUserId, postId, ...rest} = payload;
  const denormalizedData = extractDenormalizedData(rest);

  const user = await Users.findOne({_id: foreignUserId});
  if (!user || user.fmCrosspostUserId !== localUserId) {
    throw new InvalidUserError();
  }

  /**
   * TODO: Null is made legal value for fields but database types are incorrectly generated without null. 
   * Hacky fix for now. Search 84b2 to find all instances of this casting.
   */
  const document: Partial<DbPost> = {
    userId: user._id,
    fmCrosspost: {
      isCrosspost: true,
      hostedHere: false,
      foreignPostId: postId,
    },
    ...denormalizedData,
  } as Partial<DbPost>;

  const {data: post} = await Utils.createMutator({
    document,
    collection: Posts,
    validate: false,
    currentUser: user,
    // This is a hack - we have only a fraction of the necessary information for
    // a context. But it appears to be working.
    context: {
      currentUser: user,
      isFMCrosspostRequest: true,
      Users,
      repos: getAllRepos(),
    } as Partial<ResolverContext> as  ResolverContext,
  });

  return {
    status: "posted",
    postId: post._id,
  };
};

//TODO: clean up typecast `as Partial<DbPost>` below, Code: 84b2
export const onUpdateCrosspostRequest: PostRouteOf<'updateCrosspost'> = async (req) => {
  const { token } = req;
  const {postId, ...rest} = await verifyToken(token, UpdateCrosspostPayloadValidator.is);
  const denormalizedData: Partial<DbPost> = extractDenormalizedData(rest) as Partial<DbPost>;
  await Posts.rawUpdateOne({_id: postId}, {$set: denormalizedData});
  return { status: 'updated' };
};

export const onGetCrosspostRequest: PostRouteOf<'getCrosspost'> = async (req) => {
  const { collectionName, extraVariables, extraVariablesValues, fragmentName, documentId } = req;
  const apolloClient = await createClient(createAnonymousContext());
  const query = getGraphQLQueryFromOptions({
    extraVariables,
    collectionName,
    fragmentName,
    fragment: undefined,
  });
  const resolverName = getResolverNameFromOptions(collectionName);

  const { data } = await apolloClient.query({
    query,
    variables: {
      input: {
        selector: { documentId }
      },
      ...extraVariablesValues
    },
  });

  const document = data?.[resolverName]?.result;

  return { document };
};

1	import type { Request } from "express";	57✔
2	import Posts from "../../lib/collections/posts/collection";	19✔
3	import Users from "../../lib/collections/users/collection";	19✔
4	import { getGraphQLQueryFromOptions, getResolverNameFromOptions } from "../../lib/crud/withSingle";	19✔
5	import { Utils } from "../../lib/vulcan-lib";	19✔
6	import { createClient } from "../vulcan-lib/apollo-ssr/apolloClient";	19✔
7	import { createAnonymousContext } from "../vulcan-lib/query";	19✔
8	import { extractDenormalizedData } from "./denormalizedFields";	19✔
9	import { InvalidUserError, UnauthorizedError } from "./errors";	19✔
10	import { validateCrosspostingKarmaThreshold } from "./helpers";	19✔
11	import type { GetRouteOf, PostRouteOf } from "./routes";
12	import { verifyToken } from "./tokens";	19✔
13	import { getAllRepos } from "@/server/repos";	19✔
14	import {
15	ConnectCrossposterPayloadValidator,
16	CrosspostPayloadValidator,
17	UnlinkCrossposterPayloadValidator,
18	UpdateCrosspostPayloadValidator,
19	} from "./types";	19✔
20	import { connectCrossposterToken } from "../crossposting/tokens";	19✔
21
22	export const onCrosspostTokenRequest: GetRouteOf<'crosspostToken'> = async (req: Request) => {	19✔
23	const {user} = req;	×
24	if (!user) {	×
25	throw new UnauthorizedError();	×
26	}
27
28	// Throws an error if user doesn't have enough karma on the source forum (which is the current execution environment)
29	validateCrosspostingKarmaThreshold(user);	×
30
NEW 31	const token = await connectCrossposterToken.create({userId: user._id});	×
32	return {token};	×
33	};
34
35	export const onConnectCrossposterRequest: PostRouteOf<'connectCrossposter'> = async (req) => {	19✔
36	const { token, localUserId } = req;	×
37	const payload = await verifyToken(token, ConnectCrossposterPayloadValidator.is);	×
38	const {userId: foreignUserId} = payload;	×
39	await Users.rawUpdateOne({_id: foreignUserId}, {	×
40	$set: {fmCrosspostUserId: localUserId},
41	});
42	return {	×
43	status: "connected",
44	foreignUserId,
45	localUserId,
46	};
47	};
48
49	export const onUnlinkCrossposterRequest: PostRouteOf<'unlinkCrossposter'> = async (req) => {	19✔
50	const { token } = req;	×
51	const payload = await verifyToken(token, UnlinkCrossposterPayloadValidator.is);	×
52	const {userId} = payload;	×
53	await Users.rawUpdateOne({_id: userId}, {	×
54	$unset: {fmCrosspostUserId: ""},
55	});
56	return { status: 'unlinked' };	×
57	};
58
59	export const onCrosspostRequest: PostRouteOf<'crosspost'> = async (req) => {	19✔
60	const { token } = req;	×
61	const payload = await verifyToken(token, CrosspostPayloadValidator.is);	×
62	const {localUserId, foreignUserId, postId, ...rest} = payload;	×
63	const denormalizedData = extractDenormalizedData(rest);	×
64
65	const user = await Users.findOne({_id: foreignUserId});	×
66	if (!user \|\| user.fmCrosspostUserId !== localUserId) {	×
67	throw new InvalidUserError();	×
68	}
69
70	/**
71	* TODO: Null is made legal value for fields but database types are incorrectly generated without null.
72	* Hacky fix for now. Search 84b2 to find all instances of this casting.
73	*/
74	const document: Partial<DbPost> = {	×
75	userId: user._id,
76	fmCrosspost: {
77	isCrosspost: true,
78	hostedHere: false,
79	foreignPostId: postId,
80	},
81	...denormalizedData,
82	} as Partial<DbPost>;
83
84	const {data: post} = await Utils.createMutator({	×
85	document,
86	collection: Posts,
87	validate: false,
88	currentUser: user,
89	// This is a hack - we have only a fraction of the necessary information for
90	// a context. But it appears to be working.
91	context: {
92	currentUser: user,
93	isFMCrosspostRequest: true,
94	Users,
95	repos: getAllRepos(),
96	} as Partial<ResolverContext> as ResolverContext,
97	});
98
99	return {	×
100	status: "posted",
101	postId: post._id,
102	};
103	};
104
105	//TODO: clean up typecast `as Partial<DbPost>` below, Code: 84b2
106	export const onUpdateCrosspostRequest: PostRouteOf<'updateCrosspost'> = async (req) => {	19✔
107	const { token } = req;	×
108	const {postId, ...rest} = await verifyToken(token, UpdateCrosspostPayloadValidator.is);	×
109	const denormalizedData: Partial<DbPost> = extractDenormalizedData(rest) as Partial<DbPost>;	×
110	await Posts.rawUpdateOne({_id: postId}, {$set: denormalizedData});	×
111	return { status: 'updated' };	×
112	};
113
114	export const onGetCrosspostRequest: PostRouteOf<'getCrosspost'> = async (req) => {	19✔
115	const { collectionName, extraVariables, extraVariablesValues, fragmentName, documentId } = req;	×
116	const apolloClient = await createClient(createAnonymousContext());	×
117	const query = getGraphQLQueryFromOptions({	×
118	extraVariables,
119	collectionName,
120	fragmentName,
121	fragment: undefined,
122	});
123	const resolverName = getResolverNameFromOptions(collectionName);	×
124
125	const { data } = await apolloClient.query({	×
126	query,
127	variables: {
128	input: {
129	selector: { documentId }
130	},
131	...extraVariablesValues
132	},
133	});
134
135	const document = data?.[resolverName]?.result;	×
136
137	return { document };	×
138	};

ForumMagnum / ForumMagnum / 10907929025

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous