#1019

Committed 16 Sep 2024 01:13PM CUT coverage: 91.474% (+0.05%) from 91.427%

Build # #1019

Build Type

push

Committed by

Commit Message

Merge a7c402a8d into 3f893d0b1

Run Details

925 of 1055 branches covered (87.68%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

1017 of 1068 relevant lines covered (95.22%)

68.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

92.46

/src/plugins/codeStyle/index.ts

import {
    BsDiagnostic,
    createVisitor,
    FunctionExpression,
    isBrsFile,
    isXmlFile,
    isGroupingExpression,
    TokenKind,
    WalkMode,
    CancellationTokenSource,
    DiagnosticSeverity,
    OnGetCodeActionsEvent,
    AALiteralExpression,
    BrsFile,
    CompilerPlugin,
    AfterFileValidateEvent,
    Expression,
    isVoidType,
    Statement,
    SymbolTypeFlag,
    XmlFile,
    AstNode,
    Token,
    isNamespaceStatement,
    util,
    isAnyReferenceType,
    ExtraSymbolData,
    OnScopeValidateEvent,
    InternalWalkMode,
    isCallableType
} from 'brighterscript';
import { RuleAAComma } from '../..';
import { addFixesToEvent } from '../../textEdit';
import { PluginContext } from '../../util';
import { createColorValidator } from '../../createColorValidator';
import { messages } from './diagnosticMessages';
import { extractFixes } from './styleFixes';
import { BsLintDiagnosticContext } from '../../Linter';
import { Location } from 'vscode-languageserver-types';

export default class CodeStyle implements CompilerPlugin {

    name: 'codeStyle';

    constructor(private lintContext: PluginContext) {
    }

    onGetCodeActions(event: OnGetCodeActionsEvent) {
        const addFixes = addFixesToEvent(event);
        extractFixes(event.file, addFixes, event.diagnostics);
    }

    validateXMLFile(file: XmlFile) {
        const diagnostics: BsDiagnostic[] = [];
        const { noArrayComponentFieldType, noAssocarrayComponentFieldType } = this.lintContext.severity;

        const validateArrayComponentFieldType = noArrayComponentFieldType !== DiagnosticSeverity.Hint;
        const validateAssocarrayComponentFieldType = noAssocarrayComponentFieldType !== DiagnosticSeverity.Hint;

        for (const field of file.parser?.ast?.componentElement?.interfaceElement?.fields ?? []) {
            if (field.tokens.startTagName?.text?.toLowerCase() === 'field') {
                const typeAttribute = field.getAttribute('type');

                const typeValue = typeAttribute?.tokens?.value?.text?.toLowerCase();
                if (typeValue === 'array' && validateArrayComponentFieldType) {
                    diagnostics.push(
                        messages.noArrayFieldType(
                            typeAttribute?.tokens?.value?.location,
                            noArrayComponentFieldType
                        )
                    );
                } else if (typeValue === 'assocarray' && validateAssocarrayComponentFieldType) {
                    diagnostics.push(
                        messages.noAssocarrayFieldType(
                            typeAttribute?.tokens?.value?.location,
                            noAssocarrayComponentFieldType
                        )
                    );
                }
            }
        }

        return diagnostics;
    }

    validateBrsFile(file: BrsFile) {
        const diagnostics: (BsDiagnostic)[] = [];
        const { severity } = this.lintContext;
        const { inlineIfStyle, blockIfStyle, conditionStyle, noPrint, noTodo, noStop, aaCommaStyle, eolLast, colorFormat } = severity;
        const validatePrint = noPrint !== DiagnosticSeverity.Hint;
        const validateTodo = noTodo !== DiagnosticSeverity.Hint;
        const validateNoStop = noStop !== DiagnosticSeverity.Hint;
        const validateInlineIf = inlineIfStyle !== 'off';
        const validateColorFormat = (colorFormat === 'hash-hex' || colorFormat === 'quoted-numeric-hex' || colorFormat === 'never');
        const disallowInlineIf = inlineIfStyle === 'never';
        const requireInlineIfThen = inlineIfStyle === 'then';
        const validateBlockIf = blockIfStyle !== 'off';
        const requireBlockIfThen = blockIfStyle === 'then';
        const validateCondition = conditionStyle !== 'off';
        const requireConditionGroup = conditionStyle === 'group';
        const validateAAStyle = aaCommaStyle !== 'off';
        const validateEolLast = eolLast !== 'off';
        const disallowEolLast = eolLast === 'never';
        const validateColorStyle = validateColorFormat ? createColorValidator(severity) : undefined;

        // Check if the file is empty by going backwards from the last token,
        // meaning there are tokens other than `Eof` and `Newline`.
        const { tokens } = file.parser;
        let isFileEmpty = true;
        for (let i = tokens.length - 1; i >= 0; i--) {
            if (tokens[i].kind !== TokenKind.Eof &&
                tokens[i].kind !== TokenKind.Newline) {
                isFileEmpty = false;
                break;
            }
        }

        // Validate `eol-last` on non-empty files
        if (validateEolLast && !isFileEmpty) {
            const penultimateToken = tokens[tokens.length - 2];
            if (disallowEolLast) {
                if (penultimateToken?.kind === TokenKind.Newline) {
                    diagnostics.push(messages.removeEolLast(penultimateToken.location));
                }
            } else if (penultimateToken?.kind !== TokenKind.Newline) {
                // Set the preferredEol as the last newline.
                // The fix function will handle the case where preferredEol is undefined.
                // This could happen in valid single line files, like:
                // `sub foo() end sub\EOF`
                let preferredEol;
                for (let i = tokens.length - 1; i >= 0; i--) {
                    if (tokens[i].kind === TokenKind.Newline) {
                        preferredEol = tokens[i].text;
                    }
                }

                diagnostics.push(
                    messages.addEolLast(
                        penultimateToken.location,
                        preferredEol
                    )
                );
            }
        }

        file.ast.walk(createVisitor({
            // validate function style (`function` or `sub`)
            FunctionExpression: (func) => {
                this.validateFunctionStyle(func, diagnostics);
            },
            IfStatement: s => {
                const hasThenToken = !!s.tokens.then;
                if (!s.isInline && validateBlockIf) {
                    if (hasThenToken !== requireBlockIfThen) {
                        diagnostics.push(requireBlockIfThen
                            ? messages.addBlockIfThenKeyword(s)
                            : messages.removeBlockIfThenKeyword(s)
                        );
                    }
                } else if (s.isInline && validateInlineIf) {
                    if (disallowInlineIf) {
                        diagnostics.push(messages.inlineIfNotAllowed(s.location));
                    } else if (hasThenToken !== requireInlineIfThen) {
                        diagnostics.push(requireInlineIfThen
                            ? messages.addInlineIfThenKeyword(s)
                            : messages.removeInlineIfThenKeyword(s)
                        );
                    }
                }

                if (validateCondition) {
                    if (isGroupingExpression(s.condition) !== requireConditionGroup) {
                        diagnostics.push(requireConditionGroup
                            ? messages.addParenthesisAroundCondition(s)
                            : messages.removeParenthesisAroundCondition(s)
                        );
                    }
                }
            },
            WhileStatement: s => {
                if (validateCondition) {
                    if (isGroupingExpression(s.condition) !== requireConditionGroup) {
                        diagnostics.push(requireConditionGroup
                            ? messages.addParenthesisAroundCondition(s)
                            : messages.removeParenthesisAroundCondition(s)
                        );
                    }
                }
            },
            PrintStatement: s => {
                if (validatePrint) {
                    diagnostics.push(messages.noPrint(s.tokens.print.location, noPrint));
                }
            },
            LiteralExpression: e => {
                if (validateColorStyle && e.tokens.value.kind === TokenKind.StringLiteral) {
                    validateColorStyle(e.tokens.value.text, e.tokens.value.location, diagnostics);
                }
            },
            TemplateStringExpression: e => {
                // only validate template strings that look like regular strings (i.e. `0xAABBCC`)
                if (validateColorStyle && e.quasis.length === 1 && e.quasis[0].expressions.length === 1) {
                    validateColorStyle(e.quasis[0].expressions[0].tokens.value.text, e.quasis[0].expressions[0].tokens.value.location, diagnostics);
                }
            },
            AALiteralExpression: e => {
                if (validateAAStyle) {
                    this.validateAAStyle(e, aaCommaStyle, diagnostics);
                }
            },
            StopStatement: s => {
                if (validateNoStop) {
                    diagnostics.push(messages.noStop(s.tokens.stop.location, noStop));
                }
            },
            AstNode: (node: Statement | Expression) => {
                const comments = [...node.leadingTrivia, ...node.endTrivia].filter(t => t.kind === TokenKind.Comment);
                if (validateTodo && comments.length > 0) {
                    for (const e of comments) {
                        if (this.lintContext.todoPattern.test(e.text)) {
                            diagnostics.push(messages.noTodo(e.location, noTodo));
                        }
                    }
                }
            }
        }), { walkMode: WalkMode.visitAllRecursive });

        return diagnostics;
    }

    validateBrsFileInScope(file: BrsFile) {
        const diagnostics: (BsDiagnostic)[] = [];
        const { severity } = this.lintContext;
        const { nameShadowing } = severity;

        file.ast.walk(createVisitor({
            NamespaceStatement: (nsStmt) => {
                this.validateNameShadowing(file, nsStmt, nsStmt.getNameParts()?.[0], nameShadowing, diagnostics);
            },
            ClassStatement: (classStmt) => {
                this.validateNameShadowing(file, classStmt, classStmt.tokens.name, nameShadowing, diagnostics);
            },
            InterfaceStatement: (ifaceStmt) => {
                this.validateNameShadowing(file, ifaceStmt, ifaceStmt.tokens.name, nameShadowing, diagnostics);
            },
            ConstStatement: (constStmt) => {
                this.validateNameShadowing(file, constStmt, constStmt.tokens.name, nameShadowing, diagnostics);
            },
            EnumStatement: (enumStmt) => {
                this.validateNameShadowing(file, enumStmt, enumStmt.tokens.name, nameShadowing, diagnostics);
            }
            // eslint-disable-next-line no-bitwise
        }), { walkMode: WalkMode.visitStatementsRecursive | InternalWalkMode.visitFalseConditionalCompilationBlocks });

        return diagnostics;
    }

    afterFileValidate(event: AfterFileValidateEvent) {
        const { file } = event;
        if (this.lintContext.ignores(file)) {
            return;
        }

        const diagnostics: (BsDiagnostic)[] = [];
        if (isXmlFile(file)) {
            diagnostics.push(...this.validateXMLFile(file));
        } else if (isBrsFile(file)) {
            diagnostics.push(...this.validateBrsFile(file));
        }

        // add file reference
        let bsDiagnostics: BsDiagnostic[] = diagnostics.map(diagnostic => ({
            ...diagnostic,
            file
        }));

        const { fix } = this.lintContext;

        // apply fix
        if (fix) {
            bsDiagnostics = extractFixes(event.file, this.lintContext.addFixes, bsDiagnostics);
        }

        // append diagnostics
        event.program.diagnostics.register(bsDiagnostics, BsLintDiagnosticContext);
    }

    onScopeValidate(event: OnScopeValidateEvent) {
        for (const file of event.scope.getOwnFiles()) {
            if (this.lintContext.ignores(file)) {
                return;
            }

            const diagnostics: (BsDiagnostic)[] = [];
            if (isBrsFile(file)) {
                diagnostics.push(...this.validateBrsFileInScope(file));
            }

            // add file reference
            let bsDiagnostics: BsDiagnostic[] = diagnostics.map(diagnostic => ({
                ...diagnostic,
                file
            }));

            const { fix } = this.lintContext;

            // apply fix
            if (fix) {
                bsDiagnostics = extractFixes(file, this.lintContext.addFixes, bsDiagnostics);
            }

            // append diagnostics
            event.program.diagnostics.register(bsDiagnostics, BsLintDiagnosticContext);
        }
    }

    validateAAStyle(aa: AALiteralExpression, aaCommaStyle: RuleAAComma, diagnostics: (BsDiagnostic)[]) {
        const indexes = collectWrappingAAMembersIndexes(aa);
        const last = indexes.length - 1;
        const isSingleLine = (aa: AALiteralExpression): boolean => {
            return aa.tokens.open.location.range.start.line === aa.tokens.close.location.range.end.line;
        };

        indexes.forEach((index, i) => {
            const member = aa.elements[index];
            const hasComma = !!member.tokens.comma;
            if (aaCommaStyle === 'never' || (i === last && ((aaCommaStyle === 'no-dangling') || isSingleLine(aa)))) {
                if (hasComma) {
                    diagnostics.push(messages.removeAAComma(member.tokens.comma.location));
                }
            } else if (!hasComma) {
                diagnostics.push(messages.addAAComma(member.value.location));
            }
        });
    }

    validateFunctionStyle(fun: FunctionExpression, diagnostics: (BsDiagnostic)[]) {
        const { severity } = this.lintContext;
        const { namedFunctionStyle, anonFunctionStyle, typeAnnotations } = severity;
        const style = fun.functionStatement ? namedFunctionStyle : anonFunctionStyle;
        const kind = fun.tokens.functionType.kind;
        const hasReturnedValue = style === 'auto' || typeAnnotations !== 'off' ? this.getFunctionReturns(fun) : false;

        // type annotations
        if (typeAnnotations !== 'off') {
            const needsArgType = typeAnnotations.startsWith('args') || typeAnnotations.startsWith('all');
            const needsReturnType = typeAnnotations.startsWith('return') || typeAnnotations.startsWith('all');
            const allowImplicit = typeAnnotations.includes('allow-implicit');

            if (needsReturnType) {
                if (hasReturnedValue && !fun.returnTypeExpression) {
                    diagnostics.push(messages.expectedReturnTypeAnnotation(
                        // add the error to the function keyword (or just highlight the whole function if that's somehow missing)
                        fun.tokens.functionType?.location ?? fun.location
                    ));
                }
            }
            if (needsArgType) {
                const missingAnnotation = fun.parameters.find(arg => {
                    if (!arg.typeExpression) {
                        if (allowImplicit && arg.defaultValue) {
                            return false;
                        }
                        return true;
                    }
                    return false;
                });
                if (missingAnnotation) {
                    // only report 1st missing arg annotation to avoid error overload
                    diagnostics.push(messages.expectedTypeAnnotation(missingAnnotation.location));
                }
            }
        }

        // keyword style
        if (style === 'off') {
            return;
        }
        if (style === 'no-function') {
            if (kind === TokenKind.Function) {
                diagnostics.push(messages.expectedSubKeyword(fun, `(always use 'sub')`));
            }
            return;
        }

        if (style === 'no-sub') {
            if (kind === TokenKind.Sub) {
                diagnostics.push(messages.expectedFunctionKeyword(fun, `(always use 'function')`));
            }
            return;
        }

        // auto
        if (hasReturnedValue) {
            if (kind !== TokenKind.Function) {
                diagnostics.push(messages.expectedFunctionKeyword(fun, `(use 'function' when a value is returned)`));
            }
        } else if (kind !== TokenKind.Sub) {
            diagnostics.push(messages.expectedSubKeyword(fun, `(use 'sub' when no value is returned)`));
        }
    }

    getFunctionReturns(fun: FunctionExpression) {
        let hasReturnedValue = false;
        if (fun.returnTypeExpression) {
            hasReturnedValue = !isVoidType(fun.returnTypeExpression.getType({ flags: SymbolTypeFlag.typetime }));
        } else {
            const cancel = new CancellationTokenSource();
            fun.body.walk(createVisitor({
                ReturnStatement: s => {
                    hasReturnedValue = !!s.value;
                    cancel.cancel();
                }
            }), { walkMode: WalkMode.visitStatements, cancel: cancel.token });
        }
        return hasReturnedValue;
    }

    validateNameShadowing(file: BrsFile, node: AstNode, nameIdentifier: Token, severity: DiagnosticSeverity, diagnostics: (BsDiagnostic)[]) {
        const name = nameIdentifier?.text;
        if (!name || !node) {
            return;
        }
        const nameLocation = nameIdentifier.location;

        const astTable = file.ast.getSymbolTable();
        const data = {} as ExtraSymbolData;
        const typeChain = [];
        // eslint-disable-next-line no-bitwise
        const existingType = astTable.getSymbolType(name, { flags: SymbolTypeFlag.runtime | SymbolTypeFlag.typetime, data: data, typeChain: typeChain });

        if (!existingType || isAnyReferenceType(existingType)) {
            return;
        }
        if ((data.definingNode === node) || (isNamespaceStatement(data.definingNode) && isNamespaceStatement(node))) {
            return;
        }
        const otherNode = data.definingNode as unknown as { tokens: { name: Token }; location: Location };
        const thisNodeKindName = util.getAstNodeFriendlyName(node);
        let thatNodeKindName = util.getAstNodeFriendlyName(data.definingNode) ?? '';
        if (!thatNodeKindName && isCallableType(existingType)) {
            thatNodeKindName = 'Global Function';
        }

        let thatNameLocation = otherNode?.tokens?.name?.location ?? otherNode?.location;

        if (isNamespaceStatement(data.definingNode)) {
            thatNameLocation = data.definingNode.getNameParts()?.[0]?.location;
        }

        const relatedInformation = thatNameLocation ? [{
            message: `${thatNodeKindName} declared here`,
            location: thatNameLocation
        }] : undefined;

        diagnostics.push({
            ...messages.nameShadowing(thisNodeKindName, thatNodeKindName, name, severity),
            location: nameLocation,
            relatedInformation: relatedInformation
        });
    }
}

/**
 * Collect indexes of non-inline AA members
 */
export function collectWrappingAAMembersIndexes(aa: AALiteralExpression): number[] {
    const indexes: number[] = [];
    const { elements } = aa;
    const lastIndex = elements.length - 1;
    for (let i = 0; i < lastIndex; i++) {
        const e = elements[i];

        const ne = elements[i + 1];
        const hasNL = ne.location.range.start.line > e.location.range.end.line;
        if (hasNL) {
            indexes.push(i);
        }
    }
    const last = elements[lastIndex];
    if (last) {
        indexes.push(lastIndex);
    }
    return indexes;
}

1	import {	1✔
2	BsDiagnostic,
3	createVisitor,
4	FunctionExpression,
5	isBrsFile,
6	isXmlFile,
7	isGroupingExpression,
8	TokenKind,
9	WalkMode,
10	CancellationTokenSource,
11	DiagnosticSeverity,
12	OnGetCodeActionsEvent,
13	AALiteralExpression,
14	BrsFile,
15	CompilerPlugin,
16	AfterFileValidateEvent,
17	Expression,
18	isVoidType,
19	Statement,
20	SymbolTypeFlag,
21	XmlFile,
22	AstNode,
23	Token,
24	isNamespaceStatement,
25	util,
26	isAnyReferenceType,
27	ExtraSymbolData,
28	OnScopeValidateEvent,
29	InternalWalkMode,
30	isCallableType
31	} from 'brighterscript';
32	import { RuleAAComma } from '../..';
33	import { addFixesToEvent } from '../../textEdit';	1✔
34	import { PluginContext } from '../../util';
35	import { createColorValidator } from '../../createColorValidator';	1✔
36	import { messages } from './diagnosticMessages';	1✔
37	import { extractFixes } from './styleFixes';	1✔
38	import { BsLintDiagnosticContext } from '../../Linter';	1✔
39	import { Location } from 'vscode-languageserver-types';
40
41	export default class CodeStyle implements CompilerPlugin {	1✔
42
43	name: 'codeStyle';
44
45	constructor(private lintContext: PluginContext) {	149✔
46	}
47
48	onGetCodeActions(event: OnGetCodeActionsEvent) {
49	const addFixes = addFixesToEvent(event);	×
50	extractFixes(event.file, addFixes, event.diagnostics);	×
51	}
52
53	validateXMLFile(file: XmlFile) {
54	const diagnostics: BsDiagnostic[] = [];	2✔
55	const { noArrayComponentFieldType, noAssocarrayComponentFieldType } = this.lintContext.severity;	2✔
56
57	const validateArrayComponentFieldType = noArrayComponentFieldType !== DiagnosticSeverity.Hint;	2✔
58	const validateAssocarrayComponentFieldType = noAssocarrayComponentFieldType !== DiagnosticSeverity.Hint;	2✔
59
60	for (const field of file.parser?.ast?.componentElement?.interfaceElement?.fields ?? []) {	2!
61	if (field.tokens.startTagName?.text?.toLowerCase() === 'field') {	6!
62	const typeAttribute = field.getAttribute('type');	6✔
63
64	const typeValue = typeAttribute?.tokens?.value?.text?.toLowerCase();	6!
65	if (typeValue === 'array' && validateArrayComponentFieldType) {	6✔
66	diagnostics.push(	1✔
67	messages.noArrayFieldType(
68	typeAttribute?.tokens?.value?.location,	9!
69	noArrayComponentFieldType
70	)
71	);
72	} else if (typeValue === 'assocarray' && validateAssocarrayComponentFieldType) {	5✔
73	diagnostics.push(	1✔
74	messages.noAssocarrayFieldType(
75	typeAttribute?.tokens?.value?.location,	9!
76	noAssocarrayComponentFieldType
77	)
78	);
79	}
80	}
81	}
82
83	return diagnostics;	2✔
84	}
85
86	validateBrsFile(file: BrsFile) {
87	const diagnostics: (BsDiagnostic)[] = [];	64✔
88	const { severity } = this.lintContext;	64✔
89	const { inlineIfStyle, blockIfStyle, conditionStyle, noPrint, noTodo, noStop, aaCommaStyle, eolLast, colorFormat } = severity;	64✔
90	const validatePrint = noPrint !== DiagnosticSeverity.Hint;	64✔
91	const validateTodo = noTodo !== DiagnosticSeverity.Hint;	64✔
92	const validateNoStop = noStop !== DiagnosticSeverity.Hint;	64✔
93	const validateInlineIf = inlineIfStyle !== 'off';	64✔
94	const validateColorFormat = (colorFormat === 'hash-hex' \|\| colorFormat === 'quoted-numeric-hex' \|\| colorFormat === 'never');	64✔
95	const disallowInlineIf = inlineIfStyle === 'never';	64✔
96	const requireInlineIfThen = inlineIfStyle === 'then';	64✔
97	const validateBlockIf = blockIfStyle !== 'off';	64✔
98	const requireBlockIfThen = blockIfStyle === 'then';	64✔
99	const validateCondition = conditionStyle !== 'off';	64✔
100	const requireConditionGroup = conditionStyle === 'group';	64✔
101	const validateAAStyle = aaCommaStyle !== 'off';	64✔
102	const validateEolLast = eolLast !== 'off';	64✔
103	const disallowEolLast = eolLast === 'never';	64✔
104	const validateColorStyle = validateColorFormat ? createColorValidator(severity) : undefined;	64✔
105
106	// Check if the file is empty by going backwards from the last token,
107	// meaning there are tokens other than `Eof` and `Newline`.
108	const { tokens } = file.parser;	64✔
109	let isFileEmpty = true;	64✔
110	for (let i = tokens.length - 1; i >= 0; i--) {	64✔
111	if (tokens[i].kind !== TokenKind.Eof &&	180✔
112	tokens[i].kind !== TokenKind.Newline) {
113	isFileEmpty = false;	63✔
114	break;	63✔
115	}
116	}
117
118	// Validate `eol-last` on non-empty files
119	if (validateEolLast && !isFileEmpty) {	64✔
120	const penultimateToken = tokens[tokens.length - 2];	45✔
121	if (disallowEolLast) {	45✔
122	if (penultimateToken?.kind === TokenKind.Newline) {	2!
123	diagnostics.push(messages.removeEolLast(penultimateToken.location));	2✔
124	}
125	} else if (penultimateToken?.kind !== TokenKind.Newline) {	43!
126	// Set the preferredEol as the last newline.
127	// The fix function will handle the case where preferredEol is undefined.
128	// This could happen in valid single line files, like:
129	// `sub foo() end sub\EOF`
130	let preferredEol;
131	for (let i = tokens.length - 1; i >= 0; i--) {	3✔
132	if (tokens[i].kind === TokenKind.Newline) {	38✔
133	preferredEol = tokens[i].text;	4✔
134	}
135	}
136
137	diagnostics.push(	3✔
138	messages.addEolLast(
139	penultimateToken.location,
140	preferredEol
141	)
142	);
143	}
144	}
145
146	file.ast.walk(createVisitor({	64✔
147	// validate function style (`function` or `sub`)
148	FunctionExpression: (func) => {
149	this.validateFunctionStyle(func, diagnostics);	152✔
150	},
151	IfStatement: s => {
152	const hasThenToken = !!s.tokens.then;	74✔
153	if (!s.isInline && validateBlockIf) {	74✔
154	if (hasThenToken !== requireBlockIfThen) {	14✔
155	diagnostics.push(requireBlockIfThen	7✔
156	? messages.addBlockIfThenKeyword(s)
157	: messages.removeBlockIfThenKeyword(s)
158	);
159	}
160	} else if (s.isInline && validateInlineIf) {	60✔
161	if (disallowInlineIf) {	14✔
162	diagnostics.push(messages.inlineIfNotAllowed(s.location));	2✔
163	} else if (hasThenToken !== requireInlineIfThen) {	12✔
164	diagnostics.push(requireInlineIfThen	6✔
165	? messages.addInlineIfThenKeyword(s)
166	: messages.removeInlineIfThenKeyword(s)
167	);
168	}
169	}
170
171	if (validateCondition) {	74✔
172	if (isGroupingExpression(s.condition) !== requireConditionGroup) {	22✔
173	diagnostics.push(requireConditionGroup	11✔
174	? messages.addParenthesisAroundCondition(s)
175	: messages.removeParenthesisAroundCondition(s)
176	);
177	}
178	}
179	},
180	WhileStatement: s => {
181	if (validateCondition) {	12✔
182	if (isGroupingExpression(s.condition) !== requireConditionGroup) {	6✔
183	diagnostics.push(requireConditionGroup	3✔
184	? messages.addParenthesisAroundCondition(s)
185	: messages.removeParenthesisAroundCondition(s)
186	);
187	}
188	}
189	},
190	PrintStatement: s => {
191	if (validatePrint) {	120✔
192	diagnostics.push(messages.noPrint(s.tokens.print.location, noPrint));	2✔
193	}
194	},
195	LiteralExpression: e => {
196	if (validateColorStyle && e.tokens.value.kind === TokenKind.StringLiteral) {	434✔
197	validateColorStyle(e.tokens.value.text, e.tokens.value.location, diagnostics);	63✔
198	}
199	},
200	TemplateStringExpression: e => {
201	// only validate template strings that look like regular strings (i.e. `0xAABBCC`)
202	if (validateColorStyle && e.quasis.length === 1 && e.quasis[0].expressions.length === 1) {	11✔
203	validateColorStyle(e.quasis[0].expressions[0].tokens.value.text, e.quasis[0].expressions[0].tokens.value.location, diagnostics);	6✔
204	}
205	},
206	AALiteralExpression: e => {
207	if (validateAAStyle) {	33✔
208	this.validateAAStyle(e, aaCommaStyle, diagnostics);	30✔
209	}
210	},
211	StopStatement: s => {
212	if (validateNoStop) {	1!
213	diagnostics.push(messages.noStop(s.tokens.stop.location, noStop));	1✔
214	}
215	},
216	AstNode: (node: Statement \| Expression) => {
217	const comments = [...node.leadingTrivia, ...node.endTrivia].filter(t => t.kind === TokenKind.Comment);	3,010✔
218	if (validateTodo && comments.length > 0) {	1,915✔
219	for (const e of comments) {	6✔
220	if (this.lintContext.todoPattern.test(e.text)) {	26✔
221	diagnostics.push(messages.noTodo(e.location, noTodo));	10✔
222	}
223	}
224	}
225	}
226	}), { walkMode: WalkMode.visitAllRecursive });
227
228	return diagnostics;	64✔
229	}
230
231	validateBrsFileInScope(file: BrsFile) {
232	const diagnostics: (BsDiagnostic)[] = [];	64✔
233	const { severity } = this.lintContext;	64✔
234	const { nameShadowing } = severity;	64✔
235
236	file.ast.walk(createVisitor({	64✔
237	NamespaceStatement: (nsStmt) => {
238	this.validateNameShadowing(file, nsStmt, nsStmt.getNameParts()?.[0], nameShadowing, diagnostics);	4!
239	},
240	ClassStatement: (classStmt) => {
241	this.validateNameShadowing(file, classStmt, classStmt.tokens.name, nameShadowing, diagnostics);	7✔
242	},
243	InterfaceStatement: (ifaceStmt) => {
244	this.validateNameShadowing(file, ifaceStmt, ifaceStmt.tokens.name, nameShadowing, diagnostics);	7✔
245	},
246	ConstStatement: (constStmt) => {
247	this.validateNameShadowing(file, constStmt, constStmt.tokens.name, nameShadowing, diagnostics);	11✔
248	},
249	EnumStatement: (enumStmt) => {
250	this.validateNameShadowing(file, enumStmt, enumStmt.tokens.name, nameShadowing, diagnostics);	7✔
251	}
252	// eslint-disable-next-line no-bitwise
253	}), { walkMode: WalkMode.visitStatementsRecursive \| InternalWalkMode.visitFalseConditionalCompilationBlocks });
254
255	return diagnostics;	64✔
256	}
257
258	afterFileValidate(event: AfterFileValidateEvent) {
259	const { file } = event;	66✔
260	if (this.lintContext.ignores(file)) {	66!
261	return;	×
262	}
263
264	const diagnostics: (BsDiagnostic)[] = [];	66✔
265	if (isXmlFile(file)) {	66✔
266	diagnostics.push(...this.validateXMLFile(file));	2✔
267	} else if (isBrsFile(file)) {	64!
268	diagnostics.push(...this.validateBrsFile(file));	64✔
269	}
270
271	// add file reference
272	let bsDiagnostics: BsDiagnostic[] = diagnostics.map(diagnostic => ({	134✔
273	...diagnostic,
274	file
275	}));
276
277	const { fix } = this.lintContext;	66✔
278
279	// apply fix
280	if (fix) {	66✔
281	bsDiagnostics = extractFixes(event.file, this.lintContext.addFixes, bsDiagnostics);	12✔
282	}
283
284	// append diagnostics
285	event.program.diagnostics.register(bsDiagnostics, BsLintDiagnosticContext);	66✔
286	}
287
288	onScopeValidate(event: OnScopeValidateEvent) {
289	for (const file of event.scope.getOwnFiles()) {	65✔
290	if (this.lintContext.ignores(file)) {	66!
291	return;	×
292	}
293
294	const diagnostics: (BsDiagnostic)[] = [];	66✔
295	if (isBrsFile(file)) {	66✔
296	diagnostics.push(...this.validateBrsFileInScope(file));	64✔
297	}
298
299	// add file reference
300	let bsDiagnostics: BsDiagnostic[] = diagnostics.map(diagnostic => ({	66✔
301	...diagnostic,
302	file
303	}));
304
305	const { fix } = this.lintContext;	66✔
306
307	// apply fix
308	if (fix) {	66✔
309	bsDiagnostics = extractFixes(file, this.lintContext.addFixes, bsDiagnostics);	12✔
310	}
311
312	// append diagnostics
313	event.program.diagnostics.register(bsDiagnostics, BsLintDiagnosticContext);	66✔
314	}
315	}
316
317	validateAAStyle(aa: AALiteralExpression, aaCommaStyle: RuleAAComma, diagnostics: (BsDiagnostic)[]) {
318	const indexes = collectWrappingAAMembersIndexes(aa);	30✔
319	const last = indexes.length - 1;	30✔
320	const isSingleLine = (aa: AALiteralExpression): boolean => {	30✔
321	return aa.tokens.open.location.range.start.line === aa.tokens.close.location.range.end.line;	10✔
322	};
323
324	indexes.forEach((index, i) => {	30✔
325	const member = aa.elements[index];	66✔
326	const hasComma = !!member.tokens.comma;	66✔
327	if (aaCommaStyle === 'never' \|\| (i === last && ((aaCommaStyle === 'no-dangling') \|\| isSingleLine(aa)))) {	66✔
328	if (hasComma) {	36✔
329	diagnostics.push(messages.removeAAComma(member.tokens.comma.location));	18✔
330	}
331	} else if (!hasComma) {	30✔
332	diagnostics.push(messages.addAAComma(member.value.location));	12✔
333	}
334	});
335	}
336
337	validateFunctionStyle(fun: FunctionExpression, diagnostics: (BsDiagnostic)[]) {
338	const { severity } = this.lintContext;	152✔
339	const { namedFunctionStyle, anonFunctionStyle, typeAnnotations } = severity;	152✔
340	const style = fun.functionStatement ? namedFunctionStyle : anonFunctionStyle;	152✔
341	const kind = fun.tokens.functionType.kind;	152✔
342	const hasReturnedValue = style === 'auto' \|\| typeAnnotations !== 'off' ? this.getFunctionReturns(fun) : false;	152✔
343
344	// type annotations
345	if (typeAnnotations !== 'off') {	152✔
346	const needsArgType = typeAnnotations.startsWith('args') \|\| typeAnnotations.startsWith('all');	22✔
347	const needsReturnType = typeAnnotations.startsWith('return') \|\| typeAnnotations.startsWith('all');	22✔
348	const allowImplicit = typeAnnotations.includes('allow-implicit');	22✔
349
350	if (needsReturnType) {	22✔
351	if (hasReturnedValue && !fun.returnTypeExpression) {	13✔
352	diagnostics.push(messages.expectedReturnTypeAnnotation(	4✔
353	// add the error to the function keyword (or just highlight the whole function if that's somehow missing)
354	fun.tokens.functionType?.location ?? fun.location	24!
355	));
356	}
357	}
358	if (needsArgType) {	22✔
359	const missingAnnotation = fun.parameters.find(arg => {	18✔
360	if (!arg.typeExpression) {	26✔
361	if (allowImplicit && arg.defaultValue) {	14✔
362	return false;	4✔
363	}
364	return true;	10✔
365	}
366	return false;	12✔
367	});
368	if (missingAnnotation) {	18✔
369	// only report 1st missing arg annotation to avoid error overload
370	diagnostics.push(messages.expectedTypeAnnotation(missingAnnotation.location));	10✔
371	}
372	}
373	}
374
375	// keyword style
376	if (style === 'off') {	152✔
377	return;	61✔
378	}
379	if (style === 'no-function') {	91✔
380	if (kind === TokenKind.Function) {	12✔
381	diagnostics.push(messages.expectedSubKeyword(fun, `(always use 'sub')`));	6✔
382	}
383	return;	12✔
384	}
385
386	if (style === 'no-sub') {	79✔
387	if (kind === TokenKind.Sub) {	11✔
388	diagnostics.push(messages.expectedFunctionKeyword(fun, `(always use 'function')`));	5✔
389	}
390	return;	11✔
391	}
392
393	// auto
394	if (hasReturnedValue) {	68✔
395	if (kind !== TokenKind.Function) {	7✔
396	diagnostics.push(messages.expectedFunctionKeyword(fun, `(use 'function' when a value is returned)`));	2✔
397	}
398	} else if (kind !== TokenKind.Sub) {	61✔
399	diagnostics.push(messages.expectedSubKeyword(fun, `(use 'sub' when no value is returned)`));	4✔
400	}
401	}
402
403	getFunctionReturns(fun: FunctionExpression) {
404	let hasReturnedValue = false;	90✔
405	if (fun.returnTypeExpression) {	90✔
406	hasReturnedValue = !isVoidType(fun.returnTypeExpression.getType({ flags: SymbolTypeFlag.typetime }));	14✔
407	} else {
408	const cancel = new CancellationTokenSource();	76✔
409	fun.body.walk(createVisitor({	76✔
410	ReturnStatement: s => {
411	hasReturnedValue = !!s.value;	12✔
412	cancel.cancel();	12✔
413	}
414	}), { walkMode: WalkMode.visitStatements, cancel: cancel.token });
415	}
416	return hasReturnedValue;	90✔
417	}
418
419	validateNameShadowing(file: BrsFile, node: AstNode, nameIdentifier: Token, severity: DiagnosticSeverity, diagnostics: (BsDiagnostic)[]) {
420	const name = nameIdentifier?.text;	36!
421	if (!name \|\| !node) {	36!
UNCOV 422	return;	×
423	}
424	const nameLocation = nameIdentifier.location;	36✔
425
426	const astTable = file.ast.getSymbolTable();	36✔
427	const data = {} as ExtraSymbolData;	36✔
428	const typeChain = [];	36✔
429	// eslint-disable-next-line no-bitwise
430	const existingType = astTable.getSymbolType(name, { flags: SymbolTypeFlag.runtime \| SymbolTypeFlag.typetime, data: data, typeChain: typeChain });	36✔
431
432	if (!existingType \|\| isAnyReferenceType(existingType)) {	36!
UNCOV 433	return;	×
434	}
435	if ((data.definingNode === node) \|\| (isNamespaceStatement(data.definingNode) && isNamespaceStatement(node))) {	36✔
436	return;	20✔
437	}
438	const otherNode = data.definingNode as unknown as { tokens: { name: Token }; location: Location };	16✔
439	const thisNodeKindName = util.getAstNodeFriendlyName(node);	16✔
440	let thatNodeKindName = util.getAstNodeFriendlyName(data.definingNode) ?? '';	16✔
441	if (!thatNodeKindName && isCallableType(existingType)) {	16✔
442	thatNodeKindName = 'Global Function';	1✔
443	}
444
445	let thatNameLocation = otherNode?.tokens?.name?.location ?? otherNode?.location;	16✔
446
447	if (isNamespaceStatement(data.definingNode)) {	16✔
448	thatNameLocation = data.definingNode.getNameParts()?.[0]?.location;	2!
449	}
450
451	const relatedInformation = thatNameLocation ? [{	16✔
452	message: `${thatNodeKindName} declared here`,
453	location: thatNameLocation
454	}] : undefined;
455
456	diagnostics.push({	16✔
457	...messages.nameShadowing(thisNodeKindName, thatNodeKindName, name, severity),
458	location: nameLocation,
459	relatedInformation: relatedInformation
460	});
461	}
462	}
463
464	/**
465	* Collect indexes of non-inline AA members
466	*/
467	export function collectWrappingAAMembersIndexes(aa: AALiteralExpression): number[] {	1✔
468	const indexes: number[] = [];	38✔
469	const { elements } = aa;	38✔
470	const lastIndex = elements.length - 1;	38✔
471	for (let i = 0; i < lastIndex; i++) {	38✔
472	const e = elements[i];	65✔
473
474	const ne = elements[i + 1];	65✔
475	const hasNL = ne.location.range.start.line > e.location.range.end.line;	65✔
476	if (hasNL) {	65✔
477	indexes.push(i);	39✔
478	}
479	}
480	const last = elements[lastIndex];	38✔
481	if (last) {	38✔
482	indexes.push(lastIndex);	37✔
483	}
484	return indexes;	38✔
485	}

rokucommunity / bslint / #1019

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous