10855543739

Committed 13 Sep 2024 08:16PM UTC coverage: 31.87% (-0.002%) from 31.872%

Build # 10855543739

Build Type

Pull #9749

github

Committed by

ben-pace

Commit Message

finish removing review comments

Pull Request Pull Request #9749: Supplanting review bot

Run Details

5080 of 41324 branches covered (12.29%)

Branch coverage included in aggregate %.

22 of 42 new or added lines in 13 files covered. (52.38%)

50 existing lines in 4 files now uncovered.

29401 of 66868 relevant lines covered (43.97%)

185.07 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

16.88

/packages/lesswrong/components/tagging/FooterTagList.tsx

import React, { ReactNode, useCallback, useEffect, useRef, useState } from 'react';
import { Components, registerComponent, getFragment } from '../../lib/vulcan-lib';
import { useMulti } from '../../lib/crud/withMulti';
import { useMutation, gql } from '@apollo/client';
import { useCurrentUser } from '../common/withUser';
import { useTracking, useOnMountTracking } from "../../lib/analyticsEvents";
import { contentTypes } from '../posts/PostsPage/ContentType';
import { tagStyle, smallTagTextStyle } from './FooterTag';
import classNames from 'classnames';
import Card from '@material-ui/core/Card';
import { Link } from '../../lib/reactRouterWrapper';
import { forumSelect } from '../../lib/forumTypeUtils';
import { useMessages } from '../common/withMessages';
import { isLWorAF, taggingNamePluralSetting } from '../../lib/instanceSettings';
import stringify from 'json-stringify-deterministic';
import { isFriendlyUI } from '../../themes/forumTheme';
import { FRIENDLY_HOVER_OVER_WIDTH } from '../common/FriendlyHoverOver';
import { AnnualReviewMarketInfo, highlightMarket } from '../../lib/collections/posts/annualReviewMarkets';
import { stableSortTags } from '../../lib/collections/tags/helpers';

const styles = (theme: ThemeType) => ({
  root: isFriendlyUI ? {
    marginTop: 8,
    marginBottom: 8,
  } : {
    display: 'flex',
    gap: '4px',
    flexWrap: 'wrap',
    justifyContent: 'flex-start',
    alignItems: 'center',
  },
  alignRight: {
    justifyContent: 'flex-end'
  },
  allowTruncate: {
    display: isFriendlyUI ? "block" : "inline-flex",
    // Truncate to 3 rows (webkit-line-clamp would be ideal here but it adds an ellipsis
    // which can't be removed)
    maxHeight: 104,
    overflow: "hidden",
  },
  overrideMargins: {
    marginTop: 0,
    marginBottom: 0,
  },
  postTypeLink: {
    "&:hover": isFriendlyUI ? {opacity: 1} : {},
  },
  frontpageOrPersonal: {
    ...tagStyle(theme),
    backgroundColor: theme.palette.tag.hollowTagBackground,
    ...(isFriendlyUI
      ? {
        marginBottom: 0,
        "&:hover": {
          opacity: 1,
          backgroundColor: theme.palette.tag.hollowTagBackgroundHover,
        },
        "& a:hover": {
          opacity: 1,
        },
      }
      : {
        paddingTop: 4.5,
        paddingBottom: 4.5,
      }),
    border: theme.palette.tag.hollowTagBorder,
    color: theme.palette.text.dim3,
  },
  neverCoreStyling: {
    color: theme.palette.tag.text,
  },
  noBackground: {
    '&&&': {
      backgroundColor: 'transparent',
      border: 'none',
    }
  },
  card: {
    padding: 16,
    ...(isFriendlyUI
      ? {
        paddingTop: 12,
        width: FRIENDLY_HOVER_OVER_WIDTH,
      }
      : {
        width: 450,
        paddingTop: 8,
      }),
  },
  smallText: {
    ...smallTagTextStyle(theme),
  },
  showAll: {
    fontFamily: theme.palette.fonts.sansSerifStack,
    fontSize: 14,
    fontWeight: 600,
    color: theme.palette.grey[500],
    cursor: "pointer",
    width: 'fit-content',
  },
  altAddTagButton: {
    backgroundColor: theme.palette.panelBackground.default,
    display: "inline-block",
    paddingLeft: 8,
    paddingTop: 4.5,
    paddingBottom: 4.5,
    paddingRight: 8,
    borderRadius: 3,
    fontWeight: 700,
    gap: 4,
    cursor: "pointer",
    border: theme.palette.tag.border
  },
});

const FooterTagList = ({
  post,
  hideScore,
  hideAddTag,
  //used for PostsPageSplashHeader
  useAltAddTagButton,
  smallText=false,
  showCoreTags,
  hidePostTypeTag,
  link=true,
  highlightAutoApplied=false,
  allowTruncate=false,
  overrideMargins=false,
  appendElement,
  annualReviewMarketInfo,
  classes,
  align = "left",
  noBackground = false,
  neverCoreStyling = false,
  tagRight = true,
}: {
  post: PostsWithNavigation | PostsWithNavigationAndRevision | PostsList | SunshinePostsList,
  hideScore?: boolean,
  hideAddTag?: boolean,
  useAltAddTagButton?: boolean,
  showCoreTags?: boolean
  hidePostTypeTag?: boolean,
  smallText?: boolean,
  link?: boolean,
  highlightAutoApplied?: boolean,
  allowTruncate?: boolean,
  overrideMargins?: boolean,
  appendElement?: ReactNode,
  annualReviewMarketInfo?: AnnualReviewMarketInfo,
  align?: "left" | "right",
  classes: ClassesType<typeof styles>,
  noBackground?: boolean,
  neverCoreStyling?: boolean,
  tagRight?: boolean,
}) => {
  const [isAwaiting, setIsAwaiting] = useState(false);
  const rootRef = useRef<HTMLSpanElement>(null);
  const [showAll, setShowAll] = useState(!allowTruncate);
  const [displayShowAllButton, setDisplayShowAllButton] = useState(false);

  const currentUser = useCurrentUser();
  const { captureEvent } = useTracking()
  const { flash } = useMessages();

  // We already have the tags as a resolver on the post, this additional query
  // serves two purposes:
  // - It fetches more info that is only required on hover (the tagRel score,
  // the truncated description). Fetching this in a second round trip allows the
  // initial render to be faster.
  // - (somewhat speculative) It allows the mutation to be handled more seamlessly
  // (incrementing the score and reordering the tags) by updating the result of
  // this query
  const { results, loading, loadingInitial, refetch } = useMulti({
    terms: {
      view: "tagsOnPost",
      postId: post._id,
    },
    collectionName: "TagRels",
    fragmentName: "TagRelMinimumFragment", // Must match the fragment in the mutation
    limit: 100,
    fetchPolicy: 'cache-and-network',
    // Only fetch this as a follow-up query on the client
    ssr: false,
  });

  const checkShouldDisplayShowAll = useCallback(() => {
    if (!showAll && rootRef.current) {
      const el = rootRef.current;
      // Even when expanded scrollHeight and clientHeight can be off by a few pixels,
      // we are interested in the case where a whole row is hidden
      if (el.scrollHeight > (el.clientHeight + 10)) {
        setDisplayShowAllButton(true);
      } else {
        setDisplayShowAllButton(false);
      }
    }
  }, [showAll, rootRef, setDisplayShowAllButton]);

  // Check whether we should display the "Show all topics" button when:
  // - Results or loading state change
  // - The component window is resized
  const resultsSignature = stringify(results);
  useEffect(checkShouldDisplayShowAll, [showAll, loadingInitial, resultsSignature, checkShouldDisplayShowAll]);
  useEffect(() => {
    window.addEventListener("resize", checkShouldDisplayShowAll);
    return () => window.removeEventListener("resize", checkShouldDisplayShowAll);
  // eslint-disable-next-line react-hooks/exhaustive-deps
  }, [])

  const onClickShowAll = useCallback(() => {
    setShowAll(true);
    setDisplayShowAllButton(false);
  }, [setShowAll, setDisplayShowAllButton]);

  const tagIds = (results ? results.map((tagRel) => tagRel.tag?._id) : post.tags.map((tag) => tag._id)).filter(
    Boolean
  ) as string[];

  useOnMountTracking({
    eventType: "tagList",
    eventProps: {tagIds},
    captureOnMount: eventProps => eventProps.tagIds.length > 0,
    // LW doesn't get a lot of use out of `tagListMounted` events and there are a lot of them
    skip: isLWorAF || !tagIds.length || loading
  });

  const [mutate] = useMutation(gql`
    mutation addOrUpvoteTag($tagId: String, $postId: String) {
      addOrUpvoteTag(tagId: $tagId, postId: $postId) {
        ...TagRelMinimumFragment
      }
    }
    ${getFragment("TagRelMinimumFragment")}
  `);

  const onTagSelected = useCallback(async ({tagId, tagName}: {tagId: string, tagName: string}) => {
    try {
      setIsAwaiting(true);
      await mutate({
        variables: {
          tagId: tagId,
          postId: post._id,
        },
      });
      setIsAwaiting(false);
      refetch();
      captureEvent("tagAddedToItem", {tagId, tagName});
    } catch (e) {
      setIsAwaiting(false);
      flash(e.message);
    }
  }, [setIsAwaiting, mutate, refetch, post._id, captureEvent, flash]);

  const MaybeLink = ({to, children, className}: {
    to: string|null,
    children: React.ReactNode,
    className?: string,
  }) => {
    if (to) {
      return <Link to={to} className={className}>{children}</Link>
    } else {
      return <>{children}</>;
    }
  }

  const contentTypeInfo = forumSelect(contentTypes);

  const PostTypeTag = useCallback(({tooltipBody, label, neverCoreStyling}: {
    tooltipBody: ReactNode,
    label: string,
    neverCoreStyling?: boolean
  }) => {
    const {HoverOver, ContentStyles} = Components;
    return (
      <HoverOver
        title={
          <Card className={classes.card}>
            <ContentStyles contentType="comment">
              {tooltipBody}
            </ContentStyles>
          </Card>
        }
        tooltip={false}
      >
        <div className={classNames(classes.frontpageOrPersonal, {
          [classes.smallText]: smallText,
          [classes.noBackground]: noBackground,
          [classes.neverCoreStyling]: neverCoreStyling,
        })}>
          {label}
        </div>
      </HoverOver>
    );
  }, [classes, smallText, noBackground]);

  // Post type is either Curated, Frontpage, Personal, or uncategorized (in which case
  // we don't show any indicator). It's uncategorized if it's not frontpaged and doesn't
  // have reviewedByUserId set to anything.
  let postType = post.curatedDate
    ? <Link to={contentTypeInfo.curated.linkTarget} className={classes.postTypeLink}>
        <PostTypeTag label="Curated" tooltipBody={contentTypeInfo.curated.tooltipBody} neverCoreStyling={neverCoreStyling}/>
      </Link>
    : (post.frontpageDate
      ? <MaybeLink to={contentTypeInfo.frontpage.linkTarget} className={classes.postTypeLink}>
          <PostTypeTag label="Frontpage" tooltipBody={contentTypeInfo.frontpage.tooltipBody} neverCoreStyling={neverCoreStyling}/>
        </MaybeLink>
      : (post.reviewedByUserId
        ? <MaybeLink to={contentTypeInfo.personal.linkTarget} className={classes.postTypeLink}>
            <PostTypeTag label="Personal Blog" tooltipBody={contentTypeInfo.personal.tooltipBody} neverCoreStyling={neverCoreStyling}/>
          </MaybeLink>
        : null
      )
    )

  // const commentString = `<p>The <a href="https://www.lesswrong.com/bestoflesswrong">LessWrong Review</a> runs every year to select the posts that have most stood the test of time. This post is not yet eligible for review, but will be at the end of ${2023+1}. The top fifty or so posts are featured prominently on the site throughout the year.</p><p>Hopefully, the review is better than karma at judging enduring value. If we have accurate prediction markets on the review results, maybe we can have better incentives on LessWrong today. <a href="${marketUrl}">Will this post make the top fifty?</a></p>
  // `


  // const percentage = post.annualReviewMarketProbability ? (post.annualReviewMarketProbability * 100).toFixed(0) : undefined
  // const reviewMarketTag = post.manifoldReviewMarketId ? <PostTypeTag label={`Best of Year: ${percentage}%`} tooltipBody={"This is tooltip body"} neverCoreStyling={neverCoreStyling}/> : null

  const eventTag = contentTypeInfo.event && post.isEvent ? <MaybeLink to={contentTypeInfo.event.linkTarget} className={classes.postTypeLink}>
    <PostTypeTag label="Event" tooltipBody={contentTypeInfo.event.tooltipBody} neverCoreStyling={neverCoreStyling}/>
  </MaybeLink> : null

  const sortedTagInfo = results
    ? stableSortTags(results.filter((tagRel) => !!tagRel?.tag).map((tr) => ({ tag: tr.tag!, tagRel: tr })))
    : post.tags.map((tag) => ({ tag, tagRel: undefined }));

  const {Loading, FooterTag, AddTagButton, CoreTagsChecklist, PostsAnnualReviewMarketTag} = Components;

  const tooltipPlacement = useAltAddTagButton ? "bottom-end" : undefined;

  const addTagButton = <AddTagButton onTagSelected={onTagSelected} isVotingContext tooltipPlacement={tooltipPlacement}>
    {useAltAddTagButton && <span className={classNames(classes.altAddTagButton, noBackground && classes.noBackground)}>+</span>}
  </AddTagButton>

  const innerContent = (
    <>
      {!tagRight && currentUser && !hideAddTag && addTagButton}
      {showCoreTags && (
        <div>
          <CoreTagsChecklist existingTagIds={tagIds} onTagSelected={onTagSelected} />
        </div>
      )}
      {sortedTagInfo.map(
        ({ tagRel, tag }) =>
          tag && (
            <FooterTag
              key={tag._id}
              tagRel={tagRel}
              tag={tag}
              hideScore={hideScore}
              smallText={smallText}
              highlightAsAutoApplied={highlightAutoApplied && tagRel?.autoApplied}
              link={link}
              noBackground={noBackground}
              neverCoreStyling={neverCoreStyling}
            />
          )
      )}
      {!hidePostTypeTag && postType}
      {/* {post.manifoldReviewMarketId &&reviewMarketTag} */}
      {eventTag}
      {annualReviewMarketInfo && (
        <PostsAnnualReviewMarketTag post={post} annualReviewMarketInfo={annualReviewMarketInfo} />
      )}
      {tagRight && currentUser && !hideAddTag && addTagButton}
      {isAwaiting && <Loading />}
    </>
  );

  console.log("annualReviewMarketInfo", annualReviewMarketInfo)

  return <>
    <span
      ref={rootRef}
      className={classNames(classes.root, {[classes.allowTruncate]: !showAll}, {[classes.overrideMargins] : overrideMargins, [classes.alignRight]: align === "right"})}
    >
      {innerContent}
      {appendElement}
    </span>
    {displayShowAllButton && <div className={classes.showAll} onClick={onClickShowAll}>Show all {taggingNamePluralSetting.get()}</div>}
  </>
};

const FooterTagListComponent = registerComponent("FooterTagList", FooterTagList, {styles});

declare global {
  interface ComponentTypes {
    FooterTagList: typeof FooterTagListComponent
  }
}

1	import React, { ReactNode, useCallback, useEffect, useRef, useState } from 'react';	1✔
2	import { Components, registerComponent, getFragment } from '../../lib/vulcan-lib';	1✔
3	import { useMulti } from '../../lib/crud/withMulti';	1✔
4	import { useMutation, gql } from '@apollo/client';	1✔
5	import { useCurrentUser } from '../common/withUser';	1✔
6	import { useTracking, useOnMountTracking } from "../../lib/analyticsEvents";	1✔
7	import { contentTypes } from '../posts/PostsPage/ContentType';	1✔
8	import { tagStyle, smallTagTextStyle } from './FooterTag';	1✔
9	import classNames from 'classnames';	1✔
10	import Card from '@material-ui/core/Card';	1✔
11	import { Link } from '../../lib/reactRouterWrapper';	1✔
12	import { forumSelect } from '../../lib/forumTypeUtils';	1✔
13	import { useMessages } from '../common/withMessages';	1✔
14	import { isLWorAF, taggingNamePluralSetting } from '../../lib/instanceSettings';	1✔
15	import stringify from 'json-stringify-deterministic';	1✔
16	import { isFriendlyUI } from '../../themes/forumTheme';	1✔
17	import { FRIENDLY_HOVER_OVER_WIDTH } from '../common/FriendlyHoverOver';	1✔
18	import { AnnualReviewMarketInfo, highlightMarket } from '../../lib/collections/posts/annualReviewMarkets';
19	import { stableSortTags } from '../../lib/collections/tags/helpers';	1✔
20
21	const styles = (theme: ThemeType) => ({	1✔
22	root: isFriendlyUI ? {	1!
23	marginTop: 8,
24	marginBottom: 8,
25	} : {
26	display: 'flex',
27	gap: '4px',
28	flexWrap: 'wrap',
29	justifyContent: 'flex-start',
30	alignItems: 'center',
31	},
32	alignRight: {
33	justifyContent: 'flex-end'
34	},
35	allowTruncate: {
36	display: isFriendlyUI ? "block" : "inline-flex",	1!
37	// Truncate to 3 rows (webkit-line-clamp would be ideal here but it adds an ellipsis
38	// which can't be removed)
39	maxHeight: 104,
40	overflow: "hidden",
41	},
42	overrideMargins: {
43	marginTop: 0,
44	marginBottom: 0,
45	},
46	postTypeLink: {
47	"&:hover": isFriendlyUI ? {opacity: 1} : {},	1!
48	},
49	frontpageOrPersonal: {
50	...tagStyle(theme),
51	backgroundColor: theme.palette.tag.hollowTagBackground,
52	...(isFriendlyUI
53	? {	1!
54	marginBottom: 0,
55	"&:hover": {
56	opacity: 1,
57	backgroundColor: theme.palette.tag.hollowTagBackgroundHover,
58	},
59	"& a:hover": {
60	opacity: 1,
61	},
62	}
63	: {
64	paddingTop: 4.5,
65	paddingBottom: 4.5,
66	}),
67	border: theme.palette.tag.hollowTagBorder,
68	color: theme.palette.text.dim3,
69	},
70	neverCoreStyling: {
71	color: theme.palette.tag.text,
72	},
73	noBackground: {
74	'&&&': {
75	backgroundColor: 'transparent',
76	border: 'none',
77	}
78	},
79	card: {
80	padding: 16,
81	...(isFriendlyUI
82	? {	1!
83	paddingTop: 12,
84	width: FRIENDLY_HOVER_OVER_WIDTH,
85	}
86	: {
87	width: 450,
88	paddingTop: 8,
89	}),
90	},
91	smallText: {
92	...smallTagTextStyle(theme),
93	},
94	showAll: {
95	fontFamily: theme.palette.fonts.sansSerifStack,
96	fontSize: 14,
97	fontWeight: 600,
98	color: theme.palette.grey[500],
99	cursor: "pointer",
100	width: 'fit-content',
101	},
102	altAddTagButton: {
103	backgroundColor: theme.palette.panelBackground.default,
104	display: "inline-block",
105	paddingLeft: 8,
106	paddingTop: 4.5,
107	paddingBottom: 4.5,
108	paddingRight: 8,
109	borderRadius: 3,
110	fontWeight: 700,
111	gap: 4,
112	cursor: "pointer",
113	border: theme.palette.tag.border
114	},
115	});
116
117	const FooterTagList = ({	1✔
118	post,
119	hideScore,
120	hideAddTag,
121	//used for PostsPageSplashHeader
122	useAltAddTagButton,
123	smallText=false,	×
124	showCoreTags,
125	hidePostTypeTag,
126	link=true,	×
127	highlightAutoApplied=false,	×
128	allowTruncate=false,	×
129	overrideMargins=false,	×
130	appendElement,
131	annualReviewMarketInfo,
132	classes,
133	align = "left",	×
134	noBackground = false,	×
135	neverCoreStyling = false,	×
136	tagRight = true,	×
137	}: {
138	post: PostsWithNavigation \| PostsWithNavigationAndRevision \| PostsList \| SunshinePostsList,
139	hideScore?: boolean,
140	hideAddTag?: boolean,
141	useAltAddTagButton?: boolean,
142	showCoreTags?: boolean
143	hidePostTypeTag?: boolean,
144	smallText?: boolean,
145	link?: boolean,
146	highlightAutoApplied?: boolean,
147	allowTruncate?: boolean,
148	overrideMargins?: boolean,
149	appendElement?: ReactNode,
150	annualReviewMarketInfo?: AnnualReviewMarketInfo,
151	align?: "left" \| "right",
152	classes: ClassesType<typeof styles>,
153	noBackground?: boolean,
154	neverCoreStyling?: boolean,
155	tagRight?: boolean,
156	}) => {
157	const [isAwaiting, setIsAwaiting] = useState(false);	×
158	const rootRef = useRef<HTMLSpanElement>(null);	×
159	const [showAll, setShowAll] = useState(!allowTruncate);	×
160	const [displayShowAllButton, setDisplayShowAllButton] = useState(false);	×
161
162	const currentUser = useCurrentUser();	×
163	const { captureEvent } = useTracking()	×
164	const { flash } = useMessages();	×
165
166	// We already have the tags as a resolver on the post, this additional query
167	// serves two purposes:
168	// - It fetches more info that is only required on hover (the tagRel score,
169	// the truncated description). Fetching this in a second round trip allows the
170	// initial render to be faster.
171	// - (somewhat speculative) It allows the mutation to be handled more seamlessly
172	// (incrementing the score and reordering the tags) by updating the result of
173	// this query
174	const { results, loading, loadingInitial, refetch } = useMulti({	×
175	terms: {
176	view: "tagsOnPost",
177	postId: post._id,
178	},
179	collectionName: "TagRels",
180	fragmentName: "TagRelMinimumFragment", // Must match the fragment in the mutation
181	limit: 100,
182	fetchPolicy: 'cache-and-network',
183	// Only fetch this as a follow-up query on the client
184	ssr: false,
185	});
186
187	const checkShouldDisplayShowAll = useCallback(() => {	×
188	if (!showAll && rootRef.current) {	×
189	const el = rootRef.current;	×
190	// Even when expanded scrollHeight and clientHeight can be off by a few pixels,
191	// we are interested in the case where a whole row is hidden
192	if (el.scrollHeight > (el.clientHeight + 10)) {	×
193	setDisplayShowAllButton(true);	×
194	} else {
195	setDisplayShowAllButton(false);	×
196	}
197	}
198	}, [showAll, rootRef, setDisplayShowAllButton]);
199
200	// Check whether we should display the "Show all topics" button when:
201	// - Results or loading state change
202	// - The component window is resized
203	const resultsSignature = stringify(results);	×
204	useEffect(checkShouldDisplayShowAll, [showAll, loadingInitial, resultsSignature, checkShouldDisplayShowAll]);	×
205	useEffect(() => {	×
206	window.addEventListener("resize", checkShouldDisplayShowAll);	×
207	return () => window.removeEventListener("resize", checkShouldDisplayShowAll);	×
208	// eslint-disable-next-line react-hooks/exhaustive-deps
209	}, [])
210
211	const onClickShowAll = useCallback(() => {	×
212	setShowAll(true);	×
213	setDisplayShowAllButton(false);	×
214	}, [setShowAll, setDisplayShowAllButton]);
215
216	const tagIds = (results ? results.map((tagRel) => tagRel.tag?._id) : post.tags.map((tag) => tag._id)).filter(	×
217	Boolean
218	) as string[];
219
220	useOnMountTracking({	×
221	eventType: "tagList",
222	eventProps: {tagIds},
223	captureOnMount: eventProps => eventProps.tagIds.length > 0,	×
224	// LW doesn't get a lot of use out of `tagListMounted` events and there are a lot of them
225	skip: isLWorAF \|\| !tagIds.length \|\| loading	×
226	});
227
228	const [mutate] = useMutation(gql`	×
229	mutation addOrUpvoteTag($tagId: String, $postId: String) {
230	addOrUpvoteTag(tagId: $tagId, postId: $postId) {
231	...TagRelMinimumFragment
232	}
233	}
234	${getFragment("TagRelMinimumFragment")}
235	`);
236
237	const onTagSelected = useCallback(async ({tagId, tagName}: {tagId: string, tagName: string}) => {	×
238	try {	×
239	setIsAwaiting(true);	×
240	await mutate({	×
241	variables: {
242	tagId: tagId,
243	postId: post._id,
244	},
245	});
246	setIsAwaiting(false);	×
247	refetch();	×
248	captureEvent("tagAddedToItem", {tagId, tagName});	×
249	} catch (e) {
250	setIsAwaiting(false);	×
251	flash(e.message);	×
252	}
253	}, [setIsAwaiting, mutate, refetch, post._id, captureEvent, flash]);
254
255	const MaybeLink = ({to, children, className}: {	×
256	to: string\|null,
257	children: React.ReactNode,
258	className?: string,
259	}) => {
260	if (to) {	×
261	return <Link to={to} className={className}>{children}</Link>	×
262	} else {
263	return <>{children}</>;	×
264	}
265	}
266
267	const contentTypeInfo = forumSelect(contentTypes);	×
268
269	const PostTypeTag = useCallback(({tooltipBody, label, neverCoreStyling}: {	×
270	tooltipBody: ReactNode,
271	label: string,
272	neverCoreStyling?: boolean
273	}) => {
274	const {HoverOver, ContentStyles} = Components;	×
275	return (	×
276	<HoverOver
277	title={
278	<Card className={classes.card}>
279	<ContentStyles contentType="comment">
280	{tooltipBody}
281	</ContentStyles>
282	</Card>
283	}
284	tooltip={false}
285	>
286	<div className={classNames(classes.frontpageOrPersonal, {
287	[classes.smallText]: smallText,
288	[classes.noBackground]: noBackground,
289	[classes.neverCoreStyling]: neverCoreStyling,
290	})}>
291	{label}
292	</div>
293	</HoverOver>
294	);
295	}, [classes, smallText, noBackground]);
296
297	// Post type is either Curated, Frontpage, Personal, or uncategorized (in which case
298	// we don't show any indicator). It's uncategorized if it's not frontpaged and doesn't
299	// have reviewedByUserId set to anything.
300	let postType = post.curatedDate	×
301	? <Link to={contentTypeInfo.curated.linkTarget} className={classes.postTypeLink}>	×
302	<PostTypeTag label="Curated" tooltipBody={contentTypeInfo.curated.tooltipBody} neverCoreStyling={neverCoreStyling}/>
303	</Link>
304	: (post.frontpageDate
305	? <MaybeLink to={contentTypeInfo.frontpage.linkTarget} className={classes.postTypeLink}>	×
306	<PostTypeTag label="Frontpage" tooltipBody={contentTypeInfo.frontpage.tooltipBody} neverCoreStyling={neverCoreStyling}/>
307	</MaybeLink>
308	: (post.reviewedByUserId
309	? <MaybeLink to={contentTypeInfo.personal.linkTarget} className={classes.postTypeLink}>	×
310	<PostTypeTag label="Personal Blog" tooltipBody={contentTypeInfo.personal.tooltipBody} neverCoreStyling={neverCoreStyling}/>
311	</MaybeLink>
312	: null
313	)
314	)
315
316	// const commentString = `<p>The <a href="https://www.lesswrong.com/bestoflesswrong">LessWrong Review</a> runs every year to select the posts that have most stood the test of time. This post is not yet eligible for review, but will be at the end of ${2023+1}. The top fifty or so posts are featured prominently on the site throughout the year.</p><p>Hopefully, the review is better than karma at judging enduring value. If we have accurate prediction markets on the review results, maybe we can have better incentives on LessWrong today. <a href="${marketUrl}">Will this post make the top fifty?</a></p>
317	// `
318
319
320	// const percentage = post.annualReviewMarketProbability ? (post.annualReviewMarketProbability * 100).toFixed(0) : undefined
321	// const reviewMarketTag = post.manifoldReviewMarketId ? <PostTypeTag label={`Best of Year: ${percentage}%`} tooltipBody={"This is tooltip body"} neverCoreStyling={neverCoreStyling}/> : null
322
UNCOV 323	const eventTag = contentTypeInfo.event && post.isEvent ? <MaybeLink to={contentTypeInfo.event.linkTarget} className={classes.postTypeLink}>	×
324	<PostTypeTag label="Event" tooltipBody={contentTypeInfo.event.tooltipBody} neverCoreStyling={neverCoreStyling}/>
325	</MaybeLink> : null
326
327	const sortedTagInfo = results	×
328	? stableSortTags(results.filter((tagRel) => !!tagRel?.tag).map((tr) => ({ tag: tr.tag!, tagRel: tr })))	×
329	: post.tags.map((tag) => ({ tag, tagRel: undefined }));	×
330
331	const {Loading, FooterTag, AddTagButton, CoreTagsChecklist, PostsAnnualReviewMarketTag} = Components;	×
332
333	const tooltipPlacement = useAltAddTagButton ? "bottom-end" : undefined;	×
334
335	const addTagButton = <AddTagButton onTagSelected={onTagSelected} isVotingContext tooltipPlacement={tooltipPlacement}>	×
336	{useAltAddTagButton && <span className={classNames(classes.altAddTagButton, noBackground && classes.noBackground)}>+</span>}	×
337	</AddTagButton>
338
339	const innerContent = (
340	<>	×
341	{!tagRight && currentUser && !hideAddTag && addTagButton}	×
342	{showCoreTags && (	×
343	<div>
344	<CoreTagsChecklist existingTagIds={tagIds} onTagSelected={onTagSelected} />
345	</div>
346	)}
347	{sortedTagInfo.map(
348	({ tagRel, tag }) =>
349	tag && (	×
350	<FooterTag
351	key={tag._id}
352	tagRel={tagRel}
353	tag={tag}
354	hideScore={hideScore}
355	smallText={smallText}
356	highlightAsAutoApplied={highlightAutoApplied && tagRel?.autoApplied}	×
357	link={link}
358	noBackground={noBackground}
359	neverCoreStyling={neverCoreStyling}
360	/>
361	)
362	)}
363	{!hidePostTypeTag && postType}	×
364	{/* {post.manifoldReviewMarketId &&reviewMarketTag} */}
365	{eventTag}
366	{annualReviewMarketInfo && (	×
367	<PostsAnnualReviewMarketTag post={post} annualReviewMarketInfo={annualReviewMarketInfo} />
368	)}
369	{tagRight && currentUser && !hideAddTag && addTagButton}	×
370	{isAwaiting && <Loading />}	×
371	</>
372	);
373
NEW 374	console.log("annualReviewMarketInfo", annualReviewMarketInfo)	×
375
UNCOV 376	return <>	×
377	<span
378	ref={rootRef}
379	className={classNames(classes.root, {[classes.allowTruncate]: !showAll}, {[classes.overrideMargins] : overrideMargins, [classes.alignRight]: align === "right"})}
380	>
381	{innerContent}
382	{appendElement}
383	</span>
384	{displayShowAllButton && <div className={classes.showAll} onClick={onClickShowAll}>Show all {taggingNamePluralSetting.get()}</div>}	×
385	</>
386	};
387
388	const FooterTagListComponent = registerComponent("FooterTagList", FooterTagList, {styles});	1✔
389
390	declare global {
391	interface ComponentTypes {
392	FooterTagList: typeof FooterTagListComponent
393	}
394	}

ForumMagnum / ForumMagnum / 10855543739

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous