10818312869

Committed 11 Sep 2024 07:25PM UTC coverage: 13.92% (+0.004%) from 13.916%

Build # 10818312869

Build Type

push

github

Committed by

web-flow

Commit Message

Merge pull request #9146 from hicommonwealth/ryan/cleanup-deprecated-routes2

Remove deprecated routes

Run Details

2987 of 20080 branches covered (14.88%)

Branch coverage included in aggregate %.

1 of 4 new or added lines in 1 file covered. (25.0%)

1 existing line in 1 file now uncovered.

3966 of 29871 relevant lines covered (13.28%)

3.94 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

10.53

/packages/commonwealth/server/routes/communities/get_communities_handler.ts

import { AppError } from '@hicommonwealth/core';
import {
  SearchCommunitiesOptions,
  SearchCommunitiesResult,
} from 'server/controllers/server_communities_methods/search_communities';
import { ServerControllers } from '../../routing/router';
import {
  PaginationQueryParams,
  TypedRequestQuery,
  TypedResponse,
  success,
} from '../../types';

const Errors = {
  QueryRequired: 'query is required',
};

type GetCommunitiesRequestQuery = {
  active?: string;
  snapshots?: string;
  search?: string;
} & PaginationQueryParams;

type GetCommunitiesResponse = SearchCommunitiesResult;

export const getCommunitiesHandler = async (
  controllers: ServerControllers,
  req: TypedRequestQuery<GetCommunitiesRequestQuery>,
  res: TypedResponse<GetCommunitiesResponse>,
) => {
  const options = req.query;

  if (!options.search) {
    throw new AppError(Errors.QueryRequired);
  }

  // search communities
  const results = await controllers.communities.searchCommunities({
    search: options.search,
    // @ts-expect-error StrictNullChecks
    limit: parseInt(options.limit, 10) || 0,
    // @ts-expect-error StrictNullChecks
    page: parseInt(options.page, 10) || 0,
    orderBy: options.order_by,
    orderDirection:
      options.order_direction as SearchCommunitiesOptions['orderDirection'],
  });
  return success(res, results);
};

1	import { AppError } from '@hicommonwealth/core';
2	import {
3	SearchCommunitiesOptions,
4	SearchCommunitiesResult,
5	} from 'server/controllers/server_communities_methods/search_communities';
6	import { ServerControllers } from '../../routing/router';
7	import {
8	PaginationQueryParams,
9	TypedRequestQuery,
10	TypedResponse,
11	success,
12	} from '../../types';
13
14	const Errors = {	17✔
15	QueryRequired: 'query is required',
16	};
17
18	type GetCommunitiesRequestQuery = {
19	active?: string;
20	snapshots?: string;
21	search?: string;
22	} & PaginationQueryParams;
23
24	type GetCommunitiesResponse = SearchCommunitiesResult;
25
26	export const getCommunitiesHandler = async (	17✔
27	controllers: ServerControllers,
28	req: TypedRequestQuery<GetCommunitiesRequestQuery>,
29	res: TypedResponse<GetCommunitiesResponse>,
30	) => {
31	const options = req.query;	×
32
NEW 33	if (!options.search) {	×
NEW 34	throw new AppError(Errors.QueryRequired);	×
35	}
36
37	// search communities
NEW 38	const results = await controllers.communities.searchCommunities({	×
39	search: options.search,
40	// @ts-expect-error StrictNullChecks
41	limit: parseInt(options.limit, 10) \|\| 0,	×
42	// @ts-expect-error StrictNullChecks
43	page: parseInt(options.page, 10) \|\| 0,	×
44	orderBy: options.order_by,
45	orderDirection:
46	options.order_direction as SearchCommunitiesOptions['orderDirection'],
47	});
UNCOV 48	return success(res, results);	×
49	};

hicommonwealth / commonwealth / 10818312869

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous