#1034

Committed 24 Jan 2020 03:41PM UTC coverage: 96.267%. Remained the same

Build # #1034

Build Type

push

Committed by

Commit Message

Keep spaces intact when fixing 'avoid-throw'

Run Details

361 of 435 branches covered (82.99%)

0 of 1 new or added line in 1 file covered. (0.0%)

1934 of 2009 relevant lines covered (96.27%)

39.67 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.71

/lib/rules/security/avoid-throw.js

const BaseChecker = require('./../base-checker')

const ruleId = 'avoid-throw'
const meta = {
  type: 'security',

  docs: {
    description: `"throw" is deprecated, avoid to use it.`,
    category: 'Security Rules'
  },

  isDefault: false,
  recommended: true,
  defaultSetup: 'warn',
  fixable: true,

  schema: []
}

class AvoidThrowChecker extends BaseChecker {
  constructor(reporter) {
    super(reporter, ruleId, meta)
  }

  ThrowStatement(node) {
    this.error(node, '"throw" is deprecated, avoid to use it', fixer =>
      // we don't use just `node.range` because ThrowStatement includes the semicolon and the spaces before it
      // we know that node.range[0] is the 't' of throw
      // we're also pretty sure that 'throw' has 5 letters
      fixer.replaceTextRange([node.range[0], node.range[0] + 5], 'revert()')
    )
  }
}

module.exports = AvoidThrowChecker

1	const BaseChecker = require('./../base-checker')	1✔
2
3	const ruleId = 'avoid-throw'	1✔
4	const meta = {	1✔
5	type: 'security',
6
7	docs: {
8	description: `"throw" is deprecated, avoid to use it.`,
9	category: 'Security Rules'
10	},
11
12	isDefault: false,
13	recommended: true,
14	defaultSetup: 'warn',
15	fixable: true,
16
17	schema: []
18	}
19
20	class AvoidThrowChecker extends BaseChecker {
21	constructor(reporter) {
22	super(reporter, ruleId, meta)	151✔
23	}
24
25	ThrowStatement(node) {
26	this.error(node, '"throw" is deprecated, avoid to use it', fixer =>	1✔
27	// we don't use just `node.range` because ThrowStatement includes the semicolon and the spaces before it
28	// we know that node.range[0] is the 't' of throw
29	// we're also pretty sure that 'throw' has 5 letters
NEW 30	fixer.replaceTextRange([node.range[0], node.range[0] + 5], 'revert()')	×
31	)
32	}
33	}
34
35	module.exports = AvoidThrowChecker	1✔

protofire / solhint / #1034

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous