curationexperts / laevigata / a12989dc-99dc-4444-8071-a83e80b2e83c

push

circleci

[REFACTOR] Always explicitly set embargo booleans in actor stack

**RATIONALE**
The previous code did not reset embargo booleans if they were passed
into the actor stack along with an embargo type. This could result
in invalid embargo settings, e.g.
```
env.attributes[:embargo_type] = 'files_restricted'
env.attributes[:abstract_embargoed] = true
```
After runing the actors, you would have
```
etd.files_embargoed
=> true
etd.toc_embargoed
=> false
etd.abstract_embargoed
=> true
```

To prevent this type of error state, we want to always explicitly set
all three embargo booleans to true or false. The updated code will
override any individual embargo boolean attributes if the embargo
type is present.

This change also ensures that all booleans are set based only on
the most restrictive ebargo setting present. This also sets us up to
pass only a single embargo value instead of a comma separated list.

9 of 9 new or added lines in 1 file covered. (100.0%)

3036 of 3234 relevant lines covered (93.88%)

52.41 hits per line