10740506052

Committed 06 Sep 2024 02:51PM UTC coverage: 97.074% (-0.4%) from 97.462%

Build # 10740506052

Build Type

Pull #47

travis-ci

Committed by

web-flow

Commit Message

Merge 73aa570e6 into 60ccec3e6

Pull Request Pull Request #47: Hypothesis overhaul

Run Details

348 of 363 branches covered (95.87%)

Branch coverage included in aggregate %.

116 of 119 new or added lines in 2 files covered. (97.48%)

4 existing lines in 2 files now uncovered.

581 of 594 relevant lines covered (97.81%)

3.9 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

95.38

/pysmiles/read_smiles.py

# -*- coding: utf-8 -*-
# Copyright 2018 Peter C Kroon

# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
#     http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

"""
Exposes functionality needed for parsing SMILES strings.
"""

import enum
import logging

import networkx as nx

from . import PTE
from .smiles_helper import (add_explicit_hydrogens, remove_explicit_hydrogens,
                            parse_atom, fill_valence, mark_aromatic_edges,
                            mark_aromatic_atoms,  bonds_missing, format_atom,
                            _mark_chiral_atoms, _annotate_ez_isomers)
from .write_smiles import write_smiles_component

LOGGER = logging.getLogger(__name__)


@enum.unique
class TokenType(enum.Enum):
    """Possible SMILES token types"""
    ATOM = 1
    BOND_TYPE = 2
    BRANCH_START = 3
    BRANCH_END = 4
    RING_NUM = 5
    EZSTEREO = 6
    CHIRAL = 7


def _tokenize(smiles):
    """
    Iterates over a SMILES string, yielding tokens.

    Parameters
    ----------
    smiles : iterable
        The SMILES string to iterate over

    Yields
    ------
    tuple(TokenType, str)
        A tuple describing the type of token and the associated data
    """
    organic_subset = 'B C N O P S F Cl Br I * b c n o s p'.split()
    smiles = iter(smiles)
    token = ''
    peek = None
    while True:
        char = peek if peek else next(smiles, '')
        peek = None
        if not char:
            break
        if char == '[':
            token = char
            for char in smiles:  # pragma: no branch
                token += char
                if char == ']':
                    break
            yield TokenType.ATOM, token
        elif char in organic_subset:
            peek = next(smiles, '')
            if char + peek in organic_subset:
                yield TokenType.ATOM, char + peek
                peek = None
            else:
                yield TokenType.ATOM, char
        elif char in '-=#$:.':
            yield TokenType.BOND_TYPE, char
        elif char == '(':
            yield TokenType.BRANCH_START, '('
        elif char == ')':
            yield TokenType.BRANCH_END, ')'
        elif char == '%':
            # If smiles is too short this will raise a ValueError, which is
            # (slightly) prettier than a StopIteration.
            yield TokenType.RING_NUM, int(next(smiles, '') + next(smiles, ''))
        elif char in '/\\':
            yield TokenType.EZSTEREO, char
        elif char.isdigit():  # pragma: no branch
            yield TokenType.RING_NUM, int(char)


def read_smiles(smiles, explicit_hydrogen=False, zero_order_bonds=True, 
                reinterpret_aromatic=True, strict=True):
    """
    Parses a SMILES string.

    Parameters
    ----------
    smiles : iterable
        The SMILES string to parse. Should conform to the OpenSMILES
        specification.
    explicit_hydrogen : bool
        Whether hydrogens should be explicit nodes in the output graph, or be
        implicit in 'hcount' attributes.
    zero_order_bonds : bool
        Whether zero-order bonds (".") should be added as edges with an order of
        0.
    reinterpret_aromatic : bool
        Whether aromaticity should be determined from the created molecule,
        instead of taken from the SMILES string.
    strict : bool
        Whether to be more strict in accepting what is a valid SMILES string and
        what is not.

    Returns
    -------
    nx.Graph
        A graph describing a molecule. Nodes will have an 'element', 'aromatic'
        and a 'charge', and if `explicit_hydrogen` is False a 'hcount'.
        Depending on the input, they will also have 'isotope' and 'class'
        information.
        Edges will have an 'order'.
    """
    bond_to_order = {'-': 1, '=': 2, '#': 3, '$': 4, ':': 1.5, '.': 0}
    mol = nx.Graph()
    anchor = None
    idx = 0
    default_bond = 1
    default_aromatic_bond = 1.5
    next_bond = None
    branches = []
    ring_nums = {}
    current_ez = None
    prev_token = None
    prev_type = None
    ez_isomer_pairs = []
    for tokentype, token in _tokenize(smiles):
        if tokentype == TokenType.ATOM:
            mol.add_node(idx, **parse_atom(token))
            if anchor is not None:
                if next_bond is None:
                    if mol.nodes[anchor]['aromatic'] and mol.nodes[idx]['aromatic']:
                        next_bond = default_aromatic_bond
                    else:
                        next_bond = default_bond
                if next_bond or zero_order_bonds:
                    mol.add_edge(anchor, idx, order=next_bond)
                next_bond = None
            anchor = idx
            idx += 1
        elif tokentype == TokenType.BRANCH_START:
            branches.append(anchor)
        elif tokentype == TokenType.BRANCH_END:
            anchor = branches.pop()
        elif tokentype == TokenType.BOND_TYPE:
            if next_bond is not None:
                raise ValueError('Previous bond (order {}) not used. '
                                 'Overwritten by "{}"'.format(next_bond, token))
            next_bond = bond_to_order[token]
        elif tokentype == TokenType.RING_NUM:
            if token in ring_nums:
                jdx, order = ring_nums[token]
                if next_bond is None and order is None:
                    if mol.nodes[idx - 1]['aromatic'] and mol.nodes[jdx]['aromatic']:
                        next_bond = default_aromatic_bond
                    else:
                        next_bond = default_bond
                elif order is None:  # Note that the check is needed,
                    next_bond = next_bond  # But this could be pass.
                elif next_bond is None:
                    next_bond = order
                elif next_bond != order:  # Both are not None
                    raise ValueError('Conflicting bond orders for ring '
                                     'between indices {}'.format(token))
                # idx is the index of the *next* atom we're adding. So: -1.
                if mol.has_edge(idx-1, jdx):
                    raise ValueError('Edge specified by marker {} already '
                                     'exists'.format(token))
                if idx-1 == jdx:
                    raise ValueError('Marker {} specifies a bond between an '
                                     'atom and itself'.format(token))
                if next_bond or zero_order_bonds:
                    mol.add_edge(idx - 1, jdx, order=next_bond)
                    # we need to keep track of ring bonds here for the
                    # chirality assignment
                    if mol.nodes[idx-1].get('stereo', False):
                        mol.nodes[idx-1]['stereo'][1].append(jdx)
                    if mol.nodes[jdx].get('stereo', False):
                        mol.nodes[jdx]['stereo'][1].append(idx-1)

                next_bond = None
                del ring_nums[token]
            else:
                if idx == 0:
                    raise ValueError("Can't have a marker ({}) before an atom"
                                     "".format(token))
                # idx is the index of the *next* atom we're adding. So: -1.
                ring_nums[token] = (idx - 1, next_bond)
                next_bond = None
        elif tokentype == TokenType.EZSTEREO:  # pragma: no branch
            # FIXME "It is permissible, but not required, that every atom attached to a double bond be marked."
            # we found the second ez reference and
            # annotate the molecule
            if current_ez:
                ez_isomer_pairs.append((current_ez, (idx, anchor, token)))
                current_ez = None
            # current_ez is formatted as:
            # ligand, anchor, token where ligand is the atom defining CIS/TRANS
            # we found a token belonging to a branch (e.g. C(\F))
            elif prev_type == TokenType.BRANCH_START:
                current_ez = (idx, anchor, token)
#            elif prev_type == TokenType.BRANCH_STOP:
#                raise ValueError(f"The E/Z token {token} may not follow a closing bracket.")
            else:
                current_ez = (anchor, idx, token)

        prev_token = token
        prev_type = tokentype

    if ring_nums and strict:
        raise KeyError('Unmatched ring indices {}'.format(list(ring_nums.keys())))

    if current_ez and strict:
        raise ValueError('There is an unmatched stereochemical token.')

    if reinterpret_aromatic:
        mark_aromatic_atoms(mol, strict=strict)
        mark_aromatic_edges(mol)

    # This is a bit of an overreach, we should only add implicit hydrogens to
    # atoms in the organic subset. However, all non-organic atoms already have
    # a hcount, so all is well.
    fill_valence(mol)

    if strict:
        for node in mol:
            element = mol.nodes[node].get('element', '*')
            if element != '*' and element not in PTE:
                raise KeyError(f'Unknown element {element}')
            elif element != '*' and bonds_missing(mol, node):
                debug_smiles = write_smiles_component(nx.ego_graph(mol, node))
                raise KeyError(f'Node {node} ({format_atom(mol, node)}) has'
                               f' non-standard valence: ...{debug_smiles}...')

    # post-processing of E/Z isomerism
    _annotate_ez_isomers(mol, ez_isomer_pairs)

    # post-processing of chiral atoms
    # potentially we need all hydrogen in place
    _mark_chiral_atoms(mol)

    if explicit_hydrogen:
        add_explicit_hydrogens(mol)
    else:
        remove_explicit_hydrogens(mol)

    return mol

1	# -- coding: utf-8 --
2	# Copyright 2018 Peter C Kroon
3
4	# Licensed under the Apache License, Version 2.0 (the "License");
5	# you may not use this file except in compliance with the License.
6	# You may obtain a copy of the License at
7	#
8	# http://www.apache.org/licenses/LICENSE-2.0
9	#
10	# Unless required by applicable law or agreed to in writing, software
11	# distributed under the License is distributed on an "AS IS" BASIS,
12	# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
13	# See the License for the specific language governing permissions and
14	# limitations under the License.
15
16	"""
17	Exposes functionality needed for parsing SMILES strings.
18	"""
19
20	import enum	4✔
21	import logging	4✔
22
23	import networkx as nx	4✔
24
25	from . import PTE	4✔
26	from .smiles_helper import (add_explicit_hydrogens, remove_explicit_hydrogens,	4✔
27	parse_atom, fill_valence, mark_aromatic_edges,
28	mark_aromatic_atoms, bonds_missing, format_atom,
29	_mark_chiral_atoms, _annotate_ez_isomers)
30	from .write_smiles import write_smiles_component	4✔
31
32	LOGGER = logging.getLogger(__name__)	4✔
33
34
35	@enum.unique	4✔
36	class TokenType(enum.Enum):	4✔
37	"""Possible SMILES token types"""
38	ATOM = 1	4✔
39	BOND_TYPE = 2	4✔
40	BRANCH_START = 3	4✔
41	BRANCH_END = 4	4✔
42	RING_NUM = 5	4✔
43	EZSTEREO = 6	4✔
44	CHIRAL = 7	4✔
45
46
47	def _tokenize(smiles):	4✔
48	"""
49	Iterates over a SMILES string, yielding tokens.
50
51	Parameters
52	----------
53	smiles : iterable
54	The SMILES string to iterate over
55
56	Yields
57	------
58	tuple(TokenType, str)
59	A tuple describing the type of token and the associated data
60	"""
61	organic_subset = 'B C N O P S F Cl Br I * b c n o s p'.split()	4✔
62	smiles = iter(smiles)	4✔
63	token = ''	4✔
64	peek = None	4✔
65	while True:	2✔
66	char = peek if peek else next(smiles, '')	4✔
67	peek = None	4✔
68	if not char:	4✔
69	break	4✔
70	if char == '[':	4✔
71	token = char	4✔
72	for char in smiles: # pragma: no branch	4✔
73	token += char	4✔
74	if char == ']':	4✔
75	break	4✔
76	yield TokenType.ATOM, token	4✔
77	elif char in organic_subset:	4✔
78	peek = next(smiles, '')	4✔
79	if char + peek in organic_subset:	4✔
80	yield TokenType.ATOM, char + peek	4✔
81	peek = None	4✔
82	else:
83	yield TokenType.ATOM, char	4✔
84	elif char in '-=#$:.':	4✔
85	yield TokenType.BOND_TYPE, char	4✔
86	elif char == '(':	4✔
87	yield TokenType.BRANCH_START, '('	4✔
88	elif char == ')':	4✔
89	yield TokenType.BRANCH_END, ')'	4✔
90	elif char == '%':	4✔
91	# If smiles is too short this will raise a ValueError, which is
92	# (slightly) prettier than a StopIteration.
93	yield TokenType.RING_NUM, int(next(smiles, '') + next(smiles, ''))	4✔
94	elif char in '/\\':	4✔
95	yield TokenType.EZSTEREO, char	4✔
96	elif char.isdigit(): # pragma: no branch	4✔
97	yield TokenType.RING_NUM, int(char)	4✔
98
99
100	def read_smiles(smiles, explicit_hydrogen=False, zero_order_bonds=True,	4✔
101	reinterpret_aromatic=True, strict=True):
102	"""
103	Parses a SMILES string.
104
105	Parameters
106	----------
107	smiles : iterable
108	The SMILES string to parse. Should conform to the OpenSMILES
109	specification.
110	explicit_hydrogen : bool
111	Whether hydrogens should be explicit nodes in the output graph, or be
112	implicit in 'hcount' attributes.
113	zero_order_bonds : bool
114	Whether zero-order bonds (".") should be added as edges with an order of
115	0.
116	reinterpret_aromatic : bool
117	Whether aromaticity should be determined from the created molecule,
118	instead of taken from the SMILES string.
119	strict : bool
120	Whether to be more strict in accepting what is a valid SMILES string and
121	what is not.
122
123	Returns
124	-------
125	nx.Graph
126	A graph describing a molecule. Nodes will have an 'element', 'aromatic'
127	and a 'charge', and if `explicit_hydrogen` is False a 'hcount'.
128	Depending on the input, they will also have 'isotope' and 'class'
129	information.
130	Edges will have an 'order'.
131	"""
132	bond_to_order = {'-': 1, '=': 2, '#': 3, '$': 4, ':': 1.5, '.': 0}	4✔
133	mol = nx.Graph()	4✔
134	anchor = None	4✔
135	idx = 0	4✔
136	default_bond = 1	4✔
137	default_aromatic_bond = 1.5	4✔
138	next_bond = None	4✔
139	branches = []	4✔
140	ring_nums = {}	4✔
141	current_ez = None	4✔
142	prev_token = None	4✔
143	prev_type = None	4✔
144	ez_isomer_pairs = []	4✔
145	for tokentype, token in _tokenize(smiles):	4✔
146	if tokentype == TokenType.ATOM:	4✔
147	mol.add_node(idx, **parse_atom(token))	4✔
148	if anchor is not None:	4✔
149	if next_bond is None:	4✔
150	if mol.nodes[anchor]['aromatic'] and mol.nodes[idx]['aromatic']:	4✔
151	next_bond = default_aromatic_bond	4✔
152	else:
153	next_bond = default_bond	4✔
154	if next_bond or zero_order_bonds:	4✔
155	mol.add_edge(anchor, idx, order=next_bond)	4✔
156	next_bond = None	4✔
157	anchor = idx	4✔
158	idx += 1	4✔
159	elif tokentype == TokenType.BRANCH_START:	4✔
160	branches.append(anchor)	4✔
161	elif tokentype == TokenType.BRANCH_END:	4✔
162	anchor = branches.pop()	4✔
163	elif tokentype == TokenType.BOND_TYPE:	4✔
164	if next_bond is not None:	4!
165	raise ValueError('Previous bond (order {}) not used. '	×
166	'Overwritten by "{}"'.format(next_bond, token))
167	next_bond = bond_to_order[token]	4✔
168	elif tokentype == TokenType.RING_NUM:	4✔
169	if token in ring_nums:	4✔
170	jdx, order = ring_nums[token]	4✔
171	if next_bond is None and order is None:	4✔
172	if mol.nodes[idx - 1]['aromatic'] and mol.nodes[jdx]['aromatic']:	4✔
173	next_bond = default_aromatic_bond	4✔
174	else:
175	next_bond = default_bond	4✔
176	elif order is None: # Note that the check is needed,	4✔
177	next_bond = next_bond # But this could be pass.	4✔
178	elif next_bond is None:	4✔
179	next_bond = order	4✔
180	elif next_bond != order: # Both are not None	4✔
181	raise ValueError('Conflicting bond orders for ring '	4✔
182	'between indices {}'.format(token))
183	# idx is the index of the next atom we're adding. So: -1.
184	if mol.has_edge(idx-1, jdx):	4✔
185	raise ValueError('Edge specified by marker {} already '	4✔
186	'exists'.format(token))
187	if idx-1 == jdx:	4✔
188	raise ValueError('Marker {} specifies a bond between an '	4✔
189	'atom and itself'.format(token))
190	if next_bond or zero_order_bonds:	4!
191	mol.add_edge(idx - 1, jdx, order=next_bond)	4✔
192	# we need to keep track of ring bonds here for the
193	# chirality assignment
194	if mol.nodes[idx-1].get('stereo', False):	4✔
195	mol.nodes[idx-1]['stereo'][1].append(jdx)	4✔
196	if mol.nodes[jdx].get('stereo', False):	4✔
197	mol.nodes[jdx]['stereo'][1].append(idx-1)	4✔
198
199	next_bond = None	4✔
200	del ring_nums[token]	4✔
201	else:
202	if idx == 0:	4✔
203	raise ValueError("Can't have a marker ({}) before an atom"	4✔
204	"".format(token))
205	# idx is the index of the next atom we're adding. So: -1.
206	ring_nums[token] = (idx - 1, next_bond)	4✔
207	next_bond = None	4✔
208	elif tokentype == TokenType.EZSTEREO: # pragma: no branch	4✔
209	# FIXME "It is permissible, but not required, that every atom attached to a double bond be marked."
210	# we found the second ez reference and
211	# annotate the molecule
212	if current_ez:	4✔
213	ez_isomer_pairs.append((current_ez, (idx, anchor, token)))	4✔
214	current_ez = None	4✔
215	# current_ez is formatted as:
216	# ligand, anchor, token where ligand is the atom defining CIS/TRANS
217	# we found a token belonging to a branch (e.g. C(\F))
218	elif prev_type == TokenType.BRANCH_START:	4✔
219	current_ez = (idx, anchor, token)	4✔
220	# elif prev_type == TokenType.BRANCH_STOP:
221	# raise ValueError(f"The E/Z token {token} may not follow a closing bracket.")
222	else:
223	current_ez = (anchor, idx, token)	4✔
224
225	prev_token = token	4✔
226	prev_type = tokentype	4✔
227
228	if ring_nums and strict:	4✔
229	raise KeyError('Unmatched ring indices {}'.format(list(ring_nums.keys())))	4✔
230
231	if current_ez and strict:	4!
NEW 232	raise ValueError('There is an unmatched stereochemical token.')	×
233
234	if reinterpret_aromatic:	4✔
235	mark_aromatic_atoms(mol, strict=strict)	4✔
236	mark_aromatic_edges(mol)	4✔
237
238	# This is a bit of an overreach, we should only add implicit hydrogens to
239	# atoms in the organic subset. However, all non-organic atoms already have
240	# a hcount, so all is well.
241	fill_valence(mol)	4✔
242
243	if strict:	4!
244	for node in mol:	4✔
245	element = mol.nodes[node].get('element', '*')	4✔
246	if element != '*' and element not in PTE:	4!
247	raise KeyError(f'Unknown element {element}')	×
248	elif element != '*' and bonds_missing(mol, node):	4!
UNCOV 249	debug_smiles = write_smiles_component(nx.ego_graph(mol, node))	×
UNCOV 250	raise KeyError(f'Node {node} ({format_atom(mol, node)}) has'	×
251	f' non-standard valence: ...{debug_smiles}...')
252
253	# post-processing of E/Z isomerism
254	_annotate_ez_isomers(mol, ez_isomer_pairs)	4✔
255
256	# post-processing of chiral atoms
257	# potentially we need all hydrogen in place
258	_mark_chiral_atoms(mol)	4✔
259
260	if explicit_hydrogen:	4✔
261	add_explicit_hydrogens(mol)	4✔
262	else:
263	remove_explicit_hydrogens(mol)	4✔
264
265	return mol	4✔

pckroon / pysmiles / 10740506052

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous