• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

basilisp-lang / basilisp / 10729075009

05 Sep 2024 10:23PM UTC coverage: 98.899% (+0.001%) from 98.898%
10729075009

push

github

web-flow
Pass nREPL client evaled code's line and col nums to the reader (#1038)

Hi,

could you please consider patch to pass the nREPL client's eval file
line and column numbers down to the reader for more accurate compiler
exception reporting. It fixes #1037.

I have attempted a focused approach to propagate the line and column
parameters to the error reporting mechanism. If this approach is not
optimal, I am open to reorganizing the code based on better suggestions.

I've included tests down the affected path to cover these changes.

Thanks

---------

Co-authored-by: ikappaki <ikappaki@users.noreply.github.com>

1870 of 1877 branches covered (99.63%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

8547 of 8656 relevant lines covered (98.74%)

0.99 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

0.0
/src/basilisp/sitecustomize.py
1
# pragma: no cover
2

3
# Executed as part of Python's `site` package initialization if users bootstrap their
4
# Python installation using `basilisp bootstrap`.
5

6
import basilisp.main
×
7

8
basilisp.main.init()
×
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc