10723042641

Committed 05 Sep 2024 02:18PM UTC coverage: 31.837% (+0.009%) from 31.828%

Build # 10723042641

Build Type

Pull #9717

github

Committed by

oetherington

Commit Message

Revert "Temporarily switch back to V1 crosspost token route"

This reverts commit 22f09e256.

Pull Request Pull Request #9717: Crossposting refactor (Part 2 - enable new routes)

Run Details

5066 of 41356 branches covered (12.25%)

Branch coverage included in aggregate %.

7 of 14 new or added lines in 3 files covered. (50.0%)

3 existing lines in 2 files now uncovered.

29441 of 67030 relevant lines covered (43.92%)

184.54 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

24.76

/packages/lesswrong/server/fmCrosspost/resolvers.ts

import type { Request } from "express";
import { isLeft } from 'fp-ts/Either';
import { crosspostUserAgent } from "../../lib/apollo/links";
import Users from "../../lib/collections/users/collection";
import { addGraphQLMutation, addGraphQLQuery, addGraphQLResolvers } from "../../lib/vulcan-lib";
import { ApiError, UnauthorizedError } from "./errors";
import { validateCrosspostingKarmaThreshold } from "./helpers";
import { makeApiUrl, PostRequestTypes, PostResponseTypes, ValidatedPostRouteName, validatedPostRoutes, ValidatedPostRoutes } from "./routes";
import { ConnectCrossposterArgs, GetCrosspostRequest } from "./types";
import { DatabaseServerSetting } from "../databaseSettings";
import stringify from "json-stringify-deterministic";
import LRU from "lru-cache";
import { isE2E } from "@/lib/executionEnvironment";
import { connectCrossposterToken } from "../crossposting/tokens";
import { makeV2CrossSiteRequest } from "../crossposting/crossSiteRequest";
import {
  connectCrossposterRoute,
  unlinkCrossposterRoute,
} from "@/lib/fmCrosspost/routes";

export const fmCrosspostTimeoutMsSetting = new DatabaseServerSetting<number>('fmCrosspostTimeoutMs', 15000)

export const TOS_NOT_ACCEPTED_ERROR = 'You must accept the terms of use before you can publish this post';
export const TOS_NOT_ACCEPTED_REMOTE_ERROR = 'You must read and accept the Terms of Use on the EA Forum in order to crosspost.  To do so, go to https://forum.effectivealtruism.org/newPost and accept the Terms of Use presented above the draft post.';

const getUserId = (req?: Request) => {
  const userId = req?.user?._id;
  if (!userId) {
    throw new UnauthorizedError();
  }
  return userId;
}

const foreignPostCache = new LRU<string, Promise<AnyBecauseHard>>({
  maxAge: 1000 * 60 * 30, // 30 minute TTL
  updateAgeOnGet: false,
  max: 100,
});

/**
 * @deprecated
 * Old version of `makeCrossSiteRequest` - use `makeV2CrossSiteRequest` instead.
 * This is still here to support the `getCrosspost` graphql query, which will be
 * removed once crosspost bodies are denormalized across sites.
 */
const makeCrossSiteRequest = async <RouteName extends ValidatedPostRouteName>(
  routeName: RouteName,
  body: PostRequestTypes<RouteName>,
  onErrorMessage: string,
): Promise<PostResponseTypes<RouteName>> => {
  const route: ValidatedPostRoutes[RouteName] = validatedPostRoutes[routeName];
  const apiUrl = makeApiUrl(route.path);
  let result: Response;

  const controller = new AbortController();
  // Timeout early to avoid this causing frontpage loads to time out
  const timeoutId = setTimeout(() => controller.abort(), fmCrosspostTimeoutMsSetting.get());

  try {
    result = await fetch(apiUrl, {
      method: "POST",
      headers: {
        "Content-Type": "application/json",
        "User-Agent": crosspostUserAgent,
      },
      body: JSON.stringify(body),
      signal: controller.signal,
    });
  } catch (e) {
    clearTimeout(timeoutId); // Clear the timeout when an error occurs

    if (e.name === 'AbortError') {
      throw new ApiError(500, "Crosspost request timed out");
    }

    if (e.cause?.code === 'ECONNREFUSED' && e.cause?.port === 4000) {
      // We're testing locally, and the x-post server isn't running
      return { document: {} }
    } else {
      throw e
    }
  }

  clearTimeout(timeoutId); // Clear the timeout when the request completes

  // Assertion is safe because either we got a result or we threw an error or returned
  const json = await result!.json();
  const validatedResponse = route.responseValidator.decode(json);
  if (isLeft(validatedResponse) || 'error' in json) {
    // eslint-disable-next-line no-console
    console.error("Cross-site request failed:", json);
    let errorMessage = onErrorMessage;
    // TODO: temporary patch for surfacing 
    if ('error' in json && json.error === TOS_NOT_ACCEPTED_ERROR) {
      errorMessage = TOS_NOT_ACCEPTED_REMOTE_ERROR;
    }
    throw new ApiError(500, errorMessage);
  }
  
  return validatedResponse.right;
}

const crosspostResolvers = {
  Mutation: {
    connectCrossposter: async (
      _root: void,
      {token}: ConnectCrossposterArgs,
      {req, currentUser}: ResolverContext,
    ) => {
      const localUserId = getUserId(req);

      // Throws an error if user doesn't have enough karma on the receiving forum (which is the current execution environment)
      validateCrosspostingKarmaThreshold(currentUser);

      const {foreignUserId} = await makeV2CrossSiteRequest(
        connectCrossposterRoute,
        {token, localUserId},
        "Failed to connect accounts for crossposting",
      );
      await Users.rawUpdateOne({_id: localUserId}, {
        $set: {fmCrosspostUserId: foreignUserId},
      });
      return "success";
    },
    unlinkCrossposter: async (_root: void, _args: {}, {req}: ResolverContext) => {
      const localUserId = getUserId(req);
      const foreignUserId = req?.user?.fmCrosspostUserId;
      if (foreignUserId) {
        const token = await connectCrossposterToken.create({
          userId: foreignUserId,
        });
        await makeV2CrossSiteRequest(
          unlinkCrossposterRoute,
          {token},
          "Failed to unlink crossposting accounts",
        );
        await Users.rawUpdateOne({_id: localUserId}, {
          $unset: {fmCrosspostUserId: ""},
        });
      }
      return "success";
    },
  },
  Query: {
    getCrosspost: async (_root: void, {args}: {args: GetCrosspostRequest}) => {
      const key = stringify(args);
      let promise = isE2E ? null : foreignPostCache.get(key);
      if (!promise) {
        promise = makeCrossSiteRequest(
          'getCrosspost',
          args,
          'Failed to get crosspost'
        );
        foreignPostCache.set(key, promise);
      }
      const {document} = await promise;
      return document;
    }
  }
};

addGraphQLResolvers(crosspostResolvers);
addGraphQLMutation("connectCrossposter(token: String): String");
addGraphQLMutation("unlinkCrossposter: String");
addGraphQLQuery("getCrosspost(args: JSON): JSON");

1	import type { Request } from "express";	57✔
2	import { isLeft } from 'fp-ts/Either';	19✔
3	import { crosspostUserAgent } from "../../lib/apollo/links";	19✔
4	import Users from "../../lib/collections/users/collection";	19✔
5	import { addGraphQLMutation, addGraphQLQuery, addGraphQLResolvers } from "../../lib/vulcan-lib";	19✔
6	import { ApiError, UnauthorizedError } from "./errors";	19✔
7	import { validateCrosspostingKarmaThreshold } from "./helpers";	19✔
8	import { makeApiUrl, PostRequestTypes, PostResponseTypes, ValidatedPostRouteName, validatedPostRoutes, ValidatedPostRoutes } from "./routes";	19✔
9	import { ConnectCrossposterArgs, GetCrosspostRequest } from "./types";
10	import { DatabaseServerSetting } from "../databaseSettings";	19✔
11	import stringify from "json-stringify-deterministic";	19✔
12	import LRU from "lru-cache";	19✔
13	import { isE2E } from "@/lib/executionEnvironment";	19✔
14	import { connectCrossposterToken } from "../crossposting/tokens";	19✔
15	import { makeV2CrossSiteRequest } from "../crossposting/crossSiteRequest";	19✔
16	import {
17	connectCrossposterRoute,
18	unlinkCrossposterRoute,
19	} from "@/lib/fmCrosspost/routes";	19✔
20
21	export const fmCrosspostTimeoutMsSetting = new DatabaseServerSetting<number>('fmCrosspostTimeoutMs', 15000)	19✔
22
23	export const TOS_NOT_ACCEPTED_ERROR = 'You must accept the terms of use before you can publish this post';	19✔
24	export const TOS_NOT_ACCEPTED_REMOTE_ERROR = 'You must read and accept the Terms of Use on the EA Forum in order to crosspost. To do so, go to https://forum.effectivealtruism.org/newPost and accept the Terms of Use presented above the draft post.';	19✔
25
26	const getUserId = (req?: Request) => {	19✔
27	const userId = req?.user?._id;	×
28	if (!userId) {	×
29	throw new UnauthorizedError();	×
30	}
31	return userId;	×
32	}
33
34	const foreignPostCache = new LRU<string, Promise<AnyBecauseHard>>({	19✔
35	maxAge: 1000 * 60 * 30, // 30 minute TTL
36	updateAgeOnGet: false,
37	max: 100,
38	});
39
40	/**
41	* @deprecated
42	* Old version of `makeCrossSiteRequest` - use `makeV2CrossSiteRequest` instead.
43	* This is still here to support the `getCrosspost` graphql query, which will be
44	* removed once crosspost bodies are denormalized across sites.
45	*/
46	const makeCrossSiteRequest = async <RouteName extends ValidatedPostRouteName>(	19✔
47	routeName: RouteName,
48	body: PostRequestTypes<RouteName>,
49	onErrorMessage: string,
50	): Promise<PostResponseTypes<RouteName>> => {
51	const route: ValidatedPostRoutes[RouteName] = validatedPostRoutes[routeName];	×
52	const apiUrl = makeApiUrl(route.path);	×
53	let result: Response;
54
55	const controller = new AbortController();	×
56	// Timeout early to avoid this causing frontpage loads to time out
57	const timeoutId = setTimeout(() => controller.abort(), fmCrosspostTimeoutMsSetting.get());	×
58
59	try {	×
60	result = await fetch(apiUrl, {	×
61	method: "POST",
62	headers: {
63	"Content-Type": "application/json",
64	"User-Agent": crosspostUserAgent,
65	},
66	body: JSON.stringify(body),
67	signal: controller.signal,
68	});
69	} catch (e) {
70	clearTimeout(timeoutId); // Clear the timeout when an error occurs	×
71
72	if (e.name === 'AbortError') {	×
73	throw new ApiError(500, "Crosspost request timed out");	×
74	}
75
76	if (e.cause?.code === 'ECONNREFUSED' && e.cause?.port === 4000) {	×
77	// We're testing locally, and the x-post server isn't running
78	return { document: {} }	×
79	} else {
80	throw e	×
81	}
82	}
83
84	clearTimeout(timeoutId); // Clear the timeout when the request completes	×
85
86	// Assertion is safe because either we got a result or we threw an error or returned
87	const json = await result!.json();	×
88	const validatedResponse = route.responseValidator.decode(json);	×
89	if (isLeft(validatedResponse) \|\| 'error' in json) {	×
90	// eslint-disable-next-line no-console
91	console.error("Cross-site request failed:", json);	×
92	let errorMessage = onErrorMessage;	×
93	// TODO: temporary patch for surfacing
94	if ('error' in json && json.error === TOS_NOT_ACCEPTED_ERROR) {	×
95	errorMessage = TOS_NOT_ACCEPTED_REMOTE_ERROR;	×
96	}
97	throw new ApiError(500, errorMessage);	×
98	}
99
100	return validatedResponse.right;	×
101	}
102
103	const crosspostResolvers = {	19✔
104	Mutation: {
105	connectCrossposter: async (
106	_root: void,
107	{token}: ConnectCrossposterArgs,
108	{req, currentUser}: ResolverContext,
109	) => {
110	const localUserId = getUserId(req);	×
111
112	// Throws an error if user doesn't have enough karma on the receiving forum (which is the current execution environment)
113	validateCrosspostingKarmaThreshold(currentUser);	×
114
NEW 115	const {foreignUserId} = await makeV2CrossSiteRequest(	×
116	connectCrossposterRoute,
117	{token, localUserId},
118	"Failed to connect accounts for crossposting",
119	);
UNCOV 120	await Users.rawUpdateOne({_id: localUserId}, {	×
121	$set: {fmCrosspostUserId: foreignUserId},
122	});
123	return "success";	×
124	},
125	unlinkCrossposter: async (_root: void, _args: {}, {req}: ResolverContext) => {
126	const localUserId = getUserId(req);	×
127	const foreignUserId = req?.user?.fmCrosspostUserId;	×
128	if (foreignUserId) {	×
129	const token = await connectCrossposterToken.create({	×
130	userId: foreignUserId,
131	});
NEW 132	await makeV2CrossSiteRequest(	×
133	unlinkCrossposterRoute,
134	{token},
135	"Failed to unlink crossposting accounts",
136	);
UNCOV 137	await Users.rawUpdateOne({_id: localUserId}, {	×
138	$unset: {fmCrosspostUserId: ""},
139	});
140	}
141	return "success";	×
142	},
143	},
144	Query: {
145	getCrosspost: async (_root: void, {args}: {args: GetCrosspostRequest}) => {
146	const key = stringify(args);	×
147	let promise = isE2E ? null : foreignPostCache.get(key);	×
148	if (!promise) {	×
149	promise = makeCrossSiteRequest(	×
150	'getCrosspost',
151	args,
152	'Failed to get crosspost'
153	);
154	foreignPostCache.set(key, promise);	×
155	}
156	const {document} = await promise;	×
157	return document;	×
158	}
159	}
160	};	19✔
161
162	addGraphQLResolvers(crosspostResolvers);	19✔
163	addGraphQLMutation("connectCrossposter(token: String): String");	19✔
164	addGraphQLMutation("unlinkCrossposter: String");	19✔
165	addGraphQLQuery("getCrosspost(args: JSON): JSON");

ForumMagnum / ForumMagnum / 10723042641

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous