10711226040

Committed 04 Sep 2024 11:46PM UTC coverage: 31.858% (-0.01%) from 31.871%

Build # 10711226040

Build Type

Pull #9714

github

Committed by

web-flow

Commit Message

Merge 53af14f50 into 4c2a9410f

Pull Request Pull Request #9714: Crypto comments

Run Details

5074 of 41376 branches covered (12.26%)

Branch coverage included in aggregate %.

50 of 116 new or added lines in 13 files covered. (43.1%)

155 existing lines in 7 files now uncovered.

29453 of 67003 relevant lines covered (43.96%)

185.68 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

61.82

/packages/lesswrong/lib/betas.ts

// Centralized control of beta-gated features. If a feature is restricted to
// admins or to users with the opt-in flag, implement that by defining a
// function here which returns whether a given user has access to that feature.
// That way, we can look here to see what features are currently beta-gated,
// and have an easy way to un-gate in all the relevant places at once.
//
// Beta-feature test functions must handle the case where user is null.

import {
  testServerSetting,
  isEAForum,
  isLWorAF,
  hasCommentsTableOfContentSetting,
  hasSideCommentsSetting, 
  hasDialoguesSetting, 
  hasPostInlineReactionsSetting,
  isBotSiteSetting,
  isLW,
} from './instanceSettings'
import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";
import {isFriendlyUI} from '../themes/forumTheme'
import { recombeeEnabledSetting, userIdsWithAccessToLlmChat } from './publicSettings';
import { useLocation } from './routeUtil';
import { isAnyTest } from './executionEnvironment';

// States for in-progress features
const adminOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars
const moderatorOnly = (user: UsersCurrent|DbUser|null): boolean => !!(user?.isAdmin || user?.groups?.includes('sunshineRegiment'))
const optInOnly = (user: UsersCurrent|DbUser|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars
const shippedFeature = (user: UsersCurrent|DbUser|null): boolean => true; // eslint-disable-line no-unused-vars
const disabled = (user: UsersCurrent|DbUser|null): boolean => false; // eslint-disable-line no-unused-vars
const testServerOnly = (_: UsersCurrent|DbUser|null): boolean => testServerSetting.get();
const adminOrBeta = (user: UsersCurrent|DbUser|null): boolean => adminOnly(user) || optInOnly(user);

//////////////////////////////////////////////////////////////////////////////
// Features in progress                                                     //
//////////////////////////////////////////////////////////////////////////////

export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;
export const userHasBoldPostItems = disabled
export const userHasEAHomeHandbook = adminOnly
export const userCanCreateCommitMessages = moderatorOnly;
export const userHasRedesignedSettingsPage = disabled;
export const userCanUseSharing = (user: UsersCurrent|DbUser|null): boolean => moderatorOnly(user) || userOverNKarmaOrApproved(1)(user);
export const userHasNewTagSubscriptions =  isEAForum ? shippedFeature : disabled
export const userHasDefaultProfilePhotos = disabled

export const userHasAutosummarize = adminOnly

export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;

export const userHasCommentProfileImages = disabled;

export const userHasEagProfileImport = disabled;

export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;

export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;

export const userHasPeopleDirectory = (user: UsersCurrent|DbUser|null) =>
  isEAForum;

export const userHasSubscribeTabFeed = isLW ? shippedFeature : disabled;

//defining as Hook so as to combine with ABTest
export const useRecombeeFrontpage = (currentUser: UsersCurrent|DbUser|null) => {
  // TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
  // const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
  // const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
  const { query } = useLocation();
  
  const manualOptIn = currentUser && query.recExperiment === 'true';

  return isLW && (isAdmin(currentUser) || manualOptIn) && recombeeEnabledSetting.get()
}

export const userHasLlmChat = (currentUser: UsersCurrent|DbUser|null): currentUser is UsersCurrent|DbUser => {
  if (!currentUser) {
    return false
  }
  const userIdsWithAccess = userIdsWithAccessToLlmChat.get();
  
  return isLW && (isAdmin(currentUser) || userIdsWithAccess.includes(currentUser._id));
}

export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;

// Non-user-specific features
export const dialoguesEnabled = hasDialoguesSetting.get();
export const ckEditorUserSessionsEnabled = isLWorAF;
export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();
export const allowSubscribeToUserComments = true;
export const allowSubscribeToSequencePosts = isFriendlyUI;
/** On the post page, do we show users other content they might want to read */
export const hasPostRecommendations = isEAForum;
/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
export const hasDigests = isEAForum;
export const hasAccountDeletionFlow = isEAForum;
export const hasSideComments = hasSideCommentsSetting.get();
export const useElicitApi = false;
export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();
export const fullHeightToCEnabled = isLWorAF;
export const hasForumEvents = isEAForum;
export const hasSurveys = isFriendlyUI && !isBotSiteSetting.get();
export const hasCollapsedFootnotes = !isLWorAF;
export const useCurationEmailsCron = isLW;
export const hasSidenotes = isLW;

// EA Forum disabled the author's ability to moderate posts. We disregard this
// check in tests as the tests run in EA Forum mode, but we want to be able to
// test the moderation features.
export const hasAuthorModeration = !isEAForum || isAnyTest;

// Shipped Features
export const userCanManageTags = shippedFeature;
export const userCanCreateTags = shippedFeature;
export const userCanUseTags = shippedFeature;
export const userCanViewRevisionHistory = shippedFeature;
export const userHasPingbacks = shippedFeature;
export const userHasElasticsearch = shippedFeature;

1	// Centralized control of beta-gated features. If a feature is restricted to	598✔
2	// admins or to users with the opt-in flag, implement that by defining a
3	// function here which returns whether a given user has access to that feature.
4	// That way, we can look here to see what features are currently beta-gated,
5	// and have an easy way to un-gate in all the relevant places at once.
6	//
7	// Beta-feature test functions must handle the case where user is null.
8
9	import {
10	testServerSetting,
11	isEAForum,
12	isLWorAF,
13	hasCommentsTableOfContentSetting,
14	hasSideCommentsSetting,
15	hasDialoguesSetting,
16	hasPostInlineReactionsSetting,
17	isBotSiteSetting,
18	isLW,
19	} from './instanceSettings'	29✔
20	import { isAdmin, userOverNKarmaOrApproved } from "./vulcan-users/permissions";	29✔
21	import {isFriendlyUI} from '../themes/forumTheme'	29✔
22	import { recombeeEnabledSetting, userIdsWithAccessToLlmChat } from './publicSettings';	29✔
23	import { useLocation } from './routeUtil';	29✔
24	import { isAnyTest } from './executionEnvironment';	29✔
25
26	// States for in-progress features
27	const adminOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.isAdmin; // eslint-disable-line no-unused-vars	29!
28	const moderatorOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!(user?.isAdmin \|\| user?.groups?.includes('sunshineRegiment'))	29!
29	const optInOnly = (user: UsersCurrent\|DbUser\|null): boolean => !!user?.beta; // eslint-disable-line no-unused-vars	29!
30	const shippedFeature = (user: UsersCurrent\|DbUser\|null): boolean => true; // eslint-disable-line no-unused-vars	29✔
31	const disabled = (user: UsersCurrent\|DbUser\|null): boolean => false; // eslint-disable-line no-unused-vars	29✔
32	const testServerOnly = (_: UsersCurrent\|DbUser\|null): boolean => testServerSetting.get();	29✔
33	const adminOrBeta = (user: UsersCurrent\|DbUser\|null): boolean => adminOnly(user) \|\| optInOnly(user);	29!
34
35	//////////////////////////////////////////////////////////////////////////////
36	// Features in progress //
37	//////////////////////////////////////////////////////////////////////////////
38
39	export const userCanEditTagPortal = isEAForum ? moderatorOnly : adminOnly;	29!
40	export const userHasBoldPostItems = disabled	29✔
41	export const userHasEAHomeHandbook = adminOnly	29✔
42	export const userCanCreateCommitMessages = moderatorOnly;	29✔
43	export const userHasRedesignedSettingsPage = disabled;	29✔
44	export const userCanUseSharing = (user: UsersCurrent\|DbUser\|null): boolean => moderatorOnly(user) \|\| userOverNKarmaOrApproved(1)(user);	29!
45	export const userHasNewTagSubscriptions = isEAForum ? shippedFeature : disabled	29!
46	export const userHasDefaultProfilePhotos = disabled	29✔
47
48	export const userHasAutosummarize = adminOnly	29✔
49
50	export const userHasThemePicker = isFriendlyUI ? adminOnly : shippedFeature;	29!
51
52	export const userHasCommentProfileImages = disabled;	29✔
53
54	export const userHasEagProfileImport = disabled;	29✔
55
56	export const userHasEAHomeRHS = isEAForum ? shippedFeature : disabled;	29!
57
58	export const visitorGetsDynamicFrontpage = isLW ? shippedFeature : disabled;	29!
59
60	export const userHasPeopleDirectory = (user: UsersCurrent\|DbUser\|null) =>	29✔
61	isEAForum;	×
62
63	export const userHasSubscribeTabFeed = isLW ? shippedFeature : disabled;	29!
64
65	//defining as Hook so as to combine with ABTest
66	export const useRecombeeFrontpage = (currentUser: UsersCurrent\|DbUser\|null) => {	29✔
67	// TODO: figure out what went wrong with the AB tests causing caching issues, beyond `affectsLoggedOut` being set to false
68	// const recombeeOptInABTest = useABTest(newFrontpagePostFeedsWithRecommendationsOptIn)
69	// const optedIntoRecombee = (recombeeOptInABTest === "frontpageWithTabs")
UNCOV 70	const { query } = useLocation();	×
71
72	const manualOptIn = currentUser && query.recExperiment === 'true';	×
73
74	return isLW && (isAdmin(currentUser) \|\| manualOptIn) && recombeeEnabledSetting.get()	×
75	}
76
77	export const userHasLlmChat = (currentUser: UsersCurrent\|DbUser\|null): currentUser is UsersCurrent\|DbUser => {	29✔
UNCOV 78	if (!currentUser) {	×
UNCOV 79	return false	×
80	}
81	const userIdsWithAccess = userIdsWithAccessToLlmChat.get();	×
82
83	return isLW && (isAdmin(currentUser) \|\| userIdsWithAccess.includes(currentUser._id));	×
84	}
85
86	export const userHasDarkModeHotkey = isEAForum ? adminOnly : shippedFeature;	29!
87
88	// Non-user-specific features
89	export const dialoguesEnabled = hasDialoguesSetting.get();	29✔
90	export const ckEditorUserSessionsEnabled = isLWorAF;	29✔
91	export const inlineReactsHoverEnabled = hasPostInlineReactionsSetting.get();	29✔
92	export const allowSubscribeToUserComments = true;	29✔
93	export const allowSubscribeToSequencePosts = isFriendlyUI;	29✔
94	/** On the post page, do we show users other content they might want to read */
95	export const hasPostRecommendations = isEAForum;	29✔
96	/** Some Forums, notably the EA Forum, have a weekly digest that users can sign up to receive */
97	export const hasDigests = isEAForum;	29✔
98	export const hasAccountDeletionFlow = isEAForum;	29✔
99	export const hasSideComments = hasSideCommentsSetting.get();	29✔
100	export const useElicitApi = false;	29✔
101	export const commentsTableOfContentsEnabled = hasCommentsTableOfContentSetting.get();	29✔
102	export const fullHeightToCEnabled = isLWorAF;	29✔
103	export const hasForumEvents = isEAForum;	29✔
104	export const hasSurveys = isFriendlyUI && !isBotSiteSetting.get();	29✔
105	export const hasCollapsedFootnotes = !isLWorAF;	29✔
106	export const useCurationEmailsCron = isLW;	29✔
107	export const hasSidenotes = isLW;	29✔
108
109	// EA Forum disabled the author's ability to moderate posts. We disregard this
110	// check in tests as the tests run in EA Forum mode, but we want to be able to
111	// test the moderation features.
112	export const hasAuthorModeration = !isEAForum \|\| isAnyTest;	29✔
113
114	// Shipped Features
115	export const userCanManageTags = shippedFeature;	29✔
116	export const userCanCreateTags = shippedFeature;	29✔
117	export const userCanUseTags = shippedFeature;	29✔
118	export const userCanViewRevisionHistory = shippedFeature;	29✔
119	export const userHasPingbacks = shippedFeature;	29✔
120	export const userHasElasticsearch = shippedFeature;	29✔

ForumMagnum / ForumMagnum / 10711226040

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous